Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/elm
On 02/15/2013 03:50 AM, Daniel Juyung Seo wrote: Oops. CElmGadget.h is missing. Good catch. Committed as r83948. Leandro -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/elm
Thanks for the quick fix :) Daniel Juyung Seo (SeoZ) On Fri, Feb 15, 2013 at 9:01 PM, Leandro Pereira lean...@profusion.mobiwrote: On 02/15/2013 03:50 AM, Daniel Juyung Seo wrote: Oops. CElmGadget.h is missing. Good catch. Committed as r83948. Leandro -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/elm
Oops. CElmGadget.h is missing.
Daniel Juyung Seo (SeoZ)
On Fri, Feb 15, 2013 at 3:33 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
elev8: Add CElmGadget.
This is only to be used by the Elev8 E17 module.
Author: acidx
Date: 2013-02-14 10:33:00 -0800 (Thu, 14 Feb 2013)
New Revision: 83901
Trac: http://trac.enlightenment.org/e/changeset/83901
Added:
trunk/PROTO/elev8/src/modules/elm/CElmGadget.cc
Modified:
trunk/PROTO/elev8/src/modules/elm/CElmObject.h
trunk/PROTO/elev8/src/modules/elm/Makefile.am
trunk/PROTO/elev8/src/modules/elm/main.cc
Added: trunk/PROTO/elev8/src/modules/elm/CElmGadget.cc
===
--- trunk/PROTO/elev8/src/modules/elm/CElmGadget.cc
(rev 0)
+++ trunk/PROTO/elev8/src/modules/elm/CElmGadget.cc 2013-02-14
18:33:00 UTC (rev 83901)
@@ -0,0 +1,76 @@
+#include elm.h
+#include CElmGadget.h
+
+namespace elm {
+
+using namespace v8;
+
+GENERATE_TEMPLATE_FULL(CElmObject, CElmGadget);
+
+CElmGadget::CElmGadget(Local Object _jsObject, CElmObject *parent)
+ : CElmObject(_jsObject, elm_box_add(parent ? parent-GetEvasObject() :
NULL))
+{
+}
+
+CElmGadget::CElmGadget(LocalObject _jsObject, Evas_Object *parent)
+: CElmObject(_jsObject, elm_box_add(parent))
+{
+ evas_object_show(eo);
+}
+
+HandleValue CElmGadget::CreateWithEvasObjectAsParent(Evas_Object
*parent)
+{
+ CElmGadget *g = new
CElmGadget(CElmObject::GetTemplate()-InstanceTemplate()-NewInstance(),
elm_box_add(parent));
+ return g-GetJSObject();
+}
+
+HandleValue CElmGadget::CreateWithExternalizedEvasObjectAsParent(const
Arguments args)
+{
+ return CreateWithEvasObjectAsParent((Evas_Object
*)External::Cast(*args[0])-Value());
+}
+
+HandleValue CElmGadget::Pack(HandleValue obj, HandleValue replace)
+{
+ LocalValue before =
obj-ToObject()-Get(String::NewSymbol(before));
+
+ if (before-IsUndefined() !replace-IsUndefined())
+ before = replace-ToObject()-Get(String::NewSymbol(before));
+ else if (before-IsString() || before-IsNumber())
+ before =
GetJSObject()-Get(String::NewSymbol(elements))-ToObject()-Get(before);
+
+ obj = Realise(obj, GetJSObject());
+
+ if (before-IsUndefined())
+ elm_box_pack_end(eo, GetEvasObjectFromJavascript(obj));
+ else
+ elm_box_pack_before(eo, GetEvasObjectFromJavascript(obj),
+ GetEvasObjectFromJavascript(before));
+
+ return obj;
+}
+
+HandleValue CElmGadget::Unpack(HandleValue obj)
+{
+ HandleObject replace = Object::New();
+ Eina_List *list = elm_box_children_get(eo);
+ Eina_List *l = eina_list_data_find_list(list,
GetEvasObjectFromJavascript(obj));
+ if ((l = eina_list_next(l)))
+ {
+Evas_Object *_eo = (Evas_Object *)eina_list_data_get(l);
+CElmObject *before = static_castCElmObject
*(evas_object_data_get(_eo, this));
+
+if (before)
+ replace-Set(String::NewSymbol(before),
before-GetJSObject());
+ }
+ eina_list_free(list);
+ delete GetObjectFromJavascript(obj);
+ return replace;
+}
+
+void CElmGadget::Initialize(HandleObject target)
+{
+ target-Set(String::NewSymbol(Gadget), GetTemplate()-GetFunction());
+ target-Set(String::NewSymbol(NewGadgetFromEvasObject),
FunctionTemplate::New(CreateWithExternalizedEvasObjectAsParent)-GetFunction());
+}
+
+}
\ No newline at end of file
Modified: trunk/PROTO/elev8/src/modules/elm/CElmObject.h
===
--- trunk/PROTO/elev8/src/modules/elm/CElmObject.h 2013-02-14
18:32:56 UTC (rev 83900)
+++ trunk/PROTO/elev8/src/modules/elm/CElmObject.h 2013-02-14
18:33:00 UTC (rev 83901)
@@ -266,6 +266,8 @@
static HandleValue Realise(const Arguments args);
static HandleValue Realise(HandleValue desc, HandleValue parent);
+
+ static HandleValue Realise(HandleValue descValue, Evas_Object
*parentl);
};
}
Modified: trunk/PROTO/elev8/src/modules/elm/Makefile.am
===
--- trunk/PROTO/elev8/src/modules/elm/Makefile.am 2013-02-14
18:32:56 UTC (rev 83900)
+++ trunk/PROTO/elev8/src/modules/elm/Makefile.am 2013-02-14
18:33:00 UTC (rev 83901)
@@ -34,6 +34,7 @@
CElmFileSelectorButton.cc \
CElmFileSelectorEntry.cc \
CElmFlip.cc \
+ CElmGadget.cc \
CElmGenGrid.cc \
CElmGenList.cc \
CElmGrid.cc \
Modified: trunk/PROTO/elev8/src/modules/elm/main.cc
===
--- trunk/PROTO/elev8/src/modules/elm/main.cc 2013-02-14 18:32:56 UTC
(rev 83900)
+++ trunk/PROTO/elev8/src/modules/elm/main.cc 2013-02-14 18:33:00 UTC
(rev 83901)
@@ -23,6 +23,7 @@
#include CElmFileSelectorButton.h
#include CElmFileSelectorEntry.h
#include CElmFlip.h
+#include CElmGadget.h
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
Hello,
On 08/14/2012 08:04 PM, Enlightenment SVN wrote:
Log:
elev8: Flush stdout when printing debug message
Author: acidx
Modified: trunk/PROTO/elev8/src/bin/main.cc
===
--- trunk/PROTO/elev8/src/bin/main.cc 2012-08-14 19:04:50 UTC (rev 75265)
+++ trunk/PROTO/elev8/src/bin/main.cc 2012-08-14 19:04:52 UTC (rev 75266)
@@ -337,6 +337,7 @@
else if (argc = 3 !strcmp(argv[1], --debug))
{
printf(Awaiting connection from debugger on port 5858.);
+fflush(stdout);
I stumbled upon this yesterday as well, but wouldn't it be better to add
a newline at the end of the printf instead?
Regards,
Daniel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
Ecore_Getopt?
On Friday, June 29, 2012, Enlightenment SVN wrote:
Log:
elev8: Add JavaScript debugger support
To use the v8 debugger (d8), simply run elev8 with the --debug
parameter,
then the script name. On another terminal, run ``d8 --remote_debugger''
--
when connected, breakpoints can be set, etc. Type ``help'' on d8 command
line for available commands. To resume execution, use ``continue''.
Author: acidx
Date: 2012-06-29 10:03:05 -0700 (Fri, 29 Jun 2012)
New Revision: 73048
Trac: http://trac.enlightenment.org/e/changeset/73048
Modified:
trunk/PROTO/elev8/src/bin/main.cc
Modified: trunk/PROTO/elev8/src/bin/main.cc
===
--- trunk/PROTO/elev8/src/bin/main.cc 2012-06-29 17:03:02 UTC (rev 73047)
+++ trunk/PROTO/elev8/src/bin/main.cc 2012-06-29 17:03:05 UTC (rev 73048)
@@ -5,11 +5,12 @@
* then exit
*/
-#include unistd.h
#include dlfcn.h
#include Ecore.h
#include elev8_common.h
#include elev8_utils.h
+#include unistd.h
+#include v8-debug.h
#include storage.h
#include timer.h
@@ -283,9 +284,25 @@
boom(message, *String::Utf8Value(message-Get()));
}
+static Eina_Bool
+debug_message_handler_idler_cb(void *)
+{
+ DBG(Processing debug messages);
+ Debug::ProcessDebugMessages();
+ return ECORE_CALLBACK_CANCEL;
+}
+
+static void
+debug_message_handler()
+{
+ ecore_idler_add(debug_message_handler_idler_cb, NULL);
+}
+
int
-main(int argc, char **argv)
+main(int argc, char *argv[])
{
+ int script_arg = 1;
+
eina_init();
elev8_log_domain = eina_log_domain_register(elev8, EINA_COLOR_ORANGE);
if (!elev8_log_domain)
@@ -296,6 +313,10 @@
}
INF(elev8 Logging initialized. %d, elev8_log_domain);
+ V8::SetFlagsFromCommandLine(argc, argv, true);
+ V8::AddMessageListener(message, Undefined());
+ V8::SetCaptureStackTraceForUncaughtExceptions(true, 10,
StackTrace::kDetailed);
+
if (argc 2)
{
ERR(%s: Error: no input file specified., argv[0]);
@@ -305,11 +326,14 @@
argv[0], argv[0]);
exit(-1);
}
+ else if (argc = 3 !strcmp(argv[1], --debug))
+ {
+printf(Awaiting connection from debugger on port 5858.);
+Debug::EnableAgent(elev8, 5858, true);
+Debug::SetDebugMessageDispatchHandler(debug_message_handler);
+script_arg = 2;
+ }
- V8::SetFlagsFromCommandLine(argc, argv, true);
- V8::AddMessageListener(message, Undefined());
- V8::SetCaptureStackTraceForUncaughtExceptions(true, 10,
StackTrace::kDetailed);
-
HandleScope handle_scope;
global = PersistentObjectTemplate::New(ObjectTemplate::New());
@@ -327,7 +351,7 @@
if (!run_script(PACKAGE_LIB_DIR /../init.js))
goto end;
- if (!run_script(argv[1]))
+ if (!run_script(argv[script_arg]))
goto end;
ecore_main_loop_begin();
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net javascript:;
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/elm
Hi, On Thu, June 21, 2012 22:03, Enlightenment SVN wrote: Log: elev8: Implemented Enabled Pos in CElmActionSlider +GENERATE_PROPERTY_CALLBACKS(CElmActionSlider, enabled); enabled is already a property in CElmObject, maybe enabled_pos is a better name? Regards, Daniel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/elm
Daniel, On Thu, Jun 21, 2012 at 7:03 PM, Daniel Willmann dan...@totalueberwachung.de wrote: elev8: Implemented Enabled Pos in CElmActionSlider +GENERATE_PROPERTY_CALLBACKS(CElmActionSlider, enabled); Good catch. Yes, yes it is. -- Leandro -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/data/javascript
On Fri, 9 Mar 2012 12:46:58 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Remove pager.js No deprecation in PROTO: if you're using it, then you're doing it wrong. this one was my favorite. Author: acidx Date: 2012-03-09 12:46:58 -0800 (Fri, 09 Mar 2012) New Revision: 69156 Trac: http://trac.enlightenment.org/e/changeset/69156 Removed: trunk/PROTO/elev8/data/javascript/pager.js Modified: trunk/PROTO/elev8/data/javascript/Makefile.am -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
On Mon, Mar 5, 2012 at 9:36 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: As you can see, you should NOT use the eina_log.h MACRO, use the function instead and provide more meaningful file/line instead of always doing elev8_utils.cc:60 :-) Wouldn't make any difference here: Eina_Log wouldn't know about the JavaScript file name :) -- Leandro -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
On Tue, Mar 6, 2012 at 7:35 AM, Leandro Pereira lean...@profusion.mobi wrote: On Mon, Mar 5, 2012 at 9:36 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: As you can see, you should NOT use the eina_log.h MACRO, use the function instead and provide more meaningful file/line instead of always doing elev8_utils.cc:60 :-) Wouldn't make any difference here: Eina_Log wouldn't know about the JavaScript file name :) Can't you change it so it does know? and use http://docs.enlightenment.org/auto/eina/group__Eina__Log__Group.html#ga2ad47c77225cbcf8d35840547b5bbbe4 -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
On 03/06/2012 07:48 AM, Gustavo Sverzut Barbieri wrote: Can't you change it so it does know? and use http://docs.enlightenment.org/auto/eina/group__Eina__Log__Group.html#ga2ad47c77225cbcf8d35840547b5bbbe4 It is already working. What wasn't working were that imported JavaScript modules didn't set their file names, so that error messages were printed as happening on file undefined. Leandro -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
On Tue, Mar 6, 2012 at 11:59 AM, Leandro Pereira lean...@profusion.mobi wrote: On 03/06/2012 07:48 AM, Gustavo Sverzut Barbieri wrote: Can't you change it so it does know? and use http://docs.enlightenment.org/auto/eina/group__Eina__Log__Group.html#ga2ad47c77225cbcf8d35840547b5bbbe4 It is already working. What wasn't working were that imported JavaScript modules didn't set their file names, so that error messages were printed as happening on file undefined. From your example: ERR11319:elev8 elev8_utils.cc:60 boom() ./app.js:12 TypeError: Object [object Object] has no method 'derp' In my opinion it should be: ERR11319:elev8 ./app.js:12 jsfunc() TypeError: Object [object Object] has no method 'derp' did you understand what I mean? you provide JS values for file, function and line to eina_log_print(). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
On Tue, Mar 6, 2012 at 6:36 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: did you understand what I mean? you provide JS values for file, function and line to eina_log_print(). I do. I'll see how to get a stack trace as well, this might help. -- Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/bin
On Mon, Mar 5, 2012 at 4:34 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Define the JavaScript module file name Error messages are meaningful now: ERR11319:elev8 elev8_utils.cc:60 boom() ./app.js:12 TypeError: Object [object Object] has no method 'derp' Instead of: ERR10664:elev8 elev8_utils.cc:60 boom() undefined:12 TypeError: Object [object Object] has no method 'derp' As you can see, you should NOT use the eina_log.h MACRO, use the function instead and provide more meaningful file/line instead of always doing elev8_utils.cc:60 :-) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8
Cool. On Sat, Mar 3, 2012 at 2:41 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Test for the existence of Object::HasOwnProperty() Author: acidx Date: 2012-03-02 09:41:22 -0800 (Fri, 02 Mar 2012) New Revision: 68631 Trac: http://trac.enlightenment.org/e/changeset/68631 Modified: trunk/PROTO/elev8/configure.ac Modified: trunk/PROTO/elev8/configure.ac === --- trunk/PROTO/elev8/configure.ac 2012-03-02 17:41:20 UTC (rev 68630) +++ trunk/PROTO/elev8/configure.ac 2012-03-02 17:41:22 UTC (rev 68631) @@ -117,8 +117,10 @@ ]], [[ n = v8::Persistentv8::Number::New(v8::Number::New(0)); + v8::Handlev8::Object o = v8::Object::New(); + o-HasOwnProperty(v8::String::New(bazinga)); ]], -)],[V8_LIBS=-lv8], AC_MSG_ERROR([elev8 requires libv8])) +)],[V8_LIBS=-lv8], AC_MSG_ERROR([elev8 requires libv8 = 3.5.0])) LIBS=$saved_LIBS AC_MSG_RESULT([yes]) AC_LANG_POP -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/http
One comment to this commit.
On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
elev8: Remove HTTP module compile-time warnings
Author: acidx
Date: 2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012)
New Revision: 68596
Trac: http://trac.enlightenment.org/e/changeset/68596
Modified:
trunk/PROTO/elev8/src/modules/http/elev8_http.cc
Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc
===
--- trunk/PROTO/elev8/src/modules/http/elev8_http.cc2012-03-01
20:28:22 UTC (rev 68595)
+++ trunk/PROTO/elev8/src/modules/http/elev8_http.cc2012-03-01
20:39:19 UTC (rev 68596)
@@ -8,7 +8,7 @@
int XMLHttpRequest::fd_counter = 0;
HandleObjectTemplate xmlHttpReqObj;
-Eina_Bool data_callback(void *data, int type, void *event)
+Eina_Bool data_callback(void *data, int, void *event)
Why not use __UNUSED__ like the rest of EFL.
{
Ecore_Con_Event_Url_Data *url_data = (Ecore_Con_Event_Url_Data *)event;
void *ptr = ecore_con_url_data_get(url_data-url_con);
@@ -29,7 +29,7 @@
return EINA_FALSE;
}
-Eina_Bool completion_callback(void *data, int type, void *event)
+Eina_Bool completion_callback(void *data, int, void *event)
{
HandleScope handle_scope;
Ecore_Con_Event_Url_Complete *url_complete =
(Ecore_Con_Event_Url_Complete *)event;
@@ -81,7 +81,7 @@
out.write((char *)eina_binbuf_string_get(reqObj-data),
eina_binbuf_length_get(reqObj-data));
out.close();
- HTTP_INF( Size of response Data = %lu bytes,
+ HTTP_INF( Size of response Data = %d bytes,
eina_binbuf_length_get(reqObj-data));
reqObj-responseText = static_castPersistentString
(String::New(buf));
}
@@ -126,8 +126,7 @@
}
HandleValue
-response_text_getter(LocalString property,
-const AccessorInfo info)
+response_text_getter(LocalString, const AccessorInfo info)
{
LocalObject self = info.Holder();
LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0));
@@ -138,8 +137,7 @@
}
HandleValue
-status_getter(LocalString property,
-const AccessorInfo info)
+status_getter(LocalString, const AccessorInfo info)
{
LocalObject self = info.Holder();
LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0));
@@ -149,8 +147,7 @@
}
HandleValue
-readystate_getter(LocalString property,
-const AccessorInfo info)
+readystate_getter(LocalString, const AccessorInfo info)
{
LocalObject self = info.Holder();
LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0));
@@ -310,7 +307,7 @@
return Undefined();
}
-HandleValue createXMLHttpReqInstance(const Arguments args)
+HandleValue createXMLHttpReqInstance(const Arguments)
{
HandleScope scope;
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/http
On Thu, Mar 1, 2012 at 10:18 PM, Elevate Efl eflel...@gmail.com wrote: One comment to this commit. On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Remove HTTP module compile-time warnings Author: acidx Date: 2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012) New Revision: 68596 Trac: http://trac.enlightenment.org/e/changeset/68596 Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc === --- trunk/PROTO/elev8/src/modules/http/elev8_http.cc 2012-03-01 20:28:22 UTC (rev 68595) +++ trunk/PROTO/elev8/src/modules/http/elev8_http.cc 2012-03-01 20:39:19 UTC (rev 68596) @@ -8,7 +8,7 @@ int XMLHttpRequest::fd_counter = 0; HandleObjectTemplate xmlHttpReqObj; -Eina_Bool data_callback(void *data, int type, void *event) +Eina_Bool data_callback(void *data, int, void *event) Why not use __UNUSED__ like the rest of EFL. Because this is the standard way to do in C++. The rest of EFL is not C++ so we can't do this there too. Lucas De Marchi -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
