Re: [E-devel] E SVN: discomfitor trunk/e/src/modules/comp
notifications can be hard to read I guess if you have a desktop bg that's
EXACTLY the same color as the notification bg with comp enabled...maybe add
a way to increase opacity from config?
On Tue, Dec 18, 2012 at 8:33 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
in pursuit of ticket #2017, notifications now show up with the focus
effect to make them slightly more attention-getting; still no change in
opacity
Author: discomfitor
Date: 2012-12-18 00:33:04 -0800 (Tue, 18 Dec 2012)
New Revision: 81220
Trac: http://trac.enlightenment.org/e/changeset/81220
Modified:
trunk/e/src/modules/comp/e_mod_comp.c
trunk/e/src/modules/comp/e_mod_comp_cfdata.c
trunk/e/src/modules/comp/e_mod_comp_cfdata.h
Modified: trunk/e/src/modules/comp/e_mod_comp.c
===
--- trunk/e/src/modules/comp/e_mod_comp.c 2012-12-18 08:22:13 UTC
(rev 81219)
+++ trunk/e/src/modules/comp/e_mod_comp.c 2012-12-18 08:33:04 UTC
(rev 81220)
@@ -1618,6 +1618,7 @@
char buf[4096];
Eina_List *list = NULL, *l;
Match *m;
+ Eina_Bool focus = EINA_FALSE, urgent = EINA_FALSE;
const char *title = NULL, *name = NULL, *clas = NULL, *role = NULL;
Ecore_X_Window_Type primary_type = ECORE_X_WINDOW_TYPE_UNKNOWN;
@@ -1757,6 +1758,8 @@
continue;
}
}
+focus = m-focus;
+urgent = m-urgent;
if (m-shadow_style)
{
snprintf(buf, sizeof(buf), e/comp/%s,
@@ -1797,11 +1800,11 @@
edje_object_signal_emit(cw-shobj, e,state,shadow,off, e);
}
- if (cw-bd)
+ if (cw-bd || focus || urgent)
{
-if (cw-bd-focused)
+if (focus || (cw-bd cw-bd-focused))
edje_object_signal_emit(cw-shobj, e,state,focus,on, e);
-if (cw-bd-client.icccm.urgent)
+if (urgent || (cw-bd cw-bd-client.icccm.urgent))
edje_object_signal_emit(cw-shobj, e,state,urgent,on, e);
}
if (cw-visible)
Modified: trunk/e/src/modules/comp/e_mod_comp_cfdata.c
===
--- trunk/e/src/modules/comp/e_mod_comp_cfdata.c2012-12-18
08:22:13 UTC (rev 81219)
+++ trunk/e/src/modules/comp/e_mod_comp_cfdata.c2012-12-18
08:33:04 UTC (rev 81220)
@@ -23,6 +23,8 @@
E_CONFIG_VAL(D, T, argb, CHAR);
E_CONFIG_VAL(D, T, fullscreen, CHAR);
E_CONFIG_VAL(D, T, modal, CHAR);
+ E_CONFIG_VAL(D, T, focus, CHAR);
+ E_CONFIG_VAL(D, T, urgent, CHAR);
E_CONFIG_VAL(D, T, shadow_style, STR);
*conf_edd = E_CONFIG_DD_NEW(Comp_Config, Config);
@@ -106,6 +108,12 @@
mat = E_NEW(Match, 1);
cfg-match.popups = eina_list_append(cfg-match.popups, mat);
+ mat-name = eina_stringshare_add(_e_popup_notification);
+ mat-shadow_style = eina_stringshare_add(still);
+ mat-focus = 1;
+
+ mat = E_NEW(Match, 1);
+ cfg-match.popups = eina_list_append(cfg-match.popups, mat);
mat-shadow_style = eina_stringshare_add(popup);
cfg-match.borders = NULL;
Modified: trunk/e/src/modules/comp/e_mod_comp_cfdata.h
===
--- trunk/e/src/modules/comp/e_mod_comp_cfdata.h2012-12-18
08:22:13 UTC (rev 81219)
+++ trunk/e/src/modules/comp/e_mod_comp_cfdata.h2012-12-18
08:33:04 UTC (rev 81220)
@@ -56,6 +56,8 @@
charargb; // used for borders, overrides, popups, menus, 0 ==
don't use, 1 == is argb, -1 == not argb
charfullscreen; // used for borders, 0 == don't use, 1 == is
fullscreen, -1 == not fullscreen
charmodal; // used for borders, 0 == don't use, 1 == is modal,
-1 == not modal
+ charfocus; // used for setting focus state (on popups): 1 is
focused, unset is use regular logic
+ charurgent; // used for setting urgent state (on popups): 1 is
urgent, unset is use regular logic
};
EAPI voide_mod_comp_cfdata_edd_init(E_Config_DD **conf_edd,
E_Config_DD **match_edd);
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT
Re: [E-devel] E SVN: discomfitor trunk/e/src/modules/comp
On Thu, 21 Jun 2012 15:31:22 +0200 Vincent Torri vincent.to...@gmail.com said: that's a good idea. would it be possible to add a note in the code, about the reason of that change ? Vincent On Thu, Jun 21, 2012 at 3:29 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: gtk developers with IQs over 180 enjoy hiding and showing their windows constantly, especially when resizing. this broke e's comp since we are not nearly that clever and try to defer hide animations in most cases. undoing the defer whenever this happens allows us to keep up with their towering genius. fixes ticket #765 and probably some others. affected apps: claws-mail, firefox Author: discomfitor Date: 2012-06-21 06:29:45 -0700 (Thu, 21 Jun 2012) New Revision: 72600 Trac: http://trac.enlightenment.org/e/changeset/72600 Modified: trunk/e/src/modules/comp/e_mod_comp.c Modified: trunk/e/src/modules/comp/e_mod_comp.c === --- trunk/e/src/modules/comp/e_mod_comp.c 2012-06-21 12:09:08 UTC (rev 72599) +++ trunk/e/src/modules/comp/e_mod_comp.c 2012-06-21 13:29:45 UTC (rev 72600) @@ -2529,6 +2529,7 @@ Ecore_X_Event_Window_Show *ev = event; E_Comp_Win *cw = _e_mod_comp_win_find(ev-win); if (!cw) return ECORE_CALLBACK_PASS_ON; + cw-defer_hide = 0; if (cw-visible) return ECORE_CALLBACK_PASS_ON; _e_mod_comp_win_show(cw); return ECORE_CALLBACK_PASS_ON; -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/modules/comp
would it be possible to add a note in the code, about the reason of that change ? Vincent On Thu, Jun 21, 2012 at 3:29 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: gtk developers with IQs over 180 enjoy hiding and showing their windows constantly, especially when resizing. this broke e's comp since we are not nearly that clever and try to defer hide animations in most cases. undoing the defer whenever this happens allows us to keep up with their towering genius. fixes ticket #765 and probably some others. affected apps: claws-mail, firefox Author: discomfitor Date: 2012-06-21 06:29:45 -0700 (Thu, 21 Jun 2012) New Revision: 72600 Trac: http://trac.enlightenment.org/e/changeset/72600 Modified: trunk/e/src/modules/comp/e_mod_comp.c Modified: trunk/e/src/modules/comp/e_mod_comp.c === --- trunk/e/src/modules/comp/e_mod_comp.c 2012-06-21 12:09:08 UTC (rev 72599) +++ trunk/e/src/modules/comp/e_mod_comp.c 2012-06-21 13:29:45 UTC (rev 72600) @@ -2529,6 +2529,7 @@ Ecore_X_Event_Window_Show *ev = event; E_Comp_Win *cw = _e_mod_comp_win_find(ev-win); if (!cw) return ECORE_CALLBACK_PASS_ON; + cw-defer_hide = 0; if (cw-visible) return ECORE_CALLBACK_PASS_ON; _e_mod_comp_win_show(cw); return ECORE_CALLBACK_PASS_ON; -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/modules/comp
forward all beers to devilhorns for watching over my shoulder the whole time I debugged this to ensure that I didn't get too scared while reading the comp module On Thu, Jun 21, 2012 at 2:29 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: gtk developers with IQs over 180 enjoy hiding and showing their windows constantly, especially when resizing. this broke e's comp since we are not nearly that clever and try to defer hide animations in most cases. undoing the defer whenever this happens allows us to keep up with their towering genius. fixes ticket #765 and probably some others. affected apps: claws-mail, firefox Author: discomfitor Date: 2012-06-21 06:29:45 -0700 (Thu, 21 Jun 2012) New Revision: 72600 Trac: http://trac.enlightenment.org/e/changeset/72600 Modified: trunk/e/src/modules/comp/e_mod_comp.c Modified: trunk/e/src/modules/comp/e_mod_comp.c === --- trunk/e/src/modules/comp/e_mod_comp.c 2012-06-21 12:09:08 UTC (rev 72599) +++ trunk/e/src/modules/comp/e_mod_comp.c 2012-06-21 13:29:45 UTC (rev 72600) @@ -2529,6 +2529,7 @@ Ecore_X_Event_Window_Show *ev = event; E_Comp_Win *cw = _e_mod_comp_win_find(ev-win); if (!cw) return ECORE_CALLBACK_PASS_ON; + cw-defer_hide = 0; if (cw-visible) return ECORE_CALLBACK_PASS_ON; _e_mod_comp_win_show(cw); return ECORE_CALLBACK_PASS_ON; -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
