[Evolution-hackers] Required Evolution-code-help
Hi, Hopefully i am putting my question in right mailing list. I was trying to look into the root cause of the BUG(https://bugzilla.redhat.com/show_bug.cgi?id=903166) as i believe my environment is the best one to reproduce the issue.After doing a lot of RD my intuition says that it is a memory corruption issue. I looked into the openchange code (specially libmapi code1.0.4) and found that function nspi_ResolveNamesW is returning a NT_STATUS not actually the MAPISTATUS. Thus we were getting some VAGUE pop up. I am investigating further. While doing investigation i reached to the mapi function, named e_mapi_connection_init. After that i am not able to search who is the caller of that function. I did not found and dlopen/close thing as well. Thus it would be really helpful if you give some pointer regarding the caller of that function. With regards, Samarjit ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Required Evolution-code-help
Hi All,
I have observe that camel-mapi-store open a connection with Exchange server
and put it in known_connections list. This mapi-store connection is used
for periodically checking mails and updating inbox folders. If you get
mail, this connection is responsible to download those mails with periodic
polling. While composing a mail and send, function mapi_send_to_sync
tries to search all known_connections list and will pick the same
connection to send mail which one was used for downloading mails.
[code]
static gboolean
mapi_send_to_sync (CamelTransport *transport,
CamelMimeMessage *message,
CamelAddress *from,
CamelAddress *recipients,
GCancellable *cancellable,
GError **error){
..
conn = e_mapi_connection_find (profile);
..
}
This could lead to MAPI RESOLVE NAME ISSUE. Thus i have decided to create a
new connection while sending mail and then dispose off the connection. i
did the required code modification in mapi_send_to_sync function as
follows.
conn = e_mapi_connection_new (e_mail_session_get_registry
(E_MAIL_SESSION
(camel_service_get_session (service))),
profile, NULL, cancellable, mapi_error);
I build it and tried to use it. IT was UNSUCCESSFUL. it was
NT_STATUS_WRITE_FAULT as follows. I lost in sea. What to do next i am not
sure. Any idea??
-
Starting GENSEC mechanism spnego
Starting GENSEC submechanism ntlmssp
negotiate: struct NEGOTIATE_MESSAGE
Signature: 'NTLMSSP'
MessageType : NtLmNegotiate (1)
NegotiateFlags : 0x60088205 (1611170309)
1: NTLMSSP_NEGOTIATE_UNICODE
0: NTLMSSP_NEGOTIATE_OEM
1: NTLMSSP_REQUEST_TARGET
0: NTLMSSP_NEGOTIATE_SIGN
0: NTLMSSP_NEGOTIATE_SEAL
0: NTLMSSP_NEGOTIATE_DATAGRAM
0: NTLMSSP_NEGOTIATE_LM_KEY
0: NTLMSSP_NEGOTIATE_NETWARE
1: NTLMSSP_NEGOTIATE_NTLM
0: NTLMSSP_NEGOTIATE_NT_ONLY
0: NTLMSSP_ANONYMOUS
0: NTLMSSP_NEGOTIATE_OEM_DOMAIN_SUPPLIED
0: NTLMSSP_NEGOTIATE_OEM_WORKSTATION_SUPPLIED
0: NTLMSSP_NEGOTIATE_THIS_IS_LOCAL_CALL
1: NTLMSSP_NEGOTIATE_ALWAYS_SIGN
0: NTLMSSP_TARGET_TYPE_DOMAIN
0: NTLMSSP_TARGET_TYPE_SERVER
0: NTLMSSP_TARGET_TYPE_SHARE
1: NTLMSSP_NEGOTIATE_EXTENDED_SESSIONSECURITY
0: NTLMSSP_NEGOTIATE_IDENTIFY
0: NTLMSSP_REQUEST_NON_NT_SESSION_KEY
0: NTLMSSP_NEGOTIATE_TARGET_INFO
0: NTLMSSP_NEGOTIATE_VERSION
1: NTLMSSP_NEGOTIATE_128
1: NTLMSSP_NEGOTIATE_KEY_EXCH
0: NTLMSSP_NEGOTIATE_56
DomainNameLen: 0x0009 (9)
DomainNameMaxLen : 0x0009 (9)
DomainName : *
DomainName : 'WORKGROUP'
WorkstationLen : 0x0009 (9)
WorkstationMaxLen: 0x0009 (9)
Workstation : *
Workstation : 'localhost'
../librpc/rpc/dcerpc_util.c:140: auth_pad_length 0
Got challenge flags:
Got NTLMSSP neg_flags=0x62898205
NTLMSSP_NEGOTIATE_UNICODE
NTLMSSP_REQUEST_TARGET
NTLMSSP_NEGOTIATE_NTLM
NTLMSSP_NEGOTIATE_ALWAYS_SIGN
NTLMSSP_NEGOTIATE_NTLM2
NTLMSSP_NEGOTIATE_TARGET_INFO
NTLMSSP_NEGOTIATE_VERSION
NTLMSSP_NEGOTIATE_128
NTLMSSP_NEGOTIATE_KEY_EXCH
NTLMSSP: Set final flags:
Got NTLMSSP neg_flags=0x60008205
NTLMSSP_NEGOTIATE_UNICODE
NTLMSSP_REQUEST_TARGET
NTLMSSP_NEGOTIATE_NTLM
NTLMSSP_NEGOTIATE_ALWAYS_SIGN
NTLMSSP_NEGOTIATE_128
NTLMSSP_NEGOTIATE_KEY_EXCH
dcerpc: alter_resp - rpc fault: WERR_ACCESS_DENIED
Failed to bind to uuid 1544f5e0-613c-11d1-93df-00c04fd7bd09 for
1544f5e0-613c-11d1-93df-00c04fd7bd09@ncacn_ip_tcp:casarray1.hp.com[60052,print]
NT_STATUS_NET_WRITE_FAULT
Failed to connect to remote server: ncacn_ip_tcp:casarray1.hp.com[print,]
NT_STATUS_NET_WRITE_FAULT
--
With regards,
Samarjit
On Fri, Feb 22, 2013 at 4:59 AM, Zan Lynx zl...@acm.org wrote:
On Thu, 2013-02-21 at 10:26 +0100, Milan Crha wrote:
After doing a lot of RD my intuition says that it is a memory
corruption issue.
valgrind usually helps in such cases. You can run evolution like this:
$ valgrind --num-callers=50 evolution log.txt
and valgrind will check evolution for some memory issues.
I would like to offer a hint here. I have done this in the past and I
recommend using a test user account with only a very few test emails in
it.
When I attempted to run
Re: [Evolution-hackers] Required Evolution-code-help
Hi Milan Correct way would be to provide connect_sync/authenticate_ sync/disconnect_sync for the CamelMapiTransport structure, where you get everything, the password and such, without dealing with evolution internals. I can not follow the sequence of camel service connect_sync/authenticate_sync/disconnect_sync as inside that function mapi_authenticate_sync following code is present. store-priv-connection = e_mapi_connection_new ( e_mail_session_get_registry (E_MAIL_SESSION (camel_service_get_session (service))), profile, password_str, cancellable, mapi_error); Thus the pointer store-priv-connection will be overwritten during send_to_sync. Only way i found is using e_mapi_connection_new. Do let me know your view. With regards, Samarjit On Fri, Feb 22, 2013 at 3:39 PM, Milan Crha mc...@redhat.com wrote: On Fri, 2013-02-22 at 12:50 +0530, samarjit Adhikari wrote: I build it and tried to use it. IT was UNSUCCESSFUL. it was NT_STATUS_WRITE_FAULT as follows. I lost in sea. What to do next i am not sure. Any idea?? Hi, one of the reasons to reuse already running connections is slowness with which libmapi/samba connects to the server, it takes around 10 seconds here, sometimes more, sometimes less. The NT_STATUS_WRITE_FAULT is a reason of dcerpc: alter_resp - rpc fault: WERR_ACCESS_DENIED which can happen when a wrong password is used, if I recall correctly, and you passed no password, which causes the error most likely (unless you use kerberos login). The way you get to registry is also not 100% correct, but I understand there are not many options for this. I just mean that I'd not agree for such patch in upstream. Correct way would be to provide connect_sync/authenticate_sync/disconnect_sync for the CamelMapiTransport structure, where you get everything, the password and such, without dealing with evolution internals. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Required Evolution-code-help
hi All, As suggested, I have open a mapi connection using camel services but got a crash in g_rec_mutex_lock function. Crash debugging attached. it seems the connection has not being initialized yet. Any help?? My latest code changes are present in following branch. i have attached modified files as well. http://bazaar.launchpad.net/~samarjit-adhikari/evolution/evolution-mapi-3.6.2/changes With regards, Samarjit On Fri, Feb 22, 2013 at 5:46 PM, samarjit Adhikari samarjit.adhik...@gmail.com wrote: Hi Milan Correct way would be to provide connect_sync/authenticate_ sync/disconnect_sync for the CamelMapiTransport structure, where you get everything, the password and such, without dealing with evolution internals. I can not follow the sequence of camel service connect_sync/authenticate_sync/disconnect_sync as inside that function mapi_authenticate_sync following code is present. store-priv-connection = e_mapi_connection_new ( e_mail_session_get_registry (E_MAIL_SESSION (camel_service_get_session (service))), profile, password_str, cancellable, mapi_error); Thus the pointer store-priv-connection will be overwritten during send_to_sync. Only way i found is using e_mapi_connection_new. Do let me know your view. With regards, Samarjit On Fri, Feb 22, 2013 at 3:39 PM, Milan Crha mc...@redhat.com wrote: On Fri, 2013-02-22 at 12:50 +0530, samarjit Adhikari wrote: I build it and tried to use it. IT was UNSUCCESSFUL. it was NT_STATUS_WRITE_FAULT as follows. I lost in sea. What to do next i am not sure. Any idea?? Hi, one of the reasons to reuse already running connections is slowness with which libmapi/samba connects to the server, it takes around 10 seconds here, sometimes more, sometimes less. The NT_STATUS_WRITE_FAULT is a reason of dcerpc: alter_resp - rpc fault: WERR_ACCESS_DENIED which can happen when a wrong password is used, if I recall correctly, and you passed no password, which causes the error most likely (unless you use kerberos login). The way you get to registry is also not 100% correct, but I understand there are not many options for this. I just mean that I'd not agree for such patch in upstream. Correct way would be to provide connect_sync/authenticate_sync/disconnect_sync for the CamelMapiTransport structure, where you get everything, the password and such, without dealing with evolution internals. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers sendto_sync_crash Description: Binary data ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Required Evolution-code-help
I am taking about the change #1297-1301 With regards, Samarjit On Mon, Feb 25, 2013 at 10:31 AM, samarjit Adhikari samarjit.adhik...@gmail.com wrote: hi All, As suggested, I have open a mapi connection using camel services but got a crash in g_rec_mutex_lock function. Crash debugging attached. it seems the connection has not being initialized yet. Any help?? My latest code changes are present in following branch. i have attached modified files as well. http://bazaar.launchpad.net/~samarjit-adhikari/evolution/evolution-mapi-3.6.2/changes With regards, Samarjit On Fri, Feb 22, 2013 at 5:46 PM, samarjit Adhikari samarjit.adhik...@gmail.com wrote: Hi Milan Correct way would be to provide connect_sync/authenticate_ sync/disconnect_sync for the CamelMapiTransport structure, where you get everything, the password and such, without dealing with evolution internals. I can not follow the sequence of camel service connect_sync/authenticate_sync/disconnect_sync as inside that function mapi_authenticate_sync following code is present. store-priv-connection = e_mapi_connection_new ( e_mail_session_get_registry (E_MAIL_SESSION (camel_service_get_session (service))), profile, password_str, cancellable, mapi_error); Thus the pointer store-priv-connection will be overwritten during send_to_sync. Only way i found is using e_mapi_connection_new. Do let me know your view. With regards, Samarjit On Fri, Feb 22, 2013 at 3:39 PM, Milan Crha mc...@redhat.com wrote: On Fri, 2013-02-22 at 12:50 +0530, samarjit Adhikari wrote: I build it and tried to use it. IT was UNSUCCESSFUL. it was NT_STATUS_WRITE_FAULT as follows. I lost in sea. What to do next i am not sure. Any idea?? Hi, one of the reasons to reuse already running connections is slowness with which libmapi/samba connects to the server, it takes around 10 seconds here, sometimes more, sometimes less. The NT_STATUS_WRITE_FAULT is a reason of dcerpc: alter_resp - rpc fault: WERR_ACCESS_DENIED which can happen when a wrong password is used, if I recall correctly, and you passed no password, which causes the error most likely (unless you use kerberos login). The way you get to registry is also not 100% correct, but I understand there are not many options for this. I just mean that I'd not agree for such patch in upstream. Correct way would be to provide connect_sync/authenticate_sync/disconnect_sync for the CamelMapiTransport structure, where you get everything, the password and such, without dealing with evolution internals. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [Bug 903166] ResolveNames MAPI Error
Hi Milan, I have already implemented camel-service callbacks to create a new connection while sending mails and then dispose off the connection. I believe MSExchange has implemented some limitation of ResolveName query number per connection. Thus it is required to open a new connection while sending mails. Details of my check ins are given below. Please review the code change. change#1307 http://bazaar.launchpad.net/~samarjit-adhikari/evolution/evolution-mapi-3.6.2/changes Is your code fix different than me? Did you check the code in git branch. I need to import your change into bazar branch and initiate a build. The bad news is that my redhat system is in recovery process and thus not ready to test given temporary bits. My ubunu system is up and i can pull in your change and could initiate a build. I believe following last 2 commits were not related to your changes. Teach collection backend about Kerberos authenticationhttp://git.gnome.org/browse/evolution-mapi/commit/src?h=gnome-3-6id=3594369638f59269a5945c4ddc706d966f00bbdf Allow debugging of an account Authenticate processhttp://git.gnome.org/browse/evolution-mapi/commit/src?h=gnome-3-6id=da2e53f8a04c85da848b1ea8331b953b70fdfa47 With regards, Samarjit On Tue, Feb 26, 2013 at 5:10 PM, bugzi...@redhat.com wrote: Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903166 --- Comment #32 from Milan Crha mc...@redhat.com --- I managed to create a patch which always creates a new connection when sending a message, which makes sending significantly slower here, but it can be different with other servers. I created a test build [1] with the patch include, I'll appreciate if you could test it. Thanks in advance. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5057030 -- You are receiving this mail because: You reported the bug. ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Code help required for evolution hung opening meeting invitation
aah! Looks like you're running into a known GObject deadlock Interesting. let me dig into the code with this pointer. With regards, Samarjit On Mon, Mar 4, 2013 at 8:59 PM, Matthew Barnes mbar...@redhat.com wrote: On Sat, 2013-03-02 at 18:21 +0530, Samarjit Adhikari wrote: If you have any intuition why this problem is happening , do let me know. I shall look into the code and try to fix it. Looks like you're running into a known GObject deadlock. https://bugzilla.gnome.org/show_bug.cgi?id=674885 We can work around it by registering the GType earlier. Matthew Barnes ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] Evolution crashes while creating appointment from Mail
Hi All
[My Evolution configuration]
Version: 3.6.4+
Plugin: evolution-mapi
[steps to reproduce]
1. Select any mail from inbox.
2. Right Click on a mail. A action menu list will appear.
3. Choose Create--Create an Appointment
4. it will ask for Select destination
5. Select Personal on this computer followed by OK
6. A Appointment window will open. Just cancel it by closing it.
7. It will ask Would you like to save changes to this appointment?
8. Select Discard Changes
9. Now left click on any places of evolution. It will crash
Attaching gdb what is being found
===
Breakpoint 1, e_mail_reader_check_state (reader=reader@entry=0x7f22a8d31340)
at e-mail-reader.c:4129
4129e-mail-reader.c: No such file or directory.
(gdb) c
Continuing.
Breakpoint 2, camel_folder_get_parent_store (folder=0x7f22a8f93730) at
camel-folder.c:2113
2113camel-folder.c: No such file or directory.
(gdb) p folder
$1 = (CamelFolder *) 0x7f22a8f93730
(gdb) p *folder
$2 = {parent = {parent = {g_type_instance = {g_class = 0x7f22a8f93580},
ref_count = 0, qdata = 0x0}, priv = 0x7f22a8f937d0},
priv = 0x7f22a8f937e0, summary = 0x0, folder_flags =
CAMEL_FOLDER_HAS_SUMMARY_CAPABILITY, permanent_flags = 159, later = {0x0,
0x0, 0x0,
0x0}}
(gdb) b e-mail-reader.c:4172
Breakpoint 3 at 0x7f22729ff41c: file e-mail-reader.c, line 4172.
(gdb) c
Continuing.
Breakpoint 2, camel_folder_get_parent_store (folder=0x7f22a8f93730) at
camel-folder.c:2112
2112in camel-folder.c
*(gdb) p store
$3 = (GtkListStore *) 0x0
*(gdb) p *folder
$4 = {parent = {parent = {g_type_instance = {g_class = 0x7f22a8f93580},
ref_count = 0, qdata = 0x0}, priv = 0x7f22a8f937d0},
priv = 0x7f22a8f937e0, summary = 0x0, folder_flags =
CAMEL_FOLDER_HAS_SUMMARY_CAPABILITY, permanent_flags = 159, later = {0x0,
0x0, 0x0,
0x0}}
(gdb) p *folder-priv
$5 = {lock = {mutex = {mutex = 0x7f224c178940, unused = {__data = {__lock =
0, __count = 0, __owner = 0, __nusers = 0, __kind = 0,
__spins = 0, __list = {__prev = 0x0, __next = 0x0}}, __size =
'\000' repeats 39 times, __align = 0}}, depth = 0, unused = {
owner = 0, dummy = 0}}, change_lock = {mutex = 0x0, unused = {__data
= {__lock = 0, __count = 0, __owner = 0, __nusers = 0, __kind = 0,
__spins = 0, __list = {__prev = 0x0, __next = 0x0}}, __size =
'\000' repeats 39 times, __align = 0}}, frozen = 0,
changed_frozen = 0x7f22840212f0, skip_folder_lock = 0, pending_changes =
0x0, parent_store = 0x0, full_name = 0x7f224c005f90 \300c,
display_name = 0x7f224c0013f0 \260\020, description = 0x7f224c006380
\240]}
(gdb) p *account_store
No symbol account_store in current context.
===
File bt_evolution_8651_04082013.txt contains stack trace just before step
9.
File createAppointmentStackTrace contains traces when crash happens at
step 9
With regards,
Samarjit
[New LWP 8696]
[New LWP 8682]
[New LWP 8681]
[New LWP 8657]
[New LWP 8656]
[New LWP 8655]
[New LWP 8654]
[Thread debugging using libthread_db enabled]
Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1.
0x7f6e73470303 in poll () from /lib/x86_64-linux-gnu/libc.so.6
Thread 8 (Thread 0x7f6e616c6700 (LWP 8654)):
#0 0x7f6e73470303 in poll () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x7f6e739abd84 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x7f6e739ac1e2 in g_main_loop_run () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x7f6e73f774a6 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#4 0x7f6e739cf645 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x7f6e7374ee9a in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#6 0x7f6e7347bcbd in clone () from /lib/x86_64-linux-gnu/libc.so.6
#7 0x in ?? ()
Thread 7 (Thread 0x7f6e5b7b6700 (LWP 8655)):
#0 0x7f6e73470303 in poll () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x7f6e739abd84 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x7f6e739abea4 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x7f6e5b7bd4ad in ?? () from
/usr/lib/x86_64-linux-gnu/gio/modules/libdconfsettings.so
#4 0x7f6e739cf645 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x7f6e7374ee9a in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#6 0x7f6e7347bcbd in clone () from /lib/x86_64-linux-gnu/libc.so.6
#7 0x in ?? ()
Thread 6 (Thread 0x7f6e5afb5700 (LWP 8656)):
#0 0x7f6e73470303 in poll () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x7f6e739abd84 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x7f6e739abea4 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x7f6e739abef1 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x7f6e739cf645 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x7f6e7374ee9a in
Re: [Evolution-hackers] Evolution crashes while creating appointment from Mail
Hi Johnny, If 1 more person can reproduce the crash along with me , I will go ahead and report it in Bugzilla. Are you able to reproduce using my given steps ? with regards, Samarjit ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Evolution crashes while creating appointment from Mail
Hi All, I tried it with my IMAP account as well and yes it did not crash. Thus issue is with only MAPI Account. Hope some one will try to reproduce it with MAPI Account With regards, Samarjit On Mon, Apr 8, 2013 at 5:45 PM, Sasa Ostrouska cas...@gmail.com wrote: I tried it too to reproduce it on 3.6.4 it didnt crash for me. Rgds Saxa On Mon, Apr 8, 2013 at 10:00 AM, Milan Crha mc...@redhat.com wrote: On Mon, 2013-04-08 at 09:51 +0530, samarjit Adhikari wrote: If 1 more person can reproduce the crash along with me , I will go ahead and report it in Bugzilla. Are you able to reproduce using my given steps ? Hi, I tried in (to be) 3.9.1 (git master), on your original email in this thread, and after Discard I clicked on Johnny's reply to your message, and evolution didn't crash to me. It doesn't mean the bug is not present, it just means that it can depend on various factors. For example, I did this testing in my IMAP folder. On the other hand, there is a chance that 3.8.0 has it fixed. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Evolution crashes while creating appointment from Mail
Anybody able to reproduce with MAPI account? With regards, Samarjit On Mon, Apr 8, 2013 at 7:32 PM, samarjit Adhikari samarjit.adhik...@gmail.com wrote: Hi All, I tried it with my IMAP account as well and yes it did not crash. Thus issue is with only MAPI Account. Hope some one will try to reproduce it with MAPI Account With regards, Samarjit On Mon, Apr 8, 2013 at 5:45 PM, Sasa Ostrouska cas...@gmail.com wrote: I tried it too to reproduce it on 3.6.4 it didnt crash for me. Rgds Saxa On Mon, Apr 8, 2013 at 10:00 AM, Milan Crha mc...@redhat.com wrote: On Mon, 2013-04-08 at 09:51 +0530, samarjit Adhikari wrote: If 1 more person can reproduce the crash along with me , I will go ahead and report it in Bugzilla. Are you able to reproduce using my given steps ? Hi, I tried in (to be) 3.9.1 (git master), on your original email in this thread, and after Discard I clicked on Johnny's reply to your message, and evolution didn't crash to me. It doesn't mean the bug is not present, it just means that it can depend on various factors. For example, I did this testing in my IMAP folder. On the other hand, there is a chance that 3.8.0 has it fixed. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Evolution crashes while creating appointment from Mail
Hi Mila, no crash for me. Simple text message, after Discard changes I clicked on a message above the currently selected, which was downloaded and shown. You are right Milan, it is also not crashing for simple text messages. But in my environment there are lot of multipart messages. Could you give me some code hint so that I myself can start looking into it? With regards, Samarjit On Tue, Apr 9, 2013 at 3:08 PM, Milan Crha mc...@redhat.com wrote: On Mon, 2013-04-08 at 19:32 +0530, samarjit Adhikari wrote: Thus issue is with only MAPI Account. Hope some one will try to reproduce it with MAPI Account Hi, no crash for me. Simple text message, after Discard changes I clicked on a message above the currently selected, which was downloaded and shown. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Evolution crashes while creating appointment from Mail
Thanks Milan for confirming this. I was playing with gdb for this issue and have little guess that it could be because of memory corruption Then you confirm it. Let me start playing with valgrind as well. With regards, samarjit On Tue, Apr 9, 2013 at 4:17 PM, Milan Crha mc...@redhat.com wrote: On Tue, 2013-04-09 at 15:44 +0530, samarjit Adhikari wrote: You are right Milan, it is also not crashing for simple text messages. But in my environment there are lot of multipart messages. Hi, I think I got something similar with simple text message too. The thing is that every detail matters, thus: 9. Now left click on any places of evolution. It will crash is not the best description, because my any place was a message above the currently selected. If I change it to: 9a) left click on a MAPI account name in the folder tree 9b) left click on MAPI's Inbox in the folder tree then I get set of critical warnings on console and a crash of evolution. This does it only with MAPI (I tested same steps with IMAP), but the backtrace itself is different from that yours. In any case, I believe it's related, if not the same issue as you have, thus please file a bug into GNOME's bugzilla [1] and let's investigate further there. Could you give me some code hint so that I myself can start looking into it? It's not that simple, it seems like a memory corruption or a misplaced g_object_unref(), which is not easy to track. Tools like valgrind usually help. Thanks, Milan [1] https://bugzilla.gnome.org/enter_bug.cgi?product=Evolution-mapi ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] https://bugzilla.gnome.org/show_bug.cgi?id=697632
Hi All, Probably I have managed to cook a fix for bug 697632. Code review is required to confirm the fix. I am not sure how to create patch. I took a diff and attaching here. File: pluginshttp://bazaar.launchpad.net/%7Esamarjit-adhikari/evolution/evolution-3.6.2/files/353/plugins /mail-to-taskhttp://bazaar.launchpad.net/%7Esamarjit-adhikari/evolution/evolution-3.6.2/files/353/plugins/mail-to-task /mail-to-task.c Function: do_mail_to_event [branch Where I have check in my code] http://bazaar.launchpad.net/~samarjit-adhikari/evolution/evolution-3.6.2/revision/353 [Reason Behind the Change] We are not doing any g_object_ref for folder object in this function. Thus unref should not be present as well. This is a dangling g_object_unref on folder object. But one confusion I have. Do we need to add g_object_ref anywhere on folder object? Do let me know your view as well. With regards, Samarjit Proposed_Fix_697632.diff Description: Binary data ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] https://bugzilla.gnome.org/show_bug.cgi?id=697632
Thanks Milan for the review. Good catch, the e_mail_reader_get_folder() doesn't return reffed folder, but the mail-to-task still unrefs the folder. I guess it's some artifact from the time when the function was introduced. I see few more places in the mail-to-task.c which does the unref, please update your patch and attach it to bugzilla. That's the confusion I have. So will the good fix be a g_object_ref inside e_mail_reader_get_folder on folder object? or is it ok to delete the unref. In that case I need to delete all unref consistently in mail-to-task. With regards, Samarjit On Mon, Apr 15, 2013 at 1:55 PM, Milan Crha mc...@redhat.com wrote: On Mon, 2013-04-15 at 12:20 +0530, samarjit Adhikari wrote: Probably I have managed to cook a fix for bug 697632. Code review is required to confirm the fix. I am not sure how to create patch. I took a diff and attaching here. Hi, thanks for the work on this. If it's related to a bug, then attach patch there, not to the mailing list. From a quick review: a) the '//' is a C++ comment, you get a compiler warning on it; if the unref is not needed, then just delete it. b) how did you get the diff? I suppose it's not from a git clone (with 'git diff'), because the 'git diff' shows also a function name in which you did the change, while your diff doesn't do that. c) Good catch, the e_mail_reader_get_folder() doesn't return reffed folder, but the mail-to-task still unrefs the folder. I guess it's some artifact from the time when the function was introduced. I see few more places in the mail-to-task.c which does the unref, please update your patch and attach it to bugzilla. Thanks and bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] https://bugzilla.gnome.org/show_bug.cgi?id=697632
Thanks for holding my hands and helping me to move forward. With regards, Samarjit On Mon, Apr 15, 2013 at 2:24 PM, Milan Crha mc...@redhat.com wrote: On Mon, 2013-04-15 at 14:14 +0530, samarjit Adhikari wrote: That's the confusion I have. So will the good fix be a g_object_ref inside e_mail_reader_get_folder on folder object? or is it ok to delete the unref. In that case I need to delete all unref consistently in mail-to-task. I'm fine with deleting the g_object_unref() calls on folders returned by e_mail_reader_get_folder() in mail-to-task code which run in the main thread (like a response to an action), but if the folder is meant to be passed into a thread, then for thread safety ref the folder before running the thread and unref it at the end of the thread. (I'm not much helpful, right?) :) Definitely do not change e_mail_reader_get_folder(), it should be left as is. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Tentative 3.11 schedule
Hi Matt, Where did you release 3.10? I could see only old releases (3.8/9) in Evolution home page. https://projects.gnome.org/evolution/download.shtml With regards, Samarjit On Sun, Oct 13, 2013 at 9:08 PM, Matthew Barnes mbar...@redhat.com wrote: I just released 3.10.1 and still haven't seen an official release schedule from GNOME, so I penciled one in for us based on the 3.7 schedule from last year. https://wiki.gnome.org/Apps/Evolution/ReleaseHOWTO#Release_Schedule According to this schedule, the first 3.11 release is due next Monday (October 21st). Let's proceed with that unless GNOME posts something official this week. Matt ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Keeping your contacts in order
Thanks Tristan. Documention[0] gives me a lot of overview on cursor. With regards, Samarjit On Thu, Oct 24, 2013 at 10:05 PM, Tristan Van Berkom trista...@openismus.com wrote: Hi, I'm pleased to announce that today we've finally landed the addressbook cursor API in EDS master, a project which has been months in the making. What is the cursor API ? The EBookClientCursor is an API which allows iteration over a sorted contact list. The cursor could be used for a variety of things, but was primarily designed with sorted contact browsing user interfaces in mind. The cursor API provides rich i18n support, allowing and aiding one to design contact browsers which can be used, and are suitable, for virtually any locale. I'm proud of the documented[0] so please go ahead and read it :) Really there are a lot of details so I wont go over all of the features and show case the API in this email. A word on ICU localization The ICU libraries (International Components for Unicode) are now a hard dependency for Evolution Data Server. The ICU libraries are very available and in common usage. EDS already consumes ICU optionally through libphonenumber, and pango consumes ICU through harfbuzz. Another thing of note is that now the addressbook is locale aware and has a locale setting, this setting will automatically adapt to dynamic system locale changes. In the user facing APIs, the locale configuration of the addressbook can be obtained at any time with e_book_client_get_locale(). The locale configuration is driven by the system locale configuration D-Bus interface provided/defined by systemd[1], org.freedesktop.locale1. On Backends ~~~ Currently the cursor is only implemented by the local file backend, and the grunt work is done by the EBookBackendSqliteDB object (this object is also shared with other backends, making it easier at least for those backends to adapt and support the cursor API). For backends which use an EBookBackendSqliteDB object, one can implement cursors with very little effort using the EDataBookCursorSqlite cursor implementation. If other backends want to implement cursors, they need to create their own implementation of the abstract EDataBookCursor class. Some documentation on implementing the cursor class can be found here[2]. Example Code This branch comes with a sort of reference implementation for a sorted contact browser which leverages most of the cursor's features. This example code uses the template features from the new GTK+ releases, so I've added some lines to configure.ac to declare a completely separate set of dependencies to build the example code. The reasons I did it this way are: o Because we want the example code to be shown in documentation, so we would rather really show the newest, most recommended example for newly written code. o Because we don't want EDS to be bound to the same GTK+ version requirements (EDS depends on GTK+ for an authorization prompt dialog). This example code can be found here[3]. Enjoy, -Tristan [0]:https://people.gnome.org/~tvb/libebook/EBookClientCursor.html [1]:http://www.freedesktop.org/wiki/Software/systemd/localed/ [2]:https://people.gnome.org/~tvb/libedata-book/EDataBookCursor.html [3]: https://git.gnome.org/browse/evolution-data-server/tree/tests/cursor-example/ ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
