Re: [Evolution-hackers] Request for improved svn commit messages
Le samedi 06 octobre 2007 à 00:46 +0530, Srinivasa Ragavan a écrit : > Nice discussion guys. Lets go this way then. > > - Sync ChangeLogs with commit logs > - "Why instead of what" in ChangeLogs > > It is just that I never saw a reason for myself and If people see a > value out of it, lets help them then. Thanks you very much, this change will be greatly appreciated by many people ;) -- Frederic Crozat <[EMAIL PROTECTED]> Mandriva ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
Hi, On Sat, 2007-10-06 at 00:46 +0530, Srinivasa Ragavan wrote: > Nice discussion guys. Lets go this way then. > > - Sync ChangeLogs with commit logs > - "Why instead of what" in ChangeLogs > Awesome!! This would also (incredibly) reduce the effort in generating the NEWS files too... :) Srinidhi. -- ASCII ribbon campaign ( )B S Srinidhi - against HTML email X http://www.srinidhi-is.in & vCards / \Bangalore ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
ahoj, though srini has already done a good(TM) decision on this, my two cents: Am Freitag, den 05.10.2007, 10:38 +0200 schrieb Frederic Crozat: > Second, being self-contained (and therefore, ease of use for external > maintainers / lurkers / packagers / release-team). You are only thinking > of svn log when using viewcvs. But if you are, just like me, subscribed > to svn-commit mailing list, it is really much easier to see directly > what it a commit purpose (fix a typo, a bug, etc) without having to rely > on another tool / website. Same apply when using svn log command > directly. for me it makes easier to search in the codebase whether a crasher bug has been perhaps already fixed in svn by searching through the changelog for potential fixes (if a crasher bug report is about an old version, or if one source file has received a lot of changes, you can't use the line numbers of the stacktrace to look up the "source area" anymore). i've done this several times within the nautilus code and it can save some time to work that way, with evo it's sometimes really hard because you have to look up and read the bug reports all the time, yepp. andre -- mailto:[EMAIL PROTECTED] | failed http://www.iomc.de/ signature.asc Description: Dies ist ein digital signierter Nachrichtenteil ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
Nice discussion guys. Lets go this way then. - Sync ChangeLogs with commit logs - "Why instead of what" in ChangeLogs It is just that I never saw a reason for myself and If people see a value out of it, lets help them then. -Srini. On Fri, 2007-10-05 at 10:16 -0400, Matthew Barnes wrote: > On Fri, 2007-10-05 at 10:38 +0200, Frederic Crozat wrote: > > Second, being self-contained (and therefore, ease of use for external > > maintainers / lurkers / packagers / release-team). You are only thinking > > of svn log when using viewcvs. But if you are, just like me, subscribed > > to svn-commit mailing list, it is really much easier to see directly > > what it a commit purpose (fix a typo, a bug, etc) without having to rely > > on another tool / website. Same apply when using svn log command > > directly. > > I second that. I also read svn-commits-list (filtered for Evolution > packages only) because I like to follow what the other developers are > working on. I personally prefer to see longer commit messages because > it saves me from having to open ViewCVS for each and every commit to > find out what it was about. > > Also, because we keep several ChangeLogs in Evolution and E-D-S, a > complete set of changes for a particular bug is often fractured across > several different ChangeLog files. So I try to merge them into a single > ChangeLog entry when preparing a commit message, prepending full path > names to the filenames where necessary. I do this for the benefit of > others reading svn-commits-list, and also to help improve "code > archaeology" [1], as Federico talked about in one of the few insightful > responses I saw in that recent thread on desktop-devel-list. > > Also, thanks to Federico's post, I've been trying to write ChangeLog > entries that describe *why* instead of *what*. See his posting for an > excellent example. > > Those are just my personal habits and disciplines. I'll follow whatever > policy the team decrees. > > Matthew Barnes > > [1] > http://mail.gnome.org/archives/desktop-devel-list/2007-September/msg00238.html > > ___ > Evolution-hackers mailing list > Evolution-hackers@gnome.org > http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
On Fri, 2007-10-05 at 10:38 +0200, Frederic Crozat wrote: > Second, being self-contained (and therefore, ease of use for external > maintainers / lurkers / packagers / release-team). You are only thinking > of svn log when using viewcvs. But if you are, just like me, subscribed > to svn-commit mailing list, it is really much easier to see directly > what it a commit purpose (fix a typo, a bug, etc) without having to rely > on another tool / website. Same apply when using svn log command > directly. I second that. I also read svn-commits-list (filtered for Evolution packages only) because I like to follow what the other developers are working on. I personally prefer to see longer commit messages because it saves me from having to open ViewCVS for each and every commit to find out what it was about. Also, because we keep several ChangeLogs in Evolution and E-D-S, a complete set of changes for a particular bug is often fractured across several different ChangeLog files. So I try to merge them into a single ChangeLog entry when preparing a commit message, prepending full path names to the filenames where necessary. I do this for the benefit of others reading svn-commits-list, and also to help improve "code archaeology" [1], as Federico talked about in one of the few insightful responses I saw in that recent thread on desktop-devel-list. Also, thanks to Federico's post, I've been trying to write ChangeLog entries that describe *why* instead of *what*. See his posting for an excellent example. Those are just my personal habits and disciplines. I'll follow whatever policy the team decrees. Matthew Barnes [1] http://mail.gnome.org/archives/desktop-devel-list/2007-September/msg00238.html ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
Le vendredi 05 octobre 2007 à 13:36 +0530, Srinivasa Ragavan a écrit : > Oh, I remember a thread on d-d-l where there was discussion on two > ChangeLogs (one part of tree and other part of svn logs). Btw, I'm one > of those who use those short logs for svn commits and I know a few > people who copy ChangeLogs to svn commit logs. > > In anycase, I really dont know/see what is the benefit of this over the > short messages. Many times with patches and review being on bugzilla, > atleast I find easy to see what broke where with just the bug number > part of commit logs over viewcvs. First, consistency : evolution/e-d-s are almost the only modules on GNOME using "micro" message for SVN commit. And it isn't even consistent across evolution maintainers ;) Second, being self-contained (and therefore, ease of use for external maintainers / lurkers / packagers / release-team). You are only thinking of svn log when using viewcvs. But if you are, just like me, subscribed to svn-commit mailing list, it is really much easier to see directly what it a commit purpose (fix a typo, a bug, etc) without having to rely on another tool / website. Same apply when using svn log command directly. It is the same reason why we ask people, when requesting freeze break, to attach patch to mail and not just a link to bugzilla :) (Just to be clear, this suggestion is not done with my release-team hat :) -- Frederic Crozat <[EMAIL PROTECTED]> Mandriva ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
When we began to make Evolution patches 5 years ago, we were required to make the commit changlog the same as the one in ChangeLog by Evolution maintainers. So we have been doing copy&paste for all the time. Maybe this has been changed. But I still prefer this old way. This makes the viewcvs from http://svn.gnome.org more readable. And as we don't need to write down a short log, this might take less time :) Just my 2 cents. Harry Srinivasa Ragavan ??: Oh, I remember a thread on d-d-l where there was discussion on two ChangeLogs (one part of tree and other part of svn logs). Btw, I'm one of those who use those short logs for svn commits and I know a few people who copy ChangeLogs to svn commit logs. In anycase, I really dont know/see what is the benefit of this over the short messages. Many times with patches and review being on bugzilla, atleast I find easy to see what broke where with just the bug number part of commit logs over viewcvs. -Srini. On Fri, 2007-10-05 at 09:47 +0200, Frederic Crozat wrote: Hi everyone, I'd like to suggest to Evolution hackers, whenever it is possible for them, to try to improve their svn commit messages. Some of you are currently using a very short commit message (something like "fix for bug#xxx), which make reading svn commit extremely difficult without having to go each time on bugzilla to see what was the fix really for. Moreover, it also adds complexity when you are checking a file history and bump into such commits. May I suggest you use either the same ChangeLog entry you wrote in the various changelog file (so it is even faster, just use copy/paste :) or even a stripped version of it (it used to be extremely useful for CVS to see which files were changed at the same time, but it is no longer required with svn atomic commit) ? Thanks you in advance. ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for improved svn commit messages
Oh, I remember a thread on d-d-l where there was discussion on two ChangeLogs (one part of tree and other part of svn logs). Btw, I'm one of those who use those short logs for svn commits and I know a few people who copy ChangeLogs to svn commit logs. In anycase, I really dont know/see what is the benefit of this over the short messages. Many times with patches and review being on bugzilla, atleast I find easy to see what broke where with just the bug number part of commit logs over viewcvs. -Srini. On Fri, 2007-10-05 at 09:47 +0200, Frederic Crozat wrote: > Hi everyone, > > I'd like to suggest to Evolution hackers, whenever it is possible for > them, to try to improve their svn commit messages. > > Some of you are currently using a very short commit message > (something like "fix for bug#xxx), which make reading svn commit > extremely difficult without having to go each time on bugzilla to see > what was the fix really for. Moreover, it also adds complexity when you > are checking a file history and bump into such commits. > > May I suggest you use either the same ChangeLog entry you wrote in the > various changelog file (so it is even faster, just use copy/paste :) or > even a stripped version of it (it used to be extremely useful for CVS to > see which files were changed at the same time, but it is no longer > required with svn atomic commit) ? > > Thanks you in advance. ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] Request for improved svn commit messages
Hi everyone, I'd like to suggest to Evolution hackers, whenever it is possible for them, to try to improve their svn commit messages. Some of you are currently using a very short commit message (something like "fix for bug#xxx), which make reading svn commit extremely difficult without having to go each time on bugzilla to see what was the fix really for. Moreover, it also adds complexity when you are checking a file history and bump into such commits. May I suggest you use either the same ChangeLog entry you wrote in the various changelog file (so it is even faster, just use copy/paste :) or even a stripped version of it (it used to be extremely useful for CVS to see which files were changed at the same time, but it is no longer required with svn atomic commit) ? Thanks you in advance. -- Frederic Crozat <[EMAIL PROTECTED]> Mandriva ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
