[Bug 431669] Review Request: gtkyahoo - Yahoo Messenger client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkyahoo - Yahoo Messenger client https://bugzilla.redhat.com/show_bug.cgi?id=431669 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 04:16 EST --- Upstream said gtkyahoo is long since out of date.. So I closed this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 04:25 EST --- Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-4.beta2a.fc8.src.rpm Thanks for patch! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 04:45 EST --- GPLv2+ and LGPL (with appropriate version). Then put a comment explaining which files are under LGPL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 240373] Review Request: qtiplot - Data Analysis and Scientific Plotting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qtiplot - Data Analysis and Scientific Plotting https://bugzilla.redhat.com/show_bug.cgi?id=240373 Bug 240373 depends on bug 344641, which changed state. Bug 344641 Summary: Package is missing in the repo https://bugzilla.redhat.com/show_bug.cgi?id=344641 What|Old Value |New Value Status|NEW |CLOSED Resolution||NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249236] Review Request: kde-style-domino - KDE style with a soft look
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kde-style-domino - KDE style with a soft look https://bugzilla.redhat.com/show_bug.cgi?id=249236 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 05:02 EST --- Ping ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432239] New: Review Request: electronics-menu - Electronics Menu for the Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=432239 Summary: Review Request: electronics-menu - Electronics Menu for the Desktop Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://chitlesh.fedorapeople.org/RPMS/electronic-menu/electronics-menu.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/electronic-menu/electronics-menu-1.0-1.fc8.src.rpm Description: The programs from the category Electronics are currently located in the Edutainment directory. This Package adds a Edutainment-Electronics menu to the xdg menu structure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431665] Review Request: fox - A C++ library for GUI development
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fox - A C++ library for GUI development https://bugzilla.redhat.com/show_bug.cgi?id=431665 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 05:46 EST --- I'm having a chat to upstream about the issues relating to the code to get feedback. I have linked the review request in my email he has advised that he will take a look and comment so I'll await his comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 05:31 EST --- Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Fixed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432239] Review Request: electronics-menu - Electronics Menu for the Desktop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: electronics-menu - Electronics Menu for the Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=432239
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2008-02-10 06:49 EST ---
It builds under Mock, and rpmlint return one warning :
electronics-menu.noarch: W: non-conffile-in-etc
/etc/xdg/menus/applications-merged/electronics.menu
Please note that + items are OK, - items should be fixed or justified, ~ items
needs further investigation.
* MUST items
+ Respect naming guidelines.
+ License: GPLv2 OK
+ The spec file must be written in American English.
+ The spec file for the package MUST be legible.
+ The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
+ Compile on i386 and x86_64 at least.
+ locales are properly handled.
+ Every binary RPM package which stores shared library files (not just symlinks)
in any of the dynamic linker's default paths, must call ldconfig in %post and
%postun.
+ Not relocatable.
+ A package must own all directories that it creates.
+ A package must not contain any duplicate files in the %files listing.
+ Permissions on files must be set properly.
+ Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
+ Each package must consistently use macros, as described in the macros section
of Packaging Guidelines.
+ The package must contain code, or permissable content.
+ Large documentation files should go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity)
+ If a package includes something as %doc, it must not affect the runtime of the
application.
+ Header files must be in a -devel package.
+ Static libraries must be in a -static package.
+ Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
+ If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package.
+ In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
+ Packages must NOT contain any .la libtool archives, these should be removed in
the spec.
+ Packages containing GUI applications must include a %{name}.desktop file, and
that file must be properly installed with desktop-file-install in the %install
section.
+ Packages must not own files or directories already owned by other packages.
+ At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages must be valid UTF-8.
* SHOULD Items:
+ Includes licenses text.
+ The description and summary sections in the package spec file should contain
translations for supported Non-English languages, if available.
+ Builds in mock (i386 x86_64)
~ Builds on i386 x86_64 (not tested on PPC)
+ runs without segmentation faults
+ No scriptlets.
+ No subpackages.
+ The placement of pkgconfig(.pc) files depends on their usecase, and this is
usually for development purposes, so should be placed in a -devel pkg. A
reasonable exception is that the main pkg itself is a devel tool not installed
in a user runtime, e.g. gcc or gdb.
+ If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin,
or /usr/sbin consider requiring the package which provides the file instead of
the file itself. Please see File Dependencies in the Guidelines for further
information.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432239] Review Request: electronics-menu - Electronics Menu for the Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: electronics-menu - Electronics Menu for the Desktop https://bugzilla.redhat.com/show_bug.cgi?id=432239 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 06:58 EST --- Thanks Benôit for this quick review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432239] Review Request: electronics-menu - Electronics Menu for the Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: electronics-menu - Electronics Menu for the Desktop https://bugzilla.redhat.com/show_bug.cgi?id=432239 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 06:55 EST --- This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432239] Review Request: electronics-menu - Electronics Menu for the Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: electronics-menu - Electronics Menu for the Desktop https://bugzilla.redhat.com/show_bug.cgi?id=432239 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 06:58 EST --- New Package CVS Request === Package Name: electronics-menu Short Description: Electronics Menu for the Desktop Owners: chitlesh Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431156] Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities https://bugzilla.redhat.com/show_bug.cgi?id=431156 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 07:11 EST --- Okay. This package (ruby-openid) is APPROVED by me - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431181] Review Request: libitl - Libraries for The Islamic Tools and Libraries Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libitl - Libraries for The Islamic Tools and Libraries Project https://bugzilla.redhat.com/show_bug.cgi?id=431181 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 07:17 EST --- Jason, this bug blocks the following two review requests. Would you update the status? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 07:14 EST --- There seems to be a small error in the file list. My mock build failed with: Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/disk-manager-1.0.1-2.fc9-root-mockbuild RPM build errors: File not found by glob: /var/tmp/disk-manager-1.0.1-2.fc9-root-mockbuild/etc/pam.d/* File not found by glob: /var/tmp/disk-manager-1.0.1-2.fc9-root-mockbuild/etc/security/console.apps/* EXCEPTION: Command failed. See logs for output. # bash -l -c 'rpmbuild -bb --target x86_64 --nodeps //builddir/build/SPECS/disk-manager.spec' Traceback (most recent call last): File /usr/lib/python2.5/site-packages/mock/trace_decorator.py, line 70, in trace result = func(*args, **kw) File /usr/lib/python2.5/site-packages/mock/util.py, line 286, in do raise mock.exception.Error, (Command failed. See logs for output.\n # %s % (command,), ret) Error: Command failed. See logs for output. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432033] Review Request: crystalspace - Crystal Space a free 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: crystalspace - Crystal Space a free 3D engine https://bugzilla.redhat.com/show_bug.cgi?id=432033 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 07:52 EST --- Hans, I noticed today that: (note: I always enable koji static-repos repo) [EMAIL PROTECTED] ~]# yum check-update skip xerces-c.i3862.8.0-1.fc9koji-rawhide xerces-c-devel.i386 2.8.0-1.fc9koji-rawhide [EMAIL PROTECTED] ~]# Resolving Dependencies -- Running transaction check --- Package xerces-c-devel.i386 0:2.8.0-1.fc9 set to be updated --- Package xerces-c.i386 0:2.8.0-1.fc9 set to be updated -- Processing Dependency: libxerces-c.so.27 for package: cegui -- Finished Dependency Resolution cegui-0.5.0b-6.fc8.i386 from installed has depsolving problems -- Missing Dependency: libxerces-c.so.27 is needed by package cegui-0.5.0b-6.fc8.i386 (installed) Error: Missing Dependency: libxerces-c.so.27 is needed by package cegui-0.5.0b-6.fc8.i386 (installed) We have to update cegui first (as this package has cegui-devel as BR) Currently cegui build on rawhide fails as: http://koji.fedoraproject.org/koji/taskinfo?taskID=411388 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432246] New: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=432246 Summary: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa-0.2.1-1.fc8.src.rpm Description: Pic2AA is tool providing converting jpeg/png (and any other image formats supported by Qt library) to AA (Ascii Art) images, using AA-Lib library. It can show preview of converted image and save image into text file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426302] Review Request: openuniverse - OpenGL space simulator focused on the Solar System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openuniverse - OpenGL space simulator focused on the Solar System https://bugzilla.redhat.com/show_bug.cgi?id=426302 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 08:09 EST --- Well the starplot package itself does not contain any such catalogs. I think you are referring to the ones provided by: starplot-gliese3 and starplot-yale5. These packages have Redistributable, no modification permitted as their license. There was a discussion on this on [EMAIL PROTECTED] : https://www.redhat.com/archives/fedora-devel-list/2007-November/msg00742.html The conversation included Spot and Hans and it was decided to generate the *.star files, needed by Starplot, from the catalogs in %post because the license allows us to re-distribute the catalogs but not modified copies (eg., *.star files) of them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431156] Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities https://bugzilla.redhat.com/show_bug.cgi?id=431156 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 08:09 EST --- New Package CVS Request === Package Name: ruby-openid Short Description: Ruby library for verifying and serving OpenID identities Owners: allisson Branches: F-7 F-8 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 09:25 EST --- Oops.. The string strict is not needed in the spec file, sorry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 09:19 EST --- Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-5.beta2a.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 09:03 EST --- Give me the logs. I can't say what's wrong for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client
https://bugzilla.redhat.com/show_bug.cgi?id=426492
--- Additional Comments From [EMAIL PROTECTED] 2008-02-10 09:04 EST ---
Created an attachment (id=294496)
-- (https://bugzilla.redhat.com/attachment.cgi?id=294496action=view)
Patch to honor Fedora cflags correctly
Thank you to Hans for fixing gcc43 related issues!
For 2.0-0.4:
* License
-
src/tools/openpgp/gpgproc/ Dual of QPL and GPLv2 (strict)
-
- License tag must be GPLv2 (strict).
* Compiler flags
- Fedora specific compilation flags are not honored correctly.
http://koji.fedoraproject.org/koji/taskinfo?taskID=411301
The proposal patch attached fixes this issue.
http://koji.fedoraproject.org/koji/taskinfo?taskID=411576
* Timestamps
- When using cp or install commands, please use -p option
to keep timestamps on installed files.
--
install -m 644 certs/readme certs/rootcert.xml
$RPM_BUILD_ROOT%{_datadir}/%{name}/certs
--
Please fix the 3 issues above before committing into CVS.
Other things are okay.
--
This package (jabbin) is APPROVED by me
--
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 09:20 EST --- New Package CVS Request === Package Name: jabbin Short Description: Instant messaging and VoIP Jabber client Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 10:21 EST --- Actually this does not build. http://koji.fedoraproject.org/koji/taskinfo?taskID=411762 You can check if your srpm builds on koji by: $ koji build --scratch target srpm_you_want_to_try Currently target can be dist-f9, dist-f8-updates-candidate, or dist-fc7-updates-candidate (and some special targets). If the scratch build is successful, the rebuilt rpms and some logs are put under: http://koji.fedoraproject.org/scratch/your_FAS_name/task_task_id/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429593] Review Request: podsleuth - probes, identifies, and exposes properties and metadata bound to iPods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: podsleuth - probes, identifies, and exposes properties and metadata bound to iPods https://bugzilla.redhat.com/show_bug.cgi?id=429593 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 10:39 EST --- * For consistency, please use the same ExclusiveArch that the mono spec uses. http://cvs.fedora.redhat.com/viewcvs/devel/mono/mono.spec?view=auto * Please separate the -devel subpackage Requires onto different lines, because it is difficult to read otherwise. * Does the -devel package need to Require: the items that the main package BuildRequires? With those addressed, this has my review and can land. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 10:55 EST --- There seems to be a small error in the file list. It can't be an error, because disk-manager provides few files over there. checking for consolehelper... no checking for modprobe... no checking for mount... no checking for umount... no checking for blkid... no checking for dmsetup... no Error... Missing dependency for usermode and... util-linux-ng, e2fsprogs, device-mapper. -- Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Should work now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] New: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=432259 Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.nsitonline.in/hemant/stuff/speechd-rpm/speech-dispatcher.spec SRPM URL: http://www.nsitonline.in/hemant/stuff/speechd-rpm/speech-dispatcher-0.6.5-6.src.rpm Comments: We need this package for the OLPC XO laptop which is based on Fedora. This is the first package I am creating and hence know it is not up to Fedora Standards as yet, and I am looking for help to achieve the standards. I am looking for a sponsor who could assist me in the process. Description: * Common interface to different TTS engines * Handling concurrent synthesis requests – requests may come assynchronously from multiple sources within an application and/or from more different applications. * Subsequent serialization, resolution of conflicts and priorities of incomming requests * Context switching – state is maintained for each client connection independently, event for connections from within one application. * High-level client interfaces for popular programming languages * Common sound output handling – audio playback is handled by Speech Dispatcher rather than the TTS engine, since most engines have limited sound output capabilities. Thanks! Hemant -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| Status|NEW |CLOSED Resolution||NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428798] Review Request: OmegaT - Computer Aid Translation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: OmegaT - Computer Aid Translation tool https://bugzilla.redhat.com/show_bug.cgi?id=428798 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 12:02 EST --- Applied all suggestions: Spec URL: http://olea.org/tmp/omegat.spec SRPM URL: http://olea.org/paquetes-rpm/OmegaT-1.7.3-4olea.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 12:24 EST --- Why did you close this as NOTABUG? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |ASSIGNED Keywords||Reopened Resolution|NOTABUG | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo? --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 12:39 EST --- (In reply to comment #1) Why did you close this as NOTABUG? I seem to have done that by mistake.. I have reopened it now. Thanks for pointing it out. Although I am not able to figure out what the STATUS for this bug needs to be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] New: Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=432262 Summary: Review Request: flobopuyo - 2-player falling bubbles game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo-0.20-2.fc8.src.rpm Description: A two-player falling bubbles game. The goal is to make groups of four or more Puyos (colored bubbles) to make them explode and send bad ghost Puyos to your opponent. You win the game if your opponent reaches the top of the board. You can play against computer or another human. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432265] Review Request: astronomy-bookmarks - Fedora astronomy bookmarks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: astronomy-bookmarks - Fedora astronomy bookmarks https://bugzilla.redhat.com/show_bug.cgi?id=432265 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241654] Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges https://bugzilla.redhat.com/show_bug.cgi?id=241654 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:21 EST --- Jakub, All ok for me. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427061] Review Request: redmode - Switch to and from night red mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: redmode - Switch to and from night red mode Alias: redmode-review https://bugzilla.redhat.com/show_bug.cgi?id=427061 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:26 EST --- Lubomir, redmode-1.0-2.fc8.src.rpm updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432265] Review Request: astronomy-bookmarks - Fedora astronomy bookmarks
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: astronomy-bookmarks - Fedora astronomy bookmarks
https://bugzilla.redhat.com/show_bug.cgi?id=432265
--- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:22 EST ---
Release:1%{?dist}
Somewhere I heard that dist tag is not needed in cross-release noarch packages
(was it screensaver-frogs review?).
Your bookmark file embeds a couple of images/icons. Are you sure those are
freely redistributable?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432265] New: Review Request: astronomy-bookmarks - Fedora astronomy bookmarks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=432265 Summary: Review Request: astronomy-bookmarks - Fedora astronomy bookmarks Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://mmahut.fedorapeople.org/reviews/astronomy-bookmarks/astronomy-bookmarks.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/astronomy-bookmarks/astronomy-bookmarks-1-1.fc8.src.rpm Description: This package contains the astronomy bookmarks for Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427027] Review Request: PySBIG - PySBIG can read SBIG CCD files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: PySBIG - PySBIG can read SBIG CCD files https://bugzilla.redhat.com/show_bug.cgi?id=427027 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:22 EST --- New Package CVS Request === Package Name: PySBIG Short Description: PySBIG can read SBIG CCD files Owners: mmahut Branches: F-8 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432246] Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images https://bugzilla.redhat.com/show_bug.cgi?id=432246 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:52 EST --- I'm not sponsored so I can't approve this, but from what I can see it meets every requirement. The only changes I would make are that the word 'providing' should be replaced with 'for' in the summary and description, and 'preview' should be 'previews', also in the description. Source file match upstream: YES Package meets versioning and naming guidelines: YES Specfile is properly named, is cleanly written and uses macros consistently: YES Dist tag is present: YES Build root is correct: YES License field matches the actual license: YES License is open source-compatible: YES Latest version is being packaged: YES BuildRequires are proper: YES Compiler flags are appropriate: YES %clean is present: YES Package installs properly debuginfo package looks complete: YES rpmlint is silent: YES Final provides and requires are sane: YES %check is present and all tests pass: YES No shared libraries are added to the regular linker search paths: YES Owns the directories it creates: YES Doesn't own any directories it shouldn't: YES No duplicates in %files: YES File permissions are appropriate: YES No scriptlets present: YES Code, not content: YES Documentation is small, so no -docs subpackage is necessary: YES No headers: YES No pkgconfig files: YES No libtool .la droppings: YES -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427093] Review Request: gcx - Data-reduction tool for CCD photometry
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcx - Data-reduction tool for CCD photometry Alias: gcx-review https://bugzilla.redhat.com/show_bug.cgi?id=427093 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:48 EST --- Thanks Marek. All outstanding problems were adressed. RPMLint is silent now and I can't find any more issues. APPROVED (btw. consider adding a comment stating that the icon is from debian) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432265] Review Request: astronomy-bookmarks - Fedora astronomy bookmarks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: astronomy-bookmarks - Fedora astronomy bookmarks https://bugzilla.redhat.com/show_bug.cgi?id=432265 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||182235 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:46 EST --- Legal team, are these icons an issue? I know we have these also in default-bookmarks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: speech-dispatcher - Required for speech synthesis on
OLPC XO
https://bugzilla.redhat.com/show_bug.cgi?id=432259
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEEDINFO|ASSIGNED
Flag|needinfo? |
--- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:33 EST ---
Just leave as ASSIGNED. Potential reviewers can find that currently
no one is reviewing this by checking assignee.
By the way:
Would you check some general guidelines on:
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
And it is useful that you install rpmdevtools rpm and execute
$ rpmdev-newspec speech-dispatcher to create a skeleton spec file.
Also you can check your srpm or rebuilt binary rpms by $ rpmlint XXX.rpm
to detect some generic issues on your rpms.
From a quick glance:
* Summary must not be ended with dot (you can detect this by
using rpmlint. rpmlint is in rpmlint rpm)
* Please consider to use %{?dist} tag.
http://fedoraproject.org/wiki/Packaging/DistTag
* GPL license tag is no longer valid for Fedora.
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
* Packager tag must not be used. Fedora uses its own tag.
* Also Vendor tag must be removed
* AutoReqProv: yes is not needed
* Please specify BuildRoot (i.e. please don't comment it out)
* %setup must be quiet
* Please consider to use %configure macro
* Support parallel make if possible (please refer to the section
Parallel make of
http://fedoraproject.org/wiki/Packaging/Guidelines
* BuildRoot must be cleaned up when %install begins.
(see the section Prepping BuildRoot For %install of
the same wiki)
* Changing the mode of files must not be done on scriptlets
* Please use macros.
You should not use /etc/rc.d but should use /etc/rc.d/init.d
and the corresponding macro is %{_sysconfdir}
* scriptlets must be quiet unless some errors occur.
* We now recommend %defattr(-,root,root,-)
* configuration file must be put under %{_sysconfdir}, not
under %{_prefix}/%{_sysconfdir}.
Please check configure option. I guess %configure does what
you want (check what %configure does by
rpm --eval %configure)
* python directory is not right. It must be %_libdir/python2.5/site-packages,
but you must not write this directory in a explicit form but must
use some macros.
Please refer to:
http://fedoraproject.org/wiki/Packaging/Python
* Files under %infodir are automatically marked as %doc
* Please make it sure that all directories which are created when
installing this package are owned by this package or the subpackages
of this package.
For example, currently the directory
%{_libdir}/speech-dispatcher-modules/ itself is not owned by any package
* Please create -devel subpackage and move all development-related
files to the subpackage.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427093] Review Request: gcx - Data-reduction tool for CCD photometry
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcx - Data-reduction tool for CCD photometry Alias: gcx-review https://bugzilla.redhat.com/show_bug.cgi?id=427093 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:30 EST --- Lubomir, gcx-0.9.11-2.fc8.src.rpm updated. There's no link for gcx.svg, it's taken from debian package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427061] Review Request: redmode - Switch to and from night red mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: redmode - Switch to and from night red mode Alias: redmode-review https://bugzilla.redhat.com/show_bug.cgi?id=427061 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:31 EST --- Thanks Marek. All outstanding problems were adressed. RPMLint is silent now and I can't find any more issues. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: speech-dispatcher - Required for speech synthesis on
OLPC XO
https://bugzilla.redhat.com/show_bug.cgi?id=432259
--- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:39 EST ---
(In reply to comment #3)
* Please use macros.
You should not use /etc/rc.d but should use /etc/rc.d/init.d
and the corresponding macro is %{_sysconfdir}
The corresponding macro is %{_initrddir}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241654] Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges https://bugzilla.redhat.com/show_bug.cgi?id=241654 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:47 EST --- Looks good to me too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432246] Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images https://bugzilla.redhat.com/show_bug.cgi?id=432246 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 14:15 EST --- Further to the above: Forgot to mention that rpmlint is complaining about: pic2aa.i386: W: file-not-utf8 /usr/share/doc/pic2aa-0.2.1/COPYING pic2aa.i386: W: file-not-utf8 /usr/share/doc/pic2aa-0.2.1/AUTHORS on the binary RPM. Also, after a conversation in #fedora-devel, I think that specspo handles translations, so I'm not sure if these should be in the spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432246] Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images https://bugzilla.redhat.com/show_bug.cgi?id=432246 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 14:29 EST --- You can use iconv to convert it into UTF-8 Example: %prep iconv --from=ISO-8859-1 --to=UTF-8 file.txt file.txt.utf8 mv file.txt.utf8 file.txt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429445] Review Request: waf - A Python-based build system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: waf - A Python-based build system https://bugzilla.redhat.com/show_bug.cgi?id=429445 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 15:00 EST --- Spec URL: http://thm.1erlei.de/waf.spec SRPM URL: http://thm.1erlei.de/waf-1.3.2-5.fc8.src.rpm Changelog: - Update to 1.3.2. - Remove version and revision information from path to waf cache. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 398601] Review Request: cairo-clock - Cairo-rendered on-screen clock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cairo-clock - Cairo-rendered on-screen clock https://bugzilla.redhat.com/show_bug.cgi?id=398601 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 15:13 EST --- Note that a devel branch is always created. You can still build against kde3 in devel by BuildRequiring the approprate kde3 development packages. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 15:18 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431156] Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities https://bugzilla.redhat.com/show_bug.cgi?id=431156 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 15:25 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427027] Review Request: PySBIG - PySBIG can read SBIG CCD files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: PySBIG - PySBIG can read SBIG CCD files https://bugzilla.redhat.com/show_bug.cgi?id=427027 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 15:23 EST --- The short description here isn't very descriptive... Perhaps consider changing it to python support for reading SBIG CCD files or something? cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432246] Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images https://bugzilla.redhat.com/show_bug.cgi?id=432246 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 16:20 EST --- Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa-0.2.1-2.fc8.src.rpm Thanks for review and thanks for help! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 16:33 EST --- Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-6.beta2a.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications Alias: pear-URL-Mapper https://bugzilla.redhat.com/show_bug.cgi?id=431955 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 16:44 EST --- New Package CVS Request === Package Name: php-pear-Net-URL-Mapper Short Description: Simple and flexible way to build nice URLs for web applications Owners: xulchris Branches: F-7 F-8 EL-5 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432246] Review Request: pic2aa - Pic2AA is tool for converting jpeg/png to AA (Ascii Art) images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pic2aa - Pic2AA is tool for converting jpeg/png to AA (Ascii Art) images https://bugzilla.redhat.com/show_bug.cgi?id=432246 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: pic2aa -|Review Request: pic2aa - |Pic2AA is tool providing|Pic2AA is tool for |converting jpeg/png to AA |converting jpeg/png to AA |(Ascii Art) images |(Ascii Art) images -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 16:46 EST --- LGPLv2.1+ is not a correct value for the license tag; according to http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef8b05a9bd6 the correct value is LGPLv2+ The Categories tag from the desktop file should not contain Application any more ( see http://standards.freedesktop.org/menu-spec/latest/apa.html , referenced by http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755) Some minor issues: - there is no need to included util-linux-ng as BR because it is on the exceptions list (http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30-2) - duplicate BR: perl(XML::Parser) is brought in by intltool and device-mapper by e2fsprogs Everything else seems OK at the first glance -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 398601] Review Request: cairo-clock - Cairo-rendered on-screen clock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cairo-clock - Cairo-rendered on-screen clock https://bugzilla.redhat.com/show_bug.cgi?id=398601 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 16:58 EST --- (In reply to comment #12) Please DO NOT REQUEST a devel branch if this package is not compatible with KDE4. Please ignore this ! this package doesn't need kde -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427061] Review Request: redmode - Switch to and from night red mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: redmode - Switch to and from night red mode Alias: redmode-review https://bugzilla.redhat.com/show_bug.cgi?id=427061 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 17:14 EST --- New Package CVS Request === Package Name: redmode Short Description: Switch to and from night red mode Owners: mmahut Branches: F-8 InitialCC: astronomy-sig Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 17:44 EST --- I'm only not sure if I should use desktop-file-install for .desktop file in /etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator https://bugzilla.redhat.com/show_bug.cgi?id=432195 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 17:43 EST --- Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 359911] Review Request: drupal-views - Provides a method for site designers to control content presentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: drupal-views - Provides a method for site designers to control content presentation https://bugzilla.redhat.com/show_bug.cgi?id=359911 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 18:20 EST --- rpmlint is complaining about: drupal-views.noarch: E: non-standard-dir-perm /usr/share/drupal/modules/views/modules 02755 drupal-views.noarch: E: non-standard-dir-perm /usr/share/drupal/modules/views/po 02755 drupal-views.noarch: E: zero-length /usr/share/drupal/modules/views/modules/views_forum.inc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226559] Merge Review: xhtml1-dtds
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: xhtml1-dtds
https://bugzilla.redhat.com/show_bug.cgi?id=226559
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
Version|devel |rawhide
--- Additional Comments From [EMAIL PROTECTED] 2008-02-10 18:39 EST ---
I havn't looked into this too much but I noticed a couple of things:
The use of PreReq is deprecated.
The buildroot is not in the correct form (it dosn't include a %{release})
rpmlint is complaining about xhtml1-dtds.spec: W: mixed-use-of-spaces-and-tabs
(spaces: line 59, tab: line 95) (as well as the use of PreReq)
Is W3C IPR a valid License short tag?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429445] Review Request: waf - A Python-based build system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: waf - A Python-based build system https://bugzilla.redhat.com/show_bug.cgi?id=429445 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 19:55 EST --- Looks good. Parag, review? (Thomas and I will be co-maintaining, so you can review his modifications) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431156] Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities https://bugzilla.redhat.com/show_bug.cgi?id=431156 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 22:05 EST --- Build done: http://koji.fedoraproject.org/koji/buildinfo?buildID=35371 F-7 http://koji.fedoraproject.org/koji/buildinfo?buildID=35370 F-8 http://koji.fedoraproject.org/koji/buildinfo?buildID=35372 F-9 Thanks for your review Mamoru. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247983] Review Request: squeak-vm - Squeak virtual machine for OLPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squeak-vm - Squeak virtual machine for OLPC https://bugzilla.redhat.com/show_bug.cgi?id=247983 --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 23:25 EST --- please advise as to where the source code for this was originally obtained. ftp.squeak.org does not contain the same source tarball as is bundled in this package. Also note, significant portions of this package appear to be dual licensed under the LGPLv2.1+ and the Squeak license, neither of which are MIT. ./platforms/Cross/plugins/JPEGReadWriter2Plugin/jcomapi.c notes it is licensed and to read a README file, but no such file exists (contrary to the Independent JPEG Group's license). It might be considered free enough, but that's not entirely clear. There's a boatload of MP3 plugin code here. MP3 is patented. ./platforms/Cross/plugins/SoundCodecPrims/ is missing a COPYRIGHT file containing the license for code in that dir too. There's a lot of stuff under a Sun copyright with a permissive license. There's stuff under the Squeak license, not dual-licensed. There's Perl-Compatible-Regular-Expressions which is yet another license... There's GPLv2+ code in ./platforms/unix/plugins/VideoForLinuxPlugin/ccvt_types.h Debian won't carry this even in non-free. This scares me. Thanks to LaserJock for pointing out the legal mess that this code appears to be. Contining to block FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427481] Review Request: publican - publication tool chain
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: publican - publication tool chain https://bugzilla.redhat.com/show_bug.cgi?id=427481 --- Additional Comments From [EMAIL PROTECTED] 2008-02-11 02:29 EST --- http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/publican-0.28-0.fc9.src.rpm http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/publican.spec Had to bump the version as I had a couple of important bugs to fix :( * Mon Feb 11 2008 Jeff Fearn [EMAIL PROTECTED] 0.28-0 - Added gpl.txt - Fix GPL identifier as GPLv2+ - Fixed Build root - Fix desktop file - Added Provides for documentation-devel - Fix dist build target - Add dist-srpm target - fix dist failing on missing pot dir - Put docs in sub package - Added GFDL to License to cover content and Book_Template directories. - Included GFDL txt file - set full path to source -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432080] Review Request: cstream - General-purpose stream-handling tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cstream - General-purpose stream-handling tool https://bugzilla.redhat.com/show_bug.cgi?id=432080 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-11 01:09 EST --- Review: + package builds in mock (rawhide i386). koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=413928 + rpmlint is silent for SRPM and for RPM. + source files match upstream. eab4c98afef79766dd61a6a36dec845a cstream-2.7.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. SHOULD: Though I am not happy with extra flags to compiler just because it gives extra information, its ok to add them here. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432310] New: Review Request: compat-guichan06 - compatibility package for older guichan release
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=432310 Summary: Review Request: compat-guichan06 - compatibility package for older guichan release Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kobold.org/~wart/fedora/compat-guichan06.spec SRPM URL: http://www.kobold.org/~wart/fedora/compat-guichan06-0.6.1-3.fc9.src.rpm Description: Compatibility library for guichan version 0.6. The main guichan package will be upgraded to the latest 0.7.1 release at the same time that this package is imported. Currently only one package depends on libguichan-0.6.1 (ballz), and should not require a rebuild. It will, however, need to 'Requires: compat-guichan06-devel' and be patched slightly if/when it ever needs a rebuild. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432310] Review Request: compat-guichan06 - compatibility package for older guichan release
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compat-guichan06 - compatibility package for older guichan release https://bugzilla.redhat.com/show_bug.cgi?id=432310 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||426746 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429445] Review Request: waf - A Python-based build system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: waf - A Python-based build system https://bugzilla.redhat.com/show_bug.cgi?id=429445 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-11 01:09 EST --- Review: + package builds in mock (rawhide i386). koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=413925 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 9caca69cb435911c9ed6ff0519ce19ae waf-1.3.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199154] Review Request: Slony-1 (postgresql-slony-engine)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Slony-1 (postgresql-slony-engine) https://bugzilla.redhat.com/show_bug.cgi?id=199154 --- Additional Comments From [EMAIL PROTECTED] 2008-02-11 01:19 EST --- Here is 1.2.13 spec and SRPM: http://developer.postgresql.org/~devrim/rpms/other/slony1/postgresql-slony1.spec http://developer.postgresql.org/~devrim/rpms/other/slony1/postgresql-slony1-1.2.13-1.f8.src.rpm There are lots of rpmlint errors, but I could not fix them :( Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client https://bugzilla.redhat.com/show_bug.cgi?id=426492 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-02-11 02:31 EST --- Imported and built. Thanks again for review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
