[Bug 484547] Review Request: pyfacebook - Python wrapper for Facebook's API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484547 Ian Weller ianwel...@gmail.com changed: What|Removed |Added Blocks||484548 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484548] Review Request: facebook-notify - Facebook status notifier for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484548 Ian Weller ianwel...@gmail.com changed: What|Removed |Added Depends on||484547 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484548] New: Review Request: facebook-notify - Facebook status notifier for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: facebook-notify - Facebook status notifier for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=484548 Summary: Review Request: facebook-notify - Facebook status notifier for GNOME Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ianwel...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://ianweller.fedorapeople.org/SRPMS/facebook-notify/0-0.1.20090208git4552e7c/facebook-notify.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/facebook-notify/0-0.1.20090208git4552e7c/facebook-notify-0-0.1.20090208git4552e7c.fc10.src.rpm Description: This is a small application which monitors your Facebook profile and notifies you when it changes. It notifies you when any of the following events occur: * One of your friends changes their status, profile picture, or profile details * You receive a friend request, event or group invitation * Someone writes on one of your friends walls * One of your friends is tagged in a photo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484547] New: Review Request: pyfacebook - Python wrapper for Facebook's API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pyfacebook - Python wrapper for Facebook's API https://bugzilla.redhat.com/show_bug.cgi?id=484547 Summary: Review Request: pyfacebook - Python wrapper for Facebook's API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ianwel...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://ianweller.fedorapeople.org/SRPMS/pyfacebook/0.1-1.20090208svn173/pyfacebook.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/pyfacebook/0.1-1.20090208svn173/pyfacebook-0.1-1.20090208svn173.fc10.src.rpm Description: PyFacebook is a thin wrapper for accessing Facebook's RESTful API through Python. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483301 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #2 from Ralf Corsepius rc040...@freenet.de 2009-02-08 04:06:28 EDT --- Some comments: MUSTFIX: * AutoReqProv: no This disables rpm's automatic dependency tracking and therefore is strongly frowned upon. * Epoch: 1 Setting epoch to != 0 for a package to be included into Fedora is hardly useful. SHOULD: * Building on x86_64 emits serious warning, e.g. this memory.h: In member function 'void* Pool::alloc(size_t)': memory.h:55: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' memory.h: In member function 'void Pool::free(void*, size_t)': memory.h:73: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' In many cases, this kind of warnings are the origin of mal-functions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476622] Review Request: ocaml-pa-do - OCaml syntax extension for delimited overloading
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476622 --- Comment #10 from Richard W.M. Jones rjo...@redhat.com 2009-02-08 05:00:56 EDT --- Another new upstream release: Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-pa-do.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-pa-do-0.8.3-2.fc11.src.rpm * Sun Feb 8 2009 Richard W.M. Jones rjo...@redhat.com - 0.8.3-2 - New upstream version 0.8.3. - Missing BR pdflatex. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1112817 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484560] New: Review Request: pydb - An expanded version of the Python debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pydb - An expanded version of the Python debugger https://bugzilla.redhat.com/show_bug.cgi?id=484560 Summary: Review Request: pydb - An expanded version of the Python debugger Product: Fedora Version: rawhide Platform: All URL: http://bashdb.sourceforge.net/pydb OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pro...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Description of problem: Spec URL: http://people.atrpms.net/~pcavalcanti/specs/pydb.spec SRPM URL: http://people.atrpms.net/~pcavalcanti/srpms/pydb-1.25-3.fc10.src.rpm Extended Python Debugger is a more complete debugger for Python than the stock pdb.py debugger. It supports a restart command, non-interactive POSIX-like line tracing, command options, disassembly of instructions, and stack traces that give better information for exec statements. Stepping/nexting skips over method/function defs. It tries to follow gdb's command set unless there is good reason not to. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: pydb integrates with ddd, providing a graphical environment for python debugging. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484386] Review Request: gri - A language for scientific illustration
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484386
Jussi Lehtola jussi.leht...@iki.fi changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2009-02-08 06:17:32
EDT ---
Just a few comments:
- License is GPLv2+, not GPLv2.
- Remove Requires: readline, this is automatically picked up.
- Remove pushd and popd from setup, you don't need them.
- Change make command to
make %{?_smp_mflags}
as this works fine. The paths are already set by %configure.
- Replace rm -Rf with rm -rf to be consistent.
- Absolute paths in %files need to be replaced with %{_bindir}, %{_datadir} and
so on.
- Changelog is way too long, IMHO you may remove everything that is before
2006.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484386] Review Request: gri - A language for scientific illustration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484386 --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2009-02-08 06:20:18 EDT --- Also, since the package includes Emacs files, you need to read http://fedoraproject.org/wiki/Packaging/Emacs You'll have to branch the emacs script in its own subpackage, as gri probably works without it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484507] Review Request: php-channel-ezc - eZ Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484507 Guillaume Kulakowski llaum...@gmail.com changed: What|Removed |Added Blocks||484563 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484509] Review Request: php-ezc-Base - eZ Components Base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484509 Guillaume Kulakowski llaum...@gmail.com changed: What|Removed |Added Blocks||484563 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484563] New: Review Request: php-ezc-ConsoleTools - eZ Components ConsoleTools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-ezc-ConsoleTools - eZ Components ConsoleTools https://bugzilla.redhat.com/show_bug.cgi?id=484563 Summary: Review Request: php-ezc-ConsoleTools - eZ Components ConsoleTools Product: Fedora Version: 10 Platform: noarch OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: llaum...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 484507,484509 Estimated Hours: 0.0 Classification: Fedora ConsoleTools is a part of eZ Components : https://bugzilla.redhat.com/show_bug.cgi?id=484507 A set of classes to do different actions with the console (also called shell). It can render a progress bar, tables and a status bar and contains a class for parsing command line options. SPEC: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-ConsoleTools.spec SRPM: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-ConsoleTools-1.5-1.fc10.src.rpm RPM: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-ConsoleTools-1.5-1.fc10.noarch.rpm rpmlint: buil...@enterprise ~ rpmlint php-ezc-Base.* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Pear CompatInfo: +-+-+---+++ | Files | Version | C | Extensions | Constants/Tokens | +-+-+---+++ | pear/* | 5.0.0 | 0 | pcre | PHP_EOL| | | | || STDIN | | | | || abstract | | | | || catch | | | | || implements | | | | || instanceof | | | | || interface | | | | || private| | | | || protected | | | | || public | | | | || throw | | | | || try| +-+-+---+++ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #17 from Michael Schwendt bugs.mich...@gmx.net 2009-02-08 07:37:21 EDT --- Created an attachment (id=331236) -- (https://bugzilla.redhat.com/attachment.cgi?id=331236) patch for spec file I have read the packaging guidelines and found nothing that expressly prohibits this , so fixing this error isn't mandatory , is this correct ? No. For this review a fix will be mandatory. I'm going to test-build with attached patch, as I believe it to be the correct way to package this app. The buildroot path being used in %build (instead of just %install) usually is a packaging mistake/pitfall. It has lead to trouble several times before. The guidelines aren't as complete as necessary to cover each and every packaging detail. In corner-cases it may be okay to use the buildroot path in %build. But then you should have a much better rationale than a spec file comment such as needs the RPM_BUILD_ROOT in prefix to build. That's too vague and unconvincing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484509] Review Request: php-ezc-Base - eZ Components Base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484509 Guillaume Kulakowski llaum...@gmail.com changed: What|Removed |Added Blocks||484567 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484507] Review Request: php-channel-ezc - eZ Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484507 Guillaume Kulakowski llaum...@gmail.com changed: What|Removed |Added Blocks||484567 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484567] New: Review Request: php-ezc-File - eZ Components File
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-ezc-File - eZ Components File https://bugzilla.redhat.com/show_bug.cgi?id=484567 Summary: Review Request: php-ezc-File - eZ Components File Product: Fedora Version: 10 Platform: noarch OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: llaum...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 484507,484509 Estimated Hours: 0.0 Classification: Fedora Base is a part of eZ Components : https://bugzilla.redhat.com/show_bug.cgi?id=484507 Provides support for file operations which are not covered by PHP or are just missing. SPEC: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-File.spec SRPM: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-File-1.2-1.fc10.src.rpm RPM: http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-File-1.2-1.fc10.noarch.rpm rpmlint: buil...@enterprise ~ rpmlint php-ezc-Base.* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Pear CompatInfo: +-+-+---+++ | Files | Version | C | Extensions | Constants/Tokens | +-+-+---+++ | pear/* | 4.0.0 | 0 ||| +-+-+---+++ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #18 from leigh scott leigh123li...@googlemail.com 2009-02-08 08:14:06 EDT --- (In reply to comment #17) Created an attachment (id=331236) -- (https://bugzilla.redhat.com/attachment.cgi?id=331236) [details] patch for spec file I have read the packaging guidelines and found nothing that expressly prohibits this , so fixing this error isn't mandatory , is this correct ? No. For this review a fix will be mandatory. I'm going to test-build with attached patch, as I believe it to be the correct way to package this app. The buildroot path being used in %build (instead of just %install) usually is a packaging mistake/pitfall. It has lead to trouble several times before. The guidelines aren't as complete as necessary to cover each and every packaging detail. In corner-cases it may be okay to use the buildroot path in %build. But then you should have a much better rationale than a spec file comment such as needs the RPM_BUILD_ROOT in prefix to build. That's too vague and unconvincing. Thank you for the patch it works fine, I didn't know about the INSTALL_ROOT option. Here are the new SRPM Spec file with your changes from you patch Spec URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_3/qbittorrent.spec SRPM URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_3/qbittorrent-1.3.1-6.fc10.src.rpm Thank you for your help. Leigh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484229
--- Comment #19 from leigh scott leigh123li...@googlemail.com 2009-02-08
08:17:56 EDT ---
Heres the output for rpmlint
srpm
qbittorrent.src: I: checking
qbittorrent.src:27: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
qbittorrent.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
built package
qbittorrent.x86_64: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474430] Review Request: python-uulib - Python interface to RFC 4122 compliant UUID objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474430 --- Comment #12 from Ray Van Dolson ra...@bludgeon.org 2009-02-08 11:05:20 EDT --- New Package CVS Request === Package Name: python-uuid Short Description: Python interface to RFC 4122 compliant UUID objects Owners: rayvd Branches: EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483301 --- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-08 11:33:29 EDT --- (In reply to comment #2) Some comments: MUSTFIX: * AutoReqProv: no This disables rpm's automatic dependency tracking and therefore is strongly frowned upon. * Epoch: 1 Setting epoch to != 0 for a package to be included into Fedora is hardly useful. As I wrote above about Epoch and as a comment in the SPEC file about AutoReqProv, there are valid reasons for using both. SHOULD: * Building on x86_64 emits serious warning, e.g. this memory.h: In member function 'void* Pool::alloc(size_t)': memory.h:55: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' memory.h: In member function 'void Pool::free(void*, size_t)': memory.h:73: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' In many cases, this kind of warnings are the origin of mal-functions. I use the software. I didn't encounter any problems (yet). But I'll see what we can do. Finally, I made a request to you at RPMFusion. I am re-iterating it: Please, pretty please, do not write in my bugs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480887] Review Request: kguitar - Guitar Tabulature Music Editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480887
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-08
11:45:46 EDT ---
Ah, after reading http://musicxml.org/xml.html and
also this:
https://bugzilla.redhat.com/show_bug.cgi?id=357461
and also your explanation:
- This MusicXML document format license is free, GPL imcompatible
- However it seems that kguitar behaves just an interpreter or
editor for MusicXML document format license files.
So there should no license issue for this package. Then:
* _texmf macro
- Isn't the following enough?
-
%{!?_texmf: %define _texmf %(kpsewhich -expand-var '$TEXMFMAIN')}
-
! Versioning
- For svn based tarball, I prefer to include revision number
rather than the date I pulled the source because revision
number specifies the source used precisely, however
this is left to your choice.
- By the way, would you tell me if this is after or before
0.5.1 formal release?
* TeX dependency
- I think 30 Mbyte extra dependency is enough large.
Also I think that requiring another font for this package
should not be mandatory.
TeX related dependency should be split out.
I would choose kguitar-tex for TeX related subpackage.
* Timestamps
-
touch -r %{name}/x-%{name}.desktop tmpfile
-
- Is it really needed here to keep timestamps on this file?
You actually modified this desktop file here.
? Desktop file location
- Is it needed that the desktop file is installed under
%_datadir/applications/kde, not under %_datadir/applications?
Such desktop files cannot be seem from GNOME, however
it seems that this application can be used also on GNOME.
* _docdir
- Files/directories under %_docdir are automatically marked
as %doc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479832] Review Request: mmpong - a massively multiplayer pong game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479832 --- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-08 12:04:28 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484548] Review Request: facebook-notify - Facebook status notifier for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484548 Ian Weller ianwel...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX --- Comment #1 from Ian Weller ianwel...@gmail.com 2009-02-08 13:15:11 EDT --- I would say that this application is not ready for mainstream... closing, will reopen when upstream is more developed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459444] Review Request: ctdb - Clustered TDB
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459444 --- Comment #22 from Sumit Bose sb...@redhat.com 2009-02-08 13:13:03 EDT --- Ronnie Sahlberg added a COPYING file upstream. I have include the patch and uploaded the latest version to: http://sbose.fedorapeople.org/ctdb-1.0.71-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480146] Review Request: python-bicyclerepair - Python Refactoring Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480146 --- Comment #13 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-08 13:23:53 EDT --- I would to like to see a separate package for pymacs. I dislike to drop the ide support for emacs, because emacs is a wide spreaded editor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479832] Review Request: mmpong - a massively multiplayer pong game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479832 Kai maintai...@mt2009.com changed: What|Removed |Added Flag|needinfo?(maintai...@mt2009 | |.com) | --- Comment #10 from Kai maintai...@mt2009.com 2009-02-08 13:45:10 EDT --- Uh, I'm sorry! I was away for a couple of weeks. I'll get back to it when I find the time. Thanks for hanging on ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480887] Review Request: kguitar - Guitar Tabulature Music Editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480887
--- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-08
14:37:36 EDT ---
(In reply to comment #8)
Ah, after reading http://musicxml.org/xml.html and
also this:
https://bugzilla.redhat.com/show_bug.cgi?id=357461
and also your explanation:
- This MusicXML document format license is free, GPL imcompatible
- However it seems that kguitar behaves just an interpreter or
editor for MusicXML document format license files.
So there should no license issue for this package. Then:
Ok, so should I keep that MusicXML document license file in the %doc, or
doesn't it matter?
* _texmf macro
- Isn't the following enough?
-
%{!?_texmf: %define _texmf %(kpsewhich -expand-var '$TEXMFMAIN')}
-
I forgot to fix this. There's already an RPM macro %{_texmf_main} provided by
texlive-texmf package. I made the SPEC file to use that macro instead.
! Versioning
- For svn based tarball, I prefer to include revision number
rather than the date I pulled the source because revision
number specifies the source used precisely, however
this is left to your choice.
I agree. Changed.
- By the way, would you tell me if this is after or before
0.5.1 formal release?
This SVN snapshot includes some fixes that came *after* the 0.5.1 formal
release.
* TeX dependency
- I think 30 Mbyte extra dependency is enough large.
Also I think that requiring another font for this package
should not be mandatory.
TeX related dependency should be split out.
I would choose kguitar-tex for TeX related subpackage.
I split the TeX bits into a subpackage.
* Timestamps
-
touch -r %{name}/x-%{name}.desktop tmpfile
-
- Is it really needed here to keep timestamps on this file?
You actually modified this desktop file here.
I was not thinking. Removed the timestamp conservation.
? Desktop file location
- Is it needed that the desktop file is installed under
%_datadir/applications/kde, not under %_datadir/applications?
Such desktop files cannot be seem from GNOME, however
it seems that this application can be used also on GNOME.
I didn't know that the application won't be visible from gnome. I changed it to
use %_datadir/applications.
* _docdir
- Files/directories under %_docdir are automatically marked
as %doc
Removed the unnecessary %doc.
Update:
Spec URL: http://oget.fedorapeople.org/review/kguitar.spec
SRPM URL:
http://oget.fedorapeople.org/review/kguitar-0.5.1-3.926svn.fc10.src.rpm
Changelog: 0.5.1-3.926svn
- Change the EVR scheme (use svn revision instead of date in R)
- Use RPM's _texmf_main macro instead of redefining it
- Place the TeX bit into a -tex subpackage
- Specfile cleanup
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483301 --- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-08 15:04:45 EDT --- I put so much time into this package. I am still actively working on it and I am in contact with upstream and helping them fixing things out. There are people waiting for this package. Who the piteous are you to close my bug?? This is vile, disrespectful, inconsiderate and ignorant. One more time: PLEASE DO NOT POST IN MY BUGS! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483301 --- Comment #6 from Ralf Corsepius rc040...@freenet.de 2009-02-08 15:11:15 EDT --- (In reply to comment #5) I put so much time into this package. I am still actively working on it and I am in contact with upstream and helping them fixing things out. There are people waiting for this package. I rejected your package because you made it clear you are either unwilling or unable to make it compliant to the Fedora packaging standards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484315] Review Request: perl-Class-Exporter - Export class methods as regular subroutines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484315 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Ian Burrell ianburr...@gmail.com 2009-02-08 15:19:50 EDT --- New Package CVS Request === Package Name: perl-Class-Exporter Short Description: Export class methods as regular subroutines Owners: iburrell Branches: F-9 F-10 EL-5 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484591] New: Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: muse - Midi/Audio Music Sequencer https://bugzilla.redhat.com/show_bug.cgi?id=484591 Summary: Review Request: muse - Midi/Audio Music Sequencer Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: oget.fed...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://oget.fedorapeople.org/review/muse.spec SRPM URL: http://oget.fedorapeople.org/review/muse-1.0-0.2.rc1.fc10.src.rpm Description: MusE is a MIDI/Audio sequencer with recording and editing capabilities. It can perform audio effects like chorus/flanger in realtime via LASH and it supports Jack and ALSA interfaces. MusE aims to be a complete multitrack virtual studio for Linux. rpmlint is silent. Epoch: 1 is there for PlanetCCRMA compatibility. See AudioCreation SIG wiki for informations about PlanetCCRMA integration: https://fedoraproject.org/wiki/AudioCreation NOTE: This Review Request have been opened before (bug #483301) but someone with personality issues have closed that bug. Let us hope he doesn't taint this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483301 --- Comment #7 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-08 15:18:37 EDT --- PLEASE DO NOT POST IN MY BUGS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484293] Review Request: perl-Time-Progress - Elapsed and estimated finish time reporting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484293 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Ian Burrell ianburr...@gmail.com 2009-02-08 15:19:03 EDT --- New Package CVS Request === Package Name: perl-Time-Progress Short Description: Elapsed and estimated finish time reporting Owners: iburrell Branches: F-9 F-10 EL-5 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483730 --- Comment #25 from Eli Wapniarski e...@orbsky.homelinux.org 2009-02-08 15:24:25 EDT --- Jaroslav... OK... I gotta ask a maybe dumb question. I can wait if it is required. I'm only asking because of the frequency of activity and what seems to be a slow down in it. Since you submitted the last set of changes; does that mean that somebody else should conduct the review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483301
--- Comment #8 from Ralf Corsepius rc040...@freenet.de 2009-02-08 15:23:44
EDT ---
(In reply to comment #7)
Stop trolling.
#include stdio.h
int main()
{
size_t x = 0x1;
printf( %d\n, x);
printf( %zd\n, x);
}
(In reply to comment #7)
memory.h:73: warning: format '%d' expects type 'int', but argument 2 has
type
'size_t'
In many cases, this kind of warnings are the origin of mal-functions.
I use the software. I didn't encounter any problems (yet). But I'll see
what we can do.
Let me demonstrate the seriousness of this bug:
Compile this code on x86_64:
#include stdio.h
int main()
{
size_t x = 0x1;
printf( %d\n, x);
printf( %zd\n, x);
}
# gcc -Wall -O2 -o foo foo.c
foo.c: In function ‘main’:
foo.c:7: warning: format ‘%d’ expects type ‘int’, but argument 2 has type
Then run it:
./foo
0
4294967296
= Mal-function
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483301 --- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-08 15:30:03 EDT --- PLEASE DO NOT POST IN MY BUGS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 Milos Jakubicek xja...@fi.muni.cz changed: What|Removed |Added CC||xja...@fi.muni.cz AssignedTo|nob...@fedoraproject.org|xja...@fi.muni.cz Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484597] New: Review Request: python-argparse - Optparse inspired command line parser for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-argparse - Optparse inspired command line parser for Python https://bugzilla.redhat.com/show_bug.cgi?id=484597 Summary: Review Request: python-argparse - Optparse inspired command line parser for Python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: terje...@phys.ntnu.no QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora spec: http://terjeros.fedorapeople.org/python-argparse/python-argparse.spec srpm: http://terjeros.fedorapeople.org/python-argparse/python-argparse-0.8.0-1.fc10.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1113741 Description: The argparse module is an optparse-inspired command line parser that improves on optparse by: * handling both optional and positional arguments * supporting parsers that dispatch to sub-parsers * producing more informative usage messages * supporting actions that consume any number of command-line args * allowing types and actions to be specified with simple callables instead of hacking class attributes like STORE_ACTIONS or CHECK_METHODS as well as including a number of other more minor improvements on the optparse API. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484598] Review Request: grin - Grep-like tool for source code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484598 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Depends on||484597 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484597] Review Request: python-argparse - Optparse inspired command line parser for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484597 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Blocks||484598 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484598] New: Review Request: grin - Grep-like tool for source code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: grin - Grep-like tool for source code https://bugzilla.redhat.com/show_bug.cgi?id=484598 Summary: Review Request: grin - Grep-like tool for source code Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: terje...@phys.ntnu.no QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora spec: http://terjeros.fedorapeople.org/grin/grin.spec srpm: http://terjeros.fedorapeople.org/grin/grin-1.1.1-1.fc10.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1113774 Description: grin is a similar in function to GNU grep, however it's has modified behaviour to make it simpler to use when grepping source code. Some features grin feature are: * recurse directories by default * do not go into directories with specified names * do not search files with specified extensions * be able to show context lines before and after matched lines * Python regex syntax * unless suppressed via a command line option, display the filename regardless of the number of files * accept a file (or stdin) with a list of newline-separated filenames * grep through gzipped text files * be useful as a library to build custom tools quickly -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 Armin feng.sh...@gmail.com changed: What|Removed |Added CC||feng.sh...@gmail.com --- Comment #1 from Armin feng.sh...@gmail.com 2009-02-08 16:21:56 EDT --- there is an rpmlint issue with the src rpm: kde-plasma-networkmanagement.src:25: W: unversioned-explicit-obsoletes kde-plasma-networkmanager 1 packages and 0 specfiles checked; 0 errors, 1 warnings. it's better if you specify the highest version of kde-plasma-networkmanager it obsoletes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #2 from Armin feng.sh...@gmail.com 2009-02-08 16:23:08 EDT --- there is an rpmlint issue with the src rpm: kde-plasma-networkmanagement.src:25: W: unversioned-explicit-obsoletes kde-plasma-networkmanager 1 packages and 0 specfiles checked; 0 errors, 1 warnings. it's better if you specify the highest version of kde-plasma-networkmanager it obsoletes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #3 from Armin feng.sh...@gmail.com 2009-02-08 16:32:24 EDT --- kde-plasma-networkmanagement.x86_64: W: no-documentation kde-plasma-networkmanagement.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/NetworkManager-kde4.conf kde-plasma-networkmanagement.x86_64: W: obsolete-not-provided kde-plasma-networkmanager 1 packages and 0 specfiles checked; 0 errors, 3 warnings. There is no %doc (the TODO and DESIGN files could be added as %doc) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467409] Review Request: mingw32-atk - MinGW Windows Atk library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467409 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #14 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:41:11 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #4 from Armin feng.sh...@gmail.com 2009-02-08 16:38:27 EDT --- also, for debug-info, it's better if you chop the %description in two lines, rpmlint complains about this: kde-plasma-networkmanagement-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package kde-plasma-networkmanagement. kde-plasma-networkmanagement-debuginfo.x86_64: W: filename-too-long-for-joliet kde-plasma-networkmanagement-debuginfo-0.1-0.3.20090207svn.fc10.x86_64.rpm and the filename is too long for all of them, but I don't think that would be a big issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #5 from Armin feng.sh...@gmail.com 2009-02-08 16:42:41 EDT --- otherwise, it builds fine on x86_64 =) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483438] Review Request: libindi - Instrument Neutral Distributed Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483438 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:43:02 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483933] Review Request: perl-autobox - Call methods on native types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483933 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:49:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:48:19 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:50:48 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #6 from Kevin Kofler ke...@tigcc.ticalc.org 2009-02-08 16:49:25 EDT --- kde-plasma-networkmanagement.src:25: W: unversioned-explicit-obsoletes kde-plasma-networkmanager That one ought to be fixed. kde-plasma-networkmanagement.x86_64: W: no-documentation Mostly harmless. Is there no COPYING? That's worth a complaint upstream. TODO and DESIGN may or may not be worth shipping. kde-plasma-networkmanagement.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/NetworkManager-kde4.conf That's the usual D-Bus config files which aren't really config files. It could be marked %config, but I think it probably shouldn't, that file isn't really intended to be customized. The path is in /etc because that's where D-Bus expects those files to be. kde-plasma-networkmanagement.x86_64: W: obsolete-not-provided kde-plasma-networkmanager Harmless, but I think adding the Provides can't hurt and it will make yum install kde-plasma-networkmanager work. kde-plasma-networkmanagement-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package kde-plasma-networkmanagement. The line exceeds 80 characters, it should be broken into 2 lines. kde-plasma-networkmanagement-debuginfo.x86_64: W: filename-too-long-for-joliet kde-plasma-networkmanagement-debuginfo-0.1-0.3.20090207svn.fc10.x86_64.rpm Ignore that one. The name is as it has to be according to the guidelines, you can't shorten it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482856 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #12 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:53:48 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #7 from Armin feng.sh...@gmail.com 2009-02-08 16:56:16 EDT --- Mostly harmless. Is there no COPYING? That's worth a complaint upstream. TODO and DESIGN may or may not be worth shipping. no, there isn't. But I think TODO and DESIGN should be part of %doc, as they are upstream. Someone might need it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467395] Review Request: mingw32-openssl - MinGW port of the OpenSSL toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467395 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:52:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474549] Review Request: ca-cacert.org - CAcert.org CA root certificates
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474549 Tobias Mueller fedora-b...@cryptobitch.de changed: What|Removed |Added CC||fedora-b...@cryptobitch.de --- Comment #6 from Tobias Mueller fedora-b...@cryptobitch.de 2009-02-08 16:55:47 EDT --- Matthias: Do you have any official response from the cacert support mailinglist yet? I'd love to see the cacert certs shipped with fedora... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484320] Review Request: perl-Lingua-Stem-Snowball - Perl interface to Snowball stemmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484320 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:55:12 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480254] Review Request: deletemail - A non-interactive tool for deleting mails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480254 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:01:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484042] Review Request: vlgothic-fonts - Japanese TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484042 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-02-08 16:58:13 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474430] Review Request: python-uulib - Python interface to RFC 4122 compliant UUID objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474430 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:00:07 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484487] Review Request: perl-Template-Plugin-JavaScript - Encodes text to be safe in JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484487 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:05:40 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484318] Review Request: perl-HTML-DOMbo - Convert between XML::DOM and XML::Element trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484318 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:10:15 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484313] Review Request: perl-Class-Can - Inspect a class/method and say what it can do (and why)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484313 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:11:17 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481022] Review Request: SPE - Stani's Python Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481022 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added CC||ke...@tummy.com --- Comment #17 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:09:17 EDT --- Please use FAS name in the owners field. Should this package be 'SPE' or 'spe'? Case matters, and your package name so far as been 'spe'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484287] Review Request: xconvers - Ham radio convers client similar to IRC for X/GTK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484287 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:14:15 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484315] Review Request: perl-Class-Exporter - Export class methods as regular subroutines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484315 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:12:13 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484293] Review Request: perl-Time-Progress - Elapsed and estimated finish time reporting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484293 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-02-08 17:13:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #8 from Kevin Kofler ke...@tigcc.ticalc.org 2009-02-08 18:06:43 EDT --- Actually the -debuginfo description is autogenerated, so that description-line-too-long warning can also be ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484535
Milos Jakubicek xja...@fi.muni.cz changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #9 from Milos Jakubicek xja...@fi.muni.cz 2009-02-08 20:04:20
EDT ---
- regarding the rpmlint output, as discussed in previous comments -- please
fix:
kde-plasma-networkmanagement.src:25: W: unversioned-explicit-obsoletes
kde-plasma-networkmanagement.x86_64: W: obsolete-not-provided
kde-plasma-networkmanagement.x86_64: W: no-documentation
(include the TODO and DESIGN file)
- use macros in %build and %files:
%{cmake_kde4} .. -DDBUS_SYSTEM_POLICY_DIR=/etc/dbus-1/system.d
/etc/dbus-1/system.d/NetworkManager-kde4.conf
/etc = %{_sysconfdir}
- remove unnecessary BR (main package) and R (for -devel subpackage):
BR/R: NetworkManager-devel which is required by NetworkManager-glib-devel
BR/R: kdelibs4-devel which is required by kdebase-workspace-devel
Requires(post): /sbin/ldconfig xdg-utils
Requires(postun): /sbin/ldconfig xdg-utils
(Those are taken by rpm automagically)
- please provide a more appropriate description than %{summary} for the main
package.
- please provide a less general URL than just kde.org, e.g.
http://websvn.kde.org/trunk/playground/base/plasma/applets/networkmanager/
- there is no licensing info besides the qt dual license and .desktop files;
nor in an attached LICENSE file, nor in the source files -- that's bad. Please
ask upstream to include a license file and to mention the license in the
sources.
You should also include a LICENSE.GPL and GPL_EXCEPTION.txt file as the qt
license states.
- please fix the gcc flags, something like this before the make call should be
enough:
find . -name flags.make -execdir sed -i -e 's/-fno-exceptions -fno-check-new
-fno-common//' -e 's/-fno-threadsafe-statics -fvisibility=hidden
-fvisibility-inlines-hidden//' -e 's/-ansi//' {} \;
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481022] Review Request: SPE - Stani's Python Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481022 --- Comment #18 from MERCIER bioinfornat...@gmail.com 2009-02-08 20:26:11 EDT --- New Package CVS Request === Package Name: spe Short Description: spe it is a Python IDE editor released Owners: bioinfornat...@gmail.com Branches: F9 F10 InitialCC: bioinfornatics -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484535 --- Comment #10 from Milos Jakubicek xja...@fi.muni.cz 2009-02-08 20:41:52 EDT --- ad *-debuginfo.*: E: description-line-too-long: filed as 484616 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483933] Review Request: perl-autobox - Call methods on native types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483933 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482856 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480538] Review Request: iptux -- a tool for sharing and transporting files and directories in Lan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480538 Caius kaio Chance c...@dejieshi.com changed: What|Removed |Added CC||c...@dejieshi.com --- Comment #10 from Caius kaio Chance c...@dejieshi.com 2009-02-08 22:46:00 EDT --- (In reply to comment #9) Anyone can help me? fedora-review flag should be set '?' by contributor for primary reviewer to review. Since you are not sponsored packager, I could not be the primary reviewer for you. This is because pre-sponsored contributor's package review request could only be reviewed by sponsor. I could do pre-review for you instead. Once it is generally done, please set the fedora-review flag to '?' for sponsors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480538] Review Request: iptux -- a tool for sharing and transporting files and directories in Lan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480538 --- Comment #11 from Caius kaio Chance c...@dejieshi.com 2009-02-08 23:08:31 EDT --- Created an attachment (id=331277) -- (https://bugzilla.redhat.com/attachment.cgi?id=331277) build log file Check the last lines (I used mock to build it on my F10): checking for GTHREAD... yes checking for GCONF... configure: error: Package requirements (gconf-2.0 = 2.0.0) were not met: No package 'gconf-2.0' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables GCONF_CFLAGS and GCONF_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.Z5wTJb (%build) Bad exit status from /var/tmp/rpm-tmp.Z5wTJb (%build) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462521] Review Request: simplyhtml - Application and a java component for rich text processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462521 --- Comment #6 from John Guthrie guth...@counterexample.org 2009-02-08 23:37:09 EDT --- (In reply to comment #5) (In reply to comment #2) [-] Other source files are included: Please check the status and the necessity of using the files in src/com/sun and de/calcom as they appear to come from other projects. The short story is that from what I can tell, these files actually are imported into the files for this project. I will talk more about this later when it is not 2AM and I am needing sleep. ;-) This could end up being a bit of a mess. Just looking at the file com/sun/demo/ExampleFileFilter.java, the class defined by this file gets imported into three different files under com.lightdev. Moreover, these files use methods that are defined in ExampleFileFilter.java. It would be difficult to extricate this class from the com.lightdev tree without making semi-substantial changes to the code. On further inspection, one also sees that the ExampleFileFilter class extends the FileFilter class. The documentation for that class can be found here: http://java.sun.com/j2se/1.4.2/docs/api/javax/swing/filechooser/FileFilter.html According to that page, the FileFilter class is in fact an abstract class, so it is expected that a subclass will be written in order to implement this class. It appears that this particular subclass, ExampleFileFilter, was written to, well, be an example implementation. However, I am guessing that the example code did everything that the simplyhtml upstream wanted, and so they just used it directly, rather than writing their own implementation. Fortunately, ExampleFileFilter.java has a 3-clause BSD license with no advertising clause. Similar comments apply to ElementTreePanel.java. All of the de.calcom code has been placed under GPL just like the rest of the com.lightdev code. IT turns out that the lightdev.com and calcom.de domains are owned by the same person, one Ulrich Hilger. Moreover, looking at the calcom.de web site, it would appear that calcom.de was a previous name for lightdev.com. Based on this, it would seem safe to assume that the de.calcom code is part of the same project as the com.lightdev code. Is there anything that we would need to worry about with the com.sun.demo code having a BSD license vs. the rest of the code having a GPL license? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481192] Review Request: perl-pgsql_perl5 - Pg - Perl5 extension for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481192 --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2009-02-08 23:57:13 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484321] Review Request: perl-Lingua-StopWords - Stop words for several languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484321 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2009-02-09 00:05:16 EDT --- Review: + package builds in mock (rawhide i386). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1114202 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 47decfa5a040292ad7f5a5b9088baf0c Lingua-StopWords-0.09.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=13, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.11 cusr 0.02 csys = 0.15 CPU) + Package perl-Lingua-StopWords-0.09-2.fc11 = Provides: perl(Lingua::StopWords) = 0.09 perl(Lingua::StopWords::DA) = 0.08 perl(Lingua::StopWords::DE) = 0.08 perl(Lingua::StopWords::EN) = 0.08 perl(Lingua::StopWords::ES) = 0.08 perl(Lingua::StopWords::FI) = 0.08 perl(Lingua::StopWords::FR) = 0.08 perl(Lingua::StopWords::HU) = 0.08 perl(Lingua::StopWords::IT) = 0.08 perl(Lingua::StopWords::NL) = 0.08 perl(Lingua::StopWords::NO) = 0.08 perl(Lingua::StopWords::PT) = 0.08 perl(Lingua::StopWords::RU) = 0.08 perl(Lingua::StopWords::SV) = 0.08 Requires: perl(Exporter) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484315] Review Request: perl-Class-Exporter - Export class methods as regular subroutines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484315 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484313] Review Request: perl-Class-Can - Inspect a class/method and say what it can do (and why)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484313 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481727] Review Request: python-EnvisageCore - Extensible Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481727 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Flag||fedora-review? --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-02-09 00:44:14 EDT --- Review: + package builds in mock (rawhide i386). koji build= http://koji.fedoraproject.org/koji/taskinfo?taskID=1108595 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 88ce02329f0437505ca1ef429b75e66f EnvisageCore-3.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: 1) Add examples to %doc After installed this package I am unable to run test as python /usr/share/doc/python-EnvisageCore-3.0.1/examples/Hello\ World/hello_world.py == got following traceback error ImportError: No module named preferences.api Can this be fixed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Depends on||484321 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484321] Review Request: perl-Lingua-StopWords - Stop words for several languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484321 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Blocks||484323 Flag||fedora-cvs? --- Comment #4 from Ian Burrell ianburr...@gmail.com 2009-02-09 00:49:26 EDT --- New Package CVS Request === Package Name: perl-Lingua-StopWords Short Description: Stop words for several languages Owners: iburrell Branches: F-9 F-10 EL-5 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Depends on||484320 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484318] Review Request: perl-HTML-DOMbo - Convert between XML::DOM and XML::Element trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484318 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484320] Review Request: perl-Lingua-Stem-Snowball - Perl interface to Snowball stemmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484320 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||484323 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484293] Review Request: perl-Time-Progress - Elapsed and estimated finish time reporting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484293 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
