[Bug 194563] Review Request: conman - the console manager

2006-12-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-31 05:51 EST ---
(In reply to comment #13)
 Built for FC4 and 5, closing ticket.

Please do not remove the FE-ACCEPT blocker.  Thanks.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-21 03:33 EST ---
All must items fixed. APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-21 10:13 EST ---
Imported and built for devel, pending cvs branching for other builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
OtherBugsDependingO|163779  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-21 16:59 EST ---
Built for FC4 and 5, closing ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||187029
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|187029  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-20 19:00 EST ---
- rpmlint output clean
- Package is named according to Package Naming Guidelines
- spec file matches base package %{name}
- package meets Packaging Guidelines
- package is licensed with open source compatible license
- license field matches actual license
- license text included in %doc
- spec file written in American english
- spec file is legible
- source package matches upstream
b47730a326376cf731c313900095449c  conman-0.1.9.1.tar.bz2
- package successfully compiles and builds on FC-5 x86_64
- All build dependencies are listed
- package does not use locales
- package does not contain any shared libraries
- package is non-relocatable
- package owns all directories it creates
- no duplicate files in %files
- file permissions set appropriately
- contains proper %clean section
- macro usage consistant
- package contains permissible content
- package does not contain large documentation
- %doc files do not affect runtime
- no headers or static libraries
- no pkgconfig files
- no .so or .la files
- no GUI or .desktop file needed
- package does not own files or directories owned by other packages

=== MUST ===
- Package must add Requires: logrotate
- service conman start says [ OK ] but there is no conmand process started

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-21 00:04 EST ---
Okay, added 'Requires: logrotate' and figured out what was up w/the non-running 
conmand. The problem 
is that conmand exits cleanly if no CONSOLE devices are defined in 
/etc/conman.conf, meaning RETVAL 
was 0 (success), so I added a check to the initscript that will trigger a 
failure if none are present. I'll yell 
upstream and tell them this behavior is el stupido, but the initscript 
workaround should suffice for now.

http://wilsonet.com/packages/conman/conman.spec
http://wilsonet.com/packages/conman/conman-0.1.9.1-3.src.rpm

I'd do that ckfsv review for you now, but it looks like someone beat me to 
it... I owe ya one. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
OtherBugsDependingO|163778  |163776
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-19 06:56 EST ---
Above is Not an official review as I'm not yet sponsored

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-19 09:51 EST ---
you are right. Actually i thought some README file should be there that helps
end user to understand what package provides and is that require any dependency
to be installed prior.
Else package is Good.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-19 09:54 EST ---
(In reply to comment #5)
 So basically, as I understand it, you don't see any problems with the package
 outside of the lack of an upstream README, and you actually *do* have the 
 power
 to approve the package. :)

The Package Review Guidelines say:

  The primary Reviewer can be any current package owner, unless the Contributor
  is a first timer.

Somebody that is not sponsored cannot be a current package onwer, hence they
cannot be the *primary* reviewer, hence they cannot approve packages.

Parag is of course encouraged to review packages as part of the process of
getting sponsored, but formally reviewing and approving packages must be done by
an existing package owner.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-19 10:13 EST ---
(In reply to comment #7)
 The Package Review Guidelines say:
 
   The primary Reviewer can be any current package owner, unless the 
 Contributor
   is a first timer.
 
 Somebody that is not sponsored cannot be a current package onwer, hence they
 cannot be the *primary* reviewer, hence they cannot approve packages.
 
 Parag is of course encouraged to review packages as part of the process of
 getting sponsored, but formally reviewing and approving packages must be done 
 by
 an existing package owner.


Ah, okay, thank you for the clarification, mistakenly made the leap from being
encouraged to review to being able to approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-14 11:38 EST ---
The upstream initscript is an unholy mess that tries to support multiple
distributions, so I plan to create a stripped-down RH/FC-only version, but
otherwise, the package is ready for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194563] Review Request: conman - the console manager

2006-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conman - the console manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194563





--- Additional Comments From [EMAIL PROTECTED]  2006-06-14 13:21 EST ---
Okay, new -2 build pushed up, contains a much cleaner initscript and also
properly sets up log directories and log rotation.

http://wilsonet.com/packages/conman/conman-0.1.9.1-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review