[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/show_bug.cgi?id=197476 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 11:58 EST --- rpmlint is noew quite for the binary rpm. So I will APPROVE your package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 15:32 EST --- awesome. Thank you. In devel now and building. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 --- Additional Comments From [EMAIL PROTECTED] 2006-07-04 02:36 EST --- is that the correct way to fix it? this certainly isn't happening with existing python-* packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 --- Additional Comments From [EMAIL PROTECTED] 2006-07-04 03:38 EST --- (In reply to comment #4) is that the correct way to fix it? Yes. The shellbangs are put there by the upstream developers so that they can run individual parts of the package on their own for debugging. Given that the files are not installed with exec permissions, this isn't something that an end user is going to be needing to do. this certainly isn't happening with existing python-* packages. Perhaps many reviewers are happy to let them go because it's not an important issue (true in itself), or because they don't know how to fix it, or because they think the fix clutters the spec file and is therefore worse than the problem itself? My view is that it's best to shut rpmlint up as much as is reasonably possible (some things just can't be fixed because the package wouldn't work if they were), so that rpmlint generates as little output as possible. The benefit of this is that any new issues that crop up with package version or rpmlint changes are less likely to be lost amongst a barrage of unimportant issues. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 --- Additional Comments From [EMAIL PROTECTED] 2006-07-04 03:46 EST --- OK, I will patch it up shortly. Only asked cuz I didn't know and its not been covered in the python packaging guidelines :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 --- Additional Comments From [EMAIL PROTECTED] 2006-07-04 05:17 EST --- (In reply to comment #6) OK, I will patch it up shortly. Only asked cuz I didn't know and its not been covered in the python packaging guidelines :) It's not a python-specific thing; it happens quite often with perl modules too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-03 13:45 EST --- Good: + Tarball in SRPM match with upstream. + Local build works fine. + License OK. + rpmlint of source RPM ok. + Mock build works fine on FC-5 as root. Bad: - No verbatin license in %doc stanza - I think the Group should be Development/Tools - Why you set CFLAGS, when no binary file will be created - rpmlint have the following complaints to the binary RPM. E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/setup.py 0644 E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/loginfo.py 0644 E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/clients/words.py 0644 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197476] Review Request: python-cvstoys
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-cvstoys https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197476 --- Additional Comments From [EMAIL PROTECTED] 2006-07-03 19:28 EST --- Updated: Spec URL: http://www.knox.net.nz/~michael/python-cvstoys.spec SRPM URL: http://www.knox.net.nz/~michael/python-cvstoys-1.0.10-2.src.rpm There is no license file provided, upstream has been contacted. As for the rpmlint errors, I check other python packages and they were the same. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
