[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #7 from Parag AN(पराग) panem...@gmail.com  2009-03-04 00:11:18 
EDT ---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Kevin Fenzi ke...@tummy.com  2009-02-26 19:09:39 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263





--- Comment #2 from Matthias Clasen mcla...@redhat.com  2009-02-25 09:43:30 
EDT ---
I've added the versioned requires, add a comment and even did the -p.

Then, I've queried upstream (myself), but upstream said no.

New files in the same location.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

   Flag||fedora_requires_release_not
   ||e+




--- Comment #3 from Matthias Clasen mcla...@redhat.com  2009-02-25 22:13:47 
EDT ---
We should probably release-note this:

The Preferences menu does no longer have submenus. This change was done since
deep menu hierarchies are difficult to navigate for many users, and the
category-based submenus were not terribly obvious. If you are used to the
submenus, and prefer to keep the Peferences menu organized in this way, install
the preferences-menus package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-02-25 22:41:03 
EDT ---
(In reply to comment #2)
 I've added the versioned requires, add a comment and even did the -p.
 
OK.

 Then, I've queried upstream (myself), but upstream said no.
 Nice comment.

 
 New files in the same location.

thanks.

koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1182091
+ rpmlint is Not silent but ok to accept.
preferences-menus.noarch: W: no-documentation
preferences-menus.noarch: W: no-url-tag
+ Rest looks following packaging guidelines.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Matthias Clasen mcla...@redhat.com  2009-02-25 23:42:42 
EDT ---
New Package CVS Request
===
Package Name: preferences-menus 
Short Description: Categorized submenus for the Preferences menu
Owners: mclasen
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

2009-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263





--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-02-25 01:19:03 
EDT ---
1) Good to add versioned requires

2) From http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream , 
Will you please add comment in SPEC file. Otherwise I see no way to verify
source here.

3) From review guidelines,
   SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

4) Though for such small package where no upstream release happened, it looks
not really needed but good to follow guidelines
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps
== Add -p to install command

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review