[Bug 190949] Review Request: gaim-gaym
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-gaym Alias: gaim-gaym https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190949 [EMAIL PROTECTED] changed: What|Removed |Added Alias||gaim-gaym -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190949] Review Request: gaim-gaym
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-gaym https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190949 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190949] Review Request: gaim-gaym
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-gaym https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190949 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-16 11:03 EST --- With my newly recieved blessing powers I'd like to exclaim +1 Publish! I have also tested build on fc5/x86_64 and it works as expected -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190949] Review Request: gaim-gaym
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gaim-gaym
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190949
--- Additional Comments From [EMAIL PROTECTED] 2006-05-08 14:09 EST ---
Although I'm not an officially blessed reviewer I thought that I can do a test
review and learn somewhat from it.
good:
- rpmlint without any complaints
- although the upstream tarball is named qrc the user community uses the name
gaym, so I think changing the name is a good call even though it violates the
first sentence of the package naming guidelines
- specfile name matches %{name}
- license is indeed GPL
- COPYING is included in %doc
- to the best of my knowledge the spec is written in american english
- the specfile is quite readable
- tarball referenced maches the tarball included
- the package builds correctly and seems to work quite well on fc5/i386, it also
builds on fc4/x86_64 but I haven't actually tested it there
- no localization, no shared libraries, not relocateable, no scriptlets
- no duplicates in %files
- it contains a GUI but since it is embedded in gaim the .desktop MUST is not
applicable
- no scriptlets
As far as my newbies eyes can tell this package is problem free and works as
expected.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190949] Review Request: gaim-gaym
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-gaym https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190949 --- Additional Comments From [EMAIL PROTECTED] 2006-05-08 12:25 EST --- Apologies -- had pushed rel 0 rather than rel 1 of the srpm :\ Spec tweaked, explicit requires: gtk2 dropped. Spec URL: http://home.comcast.net/~ckweyl/gaim-gaym.spec SRPM URL: http://home.comcast.net/~ckweyl/gaim-gaym-0.96-2.fc5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190949] Review Request: gaim-gaym
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-gaym https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190949 --- Additional Comments From [EMAIL PROTECTED] 2006-05-08 06:34 EST --- The src.rpm gives a 404 Just a quick note on the .spec file. The Requires: gtk2 is probably redundant. rpmbuild will normally find out the correct library dependencies automagically -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
