[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/show_bug.cgi?id=196740 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-07 15:30 EST --- (In reply to comment #14) > I didn't realize that there was already precedent for this type of thing. I > hadn't seen it until now. While I don't necessarily like it, I won't have it > be > the only thing blocking the review. > > APPROVED Thanks, actually the precedents for this is where I learned todo this, thats how one develops bad habbits :) Imported & build, closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-07 14:00 EST --- I didn't realize that there was already precedent for this type of thing. I hadn't seen it until now. While I don't necessarily like it, I won't have it be the only thing blocking the review. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-07-07 13:57 EST --- Thanks for the support Paul! Wart, There are plenty of examples in FE with similar and much much harder to read shell scriptlets, please if this is the only blokcer approve. What gain is there in my removing the shellscript only to readd it with the first upstream release. I want a new upstream release to be as easy as: -bump %version -reset %release to 1 -add changelog -spectool -g -rebuild Now I know things aren't always going to be as easy as this, but having to manually edit Source0 for each upstream update is a pain, especially since one then has to remember the prefered filename-formating for all upstreams, or goto the website of upstream find the download page and find out the correct URL that way. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-07-07 13:52 EST --- There is precedent in Extras for using shell escapes for this. For instance, my own perl-Math-Pari package has a far less obvious one: http://cvs.fedora.redhat.com/viewcvs/devel/perl-Math-Pari/perl-Math-Pari.spec?root=extras&view=markup I think that if anyone looking at ths spec file doesn't "get" the "tr" subsitution almost instantly, they're going to have great difficulty following just about any type of shell script, including the rest of the spec file. The "tr" program is something you'd come across in "Scripting 101" after all. I really do think this comes down to the packager's preference myself. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740
--- Additional Comments From [EMAIL PROTECTED] 2006-07-07 13:35 EST ---
(In reply to comment #10)
> (In reply to comment #9)
> > MUSTFIX
> > ===
> > * The 'tr' trick in Source0: is cute, but my preference is to limit
> > macro substitutions in Source0 to simple %{name} and %{version} only.
> > Anything more complicated (like spawning subshells) becomes
> > harder to read. In this case, just hard code the version string.
>
> Erm, shouldn't that be a should fix. Nowhere in the guidelines it says use of
> macros etc is forbbiden in Source0. I know some people want to copy and paste
> the Source0 URL to wget, some people even want it to contain 0 macro's. I say
> those people should learn to use "spectool -g name.spec" which will do the
> macro
> expansion and cut and pasting for them, directly calling wget. -> EWONTFIX
While there are no explicit guidelines against this, I feel that it falls into
the "spec file must be legible" category. I don't think we should have to rely
on spectool to decipher source urls. I'm willing to live with macro
substitutions, but I think shell escapes add too much indirection.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740
--- Additional Comments From [EMAIL PROTECTED] 2006-07-07 07:30 EST ---
(In reply to comment #9)
> rpmlint warnings:
>
> W: ogre-devel no-documentation
>- Can be safely ignored since docs are in a -doc subpackage.
>
> E: ogre-devel invalid-soname /usr/lib64/libOgrePlatform.so libOgrePlatform.so
>- Not sure where this is coming from.
Oops, I meant to fix that one but never got around to fixing it, rpmlint is
unhappy because that is an unversioned .so directly under libdir. Since this lib
actually gets dlopened by libOgreMain I've moved it to libdir/OGRE
> MUSTFIX
> ===
> * The 'tr' trick in Source0: is cute, but my preference is to limit
> macro substitutions in Source0 to simple %{name} and %{version} only.
> Anything more complicated (like spawning subshells) becomes
> harder to read. In this case, just hard code the version string.
Erm, shouldn't that be a should fix. Nowhere in the guidelines it says use of
macros etc is forbbiden in Source0. I know some people want to copy and paste
the Source0 URL to wget, some people even want it to contain 0 macro's. I say
those people should learn to use "spectool -g name.spec" which will do the macro
expansion and cut and pasting for them, directly calling wget. -> EWONTFIX
> * -devel subpackage should use full version in base package dependency (it
> is missing -%{release}), or add a comment why it's not needed:
> Requires: %{name} = %{version}-%{release}
Fixed
> * BR: flex, bison seem to be unnecessary.
./configure was checking for them but indeed it builds fine without, removed.
New version is here:
* Fri Jul 7 2006 Hans de Goede <[EMAIL PROTECTED]> 1.2.1-2
- Make -devel package Requires on the main package fully versioned.
- Move libOgrePlatform.so out of %%{_libdir} and into the OGRE plugins dirs as
its not versioned and only used through dlopen, so its effectivly a plugin.
Spec URL: http://people.atrpms.net/~hdegoede/ogre.spec
SRPM URL: http://people.atrpms.net/~hdegoede/ogre-1.2.1-2.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740
--- Additional Comments From [EMAIL PROTECTED] 2006-07-06 18:36 EST ---
rpmlint warnings:
W: ogre-devel no-documentation
- Can be safely ignored since docs are in a -doc subpackage.
E: ogre-devel invalid-soname /usr/lib64/libOgrePlatform.so libOgrePlatform.so
- Not sure where this is coming from.
MUST
* Package/spec named appropriately
* GPL license ok, license file included
* spec file legible and in Am. English
* Builds on FC6-i386, FC6-x86_64, FC5-i386, FC5-x86_64
* Sources match upstream:
6ff98b1f14ca679ceaeec00daff2ff87 ogre-linux_osx-v1-2-1.tar.bz2
* No locales
* ldconfig called correctly from %post/%postun
* Not relocatable
* RPM_BUILD_ROOT cleaned as needed
* headers, unversioned .so, and pkgconfig files in -devel subpackage
* No libtool archives
* Does not own any directories that it should not.
* No .desktop file needed
MUSTFIX
===
* The 'tr' trick in Source0: is cute, but my preference is to limit
macro substitutions in Source0 to simple %{name} and %{version} only.
Anything more complicated (like spawning subshells) becomes
harder to read. In this case, just hard code the version string.
* -devel subpackage should use full version in base package dependency (it
is missing -%{release}), or add a comment why it's not needed:
Requires: %{name} = %{version}-%{release}
* BR: flex, bison seem to be unnecessary.
COMMENTS
* One duplicate file found: Docs/styles.css. This is ok, however, as it
is needed for the docs in both the base and the -devel-doc subpackage
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-29 07:56 EST --- #6 and #7 all the cg stuff would have to be replaced with glsl. afaik ogre supports glsl (i think theres even a trivial way to convert the shaders). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-29 07:05 EST --- (In reply to comment #6) > Could you also package the samples into ogre-samples subpackage? They can > serve > as some kind of tests. I'm not planning on doing this, many of the samples won't work withpout a propietary nvidea lib, also the samples don't even compile out of the box. Last but not least the samples are expecting to be run form a directory with certain subdirs present (all ogre programs suffer from this, see the workaround I've put into chess). So all in all the pain is not worth the gain IMHO. If someone however would submit a clean patch to add a working -samples subpackage I would happy to add that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-29 05:45 EST --- Could you also package the samples into ogre-samples subpackage? They can serve as some kind of tests. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-27 06:34 EST --- (In reply to comment #4) > Just a proposal and a matter of personal preference: > Did you consider to put the docs currently in ogre-devel-doc into > /usr/share/doc/ogre-devel* instead of /usr/share/doc/ogre-devel-doc? > Nope I didn't consider this because that is not the way how rpm works. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-27 05:35 EST --- Just a proposal and a matter of personal preference: Did you consider to put the docs currently in ogre-devel-doc into /usr/share/doc/ogre-devel* instead of /usr/share/doc/ogre-devel-doc? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-26 16:48 EST --- Sure, I will use it. I have now some troubles when building Ogre with cegui from Extras in FC4. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-26 16:36 EST --- May I advise you to swithc to my version then, it fixes a bug with fonts with relative sizes not showing, which was causing fonts for me to disappear in chess, caused me ages to find. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 --- Additional Comments From [EMAIL PROTECTED] 2006-06-26 16:34 EST --- I have packaged the current versions of Ogre for my internal needs using the same basis (Xavier Decoret) ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196744 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
