[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 --- Comment #8 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-03 12:26:26 EDT --- Please close this bug after you have push your package on bodhi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 Paul Wouters p...@xelerance.com changed: What|Removed |Added Status|RELEASE_PENDING |CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 Paul Wouters p...@xelerance.com changed: What|Removed |Added Status|ASSIGNED|RELEASE_PENDING -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 --- Comment #6 from Paul Wouters p...@xelerance.com 2009-01-23 10:37:27 EDT --- New Package CVS Request === Package Name: dnssec-conf Short Description: DNSSEC and DLV configuration and priming tool Owners: pwouters Branches: F-10, F-9, EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-01-23 18:20:30 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480567
Jochen Schmitt joc...@herr-schmitt.de changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Jochen Schmitt joc...@herr-schmitt.de 2009-01-22
12:17:38 EDT ---
Good:
+ Could downloaded upstream tar ball via spectool -g
+ Packaged tar ball matches with upstream one.
(md5sum: c998c8050c77c14eda496b26891bb4c1)
+ License GPLv2+ is matches with the copyright notice in the course file
+ Local build works fine
+ Build on koji works fine.
TDDO:
+ You need on add a extran '%' to escape the specila '%' char in the %changelog
stanza. Escaping the '$' character is no necessary in the %changelog stanza, so
you can write
* Wed Jan 21 2009 Paul Wouters p...@xelerance.com - 1.13-1
- Clarify license
- Fix mixed use of $RPM_BUILD_ROOT and %%{buildroot}
- Source tag fully qualified now
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 Paul Wouters p...@xelerance.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 --- Comment #2 from Paul Wouters p...@xelerance.com 2009-01-21 09:38:31 EDT --- Fixed all issues (bad and TODO) Spec URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf.spec SRPM URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf-1.13-1.src.rpm Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480567
--- Comment #3 from Jochen Schmitt joc...@herr-schmitt.de 2009-01-21
12:41:10 EDT ---
Bad:
- The current upstream release is 1.12.
- License tag was not changed from GPLv2+ to GPLv2
I couldN't download 1.13 via spectool -g
- Please write $$RPM_BUILD_ROOT and %%{buildroot} in the %changelog stanza for
excaping the special chars '$' and '%'
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480567 --- Comment #4 from Paul Wouters p...@xelerance.com 2009-01-21 23:34:55 EDT --- - Upstream was at 1.13, but upstream misplaced the file and fixed it :=) - Upstream license is GPLv2+, not GPLv2 - spectool -g now properly downloads 1.13 - fixed macros in changelog Spec URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf.spec SRPM URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf-1.13-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480567] Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480567
Jochen Schmitt joc...@herr-schmitt.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||joc...@herr-schmitt.de
AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de
Flag||fedora-review?
--- Comment #1 from Jochen Schmitt joc...@herr-schmitt.de 2009-01-19
14:54:51 EDT ---
God:
+ Basename of the SPEC files matches with package name
+ Name of the package fits naming guidelines
+ Package contains most recent release
+ Package contains valid License tag
+ License tag contains GPLv2+ as a valid OSS license
+ License review on source files state, that GPLv2 may be
+ Package contains a verbatin copy of the license text
+ Package has no subpackages
+ Local buidl works fine
+ Package contains %clean stanza
+ Buildroot will be deleted on the beginning of %clean and %install
+ Local install works fine
+ Local uninstall works fine
+ Start of dnssec-conf without argument works witoht crash
+ Build on koji works fine
+ Rpmlint has no complaints about the source package
+ Rpmlint has no complaints about the binary package
+ Files has proper file permissions
+ All packaged files belong to the package
+ Package contains no files belong to other packages
+ %doc subpackage has a small amont, so we need no separate doc subpackage
+ Package contains proper %changelog
Bad.
- source tag not fully quallified
- Package use $RPM_BUILD_ROOT and %{buildroot}
- License review on source files state, that GPLv2 may be
right value for the license tag
TODO:
- Please notify upstream, that eatch source file should have
a proper copyright notice
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
