[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-03-09 18:57:58 EDT ---
perl-XML-Generator-1.01-3.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version||1.01-3.fc10




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-03-09 19:04:15 EDT ---
perl-XML-Generator-1.01-3.fc9 has been pushed to the Fedora 9 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|1.01-3.fc10 |1.01-3.fc9




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-03-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #11 from Parag AN(पराग) panem...@gmail.com  2009-03-03 23:58:28 
EDT ---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-02-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #10 from Parag AN(पराग) panem...@gmail.com  2009-02-22 23:45:24 
EDT ---
Can you close this review if this package is built for all requested branches?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 CC||ianburr...@gmail.com




--- Comment #7 from Parag AN(पराग) panem...@gmail.com  2009-02-11 21:14:05 
EDT ---
*** Bug 485164 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Dennis Gilmore den...@ausil.us changed:

   What|Removed |Added

   Flag||fedora-cvs+




--- Comment #8 from Dennis Gilmore den...@ausil.us  2009-02-11 21:26:21 EDT 
---
New Package CVS Request
===
Package Name: perl-XML-Generator
Short Description: perl module for generating XML documents
Owners: ausil
Branches: EL-5 F-9 F-10
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #9 from Dennis Gilmore den...@ausil.us  2009-02-11 21:26:39 EDT 
---
CVS Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #5 from Dennis Gilmore den...@ausil.us  2009-01-29 17:12:42 EDT 
---
fixed in 
Spec URL: http://ausil.us/packages/perl-XML-Generator.spec
SRPM URL: http://ausil.us/packages/perl-XML-Generator-1.01-3.fc10.src.rpm

i checked that the tests did infact complete sucessfully

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #6 from Parag AN(पराग) panem...@gmail.com  2009-01-30 01:03:30 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1092744
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=132,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.17 cusr  0.02
csys =  0.22 CPU)
+ Package perl-XML-Generator-1.01-3.fc11 =
 Provides:
 perl(XML::Generator) = 1.01
 perl(XML::Generator::DOM) = 0.2
 perl(XML::Generator::DOM::util)
 perl(XML::Generator::cdata)
 perl(XML::Generator::comment)
 perl(XML::Generator::final)
 perl(XML::Generator::overload)
 perl(XML::Generator::pi)
 perl(XML::Generator::pretty)
 perl(XML::Generator::util)

Requires:
 perl(Carp)
 perl(XML::DOM)
 perl(XML::Generator)
 perl(base)
 perl(constant)
 perl(overload)
 perl(strict)
 perl(vars)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-01-28 22:38:13 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1090315
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=97,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.09 cusr  0.02
csys =  0.15 CPU)
+ Package perl-XML-Generator-1.01-1.fc11 =
  Provides:  perl(XML::Generator) = 1.01 perl(XML::Generator::cdata)
perl(XML::Generator::comment) perl(XML::Generator::final)
perl(XML::Generator::overload) perl(XML::Generator::pi)
perl(XML::Generator::pretty) perl(XML::Generator::util)
 Requires: perl(Carp) perl(base) perl(constant) perl(overload) perl(strict)
perl(vars)

Any reason for removing DOM.pm?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Dennis Gilmore dgilm...@redhat.com changed:

   What|Removed |Added

 CC||dgilm...@redhat.com




--- Comment #2 from Dennis Gilmore dgilm...@redhat.com  2009-01-28 23:39:55 
EDT ---
I honestly do not know why DOM.pm is removed. i picked up the spec from
spacewalk and cleaned it up.  lets add it back.

Spec URL: http://ausil.us/packages/perl-XML-Generator.spec
SRPM URL: http://ausil.us/packages/perl-XML-Generator-1.01-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Ralf Corsepius rc040...@freenet.de changed:

   What|Removed |Added

 CC||rc040...@freenet.de




--- Comment #3 from Ralf Corsepius rc040...@freenet.de  2009-01-29 00:17:37 
EDT ---
Still some issues:

* The t/DOM.t test fails due to a missing XML::DOM
= Please add
BuildRequires: perl(XML::DOM)
This should let the testsuite succeed.

* This is a noarch package.
= No need to pass OPTIMIZE in %build
Please remove OPTIMIZE.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-01-29 00:30:13 
EDT ---
(In reply to comment #3)
 Still some issues:
 
 * The t/DOM.t test fails due to a missing XML::DOM
 = Please add
 BuildRequires: perl(XML::DOM)
 This should let the testsuite succeed.
 
 * This is a noarch package.
 = No need to pass OPTIMIZE in %build
 Please remove OPTIMIZE.

Thanks for this comment. I thought its ok not to care much for noarch packages.
Thanks will take care to ask to remove OPTIMIZE for perl noarch packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review