[FFmpeg-devel] [RFC]Improve flashsv2 encoder dimension error message

2014-11-12 Thread Carl Eugen Hoyos
Hi! Please suggest a better wording. Thank you, Carl Eugen diff --git a/libavcodec/flashsv2enc.c b/libavcodec/flashsv2enc.c index 9735a13..1c016f2 100644 --- a/libavcodec/flashsv2enc.c +++ b/libavcodec/flashsv2enc.c @@ -192,7 +192,7 @@ static av_cold int flashsv2_encode_init(AVCodecContext * avc

Re: [FFmpeg-devel] [SPI] [OPW] Funding a 3rd slot

2014-11-12 Thread Thilo Borgmann
Am 12.11.14 um 19:49 schrieb Michael Niedermayer: > Hi all > > I suggest to use 6250 USD from SPI (or FFIS) to fund a 3rd slot > for the current FFmpeg OPW. > > Due to the limited time, (the deadline is like hmm now ...) > i already agreed to OPW to pay for this slot (conditional on that > SPI mo

Re: [FFmpeg-devel] [PATCH 9/9] lavf/ffm: use AVOption API to store/restore stream properties

2014-11-12 Thread Michael Niedermayer
On Thu, Nov 13, 2014 at 01:39:16AM +0100, Lukasz Marek wrote: > W dniu czwartek, 13 listopada 2014 Michael Niedermayer > napisał(a): > > > On Thu, Nov 13, 2014 at 12:50:38AM +0100, Lukasz Marek wrote: > > > On 12.11.2014 03:19, Michael Niedermayer wrote: > > > >On Wed, Nov 12, 2014 at 12:02:07AM

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Michael Niedermayer
On Thu, Nov 13, 2014 at 01:04:28AM +0100, Lukasz Marek wrote: > On 12.11.2014 20:32, Michael Niedermayer wrote: > >On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: > >>On 12 November 2014 17:53, Michael Niedermayer wrote: > >> > >>>On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sab

Re: [FFmpeg-devel] [PATCH 9/9] lavf/ffm: use AVOption API to store/restore stream properties

2014-11-12 Thread Lukasz Marek
W dniu czwartek, 13 listopada 2014 Michael Niedermayer napisał(a): > On Thu, Nov 13, 2014 at 12:50:38AM +0100, Lukasz Marek wrote: > > On 12.11.2014 03:19, Michael Niedermayer wrote: > > >On Wed, Nov 12, 2014 at 12:02:07AM +0100, Lukasz Marek wrote: > > >>On 11.11.2014 08:31, Lukasz Marek wrote:

Re: [FFmpeg-devel] [PATCH 9/9] lavf/ffm: use AVOption API to store/restore stream properties

2014-11-12 Thread Michael Niedermayer
On Thu, Nov 13, 2014 at 12:50:38AM +0100, Lukasz Marek wrote: > On 12.11.2014 03:19, Michael Niedermayer wrote: > >On Wed, Nov 12, 2014 at 12:02:07AM +0100, Lukasz Marek wrote: > >>On 11.11.2014 08:31, Lukasz Marek wrote: > >>>This is a generic solution that will not reqiore modifications when new

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Lukasz Marek
On 12.11.2014 20:32, Michael Niedermayer wrote: On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: On 12 November 2014 17:53, Michael Niedermayer wrote: On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George en

Re: [FFmpeg-devel] [RFC] cinedec: report white balance gain coefficients using metadata

2014-11-12 Thread Michael Niedermayer
On Sun, Nov 09, 2014 at 12:05:41PM +1100, Peter Ross wrote: > For cehoyos: > > The PhantomCINE file format stores unprocessed sensor data from the > camera CFA, and reports image processing coefficients in the file header. > To make meaningful use of this file format with FFmpeg, additional filte

Re: [FFmpeg-devel] [PATCH 9/9] lavf/ffm: use AVOption API to store/restore stream properties

2014-11-12 Thread Lukasz Marek
On 12.11.2014 03:19, Michael Niedermayer wrote: On Wed, Nov 12, 2014 at 12:02:07AM +0100, Lukasz Marek wrote: On 11.11.2014 08:31, Lukasz Marek wrote: This is a generic solution that will not reqiore modifications when new options are added. This also fixes problem with current implementation

Re: [FFmpeg-devel] [PATCH] lavc/options: set all codec options to defaults

2014-11-12 Thread Lukasz Marek
On 12.11.2014 23:05, Michael Niedermayer wrote: On Tue, Nov 11, 2014 at 06:30:39PM +0100, Lukasz Marek wrote: avcodec_get_context_defaults3() sets only specific options to default the values. This commit force all options to be set to the defaults. This improves effectiveness of new ffm format.

Re: [FFmpeg-devel] [PATCH] lavu/opt: fix av_opt_get function

2014-11-12 Thread Lukasz Marek
On 12.11.2014 00:48, Michael Niedermayer wrote: On Tue, Nov 11, 2014 at 09:18:44PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavutil/opt.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) LGTM Pushed this one. You may also cherry-pick it 173d51c982f1eca

Re: [FFmpeg-devel] [PATCH] ffserver_config: report not closed last tag

2014-11-12 Thread Lukasz Marek
On 09.11.2014 04:52, Reynaldo H. Verdejo Pinochet wrote: Looks good. Thanks. Feel free to push. Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/options: set all codec options to defaults

2014-11-12 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 06:30:39PM +0100, Lukasz Marek wrote: > avcodec_get_context_defaults3() sets only specific options to default the > values. > This commit force all options to be set to the defaults. > This improves effectiveness of new ffm format. > In particular it fixes "bt" option being

Re: [FFmpeg-devel] [PATCH] lavc/options: set all codec options to defaults

2014-11-12 Thread Lukasz Marek
On 11.11.2014 18:30, Lukasz Marek wrote: avcodec_get_context_defaults3() sets only specific options to default the values. This commit force all options to be set to the defaults. This improves effectiveness of new ffm format. In particular it fixes "bt" option being out of range when context is

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-12 Thread Lukasz Marek
On 12.11.2014 17:45, Stefano Sabatini wrote: On date Tuesday 2014-11-11 21:24:45 +0100, Lukasz Marek encoded: On 11.11.2014 17:19, Stefano Sabatini wrote: We have already av_get_opt() which serializes the value. Also we should probably escape the values. I saw that function, but don't remembe

Re: [FFmpeg-devel] [PATCH 6/9] ffserver_config: handle codec private options

2014-11-12 Thread Lukasz Marek
On 12.11.2014 08:23, Reynaldo H. Verdejo Pinochet wrote: [..] @@ -293,16 +295,31 @@ static int ffserver_opt_preset(const char *arg, ret = AVERROR(EINVAL); break; } -if (audio_id && !strcmp(tmp, "acodec")) { -*audio_id = opt_codec(tmp2, AVM

Re: [FFmpeg-devel] [PATCH 3/4] web/style.less: colors: Reindent and use more obvious functions

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 11:51:34AM -0800, db0 company wrote: > On Mon, Nov 10, 2014 at 10:10 PM, Timothy Gu wrote: > > Ping, and CC'ing db0 who is the maintainer of the website. > > I can't apply it myself. It looks good to me. applied thanks PS: if you want write access, send me your public s

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: refactored resolving timecode component

2014-11-12 Thread Mark Reid
--- libavformat/mxfdec.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index b533e2a..87f1e51 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1424,6 +1424,27 @@ static int mxf_

Re: [FFmpeg-devel] [SPI] [OPW] Funding a 3rd slot

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 04:54:48PM -0300, James Almer wrote: > On 12/11/14 3:49 PM, Michael Niedermayer wrote: > > Hi all > > > > I suggest to use 6250 USD from SPI (or FFIS) to fund a 3rd slot > > for the current FFmpeg OPW. > > > > Due to the limited time, (the deadline is like hmm now ...) > >

Re: [FFmpeg-devel] [SPI] [OPW] Funding a 3rd slot

2014-11-12 Thread James Almer
On 12/11/14 3:49 PM, Michael Niedermayer wrote: > Hi all > > I suggest to use 6250 USD from SPI (or FFIS) to fund a 3rd slot > for the current FFmpeg OPW. > > Due to the limited time, (the deadline is like hmm now ...) > i already agreed to OPW to pay for this slot (conditional on that > SPI mone

Re: [FFmpeg-devel] [PATCH 3/4] web/style.less: colors: Reindent and use more obvious functions

2014-11-12 Thread db0 company
On Mon, Nov 10, 2014 at 10:10 PM, Timothy Gu wrote: > Ping, and CC'ing db0 who is the maintainer of the website. I can't apply it myself. It looks good to me. -- db0 - Deby Barbara Lepage http://db0.fr/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [SPI] [OPW] Funding a 3rd slot

2014-11-12 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > I suggest to use 6250 USD from SPI (or FFIS) to fund a 3rd slot > for the current FFmpeg OPW. Great idea! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: > On 12 November 2014 17:53, Michael Niedermayer wrote: > > > On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: > > > On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > > > > Le primidi 21 brumaire,

[FFmpeg-devel] [SPI] [OPW] Funding a 3rd slot

2014-11-12 Thread Michael Niedermayer
Hi all I suggest to use 6250 USD from SPI (or FFIS) to fund a 3rd slot for the current FFmpeg OPW. Due to the limited time, (the deadline is like hmm now ...) i already agreed to OPW to pay for this slot (conditional on that SPI money can in principle be used for that) This is of course a promise

Re: [FFmpeg-devel] [PATCH] lavf/tcp: apply minor fixes to documentation

2014-11-12 Thread Timothy Gu
On Wed, Nov 12, 2014 at 7:14 AM, Stefano Sabatini wrote: > In particular, add an Examples section and correct the unit of the > listen_timeout option value, from microseconds to milliseconds. This is a huge mistake, and therefore needs to be backported to release branches as well. > --- > doc/p

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-12 Thread Binathi Bingi
Hi there, Updated changes in the patch. Please let me know if any further enhancements are required. Thanks, Binathi On Wed, Nov 12, 2014 at 8:50 PM, Stefano Sabatini wrote: > On date Wednesday 2014-11-12 00:46:09 +0530, Binathi Bingi encoded: > [...] > > From 692fb9ee19d5f9acf080eb98d22ca15f

Re: [FFmpeg-devel] [PATCH 1/2] x86/flacdsp: separate decoder and encoder dsp initialization

2014-11-12 Thread James Almer
On 12/11/14 1:38 AM, Michael Niedermayer wrote: > On Mon, Nov 10, 2014 at 05:37:28PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/x86/flacdsp_init.c | 15 +++ >> 1 file changed, 11 insertions(+), 4 deletions(-) > > LGTM Pushed, thanks. __

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Lukasz Marek
On 12 November 2014 17:53, Michael Niedermayer wrote: > On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: > > On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > > > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > > > +static int ffm_write_header_

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: > On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void > > > *priv_data, int t

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Stefano Sabatini
On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void > > *priv_data, int type) > > +{ > > +AVIOContext *tmp; > > +char *buf = NULL; > > + >

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-12 Thread Stefano Sabatini
On date Tuesday 2014-11-11 21:24:45 +0100, Lukasz Marek encoded: > On 11.11.2014 17:19, Stefano Sabatini wrote: > >We have already av_get_opt() which serializes the value. Also we should > >probably escape the values. > > I saw that function, but don't remember why I didn't use. I was > wrong obvi

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-12 Thread Stefano Sabatini
On date Wednesday 2014-11-12 00:46:09 +0530, Binathi Bingi encoded: [...] > From 692fb9ee19d5f9acf080eb98d22ca15fa1176393 Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Restore Daemon mode in FFserver > > Signed-off-by: Binathi Bingi > >

[FFmpeg-devel] [PATCH] lavf/tcp: apply minor fixes to documentation

2014-11-12 Thread Stefano Sabatini
In particular, add an Examples section and correct the unit of the listen_timeout option value, from microseconds to milliseconds. --- doc/protocols.texi | 21 +++-- libavformat/tcp.c | 6 +++--- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/doc/protocols.texi b

Re: [FFmpeg-devel] Resubmit patch - [patch 4/4] Fix bugforPOWERLE: libswscale/ppc/swscale_altivec.c

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 03:41:46PM +0800, rongyan wrote: > Hi, > Again, thanks for your patience and review. > New patch please find in the attachment. The fate test results on both LE and > BE are as follows: applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611E

Re: [FFmpeg-devel] [PATCH 3/4] web/style.less: colors: Reindent and use more obvious functions

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 01:40:43PM +0100, Michael Niedermayer wrote: > On Mon, Nov 10, 2014 at 10:10:21PM -0800, Timothy Gu wrote: > > On Thu, Nov 6, 2014 at 6:55 PM, Timothy Gu wrote: > > > Signed-off-by: Timothy Gu > > > --- > > > I feel like using hsl() in this case is clearer that the color i

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-12 Thread Lukasz Marek
On 12 November 2014 09:16, Nicolas George wrote: > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > I dont agree. Assert cannot be placed. Return value is not checked > > is set_defaults so errors are ignored. It can just leave invalid > > value. Assert here would terminate an appli

Re: [FFmpeg-devel] [PATCH 3/4] web/style.less: colors: Reindent and use more obvious functions

2014-11-12 Thread Michael Niedermayer
On Mon, Nov 10, 2014 at 10:10:21PM -0800, Timothy Gu wrote: > On Thu, Nov 6, 2014 at 6:55 PM, Timothy Gu wrote: > > Signed-off-by: Timothy Gu > > --- > > I feel like using hsl() in this case is clearer that the color is plain > > gray. Bikeshedding welcome. > > --- > > src/less/style.less | 31 +

Re: [FFmpeg-devel] [PATCH] configure: Hack to allow compilation for x32.

2014-11-12 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > +# Treat x32 as x64 without asm for now. Note > it also needs spic=$shared > +test "$subarch" = "x86_32" && check_cpp_condition > stddef.h 'defined(__x86_64__)' && > +disable asm && subarch=x86_64 The part that sets spic=$shared wa

Re: [FFmpeg-devel] [PATCH]Clarify that the tcp timeout option takes microseconds

2014-11-12 Thread Stefano Sabatini
On date Wednesday 2014-11-12 10:56:08 +0100, Carl Eugen Hoyos encoded: > Hi! > > Attached patch improves the option documentation imo. > > Please comment, Carl Eugen > diff --git a/libavformat/tcp.c b/libavformat/tcp.c > index a1b1856..0aabc9d 100644 > --- a/libavformat/tcp.c > +++ b/libavformat

Re: [FFmpeg-devel] [PATCH]Treat x32 as x86_64

2014-11-12 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > This was requested by Andreas. Merged by Michael. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Remove the option -frame_rate from avfoundation: It has no effect

2014-11-12 Thread Carl Eugen Hoyos
Thilo Borgmann mail.de> writes: > > Related to ticket #4080. > > > > Please review / merge, Carl Eugen > > Ok. The patch was merged by Michael. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCHv2] vf_interlace: Add SIMD for lowpass filter

2014-11-12 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 06:43:42PM +, Kieran Kunhya wrote: > --- > libavfilter/interlace.h | 59 + > libavfilter/vf_interlace.c | 55 +-- > libavfilter/x86/Makefile| 2 + > libavfilter/x86/vf_interlace.asm

[FFmpeg-devel] [PATCH]Clarify that the tcp timeout option takes microseconds

2014-11-12 Thread Carl Eugen Hoyos
Hi! Attached patch improves the option documentation imo. Please comment, Carl Eugen diff --git a/libavformat/tcp.c b/libavformat/tcp.c index a1b1856..0aabc9d 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -45,7 +45,7 @@ typedef struct TCPContext { #define E AV_OPT_FLAG_ENCODING_PARAM

Re: [FFmpeg-devel] [PATCH]Remove the option -frame_rate from avfoundation: It has no effect

2014-11-12 Thread Thilo Borgmann
Am 12.11.14 um 09:58 schrieb Carl Eugen Hoyos: > Hi! > > Related to ticket #4080. > > Please review / merge, Carl Eugen Ok. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]Remove the option -frame_rate from avfoundation: It has no effect

2014-11-12 Thread Carl Eugen Hoyos
Hi! Related to ticket #4080. Please review / merge, Carl Eugen From 0ea54d698be613465d92a82495001ddabae128b0 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 12 Nov 2014 09:55:11 +0100 Subject: [PATCH 2/2] lavd/avfoundation: Remove unused -frame_rate option. --- libavdevice/avfoundat

[FFmpeg-devel] [PATCH]Treat x32 as x86_64

2014-11-12 Thread Carl Eugen Hoyos
Hi! This was requested by Andreas. Please merge, Carl Eugen From 5e8e2f3861dfbc4864490401c5209fbc24df3c29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Reimar=20D=C3=B6ffinger?= Date: Wed, 12 Nov 2014 09:53:01 +0100 Subject: [PATCH 1/2] configure: Hack to treat x32 as x86_64. Allows shared compilati

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-12 Thread Nicolas George
Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > I dont agree. Assert cannot be placed. Return value is not checked > is set_defaults so errors are ignored. It can just leave invalid > value. Assert here would terminate an application. In general I > think it is not regular case - i dou

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Nicolas George
Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void > *priv_data, int type) > +{ > +AVIOContext *tmp; > +char *buf = NULL; > + > +if (priv_data) { > +if (avio_open_dyn_buf(&tmp) < 0) > +re

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-12 Thread Lukasz Marek
On 12.11.2014 09:03, Nicolas George wrote: Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : TODO: bump minor version, update doc/APIchanges New function allows to check if option is set to its default I am a bit uncomfortable with that API: this function does not test whether an opt

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-12 Thread Nicolas George
Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > TODO: bump minor version, update doc/APIchanges > > New function allows to check if option is set to its default I am a bit uncomfortable with that API: this function does not test whether an option is set to its default but if an optio