Re: [FFmpeg-devel] [PATCH] Factorize avpriv_mirror() out

2015-01-04 Thread Michael Niedermayer
On Sun, Jan 04, 2015 at 10:26:00AM +0100, Clément Bœsch wrote: On Sun, Jan 04, 2015 at 12:43:26AM -0300, James Almer wrote: On 04/01/15 12:32 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/dirac_dwt.c | 30 +++

[FFmpeg-devel] [PATCH] libavfilter/vf_blend: do not unconditionally compile both filters

2015-01-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/vf_blend.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index 538774b..a29cabc 100644 --- a/libavfilter/vf_blend.c +++

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-04 Thread Anshul
On 01/03/2015 08:40 PM, Michael Niedermayer wrote: On Sat, Jan 03, 2015 at 12:57:04PM +0530, Anshul wrote: On 01/03/2015 01:42 AM, Michael Niedermayer wrote: On Wed, Dec 31, 2014 at 07:09:33PM +0530, Anshul wrote: [..] Makefile |1 allcodecs.c|1 ccaption_dec.c | 361

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_blend: do not unconditionally compile both filters

2015-01-04 Thread Michael Niedermayer
On Sun, Jan 04, 2015 at 12:31:30PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/vf_blend.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) LGTM [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] Factorize avpriv_mirror() out

2015-01-04 Thread Michael Niedermayer
On Sun, Jan 04, 2015 at 12:24:47PM +0100, Michael Niedermayer wrote: On Sun, Jan 04, 2015 at 10:26:00AM +0100, Clément Bœsch wrote: On Sun, Jan 04, 2015 at 12:43:26AM -0300, James Almer wrote: On 04/01/15 12:32 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: only read codec tag when header size is ample

2015-01-04 Thread Michael Niedermayer
On Sun, Jan 04, 2015 at 10:48:01AM +1100, Peter Ross wrote: Signed-off-by: Peter Ross pr...@xvid.org --- libavformat/aiffdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index 91ef2a4..6271c3d 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-04 Thread Michael Niedermayer
On Sun, Jan 04, 2015 at 08:21:51PM +0530, Anshul wrote: On 01/03/2015 08:40 PM, Michael Niedermayer wrote: On Sat, Jan 03, 2015 at 12:57:04PM +0530, Anshul wrote: On 01/03/2015 01:42 AM, Michael Niedermayer wrote: On Wed, Dec 31, 2014 at 07:09:33PM +0530, Anshul wrote: [..] Makefile

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: omit more metadata elements which specific meaning

2015-01-04 Thread Michael Niedermayer
On Sun, Jan 04, 2015 at 10:55:39AM +0100, Thilo Borgmann wrote: Am 03.01.15 um 23:35 schrieb Michael Niedermayer: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/flvenc.c |8 1 file changed, 8 insertions(+) diff --git a/libavformat/flvenc.c

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-04 Thread wm4
On Sun, 4 Jan 2015 17:47:20 +0100 Michael Niedermayer michae...@gmx.at wrote: +}; + + +typedef struct CCaptionSubContext { +AVClass *class; +int parity_table[256]; this can be a static uint8_t table I don't think static variable in structure are allowed in c

Re: [FFmpeg-devel] [PATCH] Factorize avpriv_mirror() out

2015-01-04 Thread Clément Bœsch
On Sun, Jan 04, 2015 at 12:43:26AM -0300, James Almer wrote: On 04/01/15 12:32 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/dirac_dwt.c | 30 +++ libavcodec/snow_dwt.c | 70

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: omit more metadata elements which specific meaning

2015-01-04 Thread Thilo Borgmann
Am 03.01.15 um 23:35 schrieb Michael Niedermayer: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/flvenc.c |8 1 file changed, 8 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 5468c4d..eb4c088 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: only read codec tag when there is space in header

2015-01-04 Thread Peter Ross
Signed-off-by: Peter Ross pr...@xvid.org --- Revised patch. Now passes FATE. libavformat/aiffdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index 91ef2a4..8dbed32 100644 --- a/libavformat/aiffdec.c +++

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-04 Thread Hendrik Leppkes
On Sun, Jan 4, 2015 at 6:41 PM, wm4 nfx...@googlemail.com wrote: On Sun, 4 Jan 2015 17:47:20 +0100 Michael Niedermayer michae...@gmx.at wrote: +}; + + +typedef struct CCaptionSubContext { +AVClass *class; +int parity_table[256]; this can be a static uint8_t

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: only read codec tag when there is space in header

2015-01-04 Thread Michael Niedermayer
On Mon, Jan 05, 2015 at 08:44:06AM +1100, Peter Ross wrote: Signed-off-by: Peter Ross pr...@xvid.org --- Revised patch. Now passes FATE. libavformat/aiffdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) locally applied, will be in next push thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-04 Thread wm4
On Sun, 4 Jan 2015 22:49:16 +0100 Hendrik Leppkes h.lepp...@gmail.com wrote: On Sun, Jan 4, 2015 at 6:41 PM, wm4 nfx...@googlemail.com wrote: On Sun, 4 Jan 2015 17:47:20 +0100 Michael Niedermayer michae...@gmx.at wrote: +}; + + +typedef struct CCaptionSubContext {

Re: [FFmpeg-devel] [PATCH] x86/flacdsp: remove unneeded ifdeffery

2015-01-04 Thread Michael Niedermayer
On Sat, Jan 03, 2015 at 07:52:17PM -0300, James Almer wrote: On 29/12/14 5:05 PM, James Almer wrote: x86inc can translate r*m into a register or stack on its own Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/flacdsp.asm | 18 +++--- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/unsharp opencl optimization

2015-01-04 Thread Wei Gao
2015-01-04 7:34 GMT+08:00 Alexey Titov alex.ti@gmail.com: From: atitov alexey.ti...@amd.com --- libavfilter/unsharp.h | 4 ++ libavfilter/unsharp_opencl.c| 74 +++--- libavfilter/unsharp_opencl_kernel.h | 122

[FFmpeg-devel] Main git server issues

2015-01-04 Thread Michael Niedermayer
Hi all as you probably already noticed videolans git server is not working since yesterday and as they generously provide also our main git, ffmpeg git is neither. I do hope the server will be alive again soon/?tomorrow? but until then we can simply use the github mirror, ive enabled irc and mail

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: mention both ffpreset/avpreset in documentation, remove superfluous example

2015-01-04 Thread Michael Niedermayer
On Fri, Jan 02, 2015 at 11:11:48AM +0100, Werner Robitza wrote: ffmpeg looks for both .ffpreset and .avpreset files depending on whether the -[avsf]pre or -pre option is used. Added two sections for each type of preset including the rules according to which files are searched. (Notably, the

Re: [FFmpeg-devel] [PATCH] avcodec/dvdsubdec: fix out of bounds accesses

2015-01-04 Thread Michael Niedermayer
On Mon, Jan 05, 2015 at 04:45:26AM +0100, wm4 wrote: The code blindly trusted buffer offsets read from the file in the RLE decoder. Explicitly check the offset. Also error out on other RLE decoding errors. --- libavcodec/dvdsubdec.c | 13 + 1 file changed, 9 insertions(+), 4

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/unsharp opencl optimization

2015-01-04 Thread Titov, Alexey
Hi Wei, This is the first part of the whole patch right? Could you send the second part? Nope, this is the whole patch. git sendmail automatically added 1/2, even though this is the only part. Regards ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec/dvdsubdec: fix out of bounds accesses

2015-01-04 Thread wm4
The code blindly trusted buffer offsets read from the file in the RLE decoder. Explicitly check the offset. Also error out on other RLE decoding errors. --- libavcodec/dvdsubdec.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/dvdsubdec.c