Re: [FFmpeg-devel] [PATCH] avformat: Add simple ACLR atom reading to set the color range

2015-02-18 Thread Kevin Wheatley
So reading through the comments in this thread, it looks to me like some of the problems come from the use of the mov_read_extradata() function, which has more logic than the name implies, in particular it will successfully return even if it did not read the atom into the extradata, so if i just

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-18 Thread Christophe Gisquet
Hi, 2015-02-17 20:06 GMT+01:00 James Almer jamr...@gmail.com: $ make libavcodec/x86/dcadsp.o DBG=0 OK, it's mainly a matter of documentation then here, as just having DBG defined is fine. I'm not sure of the makefile syntax if DBG=1 is what is really wanted. YASM

Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-18 Thread Giorgio Vazzana
Hi, 2015-02-14 11:12 GMT+01:00 Giorgio Vazzana mywin...@gmail.com: Hi, 2015-02-14 9:33 GMT+01:00 supraja reddy supraja0...@gmail.com: Hello, I have added the necessary functions for twofish in crypto_bench. A note, there is no twofish implementation in openssl library but since the code

Re: [FFmpeg-devel] tests: fate: adding fate-test for twofish

2015-02-18 Thread Michael Niedermayer
On Wed, Feb 18, 2015 at 06:46:21PM +0530, supraja reddy wrote: Hello, I have attached a patch to add fate-test for twofish. Thanks, Supraja libavutil.mak |5 + 1 file changed, 5 insertions(+) 487a837eebc4f0d2a29bcb6f0bf87f1a198023cf

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: optimize block functions

2015-02-18 Thread Michael Niedermayer
On Sat, Feb 14, 2015 at 10:56:28PM +0800, zhaoxiu.zeng wrote: From 960eca51e6e65e6969f7d829e29ddc2387420733 Mon Sep 17 00:00:00 2001 From: Zeng Zhaoxiu zhaoxiu.z...@gmail.com Date: Sat, 14 Feb 2015 19:46:51 +0800 Subject: [PATCH 2/5] avcodec/vc1: optimize block functions This patch breaks

Re: [FFmpeg-devel] [PATCH] avformat: Add simple ACLR atom reading to set the color range

2015-02-18 Thread Michael Niedermayer
On Wed, Feb 18, 2015 at 09:40:24AM +, Kevin Wheatley wrote: So reading through the comments in this thread, it looks to me like some of the problems come from the use of the mov_read_extradata() function, which has more logic than the name implies, in particular it will successfully return

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: optimize block functions

2015-02-18 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: 0, 31, 31,1, 230400, 0x18a2f97a 0, 32, 32,1, 230400, 0xf9e82961 0, 33, 33,1, 230400, 0x57a8e9e8 -0, 34, 34,1, 230400, 0xdef6fd66 -0,

Re: [FFmpeg-devel] [PATCH] lavfi: Add support to process_command in vf_eq.c

2015-02-18 Thread arwa arif
On Sat, Jan 31, 2015 at 3:55 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Friday 2015-01-30 23:17:33 +0530, Arwa Arif encoded: I have tried to add process_command in vf_eq.c. I have attached the patch. From 1d65e493a8eb247d86b0db324cb740579662706d Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Clément Bœsch
On Wed, Feb 18, 2015 at 02:22:53PM -0800, Chris Kennedy wrote: This is a pretty obvious bug we caught in the thumbnail filter that is very subtle and hardly ever shows issues except for certain videos. Yet it can be seen how it is blatantly going out of bounds by basing the width increment

[FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Chris Kennedy
This is a pretty obvious bug we caught in the thumbnail filter that is very subtle and hardly ever shows issues except for certain videos. Yet it can be seen how it is blatantly going out of bounds by basing the width increment off of i*3 that resulted in odd crashes in rare cases. Thanks,

Re: [FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Clément Bœsch
On Wed, Feb 18, 2015 at 04:09:39PM -0800, Chris Kennedy wrote: On Wed, Feb 18, 2015 at 2:34 PM, Clément Bœsch u...@pkh.me wrote: On Wed, Feb 18, 2015 at 02:22:53PM -0800, Chris Kennedy wrote: This is a pretty obvious bug we caught in the thumbnail filter that is very subtle and hardly

[FFmpeg-devel] [PATCH 2/2] avfilter/paletteuse: add diff_mode

2015-02-18 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com TODO: bump minor --- doc/filters.texi| 15 + libavfilter/vf_paletteuse.c | 151 2 files changed, 153 insertions(+), 13 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index

[FFmpeg-devel] [PATCH 1/2] avfilter/paletteuse: fix error dithering accuracy

2015-02-18 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- libavfilter/vf_paletteuse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index a8defc7..87a90d0 100644 --- a/libavfilter/vf_paletteuse.c +++

[FFmpeg-devel] tests: fate: adding fate-test for twofish

2015-02-18 Thread supraja reddy
Hello, I have attached a patch to add fate-test for twofish. Thanks, Supraja From 577cb83254a0474ef303ec6531304705587f2a94 Mon Sep 17 00:00:00 2001 From: Supraja Meedinti supraja0...@gmail.com Date: Wed, 18 Feb 2015 18:43:03 +0530 Subject: [PATCH] tests: fate: adding fate-test for twofish

Re: [FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Chris Kennedy
On Wed, Feb 18, 2015 at 2:34 PM, Clément Bœsch u...@pkh.me wrote: On Wed, Feb 18, 2015 at 02:22:53PM -0800, Chris Kennedy wrote: This is a pretty obvious bug we caught in the thumbnail filter that is very subtle and hardly ever shows issues except for certain videos. Yet it can be seen

Re: [FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Chris Kennedy
More details attached, debug level and gdb backtrace. Hopefully this helps, and I will work on getting a file I can share showing the issue. Thanks On Wed, Feb 18, 2015 at 4:09 PM, Chris Kennedy ckenn...@groovy.org wrote: On Wed, Feb 18, 2015 at 2:34 PM, Clément Bœsch u...@pkh.me wrote: On

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/paletteuse: add diff_mode

2015-02-18 Thread Michael Niedermayer
On Wed, Feb 18, 2015 at 03:46:24PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com TODO: bump minor --- doc/filters.texi| 15 + libavfilter/vf_paletteuse.c | 151 2 files changed, 153 insertions(+), 13

Re: [FFmpeg-devel] [PATCH 1/3] lavd/alsa: set frame_size field.

2015-02-18 Thread Michael Niedermayer
On Mon, Feb 16, 2015 at 10:22:15PM +0100, Nicolas George wrote: The value tells the typical size of a packet from the demuxer. Signed-off-by: Nicolas George geo...@nsup.org --- libavdevice/alsa-audio-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] doc/filters: simplify lenscorrection option descriptions

2015-02-18 Thread Lou Logan
On Mon, 9 Feb 2015 11:04:47 -0900, Lou Logan wrote: Also mention option defaults. Also fix incorrect k1 and k2 no correction values. Signed-off-by: Lou Logan l...@lrcd.com --- doc/filters.texi | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Ping.

Re: [FFmpeg-devel] [PATCH] lavfi: Add support to process_command in vf_eq.c

2015-02-18 Thread Michael Niedermayer
On Thu, Feb 19, 2015 at 02:33:43AM +0530, arwa arif wrote: On Sat, Jan 31, 2015 at 3:55 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Friday 2015-01-30 23:17:33 +0530, Arwa Arif encoded: I have tried to add process_command in vf_eq.c. I have attached the patch. From