[FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Vilius Grigaliūnas
Input files in XYZ color space are incorrecly detected as RGB which results in incorrect output colors. This fixes pixel format detection order (in increasing bit depth to match libopenjpeg_matches_pix_fmt) when color space provided by libopenjepg is unknown. --- libavcodec/libopenjpegdec.c |

[FFmpeg-devel] [PATCH 1/2] acvodec/lipopenjpeg: Fix pixel value shift for 12-bit pixel formats

2015-03-03 Thread Vilius Grigaliūnas
This fixes pixel values not being properly shifted in libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods. Pixel formats like xyz12le need to be shifted by AVComponentDescriptor::shift to get the correct values. --- libavcodec/libopenjpegdec.c |6 -- 1 file

[FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Vilius Grigaliūnas
Input files in XYZ color space are incorrecly detected as RGB which results in incorrect output colors. This fixes pixel format detection order (in increasing bit depth to match libopenjpeg_matches_pix_fmt) when color space provided by libopenjepg is unknown. --- libavcodec/libopenjpegdec.c |

Re: [FFmpeg-devel] [PATCH] mxfenc: Adjust product name when opatom muxer is used

2015-03-03 Thread Robert Krüger
On Mon, Mar 2, 2015 at 6:56 PM, Mark Reid mindm...@gmail.com wrote: On Mon, Mar 2, 2015 at 1:46 AM, Robert Krüger krue...@lesspain.de wrote: On Sun, Mar 1, 2015 at 10:43 PM, Mark Reid mindm...@gmail.com wrote: On Sun, Mar 1, 2015 at 4:06 AM, Robert Krüger krue...@lesspain.de wrote:

Re: [FFmpeg-devel] AAC Decoder - fixed point implementation

2015-03-03 Thread Claudio Freire
On Fri, Nov 7, 2014 at 12:08 PM, Nedeljko Babic nedeljko.ba...@imgtec.com wrote: Hello, I am resending patch set with the implementation of fixed point AAC decoder. Our implementation of float emulation integrated in softfloat as requested. Patche set rebased to the newest code since there

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 12:06:09PM +0530, arwa arif wrote: I tried to change the name to fft, but it is conflicting with libavcodec/fft. So, I am unable to change that. I have updated the patch, adding support to coloured images. yes, the names could conflict in configure indeed [...] +

Re: [FFmpeg-devel] [PATCH 10/12] mips: use float* to hold pointer instead of int

2015-03-03 Thread Nedeljko Babic
LGTM - Nedeljko Od: James Cowgill [james...@cowgill.org.uk] Poslato: 26. februar 2015 14:42 Za: ffmpeg-devel@ffmpeg.org Cc: Nedeljko Babic; James Cowgill Tema: [PATCH 10/12] mips: use float* to hold pointer instead of int This is obviously needed for

Re: [FFmpeg-devel] [PATCH 12/12] mips/aaccoder: use variables instead of using register names directly

2015-03-03 Thread Nedeljko Babic
LGTM -Nedeljko Od: James Cowgill [james...@cowgill.org.uk] Poslato: 26. februar 2015 14:42 Za: ffmpeg-devel@ffmpeg.org Cc: Nedeljko Babic; James Cowgill Tema: [PATCH 12/12] mips/aaccoder: use variables instead of using register names directly On mips64,

Re: [FFmpeg-devel] [PATCH] fix VP9 packet decoder returning 0 instead of the used data size

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 12:06:40PM +0100, Steve Lhomme wrote: See https://trac.videolan.org/vlc/ticket/14022#comment:6 --- libavcodec/vp9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-03-03 Thread wm4
On Tue, 3 Mar 2015 15:03:19 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: On 3 March 2015 at 14:16, wm4 nfx...@googlemail.com wrote: On Tue, 3 Mar 2015 13:17:12 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: On 17 February 2015 at 03:27, Marton Balint c...@passwd.hu wrote:

Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-03-03 Thread Clément Bœsch
On Tue, Mar 03, 2015 at 04:26:46PM +0100, Alexander Strasser wrote: On 2015-02-17 22:15 +, Derek Buitenhuis wrote: On 2/17/2015 10:10 PM, James Almer wrote: Afaik, if the error is based on user input then EINVAL (Invalid argument) is correct. AVERROR_INVALIDDATA is when the error

Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-03-03 Thread Alexander Strasser
On 2015-02-17 22:15 +, Derek Buitenhuis wrote: On 2/17/2015 10:10 PM, James Almer wrote: Afaik, if the error is based on user input then EINVAL (Invalid argument) is correct. AVERROR_INVALIDDATA is when the error is in the bitstream/container and not an argument the user passed

[FFmpeg-devel] [PATCH] fix VP9 packet decoder returning 0 instead of the used data size

2015-03-03 Thread Steve Lhomme
See https://trac.videolan.org/vlc/ticket/14022#comment:6 --- libavcodec/vp9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 2bb2432..c7f351b 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -3760,7 +3760,7 @@ static int

[FFmpeg-devel] [PATCH] optionally write QuickTime gama atom (was Re: Gamma function)

2015-03-03 Thread Kevin Wheatley
Updated to use lrint() On Mon, Mar 2, 2015 at 12:54 PM, Kevin Wheatley kevin.j.wheat...@gmail.com wrote: Something like this - note this adds no tests, but fate still passes for me. Kevin From 794c8c3cf1e8506393fbcb4ddf1360042b0fc82f Mon Sep 17 00:00:00 2001 From: Kevin Wheatley

Re: [FFmpeg-devel] [PATCH] mxfenc: Adjust product name when opatom muxer is used

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 10:28:26AM +0100, Robert Krüger wrote: On Mon, Mar 2, 2015 at 6:56 PM, Mark Reid mindm...@gmail.com wrote: On Mon, Mar 2, 2015 at 1:46 AM, Robert Krüger krue...@lesspain.de wrote: On Sun, Mar 1, 2015 at 10:43 PM, Mark Reid mindm...@gmail.com wrote: On Sun,

Re: [FFmpeg-devel] GSoC and Outreachy

2015-03-03 Thread Robert Krüger
On Mon, Mar 2, 2015 at 10:39 PM, Michael Niedermayer michae...@gmx.at wrote: Hi all FFmpeg has been accepted in GSoC this year. Congratulations! You proved quite a few people wrong by this, I guess :-). ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] optionally write QuickTime gama atom (was Re: Gamma function)

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 11:10:54AM +, Kevin Wheatley wrote: Updated to use lrint() On Mon, Mar 2, 2015 at 12:54 PM, Kevin Wheatley kevin.j.wheat...@gmail.com wrote: Something like this - note this adds no tests, but fate still passes for me. Kevin libavcodec/pngenc.c | 29

Re: [FFmpeg-devel] [PATCH] AAC: Fix M/S stereo encoding

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 03:51:48AM -0300, Claudio Freire wrote: This patch fixes a pointer arithmetic bug in adjust_frame_information that resulted in heavily corrupted audio when using M/S encoding. Also, a backup copy of untransformed coefficients has to be kept around or attempts at

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-03-03 Thread wm4
On Tue, 3 Mar 2015 13:17:12 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: On 17 February 2015 at 03:27, Marton Balint c...@passwd.hu wrote: On Sat, 14 Feb 2015, Clément Bœsch wrote: On Sat, Feb 14, 2015 at 02:08:15AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 12:06:09PM +0530, arwa arif wrote: I tried to change the name to fft, but it is conflicting with libavcodec/fft. So, I am unable to change that. I have updated the patch, adding support to coloured images. doc/filters.texi | 22 +++ libavfilter/Makefile

Re: [FFmpeg-devel] [PATCH] optionally write QuickTime gama atom (was Re: Gamma function)

2015-03-03 Thread wm4
On Tue, 3 Mar 2015 11:10:54 + Kevin Wheatley kevin.j.wheat...@gmail.com wrote: From 794c8c3cf1e8506393fbcb4ddf1360042b0fc82f Mon Sep 17 00:00:00 2001 From: Kevin Wheatley kevin.j.wheat...@gmail.com Date: Mon, 2 Mar 2015 12:50:53 + Subject: [PATCH] Add 'gama' atom for .mov only, reuses

Re: [FFmpeg-devel] [PATCH v2] Interpretation of duration field in AVI super index chunk

2015-03-03 Thread Tobias Rapp
On 26.02.2015 15:41, Michael Niedermayer wrote: On Thu, Feb 26, 2015 at 02:14:33PM +0100, Tobias Rapp wrote: On 26.02.2015 00:51, Michael Niedermayer wrote: On Wed, Feb 25, 2015 at 05:35:33PM +0100, Tobias Rapp wrote: [...] @@ -511,7 +514,11 @@ static int avi_write_ix(AVFormatContext *s)

[FFmpeg-devel] [PATCH] mov: write colr by default

2015-03-03 Thread Robert Krüger
This is based on an earlier patch by Derek that never went in because it was argumented earlier that api breakage is not acceptable. However, that was more or less relaxed after Michael noted that the replaced flag had never been part of a release and since a number of people seem to agree, this

Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/avio: added avio_put_str16be

2015-03-03 Thread Michael Niedermayer
On Mon, Mar 02, 2015 at 08:06:13PM -0800, Mark Reid wrote: --- doc/APIchanges| 3 +++ libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 23 +++ libavformat/version.h | 4 ++-- 4 files changed, 30 insertions(+), 6 deletions(-) applied thanks [...] --

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-03-03 Thread arwa arif
On Tue, Mar 3, 2015 at 6:11 PM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Mar 03, 2015 at 12:06:09PM +0530, arwa arif wrote: I tried to change the name to fft, but it is conflicting with libavcodec/fft. So, I am unable to change that. I have updated the patch, adding support to

Re: [FFmpeg-devel] [PATCH 07/12] mips/aacdec: remove uses of mips32r2 specific ext instructions

2015-03-03 Thread James Cowgill
On Tue, 2015-03-03 at 12:42 +, Nedeljko Babic wrote: Removing these removes the dependency of this code on mips32r2 which would allow it to be used on processors which have FPU instructions, but not r2 instructions (like the mips64el debian port for instance). I would be more

Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/avio: added avio_put_str16be

2015-03-03 Thread Mark Reid
On Tue, Mar 3, 2015 at 9:25 AM, Michael Niedermayer michae...@gmx.at wrote: On Mon, Mar 02, 2015 at 08:06:13PM -0800, Mark Reid wrote: --- doc/APIchanges| 3 +++ libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 23 +++ libavformat/version.h | 4

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 04:04:09PM +0100, wm4 wrote: On Tue, 3 Mar 2015 15:03:19 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: On 3 March 2015 at 14:16, wm4 nfx...@googlemail.com wrote: On Tue, 3 Mar 2015 13:17:12 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: On 17

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Michael Bradshaw
On Tue, Mar 3, 2015 at 3:04 AM, Vilius Grigaliūnas vilius.grigaliu...@gmail.com wrote: On Tue, Mar 3, 2015 at 11:40 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Doesn't this break rgb48 images? No, it does not break rgb48. They are not affected by this change. Due to the way

Re: [FFmpeg-devel] [PATCH] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Vilius Grigaliūnas
The reason for this change is that the native jpeg2000 decoder does not yet support 4K digital cinema files (#2586). The workaround for that is to use libopenjpeg decoder, which sort of works but incorrectly detects pixel format as rgb48le instead of xyz12le. This produces wrong colors in the

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Michael Bradshaw
On Tue, Mar 3, 2015 at 1:19 AM, Vilius Grigaliūnas vilius.grigaliu...@gmail.com wrote: Input files in XYZ color space are incorrecly detected as RGB which results in incorrect output colors. This fixes pixel format detection order (in increasing bit depth to match

Re: [FFmpeg-devel] [PATCH 1/2] acvodec/lipopenjpeg: Fix pixel value shift for 12-bit pixel formats

2015-03-03 Thread Michael Bradshaw
On Tue, Mar 3, 2015 at 1:19 AM, Vilius Grigaliūnas vilius.grigaliu...@gmail.com wrote: This fixes pixel values not being properly shifted in libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods. Pixel formats like xyz12le need to be shifted by AVComponentDescriptor::shift to get

Re: [FFmpeg-devel] [PATCH] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Vilius Grigaliūnas
On Tue, Mar 3, 2015 at 4:35 AM, Michael Bradshaw mjbs...@gmail.com wrote: You can use the -pix_fmt option to specify the pixel format of the source. The openjpeg decoder will try that pixel format first before iterating through its (prioritized) list of pixel formats. That should provide a way

[FFmpeg-devel] [PATCH v4] libavformat/mxfenc: write package name metadata

2015-03-03 Thread Mark Reid
--- libavformat/mxfenc.c | 88 +-- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 82 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c

Re: [FFmpeg-devel] [PATCH 1/2] acvodec/lipopenjpeg: Fix pixel value shift for 12-bit pixel formats

2015-03-03 Thread Vilius Grigaliūnas
Overall, looks good to me. Maybe the + desc-comp[x].shift; part should be moved inside the FFMIN macro? Seems okay as is, though. I looked how it is implemented in jpeg200dec.c and there is no FFMIN there. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] mov: write colr by default

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 06:17:22PM +0100, Robert Krüger wrote: This is based on an earlier patch by Derek please mention this in the commit message that never went in because it was argumented earlier that api breakage is not acceptable. However, that was more or less relaxed after Michael

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 10:50:09PM +0530, arwa arif wrote: On Tue, Mar 3, 2015 at 6:11 PM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Mar 03, 2015 at 12:06:09PM +0530, arwa arif wrote: I tried to change the name to fft, but it is conflicting with libavcodec/fft. So, I am

Re: [FFmpeg-devel] [PATCH] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Michael Bradshaw
On Mon, Mar 2, 2015 at 11:56 PM, Vilius Grigaliūnas vilius.grigaliu...@gmail.com wrote: On Tue, Mar 3, 2015 at 4:35 AM, Michael Bradshaw mjbs...@gmail.com wrote: You can use the -pix_fmt option to specify the pixel format of the source. The openjpeg decoder will try that pixel format

Re: [FFmpeg-devel] [PATCH] mov: write colr by default

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 09:24:17PM +0100, Robert Krüger wrote: On Tue, Mar 3, 2015 at 7:23 PM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Mar 03, 2015 at 06:17:22PM +0100, Robert Krüger wrote: This is based on an earlier patch by Derek please mention this in the commit

Re: [FFmpeg-devel] [PATCH 10/12] mips: use float* to hold pointer instead of int

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 12:44:01PM +, Nedeljko Babic wrote: LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 12/12] mips/aaccoder: use variables instead of using register names directly

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 12:44:47PM +, Nedeljko Babic wrote: LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data signature.asc

[FFmpeg-devel] GSOC2015

2015-03-03 Thread krishna gandhi
Hi all I am Krishna Gupta undergraduate Electronics and Communication student at IIIT hyd. I have gone through this year ideas and project from org's GSOC page and one project that interest me a lot is MPEG-4 ALS encoder. I have little bit of theoretical idea about this from my undergraduate

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 10:19:48AM +0200, Vilius Grigaliūnas wrote: Input files in XYZ color space are incorrecly detected as RGB which results in incorrect output colors. This fixes pixel format detection order (in increasing bit depth to match libopenjpeg_matches_pix_fmt) when color space

Re: [FFmpeg-devel] [PATCH v2] Interpretation of duration field in AVI super index chunk

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 02:45:24PM +0100, Tobias Rapp wrote: On 26.02.2015 15:41, Michael Niedermayer wrote: On Thu, Feb 26, 2015 at 02:14:33PM +0100, Tobias Rapp wrote: On 26.02.2015 00:51, Michael Niedermayer wrote: On Wed, Feb 25, 2015 at 05:35:33PM +0100, Tobias Rapp wrote: [...] @@

Re: [FFmpeg-devel] [PATCH] ffplay: Switch to show waves mode if allocation/init of RDFT fails

2015-03-03 Thread Marton Balint
On Mon, 2 Mar 2015, Michael Niedermayer wrote: Fixes null pointer dereference Found-by: Paweł pantrom...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffplay.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-03-03 Thread Peter Cordes
On Sat, Feb 7, 2015 at 6:23 AM, arwa arif arwaarif1...@gmail.com wrote: On Mon, Feb 2, 2015 at 10:23 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Jan 31, 2015 at 02:30:29PM +0530, arwa arif wrote: On Thu, Jan 29, 2015 at 5:18 PM, Stefano Sabatini stefa...@gmail.com wrote:

Re: [FFmpeg-devel] [PATCH 1/2] acvodec/lipopenjpeg: Fix pixel value shift for 12-bit pixel formats

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 12:54:43PM -0700, Michael Bradshaw wrote: On Tue, Mar 3, 2015 at 1:19 AM, Vilius Grigaliūnas vilius.grigaliu...@gmail.com wrote: This fixes pixel values not being properly shifted in libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods. Pixel formats

[FFmpeg-devel] [PATCH] web/index: add News entry for GSoC 2015

2015-03-03 Thread Michael Niedermayer
--- src/index |8 1 file changed, 8 insertions(+) diff --git a/src/index b/src/index index bb60413..27cdbe5 100644 --- a/src/index +++ b/src/index @@ -36,6 +36,14 @@ News /h1 + a id=gsoc2015/ah3March 4, 2015, Google Summer of Code/h3 + p +FFmpeg has been accepted as

Re: [FFmpeg-devel] [PATCH] web/index: add News entry for GSoC 2015

2015-03-03 Thread Lou Logan
On Wed, 4 Mar 2015 01:03:05 +0100, Michael Niedermayer wrote: --- src/index |8 1 file changed, 8 insertions(+) LGTM. Some unimportant suggestions below. + a id=gsoc2015/ah3March 4, 2015, Google Summer of Code/h3 + p +FFmpeg has been accepted as a Google Summer of

Re: [FFmpeg-devel] [PATCH] ffplay: Switch to show waves mode if allocation/init of RDFT fails

2015-03-03 Thread Michael Niedermayer
On Wed, Mar 04, 2015 at 01:35:10AM +0100, Marton Balint wrote: On Mon, 2 Mar 2015, Michael Niedermayer wrote: Fixes null pointer dereference Found-by: Paweł pantrom...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffplay.c |5 - 1 file changed, 4

[FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-03 Thread Peter Cordes
I've made some patches, and am finally getting around to sending them upstream. I'm trying out gmail for dealing with a high-traffic list like this one, instead of my usual mutt. Are the one-line-paragraph long lines it's probably going to produce an annoyance for anyone? I didn't notice

Re: [FFmpeg-devel] [PATCH] web/index: add News entry for GSoC 2015

2015-03-03 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 03:17:04PM -0900, Lou Logan wrote: On Wed, 4 Mar 2015 01:03:05 +0100, Michael Niedermayer wrote: --- src/index |8 1 file changed, 8 insertions(+) LGTM. Some unimportant suggestions below. + a id=gsoc2015/ah3March 4, 2015, Google Summer of

Re: [FFmpeg-devel] AAC Decoder - fixed point implementation

2015-03-03 Thread Nedeljko Babic
Hi, On Fri, Nov 7, 2014 at 12:08 PM, Nedeljko Babic nedeljko.ba...@imgtec.com wrote: Hello, I am resending patch set with the implementation of fixed point AAC decoder. Our implementation of float emulation integrated in softfloat as requested. Patche set rebased to the newest code since

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-03-03 Thread Lukasz Marek
On 3 March 2015 at 14:16, wm4 nfx...@googlemail.com wrote: On Tue, 3 Mar 2015 13:17:12 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: On 17 February 2015 at 03:27, Marton Balint c...@passwd.hu wrote: On Sat, 14 Feb 2015, Clément Bœsch wrote: On Sat, Feb 14, 2015 at

Re: [FFmpeg-devel] AAC Decoder - fixed point implementation

2015-03-03 Thread Claudio Freire
On Tue, Mar 3, 2015 at 10:58 AM, Nedeljko Babic nedeljko.ba...@imgtec.com wrote: On Fri, Nov 7, 2014 at 12:08 PM, Nedeljko Babic nedeljko.ba...@imgtec.com wrote: Hello, I am resending patch set with the implementation of fixed point AAC decoder. Our implementation of float emulation

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Vilius Grigaliūnas
On Tue, Mar 3, 2015 at 11:40 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Doesn't this break rgb48 images? No, it does not break rgb48. They are not affected by this change. Due to the way libopenjpeg_matches_pix_fmt is implemented, rgb48 can match xyz12, but xyz12 can not match rgb48. So the

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Carl Eugen Hoyos
Vilius Grigaliūnas vilius.grigaliunas at gmail.com writes: static const enum AVPixelFormat libopenjpeg_all_pix_fmts[] = { -RGB_PIXEL_FORMATS, GRAY_PIXEL_FORMATS, YUV_PIXEL_FORMATS, XYZ_PIXEL_FORMATS +AV_PIX_FMT_RGB24, AV_PIX_FMT_RGBA, XYZ_PIXEL_FORMATS, AV_PIX_FMT_RGB48,

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Vilius Grigaliūnas
On Tue, Mar 3, 2015 at 2:05 PM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Why don't you just move XYZ_PIXEL_FORMATS in front of the list? Then the rgb24/rgba would not be detected correctly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-03-03 Thread Lukasz Marek
On 17 February 2015 at 03:27, Marton Balint c...@passwd.hu wrote: On Sat, 14 Feb 2015, Clément Bœsch wrote: On Sat, Feb 14, 2015 at 02:08:15AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint c...@passwd.hu --- Makefile | 1 + doc/ffplay.texi

Re: [FFmpeg-devel] [PATCH] avcodec/rv10: check size of s-mb_width * s-mb_height

2015-03-03 Thread Michael Niedermayer
On Mon, Mar 02, 2015 at 08:32:23PM +0100, Andreas Cadhalpun wrote: On 02.03.2015 19:37, Michael Niedermayer wrote: On Mon, Mar 02, 2015 at 07:18:10PM +0100, Andreas Cadhalpun wrote: So would you prefer using avpriv_report_missing_feature, returning an error and checking the return value in

Re: [FFmpeg-devel] [PATCH 1/2] acvodec/lipopenjpeg: Fix pixel value shift for 12-bit pixel formats

2015-03-03 Thread Vilius Grigaliūnas
On Tue, Mar 3, 2015 at 10:19 AM, Vilius Grigaliūnas vilius.grigaliu...@gmail.com wrote: This fixes pixel values not being properly shifted in libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods. Pixel formats like xyz12le need to be shifted by AVComponentDescriptor::shift to get the

Re: [FFmpeg-devel] [PATCH 2/2] acvodec/lipopenjpeg: Improve XYZ color space detection

2015-03-03 Thread Carl Eugen Hoyos
Vilius Grigaliūnas vilius.grigaliunas at gmail.com writes: Input files in XYZ color space are incorrecly detected as RGB which results in incorrect output colors. Doesn't this break rgb48 images? Could you explain how I can reproduce your issue? Carl Eugen