Re: [FFmpeg-devel] [PATCH 5/6] fate: gapless: remove useless tests

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:24:40PM +0200, wm4 wrote: These could be kept, but they are not overly useful. The only thing they had over the remaining mp3 gapless test was seeking, which was incorrect in the toc test, and only by chance correct in the notoc test. --- tests/fate/gapless.mak

Re: [FFmpeg-devel] [PATCH 5/6] fate: gapless: remove useless tests

2015-04-22 Thread wm4
On Wed, 22 Apr 2015 18:19:02 +0200 Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 12:24:40PM +0200, wm4 wrote: These could be kept, but they are not overly useful. The only thing they had over the remaining mp3 gapless test was seeking, which was incorrect in the toc

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Roger Pack
On 4/22/15, Máté Sebők smfinc@gmail.com wrote: Added NULL-ing after release on load and save, lower-cased the #include shlwapi.h and added release of pers_stream in the error handler. OK the crash is gone now. I'd like to have the IStream_Release only in one section, however. Would it be

Re: [FFmpeg-devel] [PATCH 2/2] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-22 Thread Nedeljko Babic
+static av_always_inline SoftFloat av_div_sf(SoftFloat a, SoftFloat b){ missing documentation I'll add it. is this exact ? if not what are the gurantees to the user On our tests For 80.3% of input values the output is exact For 19.2% of input values the error is one LSB bit of

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-22 Thread Pedro Arthur
Thank you for the tips, I'll work on it. 2015-04-22 3:06 GMT-03:00 nand n...@nand.wakku.to: I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the correct gamma based on the input, thus for now it is

[FFmpeg-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/aacsbr.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c index b582d3f..7e98834 100644 --- a/libavcodec/aacsbr.c +++ b/libavcodec/aacsbr.c @@

Re: [FFmpeg-devel] [PATCH 1/3] vp9: add fate test for bilinear MC filter.

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 11:51:01AM -0400, Ronald S. Bultje wrote: Sample at: http://downloads.webmproject.org/test_data/libvpx/vp90-2-06-bilinear.webm uploaded [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form

[FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-22 Thread Andreas Cadhalpun
The k != 1 case calls show_bits(gb, k), which doesn't make sense if k is 0. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/alac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index ffd2d77..9db690b 100644 ---

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Andreas Cadhalpun
On 22.04.2015 18:31, Claudio Freire wrote: On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 22.04.2015 17:35, Claudio Freire wrote: On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: +if (k ==

Re: [FFmpeg-devel] [PATCH 1/6] avformat: add common mechanism for skipping samples at the start of file

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:24:36PM +0200, wm4 wrote: This makes using the generic indexing code with mp3 easier at a later point. --- libavformat/avformat.h | 9 + libavformat/utils.c| 4 2 files changed, 13 insertions(+) applied thanks [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 3/6] avformat/mp3dec: allow enabling generic seek mode

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:24:38PM +0200, wm4 wrote: -usetoc 2 now invokes the generic seek and indexing mode. This mode skips data until the seek target is reached, and this is exact. It also makes gapless audio actually work if a seek past the start of the file is involved. Change the

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Updated patch for decoding of Bold-Italic-Underlined style records for 3gpp timed text. Fixed several build warnings. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 91 + 1

Re: [FFmpeg-devel] [PATCH 2/6] avformat/mp3dec: use the common mechanism for skipping samples

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:24:37PM +0200, wm4 wrote: The mp2 seek test results change. Whether to skip samples if the file had no LAME gapless tags was inconsistent. When seeking to the start of the file, 529 samples were skipped, but when playing from start, nothing was skipped. This commit

Re: [FFmpeg-devel] [PATCH 2/2] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 01:15:56PM +, Nedeljko Babic wrote: +static av_always_inline SoftFloat av_div_sf(SoftFloat a, SoftFloat b){ missing documentation I'll add it. is this exact ? if not what are the gurantees to the user On our tests For 80.3% of input

Re: [FFmpeg-devel] [PATCH 4/6] avformat/mp3dec: make generic index mode the default

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:24:39PM +0200, wm4 wrote: It's the most useful mode, because it seeks accurately, and does not break features like gapless audio. --- libavformat/mp3dec.c | 2 +- tests/fate/gapless.mak | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) applied thanks

[FFmpeg-devel] [PATCH] mpeg4videodec: only allow a positive length

2015-04-22 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/mpeg4videodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 8449392..9bf33dd 100644 --- a/libavcodec/mpeg4videodec.c +++

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Roger Pack
On 4/22/15, Máté Sebők smfinc@gmail.com wrote: Indeed, sorry i've forgotten to change the Eclipse' EOL to unix-- now fixed. Error handler fixed. Thank you it's very close. A few more nits and we'll be there. You have +if (ofile_stream) +IStream_Release(ofile_stream);

[FFmpeg-devel] [PATCH] bink: check vst-index_entries before using it

2015-04-22 Thread Andreas Cadhalpun
This fixes a NULL pointer dereference if vst-duration is 0. The problem was introduced in commit 0588acaf. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/bink.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/bink.c

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Roger Pack
On 4/22/15, Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 01:40:03PM +0200, Hendrik Leppkes wrote: On Wed, Apr 22, 2015 at 1:12 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 12:47:59PM +0200, Máté Sebők wrote: Indeed, sorry i've forgotten to

Re: [FFmpeg-devel] [PATCH] dss_sp: use lowercase codec name without whitespace

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 02:42:08PM +0200, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/dss_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Andreas Cadhalpun
On 22.04.2015 17:35, Claudio Freire wrote: On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: +if (k == last_k msb == last_msb) { +av_log(ac-avctx, AV_LOG_ERROR, patch construction failed\n); +return

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-22 Thread Kevin Wheatley
I'll add that for some encodings filters with negative lobes will cause ringing no matter the direction up/down, especially true for higher dynamic range encodings like log and HDR options like SMPTE ST 2084 Kevin ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] mpeg4videodec: only allow a positive length

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 04:32:42PM +0200, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/mpeg4videodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 6/6] avformat: add AVFMT_FLAG_FASTSEEK, use it for mp3

2015-04-22 Thread Nicolas George
Le tridi 3 floréal, an CCXXIII, wm4 a écrit : #define AVFMT_FLAG_KEEP_SIDE_DATA 0x4 /// Don't merge side data but keep it separate. +#define AVFMT_FLAG_FAST_SEEK 0x8 /// Enable fast, but inaccurate seeks for some formats Better with the 0, but I suspect it needs a safety gap to

[FFmpeg-devel] [PATCH 2/2] api-flac-test: Coding style

2015-04-22 Thread Ludmila Glinskih
--- libavcodec/api-flac-test.c | 72 -- 1 file changed, 24 insertions(+), 48 deletions(-) diff --git a/libavcodec/api-flac-test.c b/libavcodec/api-flac-test.c index 1540da9..5ff8f12 100644 --- a/libavcodec/api-flac-test.c +++

[FFmpeg-devel] [PATCH 1/2] api-flac-test: Fix stupid mistake

2015-04-22 Thread Ludmila Glinskih
Was comparing 0 bytes in memcmp --- libavcodec/api-flac-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/api-flac-test.c b/libavcodec/api-flac-test.c index 5ca8e8f..1540da9 100644 --- a/libavcodec/api-flac-test.c +++ b/libavcodec/api-flac-test.c @@ -117,7

Re: [FFmpeg-devel] [PATCH 1/2] api-flac-test: Fix stupid mistake

2015-04-22 Thread wm4
On Wed, 22 Apr 2015 18:09:14 +0300 Ludmila Glinskih lglins...@gmail.com wrote: Was comparing 0 bytes in memcmp --- libavcodec/api-flac-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/api-flac-test.c b/libavcodec/api-flac-test.c index

Re: [FFmpeg-devel] [PATCH 2/2] api-flac-test: Coding style

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 06:09:15PM +0300, Ludmila Glinskih wrote: --- libavcodec/api-flac-test.c | 72 -- 1 file changed, 24 insertions(+), 48 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Máté Sebők
Added NULL-ing after release on load and save, lower-cased the #include shlwapi.h and added release of pers_stream in the error handler. There is no other pers_stream, only in the save because the OleLoadFromStream loads directly to the described object. On Wed, Apr 22, 2015 at 4:46 PM, Roger

Re: [FFmpeg-devel] Loongson Optimization Patchs and Machine Express Issuse

2015-04-22 Thread 周晓勇
Sorry about the duplicated wrong patch-0007, 0007-avcodec-optimize-mpegvideo-decode-for-Loongson-3-v1.patch is the right one. -原始邮件- 发件人: 周晓勇 zhouxiaoy...@loongson.cn 发送时间: 2015年4月22日 星期三 收件人: ffmpeg-devel ffmpeg-devel@ffmpeg.org 抄送: gaoxiang gaoxi...@loongson.cn, 孟小甫

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Andreas Cadhalpun
On 22.04.2015 18:52, Vittorio Giovara wrote: On Wed, Apr 22, 2015 at 5:31 PM, Claudio Freire klaussfre...@gmail.com wrote: On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 22.04.2015 17:35, Claudio Freire wrote: On Wed, Apr 22, 2015 at 10:23 AM,

Re: [FFmpeg-devel] [PATCH] libavcodec/parser.c: re-fetch PTS/DTS if fetch failed

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 07:17:59PM +0800, luckliuyuxin wrote: [...] parser.c |5 + 1 file changed, 5 insertions(+) f3ed39fd2c44d36a96dbab27a8c810d7479e8d22 0001-re-fetch-PTS-DTS-if-fetch-failed.patch From 00b457adb855b0b25ac7cde4a9cb8c7b53fd0511 Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Philip Langdale
On 2015-04-22 03:10, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for now, even for multiple style

Re: [FFmpeg-devel] [PATCH 5/6] fate: gapless: remove useless tests

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 06:30:29PM +0200, wm4 wrote: On Wed, 22 Apr 2015 18:19:02 +0200 Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 12:24:40PM +0200, wm4 wrote: These could be kept, but they are not overly useful. The only thing they had over the remaining mp3

[FFmpeg-devel] [PATCH] fate: add mp3 CBR seek test

2015-04-22 Thread wm4
This tests the old, now non-default seek mode, and this requires a special extra argument. --- Requested... not like I think this test is overly useful. --- libavformat/seek-test.c | 2 ++ tests/fate/seek.mak | 13 +--- tests/ref/seek/extra-mp3 | 53

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 11:02:56AM -0600, Roger Pack wrote: On 4/22/15, Máté Sebők smfinc@gmail.com wrote: Of course can it be only in the error block - just deleted the other releases. Also no need for NULL-ing either in this case. Perfect. OK LGTM now. Recommend applying.

Re: [FFmpeg-devel] [PATCH] bink: check vst-index_entries before using it

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 05:08:51PM +0200, Andreas Cadhalpun wrote: This fixes a NULL pointer dereference if vst-duration is 0. The problem was introduced in commit 0588acaf. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/bink.c | 5 - 1 file

Re: [FFmpeg-devel] [libav-devel] [PATCH] dss_sp: use lowercase codec name without whitespace

2015-04-22 Thread Vittorio Giovara
On Wed, Apr 22, 2015 at 1:42 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/dss_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dss_sp.c b/libavcodec/dss_sp.c

[FFmpeg-devel] [PATCH] vp9: remove one optimization branch in iadst16 which causes overflows.

2015-04-22 Thread Ronald S. Bultje
See sample vp90-2-14-resize-fp-tiles-16-8-4-2-1.webm from the vp9 test vector set which reproduces the issue. This probably costs a few cycles, but I don't think there's an easy way to workaround that. --- libavcodec/x86/vp9itxfm.asm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Vittorio Giovara
On Wed, Apr 22, 2015 at 5:31 PM, Claudio Freire klaussfre...@gmail.com wrote: On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 22.04.2015 17:35, Claudio Freire wrote: On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun

[FFmpeg-devel] [PATCH 2/2] tests/fate-run: do not attempt to parse tiny_psnrs output if it failed

2015-04-22 Thread Michael Niedermayer
This avoids confusing syntax errors with awk later Signed-off-by: Michael Niedermayer michae...@gmx.at --- tests/fate-run.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 1a8ff94..7f129d7 100755 --- a/tests/fate-run.sh +++

[FFmpeg-devel] [PATCH 1/2] tests/tiny_psnr: do not ignore errors from run_psnr

2015-04-22 Thread Michael Niedermayer
failure to calculate psnr should not result in tiny_psnr returning success Signed-off-by: Michael Niedermayer michae...@gmx.at --- tests/tiny_psnr.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/tiny_psnr.c b/tests/tiny_psnr.c index e09f394..5f791c1 100644

[FFmpeg-devel] [PATCH 2/2] vp9: add fate test for intraonly frames.

2015-04-22 Thread Ronald S. Bultje
Sample available at: http://downloads.webmproject.org/test_data/libvpx/vp90-2-16-intra-only.webm --- tests/fate/vpx.mak | 1 + tests/ref/fate/vp9-16-intra-only | 10 ++ 2 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/vp9-16-intra-only diff --git

[FFmpeg-devel] [PATCH 1/2] vp9: fix intraonly frame decoding.

2015-04-22 Thread Ronald S. Bultje
--- libavcodec/vp9.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 1935f94..1310798 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -3111,8 +3111,8 @@ static void decode_sb(AVCodecContext *ctx, int row, int col,

Re: [FFmpeg-devel] [PATCH 2/2] vp9: add fate size for resolution changes.

2015-04-22 Thread Michael Niedermayer
On Tue, Apr 21, 2015 at 08:54:52PM -0400, Ronald S. Bultje wrote: See sample: http://downloads.webmproject.org/test_data/libvpx/vp90-2-05-resize.ivf --- tests/fate/vpx.mak | 3 +++ tests/ref/fate/vp9-05-resize | 15 +++ 2 files changed, 18 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH 1/2] tests/tiny_psnr: do not ignore errors from run_psnr

2015-04-22 Thread Timothy Gu
On Thu, Apr 23, 2015 at 04:43:09AM +0200, Michael Niedermayer wrote: failure to calculate psnr should not result in tiny_psnr returning success Signed-off-by: Michael Niedermayer michae...@gmx.at --- tests/tiny_psnr.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 1/2] postproc: Updated postprocess_template to use new sse/avx deinterlace functions

2015-04-22 Thread Tucker DiNapoli
A few notes on changes from the last version of this patch. The main issue with the previous code was with the sse2/avx2 implementation of the blockCopy function, so for the time being the MMX2 version is used instead. I tried to place the MMX2 version into a function, but this did not work, my

Re: [FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 5/6] postproc: Added support for sse2/avx2 versions of the do_a_deblock function

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 04:27:30PM -0400, Tucker DiNapoli wrote: I added a new file with the sse2/avx2 code for do_a_deblock. I also moved the code for running vertical deblock filters into it's own function, both to clean up the postprocess funciton and to make it easier to integrate the new

[FFmpeg-devel] [PATCH] avformat/atrac3plus: fix compilation warning

2015-04-22 Thread Ilya Gordeev
Compiling ffmpeg I'v got this message: libavcodec/atrac3plus.c:1784:46: warning: array subscript is below array bounds [-Warray-bounds] It's because compiler discards its suggestion about ctx-num_quant_units (1=num_quant_units=32) when ctx passed to decode_quant_wordlen(gb, ctx, num_channels,

Re: [FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 4/6] postproc: Updated postprocess_template to use new sse/avx deinterlace functions

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 04:27:29PM -0400, Tucker DiNapoli wrote: [...] +%include PPUtil.asm +;; All deinterlace functions operate on N 8x8 blocks at a time, where N +;; is the size (in bytes) of the simd registers being used divided +;; by 8, so 2 for xmm, and 4 for ymm. + +;; Deinterlace

Re: [FFmpeg-devel] [PATCH] avformat/atrac3plus: fix compilation warning

2015-04-22 Thread Michael Niedermayer
On Thu, Apr 23, 2015 at 12:41:39AM +0300, Ilya Gordeev wrote: Compiling ffmpeg I'v got this message: libavcodec/atrac3plus.c:1784:46: warning: array subscript is below array bounds [-Warray-bounds] It's because compiler discards its suggestion about ctx-num_quant_units

Re: [FFmpeg-devel] [PATCH] fate: add cinepak encoder vsynth tests

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 05:34:28PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- tests/fate/vcodec.mak| 6 +- tests/ref/vsynth/vsynth1-cinepak | 4 tests/ref/vsynth/vsynth2-cinepak | 4 tests/ref/vsynth/vsynth_lena-cinepak |

Re: [FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread James Zern
On Wed, Apr 22, 2015 at 8:59 PM, James Zern jz...@google.com wrote: s/Refer to and to sync/Refer to how to sync/ --- doc/git-howto.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 8ece341..8f4a18b 100644 ---

[FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-22 Thread James Zern
this quiets a warning: Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified internal error --- libavcodec/libvpxenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 2104876..159fbdd 100644 ---

[FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread James Zern
s/Refer to and to sync/Refer to how to sync/ --- doc/git-howto.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 8ece341..8f4a18b 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto.texi @@ -330,7 +330,7 @@ git push Will push

Re: [FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread Timothy Gu
On Wed, Apr 22, 2015 at 09:00:17PM -0700, James Zern wrote: On Wed, Apr 22, 2015 at 8:59 PM, James Zern jz...@google.com wrote: s/Refer to and to sync/Refer to how to sync/ --- doc/git-howto.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/git-howto.texi

[FFmpeg-devel] [PATCH 2/2] vp9: add fate test for segmentation image-edge issue.

2015-04-22 Thread Ronald S. Bultje
Sample available at: http://downloads.webmproject.org/test_data/libvpx/vp90-2-15-segkey_adpq.webm --- tests/fate/vpx.mak| 1 + tests/ref/fate/vp9-15-segkey_adpq | 155 ++ 2 files changed, 156 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 1/2] vp9: use aligned size to write segmentation map into cache.

2015-04-22 Thread Ronald S. Bultje
The unaligned size is not handled in setctx_2d(), causing edges of images to have improper segmentation prediction, which causes visual artifacts at image edges a few frames later. --- libavcodec/vp9.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vp9.c

Re: [FFmpeg-devel] [PATCH 1/2] vp9: add support for resolution changes in inter frames.

2015-04-22 Thread Michael Niedermayer
On Tue, Apr 21, 2015 at 08:54:51PM -0400, Ronald S. Bultje wrote: --- libavcodec/vp9.c | 316 ++- libavcodec/vp9_mc_template.c | 171 +++ libavcodec/vp9_parser.c | 5 +- libavcodec/vp9dsp.c | 205

Re: [FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 2/6] postproc: Made QP, nonBQP, and pQPb arrays

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 04:27:27PM -0400, Tucker DiNapoli wrote: From: Tucker DiNapoli t.dinapol...@gmail.com Also pulled QP initialization out of inner loop, which removed some redundent code. Added some dummy fields to PPContext to allow current code to work while changing the rest of

Re: [FFmpeg-devel] [PATCH] avformat: drop libquvi demuxer

2015-04-22 Thread Carl Eugen Hoyos
Lou Logan lou at lrcd.com writes: libquvi is dead. Shouldn't this be deprecated and removed after the next release? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 6/6] avformat: add AVFMT_FLAG_FASTSEEK, use it for mp3

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 05:27:19PM +0200, wm4 wrote: On Wed, 22 Apr 2015 17:10:30 +0200 Nicolas George geo...@nsup.org wrote: Le tridi 3 floréal, an CCXXIII, wm4 a écrit : #define AVFMT_FLAG_KEEP_SIDE_DATA 0x4 /// Don't merge side data but keep it separate. +#define

Re: [FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 3/6] postproc: Moved inline asm for packing QP to seperate function

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 04:27:28PM -0400, Tucker DiNapoli wrote: This patch contains the code for the avx2/sse2 versions of the new function, but they are deliberately ignored, since the support for avx2/sse2 isn't yet present (the next commit fixes this). This is a temporary measure until

Re: [FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 4/6] postproc: Updated postprocess_template to use new sse/avx deinterlace functions

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 04:27:29PM -0400, Tucker DiNapoli wrote: This commit adds several new files containing yasm assembly code, they are: PPContext.asm; Defines the PPContext struct using the yasm struc command PPUtil.asm; Various utility macros used in the other asm code block_copy.asm;

Re: [FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 4/6] postproc: Updated postprocess_template to use new sse/avx deinterlace functions

2015-04-22 Thread Michael Niedermayer
On Thu, Apr 23, 2015 at 01:03:09AM +0200, Michael Niedermayer wrote: On Wed, Apr 22, 2015 at 04:27:29PM -0400, Tucker DiNapoli wrote: This commit adds several new files containing yasm assembly code, they are: PPContext.asm; Defines the PPContext struct using the yasm struc command

Re: [FFmpeg-devel] [PATCH] vp9: remove another optimization branch in iadst16 which causes overflows.

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 03:48:59PM -0400, Ronald S. Bultje wrote: See sample vp90-2-14-resize-fp-tiles-16-8.webm from the vp9 test vector set to reproduce the issue. --- libavcodec/x86/vp9itxfm.asm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) applied thanks [...] -- Michael

[FFmpeg-devel] [PATCH] dss_sp: use lowercase codec name without whitespace

2015-04-22 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/dss_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dss_sp.c b/libavcodec/dss_sp.c index 42ba1c4..909ad1f 100644 --- a/libavcodec/dss_sp.c +++ b/libavcodec/dss_sp.c @@ -776,7

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 1/6] postproc: Replaced inline asm for prefetching with prefetch functions

2015-04-22 Thread Tucker DiNapoli
This set of patches is what I am submitting as qualification for the google summer of code. I wrote sse2/avx2 versions of several of the postprocessing filters (namely the accurate deblock filter and all the deinterlace filters), and made several changes to the structure of the

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 4/6] postproc: Updated postprocess_template to use new sse/avx deinterlace functions

2015-04-22 Thread Tucker DiNapoli
This commit adds several new files containing yasm assembly code, they are: PPContext.asm; Defines the PPContext struct using the yasm struc command PPUtil.asm; Various utility macros used in the other asm code block_copy.asm; Implements the block copy function, the sse2 and avx2 versions copy

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 5/6] postproc: Added support for sse2/avx2 versions of the do_a_deblock function

2015-04-22 Thread Tucker DiNapoli
I added a new file with the sse2/avx2 code for do_a_deblock. I also moved the code for running vertical deblock filters into it's own function, both to clean up the postprocess funciton and to make it easier to integrate the new sse2/avx2 versions of these filters. ---

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 2/6] postproc: Made QP, nonBQP, and pQPb arrays

2015-04-22 Thread Tucker DiNapoli
From: Tucker DiNapoli t.dinapol...@gmail.com Also pulled QP initialization out of inner loop, which removed some redundent code. Added some dummy fields to PPContext to allow current code to work while changing the rest of the postprocessing code to support the arrays. I also increased

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 6/6] postproc: Various formatting updates from the recent changes

2015-04-22 Thread Tucker DiNapoli
I did my best to make as few changes as possible to the formatting when adding new code, so this commit is just a means of making the format changes that go along with the new code. Mostly these are just changes in indentation, but I also re-formatted a few assignment statments (from x= y - x =

[FFmpeg-devel] [FFMpeg-Devel][GSoC][PATCH 3/6] postproc: Moved inline asm for packing QP to seperate function

2015-04-22 Thread Tucker DiNapoli
This patch contains the code for the avx2/sse2 versions of the new function, but they are deliberately ignored, since the support for avx2/sse2 isn't yet present (the next commit fixes this). This is a temporary measure until full sse2/avx2 implementation is complete, but it works with sse2/avx2

[FFmpeg-devel] [PATCH] fate: add cinepak encoder vsynth tests

2015-04-22 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- tests/fate/vcodec.mak| 6 +- tests/ref/vsynth/vsynth1-cinepak | 4 tests/ref/vsynth/vsynth2-cinepak | 4 tests/ref/vsynth/vsynth_lena-cinepak | 4 4 files changed, 17 insertions(+), 1 deletion(-) create

Re: [FFmpeg-devel] [libav-devel] [PATCH] alsdec: validate time diff index

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 10:59:29AM +0200, Thilo Borgmann wrote: Am 21.04.15 um 19:35 schrieb Andreas Cadhalpun: On 21.04.2015 08:14, Thilo Borgmann wrote: Am 20.04.15 um 23:20 schrieb Andreas Cadhalpun: On 19.04.2015 22:20, Luca Barbato wrote: I'd check that `master` is always between

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for now, even for multiple style records. Suggestions awaited. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for H264 lpf and weight/biweight functions

2015-04-22 Thread Shivraj Patil
-Original Message- From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Timothy Gu Sent: 21 April 2015 00:28 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for

[FFmpeg-devel] [PATCH 2/6] avformat/mp3dec: use the common mechanism for skipping samples

2015-04-22 Thread wm4
The mp2 seek test results change. Whether to skip samples if the file had no LAME gapless tags was inconsistent. When seeking to the start of the file, 529 samples were skipped, but when playing from start, nothing was skipped. This commit changes the behavior on seek to skip nothing. ---

[FFmpeg-devel] [PATCH 1/6] avformat: add common mechanism for skipping samples at the start of file

2015-04-22 Thread wm4
This makes using the generic indexing code with mp3 easier at a later point. --- libavformat/avformat.h | 9 + libavformat/utils.c| 4 2 files changed, 13 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 514e646..c2f798d 100644 ---

[FFmpeg-devel] [PATCH 3/6] avformat/mp3dec: allow enabling generic seek mode

2015-04-22 Thread wm4
-usetoc 2 now invokes the generic seek and indexing mode. This mode skips data until the seek target is reached, and this is exact. It also makes gapless audio actually work if a seek past the start of the file is involved. Change the fate-gapless-mp3 test to use the new mode, and move the old

[FFmpeg-devel] [PATCH 4/6] avformat/mp3dec: make generic index mode the default

2015-04-22 Thread wm4
It's the most useful mode, because it seeks accurately, and does not break features like gapless audio. --- libavformat/mp3dec.c | 2 +- tests/fate/gapless.mak | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index

[FFmpeg-devel] [PATCH 0/6] Fixing gapless mp3 (Nth try)

2015-04-22 Thread wm4
Updated patches. wm4 (6): avformat: add common mechanism for skipping samples at the start of file avformat/mp3dec: use the common mechanism for skipping samples avformat/mp3dec: allow enabling generic seek mode avformat/mp3dec: make generic index mode the default fate: gapless:

[FFmpeg-devel] [PATCH 5/6] fate: gapless: remove useless tests

2015-04-22 Thread wm4
These could be kept, but they are not overly useful. The only thing they had over the remaining mp3 gapless test was seeking, which was incorrect in the toc test, and only by chance correct in the notoc test. --- tests/fate/gapless.mak | 4 +--- tests/ref/fate/gapless-mp3-notoc | 5

Re: [FFmpeg-devel] [PATCH 2/5] avformat/mp3dec: use the common mechanism for skipping samples

2015-04-22 Thread wm4
On Wed, 22 Apr 2015 01:42:39 +0200 Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 01:09:26AM +0200, wm4 wrote: On Wed, 22 Apr 2015 00:48:30 +0200 Michael Niedermayer michae...@gmx.at wrote: On Tue, Apr 21, 2015 at 09:33:51PM +0200, wm4 wrote: --- Feel free

Re: [FFmpeg-devel] [PATCH 1/2] vp9: add support for resolution changes in inter frames.

2015-04-22 Thread Ronald S. Bultje
Hi, On Tue, Apr 21, 2015 at 11:25 PM, James Almer jamr...@gmail.com wrote: On 22/04/15 12:20 AM, James Almer wrote: On 21/04/15 9:54 PM, Ronald S. Bultje wrote: --- libavcodec/vp9.c | 316 ++- libavcodec/vp9_mc_template.c | 171

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Máté Sebők
Indeed, sorry i've forgotten to change the Eclipse' EOL to unix-- now fixed. Error handler fixed. Parameter names changed to audio(/video)_device_load(/save) as I think the to_file and from_file is evident and is specified in the help. About the fake input: by loading a device filter from

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:47:59PM +0200, Máté Sebők wrote: Indeed, sorry i've forgotten to change the Eclipse' EOL to unix-- now fixed. Error handler fixed. Parameter names changed to audio(/video)_device_load(/save) as I think the to_file and from_file is evident and is specified in the

[FFmpeg-devel] [PATCH] libavcodec/parser.c: re-fetch PTS/DTS if fetch failed

2015-04-22 Thread luckliuyuxin
From 00b457adb855b0b25ac7cde4a9cb8c7b53fd0511 Mon Sep 17 00:00:00 2001 From: liuyuxin liuyu...@xiaomi.com Date: Wed, 22 Apr 2015 16:56:42 +0800 Subject: [PATCH] re-fetch PTS/DTS if fetch failed Signed-off-by: liuyuxin liuyu...@xiaomi.com --- libavcodec/parser.c | 5 + 1 file changed, 5

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Michael Niedermayer
Hi On Wed, Apr 22, 2015 at 03:40:03PM +0530, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Hendrik Leppkes
On Wed, Apr 22, 2015 at 1:12 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 12:47:59PM +0200, Máté Sebők wrote: Indeed, sorry i've forgotten to change the Eclipse' EOL to unix-- now fixed. Error handler fixed. Parameter names changed to

Re: [FFmpeg-devel] [libav-devel] [PATCH] alsdec: validate time diff index

2015-04-22 Thread Thilo Borgmann
Am 21.04.15 um 19:35 schrieb Andreas Cadhalpun: On 21.04.2015 08:14, Thilo Borgmann wrote: Am 20.04.15 um 23:20 schrieb Andreas Cadhalpun: On 19.04.2015 22:20, Luca Barbato wrote: I'd check that `master` is always between `raw_buffer` and the end of it. You mean something like the attached

[FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC copy and hv mc functions

2015-04-22 Thread shivraj.patil
From: Shivraj Patil shivraj.pa...@imgtec.com Incorporated review comment. Removed __ from volatile. Signed-off-by: Shivraj Patil shivraj.pa...@imgtec.com --- libavcodec/mips/hevcdsp_init_mips.c | 19 + libavcodec/mips/hevcdsp_mips.h | 20 + libavcodec/mips/hevcdsp_msa.c | 1098

Re: [FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 01:40:03PM +0200, Hendrik Leppkes wrote: On Wed, Apr 22, 2015 at 1:12 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 12:47:59PM +0200, Máté Sebők wrote: Indeed, sorry i've forgotten to change the Eclipse' EOL to unix-- now fixed. Error

Re: [FFmpeg-devel] [GSoC] Patch which adds support for gamma correct scaling

2015-04-22 Thread nand
I intended to fetch the correct gamma value from the video/image metada or pass it by flag (like gamma=x) but yet I don't know how to get the correct gamma based on the input, thus for now it is hardcode. This is how we do it in mpv: 1. If the source has enum AVColorTransferCharacteristic