Re: [FFmpeg-devel] [PATCH][RFC] libavformat/mov Extend metadata handling to read in the keys from the 'keys' atom

2015-09-04 Thread Kevin Wheatley
On Thu, Sep 3, 2015 at 7:49 PM, Michael Niedermayer wrote: > missing checks for interger overflows of the addition and subtraction > > also the subject says "RFC", is there a reason not to push this to > git master once it otherwise looks good ? it is incomplete, basically I

[FFmpeg-devel] [PATCH] libavutil/dict: extend the list of convienience functions for storing different data types

2015-09-04 Thread Kevin Wheatley
Hi, as part of adding support for non-string data types to .mov metadata, I wondered about adding the following helper functions for storing numeric types into an AVDictionary. upfront I'll say I'm not 100% happy with the float32 and float64 named variants (vs float and double) as there is no

[FFmpeg-devel] [PATCH] avfilter/vf_thumbnail: use the name 's' for the pointer to the private context

2015-09-04 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_thumbnail.c | 58 +++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/libavfilter/vf_thumbnail.c b/libavfilter/vf_thumbnail.c index d70d063..c378791 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Make MP3 seek fast

2015-09-04 Thread Tsung-Hung Wu
Hi FFmpeg developers, Sorry for the spam. I know you are busy. Please take your time to review the patch. I don't mean to rush at all. Since the is my first patch, I just want to make sure I was doing the right thing. Please kindly let me know if I posted to a wrong mail group or made the patch

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread James Almer
On 9/4/2015 5:53 AM, Carl Eugen Hoyos wrote: > James Almer gmail.com> writes: > >> Isn't removing these two going to break >> compatibility with libav? > > (ABI or API?) > I don't think so but I absolutely may miss something. > > Carl Eugen ABI, you're removing elements from the middle of

Re: [FFmpeg-devel] [PATCH] libavutil/dict: extend the list of convienience functions for storing different data types

2015-09-04 Thread wm4
On Fri, 4 Sep 2015 14:38:54 +0100 Kevin Wheatley wrote: > Hi, > > as part of adding support for non-string data types to .mov metadata, > I wondered about adding the following helper functions for storing > numeric types into an AVDictionary. > > upfront I'll say

Re: [FFmpeg-devel] [PATCH] libavutil/dict: extend the list of convienience functions for storing different data types

2015-09-04 Thread Kevin Wheatley
On Fri, Sep 4, 2015 at 4:18 PM, wm4 wrote: > On Fri, 4 Sep 2015 14:38:54 +0100 > Kevin Wheatley wrote: > >> Hi, >> >> as part of adding support for non-string data types to .mov metadata, >> I wondered about adding the following helper functions

[FFmpeg-devel] [PATCH] vp9: do unscaled MC in scaled path if size of this reference matches.

2015-09-04 Thread Ronald S. Bultje
This can happen if we do bidirectional MC, where one reference has the same size as the current frame, but the other one doesn't. --- libavcodec/vp9.c | 219 +-- 1 file changed, 117 insertions(+), 102 deletions(-) diff --git a/libavcodec/vp9.c

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Make MP3 seek fast

2015-09-04 Thread Paul B Mahol
On 9/4/15, Tsung-Hung Wu wrote: > Hi FFmpeg developers, > > Sorry for the spam. I know you are busy. Please take your time to review > the patch. I don't mean to rush at all. > Since the is my first patch, I just want to make sure I was doing the right > thing. Please

[FFmpeg-devel] [PATCH] vp9: sync segmentation.absolute_vals between threads.

2015-09-04 Thread Ronald S. Bultje
--- libavcodec/vp9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index e6c5389..3bd2a0f 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -4335,6 +4335,7 @@ static int vp9_decode_update_thread_context(AVCodecContext *dst, const AVCodecCo

[FFmpeg-devel] [PATCH] avformat/mp3dec: Make MP3 seek fast

2015-09-04 Thread Tsung-Hung Wu
Thanks wm4. I updated the patch according to your comments. >* @@ -489,19 +489,21 @@ static int mp3_seek(AVFormatContext *s, int *>* stream_index, int64_t timestamp, *>* AVStream *st = s->streams[0]; *>* int64_t ret = av_index_search_timestamp(st, timestamp, flags); *>* int64_t

[FFmpeg-devel] [PATCH] vp9: fix edge copy for 10/12bpp frames.

2015-09-04 Thread Ronald S. Bultje
--- libavcodec/vp9.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 25a7b1d..7624743 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -3353,9 +3353,9 @@ static void decode_b(AVCodecContext *ctx, int row, int

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Make MP3 seek fast

2015-09-04 Thread Tsung-Hung Wu
From 094c6efab6c5eec1fec274bf1bcace1987ae7d03 Mon Sep 17 00:00:00 2001 From: Andy Wu Date: Mon, 31 Aug 2015 17:08:30 -0700 Subject: [PATCH] avformat/mp3dec: Make MP3 seek fast When AVFMT_FLAG_FAST_SEEK is specified, make MP3 seek operation as fast as possible. When no

[FFmpeg-devel] [PATCH] vp9: fix integer overflow in 10/12bpp DC-only calculation.

2015-09-04 Thread Ronald S. Bultje
--- libavcodec/vp9dsp_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9dsp_template.c b/libavcodec/vp9dsp_template.c index 5a8578a..9395a0c 100644 --- a/libavcodec/vp9dsp_template.c +++ b/libavcodec/vp9dsp_template.c @@ -1131,8 +1131,8 @@ static

[FFmpeg-devel] [PATCH] vp9: fix type of iadst4_1d intermediates.

2015-09-04 Thread Ronald S. Bultje
Fixes integer overflows for extreme coefficient values in 10/12bpp content. --- libavcodec/vp9dsp_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9dsp_template.c b/libavcodec/vp9dsp_template.c index 9395a0c..4d810fe 100644 ---

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > >> Isn't removing these two going to break > >> compatibility with libav? > > > > (ABI or API?) > > I don't think so but I absolutely may miss something. > ABI, you're removing elements from the middle of the > struct. In which situation would that be an

[FFmpeg-devel] [PATCH] vp9: always sync segmentation.feat between threads.

2015-09-04 Thread Ronald S. Bultje
--- libavcodec/vp9.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 238185a..e6c5389 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -4340,10 +4340,8 @@ static int vp9_decode_update_thread_context(AVCodecContext *dst,

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread James Almer
On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: > James Almer gmail.com> writes: Isn't removing these two going to break compatibility with libav? >>> >>> (ABI or API?) >>> I don't think so but I absolutely may miss something. > >> ABI, you're removing elements from the middle of the >>

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread Hendrik Leppkes
On Fri, Sep 4, 2015 at 11:43 PM, James Almer wrote: > On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: >> James Almer gmail.com> writes: > Isn't removing these two going to break > compatibility with libav? (ABI or API?) I don't think so but I absolutely may

Re: [FFmpeg-devel] [PATCH]Support more mxf files with codec_ul

2015-09-04 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Please also look at the patch attached in ticket #4820, > I will add the additional uls if you don't object. I pushed these additional codec_uls since they affect decoding only together with my patch posted here. Hope that's ok, Carl Eugen

[FFmpeg-devel] [PATCH] vp9: check return value of ff_thread_ref_frame().

2015-09-04 Thread Ronald S. Bultje
Fixes CID 1322309. --- libavcodec/vp9.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7624743..e67c761 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -4250,7 +4250,8 @@ static int vp9_decode_frame(AVCodecContext *ctx, void

Re: [FFmpeg-devel] [PATCH] vp9: check return value of ff_thread_ref_frame().

2015-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2015 at 07:33:29PM -0400, Ronald S. Bultje wrote: > Fixes CID 1322309. > --- > libavcodec/vp9.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) this breaks fate --- ./tests/ref/fate/vp9-16-intra-only 2015-09-05 00:47:48.445308437 +0200 +++

[FFmpeg-devel] [PATCH] vp9: check return value of ff_thread_ref_frame().

2015-09-04 Thread Ronald S. Bultje
Fixes CID 1322309. --- libavcodec/vp9.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7624743..25e7419 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -4250,7 +4250,9 @@ static int vp9_decode_frame(AVCodecContext *ctx,

Re: [FFmpeg-devel] [PATCH] libavutil/dict: extend the list of convienience functions for storing different data types

2015-09-04 Thread Nicolas George
L'octidi 18 fructidor, an CCXXIII, Kevin Wheatley a écrit : > as part of adding support for non-string data types to .mov metadata, > I wondered about adding the following helper functions for storing > numeric types into an AVDictionary. > > upfront I'll say I'm not 100% happy with the float32

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Make MP3 seek fast

2015-09-04 Thread wm4
On Fri, 4 Sep 2015 13:55:22 -0700 Tsung-Hung Wu wrote: > From 094c6efab6c5eec1fec274bf1bcace1987ae7d03 Mon Sep 17 00:00:00 2001 > From: Andy Wu > Date: Mon, 31 Aug 2015 17:08:30 -0700 > Subject: [PATCH] avformat/mp3dec: Make MP3 seek fast > >

Re: [FFmpeg-devel] [PATCH]Remove experimental flag from j2k encoder

2015-09-04 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > .init = j2kenc_init, > .encode2= encode_frame, > .close = j2kenc_destroy, > -.capabilities = AV_CODEC_CAP_EXPERIMENTAL, Patch applied. Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread wm4
On Fri, 4 Sep 2015 19:42:18 -0300 James Almer wrote: > On 9/4/2015 7:06 PM, Hendrik Leppkes wrote: > > On Fri, Sep 4, 2015 at 11:43 PM, James Almer wrote: > >> On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: > >>> James Almer gmail.com> writes: > >> Isn't

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread James Almer
On 9/4/2015 7:06 PM, Hendrik Leppkes wrote: > On Fri, Sep 4, 2015 at 11:43 PM, James Almer wrote: >> On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: >>> James Almer gmail.com> writes: >> Isn't removing these two going to break >> compatibility with libav? > > (ABI

Re: [FFmpeg-devel] [PATCH] vp9: check return value of ff_thread_ref_frame().

2015-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2015 at 08:11:05PM -0400, Ronald S. Bultje wrote: > Fixes CID 1322309. > --- > libavcodec/vp9.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > Isn't removing these two going to break > compatibility with libav? (ABI or API?) I don't think so but I absolutely may miss something. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org