Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:44 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Apologies for the copy/pasted patch, but can't send via send-email. > > Maybe you should take some time to tackle your email troubles? > >> ISO C %p format specifier applies to

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Apologies for the copy/pasted patch, but can't send via send-email. Maybe you should take some time to tackle your email troubles? > ISO C %p format specifier applies to void * data pointers. This casts > relevant pointers to void * i

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:33 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> ISO C requires at least one argument in the place of the ellipsis in a >> variadic macro. In particular, under -pedantic, this triggers the >> warning -Wgnu-zero-variadic-macro-

[FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Ganesh Ajjanagadde
Hi all, Apologies for the copy/pasted patch, but can't send via send-email. Copy pasted for review below, attached also for a non-clobbered version. -- >From 99cd052b614553757efa1954bf8bf4dd3caf66d0 Mon Sep 17 00:00:

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > ISO C requires at least one argument in the place of the ellipsis in a > variadic macro. In particular, under -pedantic, this triggers the > warning -Wgnu-zero-variadic-macro-arguments on clang 3.7. > > Signed-off-by: Ganesh Ajjanagadd

[FFmpeg-devel] [PATCH 1/5] all: fix -Wextra-semi reported on clang

2015-10-24 Thread Ganesh Ajjanagadde
Hi all, Apologies for the copy/pasted patch, but can't send via send-email. Copy pasted for review below, attached also for a non-clobbered version. -- >From 82b889a359925d1f9f7496c916cf24146b44e648 Mon Sep 17 00:00:00 2001

[FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Ganesh Ajjanagadde
ISO C restricts enumerator values to the range of int. Thus (for instance) 0x8000 unfortunately does not work, and throws a warning with -Wpedantic on clang 3.7. This fixes such errors by explicitly casting as an int, doing the desired unsigned to signed conversion. This method works on all c

[FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
ISO C requires at least one argument in the place of the ellipsis in a variadic macro. In particular, under -pedantic, this triggers the warning -Wgnu-zero-variadic-macro-arguments on clang 3.7. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_asetrate.c | 4 ++-- libavfilter/asrc_sine.c

[FFmpeg-devel] [PATCH 3/5] all: use function pointer instead of void * data pointer

2015-10-24 Thread Ganesh Ajjanagadde
ISO C does not guarantee that functions and data live in the same address space. It is thus (strictly speaking) illegal to assign to a void * (which is a data pointer) from a function pointer. Found by enabling -Wpedantic on clang 3.7. Signed-off-by: Ganesh Ajjanagadde --- ffmpeg_opt.c

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:15 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Fixes CID 1322329. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavcodec/pthread_frame.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 04:13:18 +0200 Michael Niedermayer wrote: > On Thu, Oct 22, 2015 at 09:48:30PM -0700, Dale Curtis wrote: > > On Wed, Oct 21, 2015 at 6:52 PM, Dale Curtis > > wrote: > > > > > On Tue, Oct 20, 2015 at 11:50 PM, Michael Niedermayer < > > > mich...@niedermayer.cc> wrote: > >

Re: [FFmpeg-devel] Wanted to contribute

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 18:21:45 +0530 rishi shah wrote: > Hi ! > I wanted to contribute in FFMpeg organization. What can be the good > starting point? I have Mac OS. Here's an overview: http://ffmpeg.org/developer.html#Contributing ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-24 Thread Clément Bœsch
On Sat, Oct 24, 2015 at 03:16:15PM +0200, Clément Bœsch wrote: > On Fri, Oct 23, 2015 at 12:41:18PM -0400, Ronald S. Bultje wrote: > [...] > > ffmpeg -h full, searching to -sws_flags, gives this: > > -sws_flags E..V scaler flags (default 4) > > fast_bilinear

Re: [FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-24 Thread Clément Bœsch
On Fri, Oct 23, 2015 at 12:41:18PM -0400, Ronald S. Bultje wrote: [...] > ffmpeg -h full, searching to -sws_flags, gives this: > -sws_flags E..V scaler flags (default 4) > fast_bilinearE..V fast bilinear > bilinear E..V bilin

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Fixes CID 1322329. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/pthread_frame.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > index 765

[FFmpeg-devel] [PATCH] avutil/opt: print more meaningful default flags values

2015-10-24 Thread Clément Bœsch
Example: % ./ffmpeg -h encoder=gif [...] GIF encoder AVOptions: -gifflagsE..V set GIF flags (default offsetting+transdiff) offsetting E..V enable picture offsetting transdiffE..V enable transparency detection between fr

[FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Ganesh Ajjanagadde
Fixes CID 1322329. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/pthread_frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 7651211..ca06e3d 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_

Re: [FFmpeg-devel] [PATCH] version.sh: add note that ffversion.h is auto-generated

2015-10-24 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 7:04 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > version.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/version.sh b/version.sh > index f9754eb..a9d7e39 100755 > --- a/version.sh > +++ b/version.sh > @@ -54,6 +54,7 @@ GUARD=$(ech

Re: [FFmpeg-devel] [PATCH] avcodec/huffman: replace qsort with AV_QSORT

2015-10-24 Thread Ganesh Ajjanagadde
On Thu, Oct 22, 2015 at 10:25 PM, Ganesh Ajjanagadde wrote: > > On Thu, Oct 22, 2015 at 9:28 PM, Timothy Gu wrote: > > On Thu, Oct 22, 2015 at 5:01 PM Ganesh Ajjanagadde > > wrote: > >> > >> Sample benchmark (x86-64, Haswell, GNU/Linux), fraps-v2 from FATE: > >> new: > >> 280110 decicycles in qs

[FFmpeg-devel] Wanted to contribute

2015-10-24 Thread rishi shah
Hi ! I wanted to contribute in FFMpeg organization. What can be the good starting point? I have Mac OS. Thanks, Rishi ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Ronald S. Bultje
--- libavcodec/x86/videodsp.asm | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/videodsp.asm b/libavcodec/x86/videodsp.asm index 25d4364..48f5ac0 100644 --- a/libavcodec/x86/videodsp.asm +++ b/libavcodec/x86/videodsp.asm @@ -194,8 +194,12 @@ hvar

Re: [FFmpeg-devel] [PATCH] vp9: uses ff_set_dimensions (which sets coded_width/height).

2015-10-24 Thread wm4
On Fri, 23 Oct 2015 21:40:14 -0400 "Ronald S. Bultje" wrote: > Fixes ticket 4935. > --- > libavcodec/vp9.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 3753e89..cee17d9 100644 > --- a/libavcodec/vp9.c > +++ b/libavcodec/v

Re: [FFmpeg-devel] [PATCH 01/11] libavformat/mxfdec.c: klv_read_packet: Properly check klv_decode_ber_length return value.

2015-10-24 Thread Tomas Härdin
On Thu, 2015-10-22 at 19:25 +0200, Alexis Ballier wrote: > On Wed, 21 Oct 2015 23:31:29 +0200 > Tomas Härdin wrote: > > > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > > klv_decode_ber_length cannot return -1, but can return > > > AVERROR_INVALIDDATA. Store its return value in a si

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-24 Thread wm4
On Fri, 23 Oct 2015 15:35:15 -0700 Dale Curtis wrote: > Changes from partial initialization which happens for every > initialize call to a full initialization once per process. Changes > as discussed on list by wm4 and rbultje. > > Passes fft-test and fate suite. > > Signed-off-by: Dale Curtis

Re: [FFmpeg-devel] [PATCH]lavf/ingenient: Add a probe function

2015-10-24 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > > ingenientdec.c | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-) > > 4fb270cd44d0ed3ee53dbf1216a5cbb4dba00d8c patchingenient.diff > > i cant test either but if it works it should be ok Patch applied. Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavc/hapdec: Correct colour spaces

2015-10-24 Thread Carl Eugen Hoyos
Tom Butterworth gmail.com> writes: > > Attached patch fixes hap colour spaces as > > reminded by Tom Butterworth. > > LGTM, thanks Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/mxfenc.c: Fix segfault when writing an audio packet when there has not been a video one.

2015-10-24 Thread Alexis Ballier
On Wed, 21 Oct 2015 22:43:04 +0200 Tomas Härdin wrote: > On Tue, 2015-10-20 at 16:43 +0200, Marton Balint wrote: > > On Mon, 19 Oct 2015, Tomas Härdin wrote: > > > > > On Mon, 2015-10-19 at 11:40 +0200, Alexis Ballier wrote: > > >> On Mon, 19 Oct 2015 10:30:00 +0200 > > >> Michael Niedermaye

Re: [FFmpeg-devel] [PATCH] vp9: uses ff_set_dimensions (which sets coded_width/height).

2015-10-24 Thread Hendrik Leppkes
On Sat, Oct 24, 2015 at 3:40 AM, Ronald S. Bultje wrote: > Fixes ticket 4935. > --- > libavcodec/vp9.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 3753e89..cee17d9 100644 > --- a/libavcodec/vp9.c > +++ b/libavcodec/vp9.c >

<    1   2