Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

On 06.11.2015 22:29, wm4 wrote: > On Fri, 6 Nov 2015 22:18:04 +0100 > Andreas Cadhalpun wrote: > >> This fixes a stack buffer overflow. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/pngdec.c | 3 ++- >> 1 file

Re: [FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

On Sun, 2015-10-25 at 21:43 +0100, Tomas Härdin wrote: > On Thu, 2015-10-22 at 19:47 +0200, Alexis Ballier wrote: > > On Wed, 21 Oct 2015 23:45:07 +0200 > > Tomas Härdin wrote: > > > > > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > > > Some files such as

Re: [FFmpeg-devel] [PATCH 1/2] mmaldec: add vc1 decoding support

On 11/6/2015 12:15 PM, wm4 wrote: > --- > configure | 3 +++ > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 ++ > libavcodec/mmaldec.c | 12 > 4 files changed, 18 insertions(+) > > diff --git a/configure b/configure > index f770534..8c940a7 100755 >

Re: [FFmpeg-devel] [PATCH] web/download: point to the official Debian/Ubuntu packages

On Fri, Nov 06, 2015 at 08:18:39PM +0100, Andreas Cadhalpun wrote: [...] > diff --git a/src/download b/src/download > index 5691fbd..6d3517e 100644 > --- a/src/download > +++ b/src/download > @@ -53,13 +53,22 @@ > > Linux Packages > > +

Re: [FFmpeg-devel] [PATCH 1/2] pixblockdsp: x86: Condense diff_pixels_* to a shared macro

On Sun, Nov 1, 2015 at 8:59 AM Timothy Gu wrote: > --- > libavcodec/x86/pixblockdsp.asm | 66 > -- > 1 file changed, 31 insertions(+), 35 deletions(-) > Ping set. Timothy ___

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

On Fri, 6 Nov 2015 23:56:52 +0100 Andreas Cadhalpun wrote: > On 06.11.2015 22:29, wm4 wrote: > > On Fri, 6 Nov 2015 22:18:04 +0100 > > Andreas Cadhalpun wrote: > > > >> This fixes a stack buffer overflow. > >> > >>

Re: [FFmpeg-devel] [PATCH] ffserver: fix incorrect strlcpy usage

On Fri, Nov 6, 2015 at 10:42 PM, Mark Harris wrote: > On Fri, Nov 6, 2015 at 12:49 PM, Ganesh Ajjanagadde > wrote: >> Somewhat ironic that this "safe" interface is actually being used >> unsafely here. This fixes the usage preventing potential null

Re: [FFmpeg-devel] [PATCH 1/2] pixblockdsp: x86: Condense diff_pixels_* to a shared macro

On 11/1/2015 1:59 PM, Timothy Gu wrote: > --- > libavcodec/x86/pixblockdsp.asm | 66 > -- > 1 file changed, 31 insertions(+), 35 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] pixblockdsp: x86: Condense diff_pixels_* to a shared macro

Hi, On Sun, Nov 1, 2015 at 11:59 AM, Timothy Gu wrote: > --- > libavcodec/x86/pixblockdsp.asm | 66 > -- > 1 file changed, 31 insertions(+), 35 deletions(-) > > diff --git a/libavcodec/x86/pixblockdsp.asm >

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

On 11/6/15, Andreas Cadhalpun wrote: > On 06.11.2015 22:29, wm4 wrote: >> On Fri, 6 Nov 2015 22:18:04 +0100 >> Andreas Cadhalpun wrote: >> >>> This fixes a stack buffer overflow. >>> >>> Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] ffserver: fix incorrect strlcpy usage

On Fri, Nov 6, 2015 at 12:49 PM, Ganesh Ajjanagadde wrote: > Somewhat ironic that this "safe" interface is actually being used > unsafely here. This fixes the usage preventing potential null pointer > dereference, where the old code was doubly broken: ctime can return >

Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

On 11/6/15, Andreas Cadhalpun wrote: > The return type of strlen is size_t, i.e. unsigned, so if pd->buf_size > is 3, the right side overflows leading to a wrong result of the > comparison and subsequently a heap buffer overflow. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

On Fri, Nov 06, 2015 at 09:11:40PM +0100, Andreas Cadhalpun wrote: > Subject: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison *unsigned [...] Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > > iam with whatever default people prefer > > IIRC, the current default yields different results when rematrixing from > float to float and then converting from

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

On Fri, 6 Nov 2015 10:54:28 +0100 Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > > > iam with whatever default people prefer > > > > IIRC, the current

[FFmpeg-devel] [PATCH] libavformat/hls.c: if avio_open2 failed, retry it several times.

From 6705d9c9e4ded00075b4d8b23cb05ea2c65146ee Mon Sep 17 00:00:00 2001 From: liuyuxin Date: Fri, 6 Nov 2015 16:17:40 +0800 Subject: [PATCH] Network environment or video websites maybe lead to avio_open2 failed, but if we try avio_open2 several times, it will return success.

[FFmpeg-devel] Return 0 in case of fail...

there's this snippet in ffserver.c : len = c->buffer_end - c->buffer_ptr; if (len < 4) { /* fail safe - should never happen */ fail1: //I am talking about this label fail1

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

On Fri, 6 Nov 2015 12:58:23 +0100 Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > > On Fri, 6 Nov 2015 10:54:28 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > On Fri, 6 Nov 2015 10:54:28 +0100 > Michael Niedermayer wrote: > > > On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote: > > > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : > > > > iam

Re: [FFmpeg-devel] [PATCH] web/download: point to the official Debian/Ubuntu packages

On Fri, Nov 06, 2015 at 05:18:23PM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > > Should we also keep the previous links somewhere? yes, please [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In

Re: [FFmpeg-devel] [PATCH] web/download: point to the official Debian/Ubuntu packages

On 06.11.2015 20:04, Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 05:18:23PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> > >> Should we also keep the previous links somewhere? > > yes, please OK, attached is a variant,

Re: [FFmpeg-devel] Intel QuickSync Video

@Will Kelleher CPU: http://ark.intel.com/products/75122/Intel-Core-i7-4770-Processor-8M-Cache-up-to-3_90-GHz MediaSDK: Intel-linux-media-ocl_generic_16.4.2.1-39163_64bit.tar.gz (inside package of mediaserverstudioessentials2015r6.tar.gz) Ubuntu 14.04.3 LTS, Codename: trusty @Sven Dueking

Re: [FFmpeg-devel] [PATCH] hevc: extract SEI caption data

On Thu, Nov 05, 2015 at 08:15:33AM -0600, Will Kelleher wrote: > Signed-off-by: Will Kelleher > --- > libavcodec/hevc.c | 10 +++ > libavcodec/hevc.h | 4 +++ > libavcodec/hevc_sei.c | 79 > +++ > 3 files

Re: [FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

On Fri, Nov 6, 2015 at 7:25 AM, Michael Niedermayer wrote: > On Sat, Oct 31, 2015 at 10:46:09AM -0400, Ganesh Ajjanagadde wrote: >> On Wed, Oct 28, 2015 at 10:05 PM, Ganesh Ajjanagadde >> wrote: >> > On Wed, Oct 28, 2015 at 10:00 PM, Michael Niedermayer

Re: [FFmpeg-devel] Intel QuickSync Video

> Hello, > > I try to transcode with quick sync, but it doesn't work. > I did follow: https://ffmpeg.org/general.html#Intel-QuickSync-Video > > > I get this error > [h264_qsv @ 0x3017580] Error initializing an internal MFX session > Error while opening encoder for output stream #0:0 - maybe

Re: [FFmpeg-devel] [PATCHv3] avfilter: add anoisesrc

On 11/6/15, Kyle Swanson wrote: > Here's v3. Uses AV_OPT_TYPE_CONST now. Just sent this with the wrong subject > line, here it is again. (sorry!) > > Signed-off-by: Kyle Swanson > --- > Changelog| 1 + > doc/filters.texi | 36

[FFmpeg-devel] [PATCH 1/2] mmaldec: add vc1 decoding support

--- configure | 3 +++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 ++ libavcodec/mmaldec.c | 12 4 files changed, 18 insertions(+) diff --git a/configure b/configure index f770534..8c940a7 100755 --- a/configure +++ b/configure @@ -2516,6 +2516,9 @@

[FFmpeg-devel] [PATCH 2/2] mmaldec: correct package buffering accounting

The assert in ffmmal_stop_decoder() could trigger sometimes. The packets_buffered counter was indeed not correctly maintained, and packets were not subtracted from it if they were still in the waiting queue. --- libavcodec/mmaldec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[FFmpeg-devel] [PATCH] Fix: VP9 superframe parsing when the superframe contains only one frame

Hi, The attached patch fixes an issue with the superframe index parsing. Please find attached a VP9 IVF stream showing the issue (if you try to remux it to webm). The gist of the problem is that the vp9 superframe parser seems to expect at least two frames inside the superframe. Cheers,

[FFmpeg-devel] [PATCHv4] avfilter: add anoisesrc

Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 36 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/asrc_anoisesrc.c | 207 +++

Re: [FFmpeg-devel] [PATCH] Fix: VP9 superframe parsing when the superframe contains only one frame

Hi, On Fri, Nov 6, 2015 at 11:10 AM, Sebastien Alaiwan < sebastien.alai...@allegrodvt.com> wrote: > Hi, > > The attached patch fixes an issue with the superframe index parsing. > Please find attached a VP9 IVF stream showing the issue (if you try to > remux it to webm). > The gist of the problem

Re: [FFmpeg-devel] [PATCH] Fix: VP9 superframe parsing when the superframe contains only one frame

On 11/06/2015 05:37 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 6, 2015 at 11:10 AM, Sebastien Alaiwan < > sebastien.alai...@allegrodvt.com> wrote: > >> Hi, >> >> The attached patch fixes an issue with the superframe index parsing. >> Please find attached a VP9 IVF stream showing the issue

[FFmpeg-devel] [PATCH] vp9_parser: allow superframes with a single frame.

--- libavcodec/vp9_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 6713850..2e9235e 100644 --- a/libavcodec/vp9_parser.c +++ b/libavcodec/vp9_parser.c @@ -132,7 +132,7 @@ static int parse(AVCodecParserContext

Re: [FFmpeg-devel] [PATCH] Fix: VP9 superframe parsing when the superframe contains only one frame

On Fri, 06 Nov 2015 18:00:35 +0100 Sebastien Alaiwan wrote: > On 11/06/2015 05:37 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Nov 6, 2015 at 11:10 AM, Sebastien Alaiwan < > > sebastien.alai...@allegrodvt.com> wrote: > > > >> Hi, > >> > >> The

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 79 +++ 3 files changed, 93 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index

Re: [FFmpeg-devel] [PATCH] vp9_parser: allow superframes with a single frame.

On 11/6/15, Ronald S. Bultje wrote: > --- > libavcodec/vp9_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c > index 6713850..2e9235e 100644 > --- a/libavcodec/vp9_parser.c > +++

[FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

The return type of strlen is size_t, i.e. unsigned, so if pd->buf_size is 3, the right side overflows leading to a wrong result of the comparison and subsequently a heap buffer overflow. Signed-off-by: Andreas Cadhalpun --- libavformat/jvdec.c | 2 +- 1 file

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 80 +++ 3 files changed, 94 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index

[FFmpeg-devel] AMD VCE encoder

Hello, I was looking into AMD VCE encoder and I did realize that there is only a Windows SDK. Should I try to add a Windows only feature? And it won't be able to compile on Linux. What do you guys think about it? ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] AMD VCE encoder

On 11/6/2015 4:43 PM, Lucas Andrade wrote: > Hello, I was looking into AMD VCE encoder and I did realize that there is > only a Windows SDK. Should I try to add a Windows only feature? And it > won't be able to compile on Linux. What do you guys think about it? There are tons of OS exclusive

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add testsrc2 test source.

On 10/25/15, Nicolas George wrote: > Similar to testsrc, but using drawutils and therefore > supporting a lot of pixel formats instead of just rgb24. > This allows using it as input for other tests without > requiring a format conversion. > It is also slightly faster than testsrc

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 80 +++ 3 files changed, 94 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index

Re: [FFmpeg-devel] [PATCH] web/download: point to the official Debian/Ubuntu packages

On Fri, Nov 06, 2015 at 08:18:39PM +0100, Andreas Cadhalpun wrote: > On 06.11.2015 20:04, Michael Niedermayer wrote: > > On Fri, Nov 06, 2015 at 05:18:23PM +0100, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> > > > >> Should we

Re: [FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

On Sat, Oct 31, 2015 at 10:46:09AM -0400, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:05 PM, Ganesh Ajjanagadde wrote: > > On Wed, Oct 28, 2015 at 10:00 PM, Michael Niedermayer > > wrote: > >> On Tue, Oct 27, 2015 at 08:09:03PM -0400, Ganesh

[FFmpeg-devel] [PATCH] avutil/pixdesc: fix incorrect strlen arithmetic

strlen returns a size_t, which is unsigned. If it is less than 2 for some pixel format. wrap-around will happen and a bad pointer dereference will take place. Yes, this is at the moment theoretical, but nonetheless dangerous in my view and the fix is very simple.

Re: [FFmpeg-devel] [PATCH] avutil/pixdesc: fix incorrect strlen arithmetic

On Fri, Nov 6, 2015 at 4:06 PM, Ganesh Ajjanagadde wrote: > strlen returns a size_t, which is unsigned. If it is less than 2 for > some pixel format. wrap-around will happen and a bad pointer dereference > will take place. > > Yes, this is at the moment theoretical, but

[FFmpeg-devel] [PATCH] ffserver: fix incorrect strlcpy usage

Somewhat ironic that this "safe" interface is actually being used unsafely here. This fixes the usage preventing potential null pointer dereference, where the old code was doubly broken: ctime can return NULL, and ctime can return an arbitrarily long buffer. Signed-off-by: Ganesh Ajjanagadde

[FFmpeg-devel] [PATCH] apng: use correct size for output buffer

This fixes a stack buffer overflow. Signed-off-by: Andreas Cadhalpun --- libavcodec/pngdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 689aa2b..c974654 100644 --- a/libavcodec/pngdec.c

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

On Fri, 6 Nov 2015 22:18:04 +0100 Andreas Cadhalpun wrote: > This fixes a stack buffer overflow. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/pngdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[FFmpeg-devel] ffmpeg print_report for rtmp streams

Hello, I have no experience with submitting patches to ffmpeg yet and so I am sorry if I am going about this the wrong way but I wanted to discuss a change that I made to print_report which is related to this bug: https://trac.ffmpeg.org/ticket/1446 We are using stdout from ffmpeg to monitor