[FFmpeg-devel] [PATCH v2] lavf/matroskadec: Set A_QUICKTIME bit depth

2016-01-15 Thread Mats Peterson
Since mkvmerge doesn't set the bit depth for A_QUICKTIME audio (as far as I know), the track->audio.bitdepth variable will be zero, and its value needs to be retrieved from the sound sample description. Also, confine the 0x to 'raw '/'twos' fourcc mapping to old version 0 sound sample

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw QuickTime video

2016-01-15 Thread Mats Peterson
On 01/13/2016 01:42 PM, Mats Peterson wrote: Match the use of AV_PIX_FMT_PAL8 for 1-bit QuickTime Animation in lavc/qtrle. To reiterate, 1-bit video is not necessary black & white in QuickTime, merely bi-level. The two colors can be any color. The palette, either included in the sample

Re: [FFmpeg-devel] [PATCH v2] lavf/matroskadec: Set A_QUICKTIME bit depth

2016-01-15 Thread Mats Peterson
On 01/15/2016 11:12 AM, Mats Peterson wrote: Since mkvmerge doesn't set the bit depth for A_QUICKTIME audio (as far as I know), the track->audio.bitdepth variable will be zero, and its value needs to be retrieved from the sound sample description. Also, confine the 0x to 'raw '/'twos'

[FFmpeg-devel] [PATCH v3] lavf/matroskadec: Set A_QUICKTIME bit depth

2016-01-15 Thread Mats Peterson
FFmpeg curiously uses 'sowt' as the fourcc when writing 8-bit signed QuickTime data, so cater for this as well. Description follows: Since mkvmerge doesn't set the bit depth for A_QUICKTIME audio (as far as I know), the track->audio.bitdepth variable will be zero, and its value needs to be

[FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-15 Thread Arttu Ylä-Outinen
Updates libkvazaar to pass the exact frame rate to Kvazaar by setting the numerator and denominator separately instead of a single floating point number. The exact frame rate is needed for writing timing info to the bitstream. Requires Kvazaar version 0.8.1. Signed-off-by: Arttu Ylä-Outinen

[FFmpeg-devel] [PATCH 1/2] ffplay: Seek only when pressing the right mouse button on the video window.

2016-01-15 Thread Vittorio Gambaletta (VittGam)
Seeking by clicking on the video window can be annoying, because the user might click on it accidentally while eg. trying to get focus on it, and ffplay seeks instead. This commit changes that behaviour to seek only when the right mouse button is used to click and drag on the window.

[FFmpeg-devel] [PATCH 2/2] ffplay: Toggle full screen when double-clicking the video window with the left mouse button.

2016-01-15 Thread Vittorio Gambaletta (VittGam)
Now that the seek only happens with the right mouse button, it makes sense to toggle full screen when double-clicking with the left mouse button, like other video players do. Signed-off-by: Vittorio Gambaletta --- ffplay.c | 18 ++ 1 file changed, 18

[FFmpeg-devel] [PATCH] mov: Add an option to toggle dref opening

2016-01-15 Thread Derek Buitenhuis
This feature is mostly only used by NLE software, and is both of dubious value being enabled by default, and a possible security risk. Signed-off-by: Derek Buitenhuis --- libavformat/isom.h| 1 + libavformat/mov.c | 22 +-

Re: [FFmpeg-devel] [PATCH] x86/intmath: add sse optimized av_clipf and av_clipd

2016-01-15 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 02:26:26PM -0300, James Almer wrote: > On 1/7/2016 10:32 AM, Michael Niedermayer wrote: > > On Thu, Jan 07, 2016 at 12:36:02AM -0300, James Almer wrote: > >> Signed-off-by: James Almer > >> --- > >> I could also include stdlib.h inside the __GNU__

[FFmpeg-devel] [PATCH 3/3] lavc/wmadec: replace pow by faster functions

2016-01-15 Thread Ganesh Ajjanagadde
Further speedups possible by getting rid of exp2f... Signed-off-by: Ganesh Ajjanagadde --- libavcodec/wmadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index da54182..1a84323 100644 ---

[FFmpeg-devel] [PATCH 1/3] lavc/atrac3plusdsp: change pow(2, x) to exp2f(x)

2016-01-15 Thread Ganesh Ajjanagadde
Much faster generation possible; but array is small so don't want to bloat the binary. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/atrac3plusdsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/atrac3plusdsp.c

[FFmpeg-devel] [PATCH 2/3] lavc/opus_celt: replace pow(2, x) by exp2f(x)

2016-01-15 Thread Ganesh Ajjanagadde
Faster methods possible; since exponent is always a multiple of 1/8. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/opus_celt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/opus_celt.c b/libavcodec/opus_celt.c index 474452f..61a9dc6

[FFmpeg-devel] [PATCH 2/4] avcodec/v210: add avx2 version of the 8-bit line encoder

2016-01-15 Thread James Darnley
Around 35% faster than the avx version. Signed-off-by: Henrik Gramner --- The only changes here are the ones suggested by Henrik and a whitespace change for alignment at the function definition in v210enc_init.c --- libavcodec/v210enc.c | 5 +++--

[FFmpeg-devel] [PATCH 4/4] avcodec/v210: document the requirement for sample_factor

2016-01-15 Thread James Darnley
The sample factor must be the same for both 8- and 10-bit functions chosen otherwise the output will be incorrect. --- Should I squash this one too? --- libavcodec/v210enc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/v210enc.h b/libavcodec/v210enc.h index

[FFmpeg-devel] [PATCH 3/4] avcodec/v210: add avx2 version of the 10-bit line encoder

2016-01-15 Thread James Darnley
Around 25% faster than the ssse3 version. --- New patch. Should I squash this into the previous patch before committing? --- libavcodec/v210enc.c | 11 +-- libavcodec/x86/constants.c| 3 ++- libavcodec/x86/constants.h| 2 +- libavcodec/x86/v210enc.asm| 20

[FFmpeg-devel] [PATCH 1/4] fate: add 10-bit v210 encoder tests

2016-01-15 Thread James Darnley
--- Is the name I chose for the 10-bit tests (v210-10) okay? --- tests/fate/vcodec.mak| 3 ++- tests/ref/vsynth/vsynth1-v210-10 | 4 tests/ref/vsynth/vsynth2-v210-10 | 4 tests/ref/vsynth/vsynth3-v210-10 | 4 tests/ref/vsynth/vsynth_lena-v210-10 | 4

Re: [FFmpeg-devel] [PATCH] avcodec/h264: mmxext 4:2:2 chroma deblock/loop filter

2016-01-15 Thread James Darnley
On 2016-01-15 04:21, Ronald S. Bultje wrote: > If you don't need r%dm (looks like you don't, but didn't check > exhaustively), you can also use a negative stack size (0 - mmsize - > ARCH_X86_64 * 2 * mmsize), then it will not create a stack pointer. I am already using r[0-3]m for storage. (A

Re: [FFmpeg-devel] [PATCH] avcodec/h264: mmxext 4:2:2 chroma deblock/loop filter

2016-01-15 Thread James Darnley
On 2016-01-15 03:55, James Almer wrote: > On 1/14/2016 11:05 PM, James Darnley wrote: >> diff --git a/libavcodec/x86/h264_deblock.asm >> b/libavcodec/x86/h264_deblock.asm >> index 5151f3c..20f0814 100644 >> --- a/libavcodec/x86/h264_deblock.asm >> +++ b/libavcodec/x86/h264_deblock.asm >> @@

[FFmpeg-devel] feature request: add instructions on the trac upload page for how to upload larger files

2016-01-15 Thread Roger Pack
I know ways exist to "upload" a file larger than 2.5MB. However many people "at trac upload time" may be unfamiliar with those. Might be nice to add a link on the trac "upload" page to the instructions for larger files. Example page:

[FFmpeg-devel] [PATCH v2 3/3] configure: remove libzvbi GPL dependency

2016-01-15 Thread Marton Balint
The COPYING.LIB file in the zvbi source tree as well as libzvbi.h references the GNU Library General Public License version 2 since version 0.2.28. Signed-off-by: Marton Balint --- configure| 5 +++-- doc/general.texi | 6 -- 2 files changed, 3 insertions(+), 8

[FFmpeg-devel] libavformat/tcp.c : add send_buffer_size and recv_buffer_size options

2016-01-15 Thread Perette Barella
Attached is a patch to libavformat/tcp.c for your consideration. It adds two new options that may be set via the dictionary: - send_buffer_size - recv_buffer_size When present, setsockopt() is used with SO_SNDBUF and SO_RCVBUF to set socket buffer sizes. I chose to make send and receive

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/dca: add native DCA decoder based on libdcadec

2016-01-15 Thread James Almer
On 1/14/2016 1:28 PM, foo86 wrote: > +static void sumdiff_c(int32_t *v1, int32_t *v2, intptr_t len) > +{ > +int i; > + > +for (i = 0; i < len; i++) { > +int32_t t = v1[i] - v2[i]; > +v1[i] += v2[i]; > +v2[i] = t; > +} > +} You have AVFixedDSPContext's

Re: [FFmpeg-devel] [PATCHv3] lavu/x86/lls: add fma3 optimizations for update_lls

2016-01-15 Thread Ganesh Ajjanagadde
On Thu, Jan 14, 2016 at 7:39 PM, Ganesh Ajjanagadde wrote: > This improves accuracy (very slightly) and speed for processors having > fma3. > > Sample benchmark (fate flac-16-lpc-cholesky, Haswell): > old: > 5993610 decicycles in ff_lpc_calc_coefs, 64 runs, 0

Re: [FFmpeg-devel] [PATCH] avcodec/h264: mmxext 4:2:2 chroma deblock/loop filter

2016-01-15 Thread James Darnley
On 2016-01-15 21:55, James Almer wrote: > On 1/15/2016 5:00 PM, James Darnley wrote: >> On 2016-01-15 03:55, James Almer wrote: >>> On 1/14/2016 11:05 PM, James Darnley wrote: diff --git a/libavcodec/x86/h264_deblock.asm b/libavcodec/x86/h264_deblock.asm index 5151f3c..20f0814

Re: [FFmpeg-devel] feature request: add instructions on the trac upload page for how to upload larger files

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 02:00:19PM -0700, Roger Pack wrote: > I know ways exist to "upload" a file larger than 2.5MB. > However many people "at trac upload time" may be unfamiliar with those. > Might be nice to add a link on the trac "upload" page to the > instructions for larger files. Example

Re: [FFmpeg-devel] [PATCH v3] lavf/matroskadec: Set A_QUICKTIME bit depth

2016-01-15 Thread Mats Peterson
On 01/15/2016 01:06 PM, Mats Peterson wrote: FFmpeg curiously uses 'sowt' as the fourcc when writing 8-bit signed QuickTime data, so cater for this as well. Description follows: Since mkvmerge doesn't set the bit depth for A_QUICKTIME audio (as far as I know), the track->audio.bitdepth variable

[FFmpeg-devel] [PATCH] lavf/matroskadec: Get sample size from private data

2016-01-15 Thread Mats Peterson
Since track->audio.bitdepth is zero for A_QUICKTIME, the sample size has to be retrieved from the private data. Also, 'twos' and 'sowt' audio can be signed 8-bit. Mats >From dbddf5d5fba7992e52bb25db214e7b4debfb8023 Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Fri, 15

[FFmpeg-devel] [PATCH] lavf/mov: Don't limit fourcc 0 -> raw/twos to version 0 sample descriptions

2016-01-15 Thread Mats Peterson
I had the notion that the fourcc 0x to raw/twos mapping was only valid for version 0 sound sample descriptions. However, the documentation is quite foggy regarding this subject, so it's better to do this mapping regardless of sample description version. Mats -- Mats Peterson

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 10:24:43PM +, Dan Sanders wrote: > Michael, I wanted to check if you have you looked into this playback issue, > or were planning to? i didnt look into it, i had thought rodger would look into it as it was his patch ... rodger, did you look into this ? [...] --

Re: [FFmpeg-devel] libavformat/tcp.c : add send_buffer_size and recv_buffer_size options

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 04:40:38PM -0500, Perette Barella wrote: > Attached is a patch no, theres no patch [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator signature.asc Description:

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-15 Thread Jean-Yves Avenard
On 15 January 2016 at 18:51, wm4 wrote: > API users might check for the existence of such pixfmts with #ifdef, > and I don't understand the reasoning behind your patch. Why would > external projects redefine these macros? All other pixfmts are already enums, why the

Re: [FFmpeg-devel] [PATCH] News entry for FFmpeg 2.8.5, 2.7.5, 2.6.7, 2.5.10

2016-01-15 Thread Michael Niedermayer
On Sat, Jan 16, 2016 at 03:15:44AM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > --- > src/index | 14 ++ > 1 file changed, 14 insertions(+) btw, i soon go to bed, so dont hesitate to push while iam sleeping if it LGTY [...] --

Re: [FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 03:42:29PM +0200, Arttu Ylä-Outinen wrote: > Updates libkvazaar to pass the exact frame rate to Kvazaar by setting > the numerator and denominator separately instead of a single floating > point number. The exact frame rate is needed for writing timing info to > the

Re: [FFmpeg-devel] [PATCH 1/4] fate: add 10-bit v210 encoder tests

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 08:07:13PM +0100, James Darnley wrote: > --- > Is the name I chose for the 10-bit tests (v210-10) okay? sure and patch seems working here so should be ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is

Re: [FFmpeg-devel] [PATCH] build: make out-of-tree builds bit-identical to in-tree builds

2016-01-15 Thread Michael Niedermayer
On Mon, Dec 28, 2015 at 10:12:56PM +0100, Andreas Cadhalpun wrote: > Previously the full source path was embedded inconsistently in the debug > information between in-tree/out-of-tree builds. > > The 'vpath %.inc' becomes necessary for finding > libavfilter/all_channel_layouts.inc in out-of-tree

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Get sample size from private data

2016-01-15 Thread Mats Peterson
On 01/15/2016 11:31 PM, Mats Peterson wrote: Since track->audio.bitdepth is zero for A_QUICKTIME When parsing files created with mkvmerge, that is. Mats ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] News entry for FFmpeg 2.8.5, 2.7.5, 2.6.7, 2.5.10

2016-01-15 Thread Michael Niedermayer
From: Michael Niedermayer --- src/index | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/index b/src/index index 554ad0e..56a7956 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,20 @@ News + January 16, 2015, FFmpeg 2.8.5, 2.7.5,

Re: [FFmpeg-devel] [PATCH] avcodec/h264: mmxext 4:2:2 chroma deblock/loop filter

2016-01-15 Thread Ronald S. Bultje
Hi, On Fri, Jan 15, 2016 at 4:47 PM, James Darnley wrote: > On 2016-01-15 21:55, James Almer wrote: > > On 1/15/2016 5:00 PM, James Darnley wrote: > >> On 2016-01-15 03:55, James Almer wrote: > >>> On 1/14/2016 11:05 PM, James Darnley wrote: > diff --git

Re: [FFmpeg-devel] [PATCH 2/3] lavc/opus_celt: replace pow(2, x) by exp2f(x)

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 02:01:11PM -0500, Ganesh Ajjanagadde wrote: > Faster methods possible; since exponent is always a multiple of 1/8. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/opus_celt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 1/3] lavc/atrac3plusdsp: change pow(2, x) to exp2f(x)

2016-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 02:01:10PM -0500, Ganesh Ajjanagadde wrote: > Much faster generation possible; but array is small so don't want to bloat > the binary. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/atrac3plusdsp.c | 3 ++- > 1 file changed, 2

[FFmpeg-devel] [PATCH 2/2] fate: add fixed-dsp test

2016-01-15 Thread James Almer
Adapted from float-dsp Signed-off-by: James Almer --- libavutil/Makefile | 1 + libavutil/fixed_dsp.c| 249 +++ tests/fate/libavutil.mak | 6 ++ 3 files changed, 256 insertions(+) diff --git a/libavutil/Makefile

[FFmpeg-devel] [PATCH 1/2] x86/fixed_dsp: add ff_butterflies_fixed_sse2

2016-01-15 Thread James Almer
Signed-off-by: James Almer --- libavutil/fixed_dsp.c | 3 +++ libavutil/fixed_dsp.h | 2 ++ libavutil/x86/Makefile | 2 ++ libavutil/x86/fixed_dsp.asm| 48 ++ libavutil/x86/fixed_dsp_init.c | 35

Re: [FFmpeg-devel] [PATCH] News entry for FFmpeg 2.8.5, 2.7.5, 2.6.7, 2.5.10

2016-01-15 Thread Ganesh Ajjanagadde
On Fri, Jan 15, 2016 at 9:15 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > --- > src/index | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/index b/src/index > index 554ad0e..56a7956 100644 > ---

Re: [FFmpeg-devel] [PATCH] mpeg4videodec: silence ubsan warning

2016-01-15 Thread Andreas Cadhalpun
On 15.01.2016 03:17, Michael Niedermayer wrote: > On Fri, Jan 15, 2016 at 12:30:28AM +0100, Andreas Cadhalpun wrote: >> s->ac_val[0][0] is of type 'int16_t [16]', but points into a larger buffer. >> Here it is used as base pointer to find the correct position in the >> larger buffer by adding

Re: [FFmpeg-devel] libavformat/tcp.c : add send_buffer_size and recv_buffer_size options

2016-01-15 Thread Perette Barella
On 2016年01月15日, at 18:42, Michael Niedermayer wrote: > no, theres no patch Trying again, including it inline below: --- tcp.c 2015-12-19 21:07:51.0 -0500 +++ /Users/perette/Desktop/tcp.c2016-01-15 16:09:03.0 -0500 @@ -37,19 +37,23 @@

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2016-01-15 Thread Dan Sanders
Michael, I wanted to check if you have you looked into this playback issue, or were planning to? - Dan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-15 Thread Richard Smith
On Fri Jan 15 08:51:07 CET 2016 wm4 wrote; > On Thu, 14 Jan 2016 13:58:14 -0800 Richard Smith > wrote: > > libavutil/pixfmt.h defines a collection of endian-specific pixel formats as > > macros. These macro names can cause conflicts with external projects that > > use those identifiers for

[FFmpeg-devel] [PATCH] remove the deprecated avpicture_get_size() function

2016-01-15 Thread Eddie Hao
--- libavcodec/avcodec.h | 6 -- libavcodec/avpicture.c | 5 - libavcodec/libutvideodec.cpp | 3 ++- libavcodec/libutvideoenc.cpp | 3 ++- libavdevice/decklink_dec.cpp | 2 +- libavdevice/lavfi.c | 3 ++- libavformat/frmdec.c | 3 ++- 7 files changed, 9

Re: [FFmpeg-devel] [PATCH 3/3] configure: remove libzvbi GPL dependency

2016-01-15 Thread Carl Eugen Hoyos
Marton Balint passwd.hu> writes: > The COPYING.LIB file in the zvbi source tree as > well as libzvbi.h references the GNU Library > General Public License version 2. This may need a version check for "0.2.28" or later. Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-15 Thread Hendrik Leppkes
On Thu, Jan 14, 2016 at 10:58 PM, Richard Smith wrote: > libavutil/pixfmt.h defines a collection of endian-specific pixel formats as > macros. These macro names can cause conflicts with external projects that > use those identifiers for their own purposes. Here's a patch to