Re: [FFmpeg-devel] [PATCH] ffmpeg: don't overwrite av_bsf_receive_packet return value before checking it

2016-11-04 Thread James Almer
On 11/4/2016 8:13 AM, Michael Niedermayer wrote: > On Fri, Nov 04, 2016 at 12:21:16AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> ffmpeg.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > LGTM > > thx > > PS: not sure ret ==

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Steven Liu
2016-11-04 23:04 GMT+08:00 Michael Niedermayer : > On Fri, Nov 04, 2016 at 10:47:35PM +0800, Steven Liu wrote: > > 2016-11-04 22:38 GMT+08:00 Michael Niedermayer : > > > > > On Fri, Nov 04, 2016 at 08:58:56PM +0800, Steven Liu wrote: > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/rawdec: check for side data before checking its size

2016-11-04 Thread James Almer
On 11/4/2016 8:31 AM, Michael Niedermayer wrote: > On Thu, Nov 03, 2016 at 10:34:58PM -0300, James Almer wrote: >> Fixes valgrind warnings about usage of uninitialized values. >> >> Signed-off-by: James Almer >> --- >> libavcodec/rawdec.c | 2 +- >> 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] fate: add bsf tests for ticket 5927

2016-11-04 Thread James Almer
On 11/4/2016 8:46 PM, Michael Niedermayer wrote: > On Fri, Nov 04, 2016 at 05:42:49PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Sample is in https://0x0.st/2NK.mp4 >> >> Should be renamed to thezerotheorem-cut.mp4 and placed in the h264 folder. > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread James Almer
On 11/4/2016 9:54 PM, Michael Niedermayer wrote: > On Fri, Nov 04, 2016 at 07:59:48PM -0300, James Almer wrote: >> On 11/4/2016 3:12 PM, Michael Niedermayer wrote: >>> On Fri, Nov 04, 2016 at 12:57:39PM -0300, James Almer wrote: On 11/4/2016 9:43 AM, Michael Niedermayer wrote: > The

Re: [FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference

2016-11-04 Thread Michael Niedermayer
On Sat, Nov 05, 2016 at 12:20:21AM +0100, Andreas Cadhalpun wrote: > Metadata streams have priv_data set to NULL. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) probably ok, iam not a

Re: [FFmpeg-devel] IMF support?

2016-11-04 Thread Carl Eugen Hoyos
2016-11-04 18:57 GMT+01:00 Derek Prestegard : > mxf @ 00d369a0] OPAtom misinterpreted as OP1a? KLV for edit unit 0 > extending into next edit unit is not implemented. Update your FFmpeg > version to the newest one from Git. If the problem still occurs, it means > that

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 07:59:48PM -0300, James Almer wrote: > On 11/4/2016 3:12 PM, Michael Niedermayer wrote: > > On Fri, Nov 04, 2016 at 12:57:39PM -0300, James Almer wrote: > >> On 11/4/2016 9:43 AM, Michael Niedermayer wrote: > >>> The bitstream filters do not work with merged in side data >

[FFmpeg-devel] [PATCH}lavf/mxfdec: Search all components of material track for source package

2016-11-04 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #5925 here. Please review, Carl Eugen From c928270086e6021fba7d6d3201be7ea569e37253 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 5 Nov 2016 01:48:10 +0100 Subject: [PATCH] lavf/mxfdec: Search all components of material track for

Re: [FFmpeg-devel] [PATCH] fate: add bsf tests for ticket 5927

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 05:42:49PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Sample is in https://0x0.st/2NK.mp4 > > Should be renamed to thezerotheorem-cut.mp4 and placed in the h264 folder. uploaded Tested-by: michael on x86-32/64 linux mingw32/64 arm

[FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference

2016-11-04 Thread Andreas Cadhalpun
Metadata streams have priv_data set to NULL. Signed-off-by: Andreas Cadhalpun --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index d2166ee..a1a79ce 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread James Almer
On 11/4/2016 3:12 PM, Michael Niedermayer wrote: > On Fri, Nov 04, 2016 at 12:57:39PM -0300, James Almer wrote: >> On 11/4/2016 9:43 AM, Michael Niedermayer wrote: >>> The bitstream filters do not work with merged in side data >>> >>> This leaves the input packet split if it is being split. >>> It

[FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

2016-11-04 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 87de15f..d6dca18 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2391,7 +2391,7 @@ int

[FFmpeg-devel] [PATCH] lzf: update pointer p after realloc

2016-11-04 Thread Andreas Cadhalpun
This fixes heap-use-after-free detected by AddressSanitizer. Signed-off-by: Andreas Cadhalpun --- libavcodec/lzf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/lzf.c b/libavcodec/lzf.c index 409a7ff..5b7526e 100644 --- a/libavcodec/lzf.c +++

Re: [FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

2016-11-04 Thread Sasi Inguva
yeah. that is better. On Thu, Nov 3, 2016 at 3:41 PM, Hendrik Leppkes wrote: > On Thu, Nov 3, 2016 at 11:31 PM, Sasi Inguva > wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavcodec/utils.c | 4 +++- > > 1 file

[FFmpeg-devel] Add support for 24 bit RTSP audio playback

2016-11-04 Thread Timur Aydin
Hello guys, When ffplay is used to play from the RTSP URL that serves 24 bit audio content, ffplay fails to recognize the audio codec format. The attached patch adds support for playing 24 bit audio content over RTSP by defining a dynamic payload handler for "L24". -- Timur Aydin diff

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-04 Thread Sasi Inguva
So, if I am not wrong, the only case when that would happen is, if edit list media time was < 0 . And that would be a corrupt MOV file, unless edit list media time = -1. I tried to create such a file with AtomInspector but it doesn't let me. On Fri, Nov 4, 2016 at 10:05 AM, Derek Buitenhuis <

Re: [FFmpeg-devel] [PATCH] doc/examples: add fuzz target for individual ffmpeg APIs for in-process fuzzing with libFuzzer, AFL, and similar fuzzing engines.

2016-11-04 Thread Michael Niedermayer
On Fri, Oct 28, 2016 at 11:02:21PM +0200, Michael Niedermayer wrote: > From: Thomas Garnier > > Signed-off-by: Michael Niedermayer > --- > doc/examples/decoder_targeted.c | 183 > > 1 file changed, 183

[FFmpeg-devel] [PATCH] flvdec: set need_context_update when changing codec id

2016-11-04 Thread Andreas Cadhalpun
Otherwise the codec context and codecpar might disagree on the codec id, triggering asserts in av_parser_parse2. Signed-off-by: Andreas Cadhalpun --- libavformat/flvdec.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH] oggparsetheora: set need_context_update when changing codec id

2016-11-04 Thread Andreas Cadhalpun
Otherwise the codec context and codecpar might disagree on the codec id, triggering asserts in av_parser_parse2. Signed-off-by: Andreas Cadhalpun --- libavformat/oggparsetheora.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/oggparsetheora.c

Re: [FFmpeg-devel] [PATCH 0/2] Move show_*() code from cmdutils to libs

2016-11-04 Thread Reynaldo H. Verdejo Pinochet
On 11/04/2016 01:16 PM, Michael Niedermayer wrote: Printing the available codecs, decoders, encoders, bitstream filters and their options and capabilities is usefull for Apps in general and not just ffmpeg. [..] We had a chat about this with Michael and I think it indeed makes sense so +1

[FFmpeg-devel] [PATCH] fate: add bsf tests for ticket 5927

2016-11-04 Thread James Almer
Signed-off-by: James Almer --- Sample is in https://0x0.st/2NK.mp4 Should be renamed to thezerotheorem-cut.mp4 and placed in the h264 folder. tests/fate/ffmpeg.mak| 6 ++ tests/ref/fate/h264_mp4toannexb_ticket5927 | 21 +

[FFmpeg-devel] IMF support?

2016-11-04 Thread Derek Prestegard
Hey folks! Netflix has published a sample IMF package with lots of neat gee-whiz features like lossless 10 bit 4kp60 J2K video graded for HDR! The video actually seems to pass through ffmpeg just fine - I was able to step it down into 1080p ProRes no problem. However, the audio files don't seem

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread James Almer
On 11/4/2016 3:12 PM, Michael Niedermayer wrote: > On Fri, Nov 04, 2016 at 12:57:39PM -0300, James Almer wrote: >> On 11/4/2016 9:43 AM, Michael Niedermayer wrote: >>> The bitstream filters do not work with merged in side data >>> >>> This leaves the input packet split if it is being split. >>> It

[FFmpeg-devel] [PATCH 2/2] move cmdutils show_* related to avcodec into libavcodec

2016-11-04 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- cmdutils.c | 287 +--- cmdutils.h | 26 cmdutils_common_opts.h | 8 +- libavcodec/Makefile| 1 + libavcodec/avcodec.h | 28 libavcodec/cmdutils.c | 383

[FFmpeg-devel] [PATCH 1/2] Move av_show_help_children() to avutil/opt

2016-11-04 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- cmdutils.c | 20 cmdutils.h | 5 - ffmpeg_opt.c| 10 +- ffplay.c| 8 ffprobe.c | 2 +- libavutil/opt.c | 12 libavutil/opt.h | 7 +++ 7 files

[FFmpeg-devel] [PATCH 0/2] Move show_*() code from cmdutils to libs

2016-11-04 Thread Michael Niedermayer
Printing the available codecs, decoders, encoders, bitstream filters and their options and capabilities is usefull for Apps in general and not just ffmpeg. This patch-set is also required for moving ffserver into a separate repository as it too uses these functions and they otherwise would need

Re: [FFmpeg-devel] [PATCH 1/2] hevc: Move hevc_decode_extradata before frame decoding

2016-11-04 Thread Vittorio Giovara
On Thu, Nov 3, 2016 at 2:06 PM, Michael Niedermayer wrote: > On Wed, Nov 02, 2016 at 11:48:57AM -0400, Vittorio Giovara wrote: >> Avoids a forward-declaration in the following commit. >> >> Signed-off-by: Vittorio Giovara >> --- >> Please CC.

Re: [FFmpeg-devel] [PATCH 1/3] diracdec: use correct buffer for slice_params_buf realloc

2016-11-04 Thread Andreas Cadhalpun
On 04.11.2016 20:07, Rostislav Pehlivanov wrote: > On 4 November 2016 at 18:10, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> This fixes a double-free detected by AddressSanitizer. >> >> The problem was introduced in commit >> dcad4677d637cd2f701917e38361fa96b8c9a418. >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/hap: consistent name for codec

2016-11-04 Thread Lou Logan
On Fri, 4 Nov 2016 16:55:27 +0100, Paul B Mahol wrote: > ok Fixed typo in commit message and pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] diracdec: use correct buffer for slice_params_buf realloc

2016-11-04 Thread Rostislav Pehlivanov
On 4 November 2016 at 18:10, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > This fixes a double-free detected by AddressSanitizer. > > The problem was introduced in commit > dcad4677d637cd2f701917e38361fa96b8c9a418. > > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH 2/3] diracdec: clear slice_params_num_buf on allocation failure

2016-11-04 Thread Rostislav Pehlivanov
On 4 November 2016 at 18:11, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Otherwise it can be non-zero next time decode_lowdelay is called, causing > slice_params_buf not to be allocated, leading to a NULL pointer > dereference. > > The problem was introduced in commit >

Re: [FFmpeg-devel] [PATCH 3/3] diracdec: check return code of get_buffer_with_edge

2016-11-04 Thread Rostislav Pehlivanov
On 4 November 2016 at 18:11, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > If it fails, buffers aren't allocated, causing NULL pointer dereferencing. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/diracdec.c | 4 +++- > 1 file changed,

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Lou Logan
On Fri, 4 Nov 2016 11:24:06 +0800, Steven Liu wrote: > Add keyframe index metadata > Used to facilitate seeking; particularly for HTTP pseudo streaming. > > Reviewed-by: Lou Logan > Signed-off-by: Steven Liu > --- > doc/muxers.texi |3 + >

Re: [FFmpeg-devel] [PATCH] qsvenc: do not re-execute encoding on all positive status codes

2016-11-04 Thread Mark Thompson
On 04/11/16 16:39, Ivan Uskov wrote: > Hello Mark, > > Thursday, November 3, 2016, 10:55:05 PM, you wrote: > >> From: Anton Khirnov > >> It should only be done for DEVICE_BUSY/IN_EXECUTION > >> (cherry picked from commit 0956fd460681e8ccbdae19f135f0d3970bf95c2f) >> Fixes

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 12:57:39PM -0300, James Almer wrote: > On 11/4/2016 9:43 AM, Michael Niedermayer wrote: > > The bitstream filters do not work with merged in side data > > > > This leaves the input packet split if it is being split. > > It could be merged again, if thats preferred ? That

[FFmpeg-devel] [PATCH 3/3] diracdec: check return code of get_buffer_with_edge

2016-11-04 Thread Andreas Cadhalpun
If it fails, buffers aren't allocated, causing NULL pointer dereferencing. Signed-off-by: Andreas Cadhalpun --- libavcodec/diracdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index

[FFmpeg-devel] [PATCH 2/3] diracdec: clear slice_params_num_buf on allocation failure

2016-11-04 Thread Andreas Cadhalpun
Otherwise it can be non-zero next time decode_lowdelay is called, causing slice_params_buf not to be allocated, leading to a NULL pointer dereference. The problem was introduced in commit dcad4677d637cd2f701917e38361fa96b8c9a418. Signed-off-by: Andreas Cadhalpun

[FFmpeg-devel] [PATCH 1/3] diracdec: use correct buffer for slice_params_buf realloc

2016-11-04 Thread Andreas Cadhalpun
This fixes a double-free detected by AddressSanitizer. The problem was introduced in commit dcad4677d637cd2f701917e38361fa96b8c9a418. Signed-off-by: Andreas Cadhalpun --- libavcodec/diracdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-11-04 Thread Pallavi Kumari
>> ok, do you know how to compute that or should i explain it ? Explanation will help. Is there any function in FFmpeg to get absolute value of FFT? and how to get frequency data? On Fri, Nov 4, 2016 at 11:04 PM, Michael Niedermayer wrote: > On Fri, Nov 04, 2016 at

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 09:01:22PM +0530, Pallavi Kumari wrote: > >> The frequency components after a R->C FFT are complex numbers > >> the peak values of complex numbers are not the same as the maxima of > >> their real components > >> did the paper this is based on say anything about what is

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-04 Thread Derek Buitenhuis
On 11/3/2016 10:36 PM, Sasi Inguva wrote: > +if (index == -1) { > +av_log(mov->fc, AV_LOG_ERROR, > + "st: %d edit list %"PRId64" Cannot find an index > entry before timestamp: %"PRId64"\n", > + st->index, edit_list_index,

Re: [FFmpeg-devel] [PATCH] qsvenc: do not re-execute encoding on all positive status codes

2016-11-04 Thread Ivan Uskov
Hello Mark, Thursday, November 3, 2016, 10:55:05 PM, you wrote: > From: Anton Khirnov > It should only be done for DEVICE_BUSY/IN_EXECUTION > (cherry picked from commit 0956fd460681e8ccbdae19f135f0d3970bf95c2f) > Fixes ticket #5924. > --- > libavcodec/qsvenc.c | 2 +- > 1

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread James Almer
On 11/4/2016 9:43 AM, Michael Niedermayer wrote: > The bitstream filters do not work with merged in side data > > This leaves the input packet split if it is being split. > It could be merged again, if thats preferred ? That would involve > an extra malloc and memcpy though Since side data is

Re: [FFmpeg-devel] [PATCH] avcodec/hap: consistent name for codec

2016-11-04 Thread Paul B Mahol
On 11/4/16, Tom Butterworth wrote: > "Vidvox Hap", not "Vidvox Hap encoder" or "Vidvox Hap decoder". Fixes bad > name in fmmpeg -codecs, matches other codec naming. > --- > libavcodec/codec_desc.c | 2 +- > libavcodec/hapdec.c | 2 +- > libavcodec/hapenc.c | 2 +- >

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Steven Liu
2016年11月4日星期五,Michael Niedermayer 写道: > On Fri, Nov 04, 2016 at 10:47:35PM +0800, Steven Liu wrote: > > 2016-11-04 22:38 GMT+08:00 Michael Niedermayer : > > > > > On Fri, Nov 04, 2016 at 08:58:56PM +0800, Steven Liu wrote: > > > > 2016-11-04 20:44

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-11-04 Thread Pallavi Kumari
>> The frequency components after a R->C FFT are complex numbers >> the peak values of complex numbers are not the same as the maxima of >> their real components >> did the paper this is based on say anything about what is recommanded >> to take here for the maxima? >> It would seem logic to me

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 10:47:35PM +0800, Steven Liu wrote: > 2016-11-04 22:38 GMT+08:00 Michael Niedermayer : > > > On Fri, Nov 04, 2016 at 08:58:56PM +0800, Steven Liu wrote: > > > 2016-11-04 20:44 GMT+08:00 Michael Niedermayer : > > > > > > > On

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use metadata key/value to set mastering metadata

2016-11-04 Thread Neil Birkbeck
On Wed, Jun 8, 2016 at 11:27 PM, Dave Rice wrote: > > > On Jun 8, 2016, at 11:03 PM, Neil Birkbeck > wrote: > > > > The most recent patch should still apply cleanly (unless we have a > > better way to set these elements). Thanks > > There are specific

Re: [FFmpeg-devel] [RFC] [PATCH 0/2] Two alternative ways to fix auto bsfs and merged side data

2016-11-04 Thread James Almer
On 11/4/2016 10:13 AM, James Almer wrote: > On 11/4/2016 9:43 AM, Michael Niedermayer wrote: >> Here are 2 ways to fix merged side data and auto BSFs >> the testcase i have requires a non public rtmp stream > > The first patch wouldn't fix auto-bsf when used without the CLI, > i think, so the

Re: [FFmpeg-devel] [PATCH v1] avformat/flvdec: add debug message to list keyframes index metadata

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 07:54:48PM +0800, Steven Liu wrote: > when parsing keyframe index metadata, list the message by trace log > > Signed-off-by: Steven Liu > --- > libavformat/flvdec.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) LGTM thx [...] --

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: add early support for colour elements

2016-11-04 Thread Neil Birkbeck
> > > This seems to have been made official now, as usual under version 4 > like every other new element. > https://github.com/Matroska-Org/libmatroska/commit/ > cd05bc14b42bd88218c61837208fa2b6c79b1de4 > > Could you confirm there were no changes to the draft and remove the > experimental checks

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Steven Liu
2016-11-04 22:47 GMT+08:00 Steven Liu : > > > 2016-11-04 22:38 GMT+08:00 Michael Niedermayer : > >> On Fri, Nov 04, 2016 at 08:58:56PM +0800, Steven Liu wrote: >> > 2016-11-04 20:44 GMT+08:00 Michael Niedermayer > >: >> >

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Steven Liu
2016-11-04 22:38 GMT+08:00 Michael Niedermayer : > On Fri, Nov 04, 2016 at 08:58:56PM +0800, Steven Liu wrote: > > 2016-11-04 20:44 GMT+08:00 Michael Niedermayer : > > > > > On Fri, Nov 04, 2016 at 11:24:06AM +0800, Steven Liu wrote: > > > > Add

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 08:58:56PM +0800, Steven Liu wrote: > 2016-11-04 20:44 GMT+08:00 Michael Niedermayer : > > > On Fri, Nov 04, 2016 at 11:24:06AM +0800, Steven Liu wrote: > > > Add keyframe index metadata > > > Used to facilitate seeking; particularly for HTTP pseudo

[FFmpeg-devel] [PATCH] avcodec/hap: consistent name for codec

2016-11-04 Thread Tom Butterworth
"Vidvox Hap", not "Vidvox Hap encoder" or "Vidvox Hap decoder". Fixes bad name in fmmpeg -codecs, matches other codec naming. --- libavcodec/codec_desc.c | 2 +- libavcodec/hapdec.c | 2 +- libavcodec/hapenc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [RFC] [PATCH 0/2] Two alternative ways to fix auto bsfs and merged side data

2016-11-04 Thread Carl Eugen Hoyos
2016-11-04 13:43 GMT+01:00 Michael Niedermayer : > Here are 2 ways to fix merged side data and auto BSFs Please mention ticket #5927 when committing one of the solutions. Thank you, Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [RFC/PATCH]ffmpeg: Warn if thousands of frames are duplicated

2016-11-04 Thread Carl Eugen Hoyos
2016-11-04 2:41 GMT+01:00 Michael Niedermayer : > On Fri, Nov 04, 2016 at 12:20:54AM +0100, Carl Eugen Hoyos wrote: >> 2016-11-04 0:19 GMT+01:00 Carl Eugen Hoyos : >> >> > Not sure if this really helps but ffmpeg can duplicate an enormous >> > amount of

Re: [FFmpeg-devel] [RFC] [PATCH 0/2] Two alternative ways to fix auto bsfs and merged side data

2016-11-04 Thread James Almer
On 11/4/2016 9:43 AM, Michael Niedermayer wrote: > Here are 2 ways to fix merged side data and auto BSFs > the testcase i have requires a non public rtmp stream The first patch wouldn't fix auto-bsf when used without the CLI, i think, so the second is IMO the better solution. We also have the

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 05:27:34PM +0530, Pallavi Kumari wrote: > patch attached. > > On Fri, Nov 4, 2016 at 3:29 PM, Michael Niedermayer > wrote: > > > On Fri, Nov 04, 2016 at 07:46:34AM +0530, Pallavi Kumari wrote: > > > Updated patch attached. PFA > > [...] > > > > >

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Steven Liu
2016-11-04 20:58 GMT+08:00 Steven Liu : > > > 2016-11-04 20:44 GMT+08:00 Michael Niedermayer : > >> On Fri, Nov 04, 2016 at 11:24:06AM +0800, Steven Liu wrote: >> > Add keyframe index metadata >> > Used to facilitate seeking; particularly for HTTP

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Steven Liu
2016-11-04 20:44 GMT+08:00 Michael Niedermayer : > On Fri, Nov 04, 2016 at 11:24:06AM +0800, Steven Liu wrote: > > Add keyframe index metadata > > Used to facilitate seeking; particularly for HTTP pseudo streaming. > > > > Reviewed-by: Lou Logan > >

Re: [FFmpeg-devel] [PATCH v1] avformat/flvenc: add add_keyframe_index option

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 11:24:06AM +0800, Steven Liu wrote: > Add keyframe index metadata > Used to facilitate seeking; particularly for HTTP pseudo streaming. > > Reviewed-by: Lou Logan > Signed-off-by: Steven Liu > --- > doc/muxers.texi |3 + >

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Always run av_packet_split_side_data() before writing a packet

2016-11-04 Thread Michael Niedermayer
The new automatically inserted bitstream filters are not compatible with merged side data. This works around this by spliting the side data out. Signed-off-by: Michael Niedermayer --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c

[FFmpeg-devel] [PATCH 2/2] avformat/mux: split side data before internal auto BSF

2016-11-04 Thread Michael Niedermayer
The bitstream filters do not work with merged in side data This leaves the input packet split if it is being split. It could be merged again, if thats preferred ? That would involve an extra malloc and memcpy though Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH v1] add show_demuxers and show_muxers

2016-11-04 Thread Steven Liu
add -muxers and -demuxers parameters to list the dexmuers and muxers Signed-off-by: Steven Liu --- cmdutils.c | 66 +++ cmdutils.h | 14 ++ cmdutils_common_opts.h |2 + 3 files changed, 59

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: add debug message to list keyframes index metadata

2016-11-04 Thread Steven Liu
2016-11-04 19:26 GMT+08:00 Michael Niedermayer : > On Fri, Nov 04, 2016 at 04:08:14PM +0800, Steven Liu wrote: > > when parsing keyframe index metadata, list the message by debug log > > > > Signed-off-by: Steven Liu > > --- > > libavformat/flvdec.c

Re: [FFmpeg-devel] [PATCH] add show_demuxers and show_muxers

2016-11-04 Thread Steven Liu
2016-11-04 19:36 GMT+08:00 Michael Niedermayer : > On Fri, Nov 04, 2016 at 03:17:23PM +0800, Steven Liu wrote: > > add -muxers and -demuxers parameters to list the dexmuers and muxers > > > > Signed-off-by: Steven Liu > > --- > > cmdutils.c

Re: [FFmpeg-devel] [PATCH] avcodec/rawdec: check for side data before checking its size

2016-11-04 Thread Michael Niedermayer
On Thu, Nov 03, 2016 at 10:34:58PM -0300, James Almer wrote: > Fixes valgrind warnings about usage of uninitialized values. > > Signed-off-by: James Almer > --- > libavcodec/rawdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: add debug message to list keyframes index metadata

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 04:08:14PM +0800, Steven Liu wrote: > when parsing keyframe index metadata, list the message by debug log > > Signed-off-by: Steven Liu > --- > libavformat/flvdec.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] ffmpeg: don't overwrite av_bsf_receive_packet return value before checking it

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 12:21:16AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > ffmpeg.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) LGTM thx PS: not sure ret == AVERROR(EAGAIN) should maybe be done earlier [...] -- Michael GnuPG

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-11-04 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 07:46:34AM +0530, Pallavi Kumari wrote: > Updated patch attached. PFA [...] > Makefile|1 > af_peakpoints.c | 263 > > allfilters.c|1 > version.h |2 > 4 files changed, 266

[FFmpeg-devel] [PATCH] avformat/flvdec: add debug message to list keyframes index metadata

2016-11-04 Thread Steven Liu
when parsing keyframe index metadata, list the message by debug log Signed-off-by: Steven Liu --- libavformat/flvdec.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e53c345..e2a4669 100644 ---

[FFmpeg-devel] [PATCH] add show_demuxers and show_muxers

2016-11-04 Thread Steven Liu
add -muxers and -demuxers parameters to list the dexmuers and muxers Signed-off-by: Steven Liu --- cmdutils.c | 60 +++--- cmdutils.h | 14 cmdutils_common_opts.h | 2 ++ 3 files changed,