Re: [FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

2016-12-03 Thread Moritz Barsnick
On Wed, Nov 30, 2016 at 16:44:40 +, Gregory J Wolfe wrote: > Not sure exactly what you mean by "documentation update". Some > comments in the code, or more verbosity than "enable/disable load > balancing"? Please elaborate. I was referring to doc/encoders.texi, but just noticed that libopenh

[FFmpeg-devel] FFmpeg and callbacks

2016-12-03 Thread Denis
Hi. With the old ffmpeg version 2.0.0 I can add my custom callback to pass to avio_open function by patching the files allformats.c and file.c. Now I can't to pacth the new version 3.2.1 because I can't add to file allformats.c the line of code REGISTER_PROTOCOL (BUFFERCALLBACK, buffercallback)

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 03:11:33PM +0100, Michael Niedermayer wrote: > On Mon, Nov 28, 2016 at 07:15:28PM +0100, Nicolas George wrote: > > Deadline: 2016-12-06 00:00 UTC. > > > > I propose, and put to the discussion, that the decision to drop ffserver > > is revoked, conditioned to the fixing of t

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 06:00:12PM +0100, Timo Rothenpieler wrote: > ping > > If nobody has a better idea how to resolve the crash, I'm going to push > this today. i dont think this patch really fixes it with this patch and the same sample: make -j12 && ./ffmpeg -vcodec h264_cuvid -i full20.ts

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-12-03 Thread Nicolas George
Le quartidi 14 frimaire, an CCXXV, Muhammad Faiz a écrit : > Does this make AV_BUFFERSRC_FLAG_PUSH useless? For the most part, yes. I intended to do the cleanup of these small aspects of the API after implementing a cleaner over API. Regards, -- Nicolas George signature.asc Description: Dig

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-12-03 Thread Muhammad Faiz
On 11/27/16, Nicolas George wrote: > A lot of changes happen at the same time: > > - Add a framequeue fifo to AVFilterLink. > > - split AVFilterLink.status into status_in and status_out: requires > changes to the few filters and programs that use it directly > (f_interleave, split, filtfmts).

Re: [FFmpeg-devel] [PATCH] swresample/resample: do not rebuild filter when sample_delta is zero

2016-12-03 Thread Muhammad Faiz
On 12/3/16, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 03:10:54AM +0700, Muhammad Faiz wrote: >> Signed-off-by: Muhammad Faiz >> --- >> libswresample/resample.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > probably ok Applied Thank's __

[FFmpeg-devel] [PATCH] lavfi/formats: allow unknown channel layouts by default

2016-12-03 Thread Marton Balint
Since the default in the libav fork is to only allow known layouts, making unknown layouts allowed by default here can be a security risk for filters directly merged from libav. However, usually it is simple to detect such cases, use of av_get_channel_layout_nb_channels is a good indicator, so I su

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

2016-12-03 Thread Timo Rothenpieler
ping If nobody has a better idea how to resolve the crash, I'm going to push this today. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-12-03 Thread Nicolas George
Le septidi 7 frimaire, an CCXXV, Nicolas George a écrit : > A lot of changes happen at the same time: > > - Add a framequeue fifo to AVFilterLink. > > - split AVFilterLink.status into status_in and status_out: requires > changes to the few filters and programs that use it directly > (f_interl

Re: [FFmpeg-devel] [PATCH] swresample/resample: do not rebuild filter when sample_delta is zero

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 03:10:54AM +0700, Muhammad Faiz wrote: > Signed-off-by: Muhammad Faiz > --- > libswresample/resample.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) probably ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and wh

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
> > Indeed, in theory that would work. I always forget about these options. > In my experience they do not work reliably, and I would argue against > their use in portable code. For example, starting there: > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html > can you tell

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Hendrik Leppkes
On Sat, Dec 3, 2016 at 2:13 PM, Matt Oliver wrote: > On 3 December 2016 at 23:40, Hendrik Leppkes wrote: > >> On Sat, Dec 3, 2016 at 1:33 PM, Matt Oliver wrote: >> > >> > I havent fully tested Hendriks idea as the msdn docs dont recommend >> calling >> > multiple winsock functions at the same ti

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-03 Thread Michael Niedermayer
On Mon, Nov 28, 2016 at 07:15:28PM +0100, Nicolas George wrote: > Deadline: 2016-12-06 00:00 UTC. > > I propose, and put to the discussion, that the decision to drop ffserver > is revoked, conditioned to the fixing of the technical issues that lead > to it. > > In other words, if the technical pr

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Nicolas George
Replying for the completeness of the discussion. Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > Thats the trick, not to large that it results noticeable shutdown delays to > the user but not to quick that it polls to often, on a modern machine id > think something like 0.01s would be ok.

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Nicolas George
Le quartidi 14 frimaire, an CCXXV, Matt Oliver a écrit : > Would something like the following work for you: I would not oppose on principle, just a few details. > > --- > libavformat/udp.c | 46 +- > 1 file changed, 29 insertions(+), 17 deletions(-) >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 23:40, Hendrik Leppkes wrote: > On Sat, Dec 3, 2016 at 1:33 PM, Matt Oliver wrote: > > > > I havent fully tested Hendriks idea as the msdn docs dont recommend > calling > > multiple winsock functions at the same time from different threads so i > > wasnt sure about how well

Re: [FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 02:03:22PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 13:14, Michael Niedermayer wrote: > > On Sat, Dec 03, 2016 at 12:51:12PM +0100, Andreas Cadhalpun wrote: > >> On 03.12.2016 00:52, Michael Niedermayer wrote: > >>> @@ -364,14 +364,19 @@ static int ffm2_read_header(AV

Re: [FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:43, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:48:43PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> It should still be possible to set these through >>> recommended_encoder_configuration >>> >>> Signed-off-by: Michael Niederma

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:39, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) >>> ret = AVERROR_INVALIDDATA; >>>

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:37, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) >>> ret = AVERROR_INVALIDDATA; >>>

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:31, Michael Niedermayer wrote: > all done locally, Thanks, patch is OK then. > some of this code is btw not tested by fate Yes, the FFM1 code path is not tested by FATE. Personally I think it would make more sense to remove support for FFM1 than adding a FATE test for it. The c

Re: [FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:23, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 01:14:19AM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> Modern ffserver should not need these >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavformat/ffmdec.c | 148 >>>

Re: [FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:14, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:51:12PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -364,14 +364,19 @@ static int ffm2_read_header(AVFormatContext *s) >>> } >>> codecpar->bit_rate =

Re: [FFmpeg-devel] [PATCH 4/5] ffserver: remove one avcodec_context_copy()

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:49:28PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > ffserver.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/ffserver.c b/ffserver.c > > index 19

Re: [FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:48:43PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > It should still be possible to set these through > > recommended_encoder_configuration > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/ffmdec.c | 27 ++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Hendrik Leppkes
On Sat, Dec 3, 2016 at 1:33 PM, Matt Oliver wrote: > > I havent fully tested Hendriks idea as the msdn docs dont recommend calling > multiple winsock functions at the same time from different threads so i > wasnt sure about how well received a patch that relies on closesocket to > unblock the recv

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > > ret = AVERROR_INVALIDDATA; > > goto fail; > > } > > -

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > > ret = AVERROR_INVALIDDATA; > > goto fail; > > } > > -

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 22:33, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > > I was just writing an email to rephrase but you beet me to it (sorry i > > wasnt faster) > > No problem. > > > I should rephrase this to "Why is polling with an acceptable > timeout/slee

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 01:19:05AM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > This is a bit messy as codecar does not support AVOptions so we need > > to use AVCodecContext where AVOptions are required and copy back and forth. > > > > Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 01:14:19AM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > Modern ffserver should not need these > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/ffmdec.c | 148 > > +-

Re: [FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:51:12PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > @@ -364,14 +364,19 @@ static int ffm2_read_header(AVFormatContext *s) > > } > > codecpar->bit_rate = avio_rb32(pb); > > if (codecpar->bit_r

Re: [FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > @@ -364,14 +364,19 @@ static int ffm2_read_header(AVFormatContext *s) > } > codecpar->bit_rate = avio_rb32(pb); > if (codecpar->bit_rate < 0) { > -av_log(codec, AV_LOG_ERROR, "Invalid bit rate %

Re: [FFmpeg-devel] [PATCH 4/5] ffserver: remove one avcodec_context_copy()

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > ffserver.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ffserver.c b/ffserver.c > index 19c3ceda1a..3ff761f68f 100644 > --- a/ffserver.c > +++ b/ffserver.c > @@ -2854,7 +285

Re: [FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > It should still be possible to set these through > recommended_encoder_configuration > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 27 --- > 1 file changed, 8 insertions(+), 19 deletions(-) > > di

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > ret = AVERROR_INVALIDDATA; > goto fail; > } > -codec->width = avio_rb16(pb); > -codec->height = avio_rb16(

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > I was just writing an email to rephrase but you beet me to it (sorry i > wasnt faster) No problem. > I should rephrase this to "Why is polling with an acceptable timeout/sleep > not acceptable". Obviously a event based callback would be more

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 22:05, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > > That was because the pthread wrappers dont set errno, so its a required > > change to remove dependency on pthread. > > The pthread wrappers are supposed to match the pthread API, and it

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > That was because the pthread wrappers dont set errno, so its a required > change to remove dependency on pthread. The pthread wrappers are supposed to match the pthread API, and it does not use errno: this change is needed by itself. > Your

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 05:17, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > > Which changes would those be? > > The fix of errno / return value for pthread_cond_timedwait() for > example. > That was because the pthread wrappers dont set errno, so its a required c