Re: [FFmpeg-devel] [PATCH] update to add preclose function, help to fix rtsp didn't send teardown after ffplay close stream

2017-03-02 Thread Hendrik Leppkes
On Thu, Mar 2, 2017 at 2:42 AM, Vincent Luo wrote: > From: Vincent Luo > > --- > ffplay.c | 1 + > libavformat/avformat.h | 11 ++- > libavformat/rtspdec.c | 9 + > libavformat/utils.c| 12 > 4 files changed, 32 insertions(+), 1 deletion(-) > > d

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec: estimate output bitrate for uncompressed video codecs

2017-03-02 Thread Tobias Rapp
On 06.02.2017 13:33, Tobias Rapp wrote: Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Signed-off-by: Tobias Rapp --- libavcodec/r210enc.c | 15 +++ libavcodec/rawenc

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec: estimate output bitrate for ffv1/huffyuv codecs

2017-03-02 Thread Tobias Rapp
On 06.02.2017 13:33, Tobias Rapp wrote: Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Signed-off-by: Tobias Rapp --- libavcodec/ffv1enc.c | 4 libavcodec/huffyuv

[FFmpeg-devel] [PATCH] update to add preclose function, help to fix rtsp didn't send teardown after ffplay close stream

2017-03-02 Thread Vincent Luo
From: Vincent Luo --- ffplay.c | 1 + libavformat/avformat.h | 11 ++- libavformat/rtspdec.c | 9 + libavformat/utils.c| 12 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index 79dc768..42e538b 100644 --- a/ff

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v5']

2017-03-02 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option. --- libavcodec/omx.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 16df50e..19b4f33 100644 --- a/libavcodec/omx.c +++ b/libavcodec/omx.c @@ -

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread James Zern
On Thu, Mar 2, 2017 at 11:00 AM, Kagami Hiiragi wrote: > From ae3856c302284d60761c3ad122ff49b7b9b68114 Mon Sep 17 00:00:00 2001 > From: Kagami Hiiragi > Date: Thu, 2 Mar 2017 21:19:09 +0300 > Subject: [PATCH] lavc/libvpxenc: add -row-mt option > > --- > libavcodec/libvpxenc.c | 11 +++ >

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: set kCVPixelBufferIOSurfaceOpenGLTextureCompatibilityKey

2017-03-02 Thread wm4
On Fri, 3 Mar 2017 10:37:08 +0800 Wang Bin wrote: > It's macOS only. For iOS, we can use kCVPixelBufferOpenGLESCompatibilityKey So what happens on iOS with the current code? If it doesn't work, could you add support for using the iOS-specific constant on iOS? (From what I know, GLES is exclusive

[FFmpeg-devel] [PATCH 2/2] avutil/md5: stop discarding the const qualifier for the src pointer

2017-03-02 Thread James Almer
The code modifying the buffer on big endian systems was removed. Signed-off-by: James Almer --- libavutil/md5.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavutil/md5.c b/libavutil/md5.c index d3698dcb1d..1069ef1efe 100644 --- a/libavutil/md5.c +++ b/liba

[FFmpeg-devel] [PATCH 1/2] avutil/md5: fix misaligned reads

2017-03-02 Thread James Almer
This makes ubsan happy and also considerably increases performance on big endian systems. Signed-off-by: James Almer --- libavutil/md5.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/libavutil/md5.c b/libavutil/md5.c index 8c36aa80c4..d3698dcb1d 100644 ---

[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg12dec: Fix runtime error: left shift of negative value -13

2017-03-02 Thread Michael Niedermayer
Fixes: 709/clusterfuzz-testcase-4789836449841152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpeg12dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg12

[FFmpeg-devel] [PATCH 1/3] avcodec/adxdec: Fix runtime error: left shift of negative value -1

2017-03-02 Thread Michael Niedermayer
Fixes: 705/clusterfuzz-testcase-5129572590813184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/adxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/adxdec.c

[FFmpeg-devel] [PATCH 3/3] avcodec/h264_mvpred: Fix multiple runtime error: left shift of negative value

2017-03-02 Thread Michael Niedermayer
Fixes: 710/clusterfuzz-testcase-5091051431788544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h264_mvpred.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: set kCVPixelBufferIOSurfaceOpenGLTextureCompatibilityKey

2017-03-02 Thread Wang Bin
It's macOS only. For iOS, we can use kCVPixelBufferOpenGLESCompatibilityKey ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] HEVC Video Transcode Transfer VUI, SEI Information

2017-03-02 Thread Ben Chang
Hi, I posted a query regarding HDR transcode on the user forum a few weeks earlier and did not get a very clear answer; re-posting here in devel to see if I can gain more insight (sorry about duplication). >I was wondering if ffmpeg supports transfer of VUI and SEI info between an >original bi

[FFmpeg-devel] [PATCH V2] vf_hwupload: Add missing return value check

2017-03-02 Thread Jun Zhao
V2: Fix the potential memory leak.2 From eb283d277679b5dac9c43e8d3c98bcc9367b592f Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Fri, 3 Mar 2017 09:25:53 +0800 Subject: [PATCH] vf_hwupload: Add missing return value check Add missing return value checks and fix the potential memory leak. Signed-of

Re: [FFmpeg-devel] [PATCH] vf_hwupload: Add missing return value check

2017-03-02 Thread Jun Zhao
On 2017/3/1 5:44, Mark Thompson wrote: > On 27/02/17 02:23, Jun Zhao wrote: >> From e60a958c78ba084e0745acebec5125394387c5b1 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Mon, 27 Feb 2017 10:08:36 +0800 >> Subject: [PATCH] vf_hwupload: Add missing return value checks >> >> Add missing retu

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v5]

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 05:42:29AM +0900, Takayuki 'January June' Suwa wrote: > From: Takayuki 'January June' Suwa > > This adds "-profile[:v] profile_name"-style option. > --- > libavcodec/omx.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/libavco

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 11:43:15PM +0100, Carl Eugen Hoyos wrote: > 2017-03-01 13:07 GMT+01:00 Michael Niedermayer : > > On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : > >> > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 04:43:27PM -0500, Dave Rice wrote: > > > On Mar 2, 2017, at 9:59 AM, James Almer wrote: > > > > On 3/2/2017 11:47 AM, Tobias Rapp wrote: > >> On 02.03.2017 15:22, James Almer wrote: > >>> On 3/2/2017 6:28 AM, Nicolas George wrote: > Le primidi 11 ventôse, an CCXXV, J

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: move the segment files handle close before temp flags process

2017-03-02 Thread Steven Liu
2017-03-01 10:23 GMT+08:00 Steven Liu : > fix ticket: #6204 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 9cf6211..b8122f1 100644 > --- a/libavformat/h

[FFmpeg-devel] unsubscribe

2017-03-02 Thread Christo Grozev
unsubscribe -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Michael Niedermayer Sent: Friday, March 3, 2017 12:02 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] ffmpeg_opt: pass output framerate as a

Re: [FFmpeg-devel] [PATCH v2 1/3] ffmpeg_opt: pass output framerate as a hint to the encoder

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 03:35:08PM +0100, Tobias Rapp wrote: > On 02.03.2017 03:27, Michael Niedermayer wrote: > >On Mon, Feb 27, 2017 at 09:50:31AM +0100, Tobias Rapp wrote: > >>On 26.02.2017 16:09, Michael Niedermayer wrote: > >>>On Mon, Feb 20, 2017 at 04:05:00PM +0100, Tobias Rapp wrote: >

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: update bitrates on dash_write_trailer

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 11:48:47PM +0100, Przemysław Sobala wrote: > 23 lut 2017 21:39 "Przemysław Sobala" > napisał(a): > > On Wednesday, February 22, 2017, Przemysław Sobala < > przemyslaw.sob...@gmail.com> wrote: > > > From: Przemysław Sobala > > > > Provides a way to change bandwidth (bitra

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 10:35:21AM +0100, wm4 wrote: > On Fri, 17 Feb 2017 21:15:56 +0100 > Michael Niedermayer wrote: > > > On Fri, Feb 17, 2017 at 07:02:10AM +0100, wm4 wrote: > > > On Thu, 16 Feb 2017 10:29:36 -0800 > > > Aman Gupta wrote: > > > > > > > From: Aman Gupta > > > > > > > > T

Re: [FFmpeg-devel] [PATCH] Revert "avutil/frame: Disallow zero sized frame side data"

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 01:02:11PM +0100, Michael Niedermayer wrote: > Found a case where we use size==0, the other related commits > remain needed, and should be sufficient to fix the original issue > > This reverts commit 7e4f32f4e4b93c95dcc872cb844c5548e69f352e. > --- > libavutil/frame.c | 2 -

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/interplayvideo: Fix timeout from lack of bitstream end check

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 06:31:25PM +0100, Michael Niedermayer wrote: > Fixes: 697/clusterfuzz-testcase-6111250582863872 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/interplayvideo

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpegaudiodec_template: Fix runtime error: signed integer overflow: 2053224902 + 2053224902 cannot be represented in type 'int'

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 06:31:24PM +0100, Michael Niedermayer wrote: > Fixes: 696/clusterfuzz-testcase-5853632270434304 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegaudiodec_t

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mjpegdec: Fix runtime error: left shift of negative value -511

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 06:31:23PM +0100, Michael Niedermayer wrote: > Fixes: 693/clusterfuzz-testcase-6109776066904064 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpegdec.c | 2

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread Kagami Hiiragi
On 03/03/17 01:16, Moritz Barsnick wrote: > On Thu, Mar 02, 2017 at 22:00:36 +0300, Kagami Hiiragi wrote: >> +{"row-mt", "Row based multi-threading", OFFSET(row_mt), >> AV_OPT_TYPE_INT, {.i64 = -1}, -1, 1, VE}, >^ > Wo

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread Moritz Barsnick
On Thu, Mar 02, 2017 at 22:00:36 +0300, Kagami Hiiragi wrote: > +{"row-mt", "Row based multi-threading", OFFSET(row_mt), AV_OPT_TYPE_INT, > {.i64 = -1}, -1, 1, VE}, ^ Woudn't a _BOOL type accept exactly the same ranges

Re: [FFmpeg-devel] [PATCH]lavf/mpeg: Identify sub-stream ID 0xa1 as mlp

2017-03-02 Thread Hendrik Leppkes
On Wed, Mar 9, 2016 at 2:14 PM, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > >> > mpeg.c |2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > 441c00cda76c5f59b560517115ad1677ab8061bd patchmpegmlp.diff >> > diff --git a/libavformat/mpeg.c b/libavformat/mp

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Dave Rice
> On Mar 2, 2017, at 9:59 AM, James Almer wrote: > > On 3/2/2017 11:47 AM, Tobias Rapp wrote: >> On 02.03.2017 15:22, James Almer wrote: >>> On 3/2/2017 6:28 AM, Nicolas George wrote: Le primidi 11 ventôse, an CCXXV, James Almer a écrit : > Ah, i see there's generic code to read and wri

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread James Almer
On 3/2/2017 2:27 PM, wm4 wrote: > Well, you already announced that you'd leave the project a few months > ago or so, but nothing happened. As an (apparently involuntary) de-facto > project leader who refuses to fix the leadership associated problems of > the project, it's of course not strange that

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 06:27:29PM +0100, wm4 wrote: > On Thu, 2 Mar 2017 17:12:04 +0100 > Michael Niedermayer wrote: > > > On Thu, Mar 02, 2017 at 02:37:09PM +0100, wm4 wrote: > > > On Thu, 2 Mar 2017 14:03:18 +0100 > > > Michael Niedermayer wrote: > > > > > > > On Thu, Mar 02, 2017 at 09:53

[FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread Kagami Hiiragi
From ae3856c302284d60761c3ad122ff49b7b9b68114 Mon Sep 17 00:00:00 2001 From: Kagami Hiiragi Date: Thu, 2 Mar 2017 21:19:09 +0300 Subject: [PATCH] lavc/libvpxenc: add -row-mt option --- libavcodec/libvpxenc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-03-02 Thread Aman Gupta
On Thu, Mar 2, 2017 at 2:04 AM, wm4 wrote: > On Thu, 2 Mar 2017 10:47:23 +0100 > Hendrik Leppkes wrote: > > > On Thu, Mar 2, 2017 at 10:35 AM, wm4 wrote: > > > On Fri, 17 Feb 2017 21:15:56 +0100 > > > Michael Niedermayer wrote: > > > > > >> On Fri, Feb 17, 2017 at 07:02:10AM +0100, wm4 wrote:

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-02 Thread Aman Gupta
On Thu, Mar 2, 2017 at 1:34 AM, wm4 wrote: > On Tue, 21 Feb 2017 13:40:08 -0800 > Aman Gupta wrote: > > > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje > > wrote: > > > > > Hi, > > > > > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > > > > > >> diff --git a/libavcodec/h264dec.c b/l

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 17:34:11 +0100 Carl Eugen Hoyos wrote: > 2017-03-01 13:31 GMT+01:00 wm4 : > > On Wed, 1 Mar 2017 13:06:29 +0100 > > Carl Eugen Hoyos wrote: > > > >> 2017-03-01 12:36 GMT+01:00 wm4 : > >> > On Wed, 1 Mar 2017 12:20:10 +0100 > >> > Carl Eugen Hoyos wrote: > >> > > >> >> 2

Re: [FFmpeg-devel] [PATCH]lavc/sheervideo: Fix Y prediction for interlaced frames with alpha

2017-03-02 Thread Carl Eugen Hoyos
2017-03-02 11:09 GMT+01:00 Paul B Mahol : > On 3/1/17, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6210 visually. >> >> Please review, Carl Eugen >> > > lgtm Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 17:12:04 +0100 Michael Niedermayer wrote: > On Thu, Mar 02, 2017 at 02:37:09PM +0100, wm4 wrote: > > On Thu, 2 Mar 2017 14:03:18 +0100 > > Michael Niedermayer wrote: > > > > > On Thu, Mar 02, 2017 at 09:53:02AM +0100, wm4 wrote: > > > > These patches merge the previously

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Carl Eugen Hoyos
2017-03-01 23:43 GMT+01:00 Carl Eugen Hoyos : > 2017-03-01 13:07 GMT+01:00 Michael Niedermayer : >> On Wed, Mar 01, 2017 at 09:43:57AM +0100, Carl Eugen Hoyos wrote: >>> 2017-03-01 4:40 GMT+01:00 Michael Niedermayer : >>> > On Tue, Feb 28, 2017 at 08:45:44PM +0100, Carl Eugen Hoyos wrote: >>> >> Hi

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-03-02 Thread Carl Eugen Hoyos
2017-03-01 13:31 GMT+01:00 wm4 : > On Wed, 1 Mar 2017 13:06:29 +0100 > Carl Eugen Hoyos wrote: > >> 2017-03-01 12:36 GMT+01:00 wm4 : >> > On Wed, 1 Mar 2017 12:20:10 +0100 >> > Carl Eugen Hoyos wrote: >> > >> >> 2017-02-25 15:59 GMT+01:00 wm4 : >> >> > I'm documenting existing practice. >> >> >>

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread Carl Eugen Hoyos
2017-03-02 16:03 GMT+01:00 wm4 : > On Thu, 2 Mar 2017 14:03:18 +0100 > Michael Niedermayer wrote: > >> This one looses the first displayed subtitle (the green "help") >> ./ffmpeg -i ~/tickets/153/bbc_small.ts -filter_complex '[0:v][0:s]overlay' >> -qscale 2 -t 3 test.avi > > Attached patch fixes

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 02:37:09PM +0100, wm4 wrote: > On Thu, 2 Mar 2017 14:03:18 +0100 > Michael Niedermayer wrote: > > > On Thu, Mar 02, 2017 at 09:53:02AM +0100, wm4 wrote: > > > These patches merge the previously skipped Libav commits, which made > > > avconv lazily initialize libavfilter gr

[FFmpeg-devel] Using new decoder interface

2017-03-02 Thread Brett Tiplitz
I've tried to update my code from avcodec_decode_audio4 to the new avcodec_send_packet. I've got a block of data to decode, so this is not a streaming design. 1. When I pass a big block of data to the interface, the time required to process the buffer goes from 1.5s to 30s. 2. When I try and pa

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 14:03:18 +0100 Michael Niedermayer wrote: > This one looses the first displayed subtitle (the green "help") > ./ffmpeg -i ~/tickets/153/bbc_small.ts -filter_complex '[0:v][0:s]overlay' > -qscale 2 -t 3 test.avi Attached patch fixes it. Will push it as part of the series tomor

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread James Almer
On 3/2/2017 11:47 AM, Tobias Rapp wrote: > On 02.03.2017 15:22, James Almer wrote: >> On 3/2/2017 6:28 AM, Nicolas George wrote: >>> Le primidi 11 ventôse, an CCXXV, James Almer a écrit : Ah, i see there's generic code to read and write CodecPrivate elements to and from raw extradata for

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread James Almer
On 3/2/2017 5:44 AM, Carl Eugen Hoyos wrote: > 2017-03-02 0:26 GMT+01:00 James Almer : >> On 3/1/2017 7:18 PM, Carl Eugen Hoyos wrote: > This doesn't consider the CodecPrivate contents for FFV1 v3 and above. It's only valid for v1 and v2. >>> >>> Is this comment meant for the muxer or th

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: remove meaningless warning

2017-03-02 Thread Steven Liu
2017-03-02 18:01 GMT+08:00 wm4 : > Ever since the codecpar changes, this has been always printed when > opening a flv file. This is because the codecpar changes made all > streams to be added lazily as read_packet is called. > --- > libavformat/flvdec.c | 1 - > 1 file changed, 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Tobias Rapp
On 02.03.2017 15:22, James Almer wrote: On 3/2/2017 6:28 AM, Nicolas George wrote: Le primidi 11 ventôse, an CCXXV, James Almer a écrit : Ah, i see there's generic code to read and write CodecPrivate elements to and from raw extradata for native codecids where no special handling is required.

Re: [FFmpeg-devel] [PATCH v2 1/3] ffmpeg_opt: pass output framerate as a hint to the encoder

2017-03-02 Thread Tobias Rapp
On 02.03.2017 03:27, Michael Niedermayer wrote: On Mon, Feb 27, 2017 at 09:50:31AM +0100, Tobias Rapp wrote: On 26.02.2017 16:09, Michael Niedermayer wrote: On Mon, Feb 20, 2017 at 04:05:00PM +0100, Tobias Rapp wrote: On 20.02.2017 15:09, Mark Thompson wrote: On 06/02/17 12:33, Tobias Rapp wr

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread James Almer
On 3/2/2017 6:28 AM, Nicolas George wrote: > Le primidi 11 ventôse, an CCXXV, James Almer a écrit : >> Ah, i see there's generic code to read and write CodecPrivate elements >> to and from raw extradata for native codecids where no special handling >> is required. >> >> In any case, the spec says >

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 14:03:18 +0100 Michael Niedermayer wrote: > On Thu, Mar 02, 2017 at 09:53:02AM +0100, wm4 wrote: > > These patches merge the previously skipped Libav commits, which made > > avconv lazily initialize libavfilter graphs. This means the filters > > are initialized with the actual

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread Michael Niedermayer
On Thu, Mar 02, 2017 at 09:53:02AM +0100, wm4 wrote: > These patches merge the previously skipped Libav commits, which made > avconv lazily initialize libavfilter graphs. This means the filters > are initialized with the actual output format, instead of whatever > libavformat reports. > > It's a p

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 12:44:57 +0100 Michael Niedermayer wrote: > On Wed, Mar 01, 2017 at 01:31:02PM +0100, wm4 wrote: > > On Wed, 1 Mar 2017 13:06:29 +0100 > > Carl Eugen Hoyos wrote: > > > > > 2017-03-01 12:36 GMT+01:00 wm4 : > > > > On Wed, 1 Mar 2017 12:20:10 +0100 > > > > Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-03-02 Thread Michael Niedermayer
On Wed, Mar 01, 2017 at 01:31:02PM +0100, wm4 wrote: > On Wed, 1 Mar 2017 13:06:29 +0100 > Carl Eugen Hoyos wrote: > > > 2017-03-01 12:36 GMT+01:00 wm4 : > > > On Wed, 1 Mar 2017 12:20:10 +0100 > > > Carl Eugen Hoyos wrote: > > > > > >> 2017-02-25 15:59 GMT+01:00 wm4 : > > >> > I'm documenti

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Peter B.
On 03/01/2017 03:00 PM, Jerome Martinez wrote: > My suggestion: > - support by the demuxer > - for the muxer, support only if a specific explicit option is set, > default stays AVI compatibility layer (no break in playback by old > players). This sounds like a very practical approach to me: New fi

Re: [FFmpeg-devel] [PATCH]lavc/sheervideo: Fix Y prediction for interlaced frames with alpha

2017-03-02 Thread Paul B Mahol
On 3/1/17, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6210 visually. > > Please review, Carl Eugen > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/flvdec: remove meaningless warning

2017-03-02 Thread wm4
Ever since the codecpar changes, this has been always printed when opening a flv file. This is because the codecpar changes made all streams to be added lazily as read_packet is called. --- libavformat/flvdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/f

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support QDMC

2017-03-02 Thread Paul B Mahol
On 3/1/17, Carl Eugen Hoyos wrote: > Hi! > > Attached patch allows muxing and demuxing of QDMC in mkv. > > Please comment, Carl Eugen > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 10:47:23 +0100 Hendrik Leppkes wrote: > On Thu, Mar 2, 2017 at 10:35 AM, wm4 wrote: > > On Fri, 17 Feb 2017 21:15:56 +0100 > > Michael Niedermayer wrote: > > > >> On Fri, Feb 17, 2017 at 07:02:10AM +0100, wm4 wrote: > >> > On Thu, 16 Feb 2017 10:29:36 -0800 > >> > Aman Gu

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-03-02 Thread Hendrik Leppkes
On Thu, Mar 2, 2017 at 10:35 AM, wm4 wrote: > On Fri, 17 Feb 2017 21:15:56 +0100 > Michael Niedermayer wrote: > >> On Fri, Feb 17, 2017 at 07:02:10AM +0100, wm4 wrote: >> > On Thu, 16 Feb 2017 10:29:36 -0800 >> > Aman Gupta wrote: >> > >> > > From: Aman Gupta >> > > >> > > This fixes playback o

[FFmpeg-devel] [PATCH v2 2/2] ffmpeg: remove unnecessary hack for decoders which refuse to drain

2017-03-02 Thread wm4
Now the previous commit takes care of this instead. --- ffmpeg.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 38395e7598..ee791d68a3 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2529,12 +2529,6 @@ static int process_input_packet(InputStream *ist, const AVPacket *

[FFmpeg-devel] [PATCH v2 1/2] lavc: consider an error during decoder draining as EOF

2017-03-02 Thread wm4
There is no reason that draining couldn't return an error or two. But some decoders don't handle this very well, and might always return an error. This can lead to API users getting into an infinite loop and burning CPU, because no progress is made and EOF is never returned. In fact, ffmpeg.c cont

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-03-02 Thread wm4
On Fri, 17 Feb 2017 21:15:56 +0100 Michael Niedermayer wrote: > On Fri, Feb 17, 2017 at 07:02:10AM +0100, wm4 wrote: > > On Thu, 16 Feb 2017 10:29:36 -0800 > > Aman Gupta wrote: > > > > > From: Aman Gupta > > > > > > This fixes playback of h264 streams with SPS changes. One such sample > >

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: set kCVPixelBufferIOSurfaceOpenGLTextureCompatibilityKey

2017-03-02 Thread wm4
On Fri, 24 Feb 2017 10:49:39 +0100 wm4 wrote: > Makes sure the output can be mapped as OpenGL texture. > This is what at least video players normally want. > --- > libavcodec/videotoolbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotool

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-02 Thread wm4
On Tue, 21 Feb 2017 13:40:08 -0800 Aman Gupta wrote: > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje > wrote: > > > Hi, > > > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > > > >> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > >> index 41c0964392..a0ae632fed 100644 >

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: allow not setting the kCVPixelBufferPixelFormatTypeKey

2017-03-02 Thread wm4
On Fri, 24 Feb 2017 10:44:23 +0100 wm4 wrote: > If AVVideotoolboxContext.cv_pix_fmt_type is set to 0, don't set the > kCVPixelBufferPixelFormatTypeKey value on the VT decoder. > > This makes VT output its native format, which can be much faster on > some hardware iterations (if the native format

Re: [FFmpeg-devel] [PATCH 1/2] lavc, lavf, lavu: remove AVOption requirement to access public fields

2017-03-02 Thread wm4
On Mon, 13 Feb 2017 11:51:28 +0100 wm4 wrote: > Allow all struct fields to be accessed directly, as long as they're > public. > > Before this change, many fields were "public", but could be accessed via > AVOption only. This meant they were effectively not public, but were > present for document

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Nicolas George
Le primidi 11 ventôse, an CCXXV, James Almer a écrit : > Ah, i see there's generic code to read and write CodecPrivate elements > to and from raw extradata for native codecids where no special handling > is required. > > In any case, the spec says > > "For FFV1 versions 2 or less, Private Data SH

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread wm4
On Thu, 2 Mar 2017 09:58:29 +0100 Carl Eugen Hoyos wrote: > 2017-03-02 9:53 GMT+01:00 wm4 : > > > I will push this tomorrow, except if critical failures are found. > > Please give people a few days to test and / or comment. You had 3 weeks. ___ ffm

Re: [FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread Carl Eugen Hoyos
2017-03-02 9:53 GMT+01:00 wm4 : > I will push this tomorrow, except if critical failures are found. Please give people a few days to test and / or comment. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listi

[FFmpeg-devel] [PATCH v3 6/7] ffmpeg: restructure sending EOF to filters

2017-03-02 Thread wm4
From: Anton Khirnov Be more careful when an input stream encounters EOF when its filtergraph has not been configured yet. The current code would immediately mark the corresponding output streams as finished, while there may still be buffered frames waiting for frames to appear on other filtergrap

[FFmpeg-devel] [PATCH v3 7/7] ffmpeg_cuvid: adapt for recent filter graph initialization changes

2017-03-02 Thread wm4
From: Timo Rothenpieler --- ffmpeg.c | 13 -- ffmpeg.h | 1 - ffmpeg_cuvid.c | 141 - 3 files changed, 30 insertions(+), 125 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 10c66eee75..27bfc72cff 100644 --- a/ffmpeg.

[FFmpeg-devel] [PATCH v3 5/7] ffmpeg: move flushing the queued frames to configure_filtergraph()

2017-03-02 Thread wm4
From: Anton Khirnov This is a more appropriate place for it, and will also be useful in the following commit. This merges Libav commit d2e56cf. It was previously skipped. Signed-off-by: wm4 --- ffmpeg.c| 11 --- ffmpeg_filter.c | 11 +++ 2 files changed, 11 insertions(

[FFmpeg-devel] [PATCH v3 1/7] ffmpeg: make sure packets put into the muxing FIFO are refcounted

2017-03-02 Thread wm4
Some callers (like do_subtitle_out()) call this with an AVPacket that is not refcounted. This can cause undefined behavior. Calling av_packet_move_ref() does not make a packet refcounted if it isn't yet. (And it can't be made to, because it always succeeds, and can't return ENOMEM.) Call av_packe

[FFmpeg-devel] [PATCH v3 2/7] ffmpeg: do packet ts rescaling in write_packet()

2017-03-02 Thread wm4
From: Anton Khirnov This will be useful in the following commit, after which the muxer timebase is not always available when encoding. This merges Libav commit 3e265ca. It was previously skipped. There are some changes with how/when the mux_timebase field is set, because the Libav approach ofte

[FFmpeg-devel] [PATCH v3 4/7] ffmpeg: fix printing of filter input/output names

2017-03-02 Thread wm4
Broken by the previous Libav commit (even in Libav, thus a separate commit). Signed-off-by: wm4 --- ffmpeg_filter.c | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c index 8490f4a455..f21a8c85f8 10

[FFmpeg-devel] [PATCH v3 0/7] Merge lazy filter initialization in ffmpeg CLI

2017-03-02 Thread wm4
These patches merge the previously skipped Libav commits, which made avconv lazily initialize libavfilter graphs. This means the filters are initialized with the actual output format, instead of whatever libavformat reports. It's a prerequisite to making hardware decoding support saner, as hardwar

[FFmpeg-devel] [PATCH v3 3/7] ffmpeg: init filtergraphs only after we have a frame on each input

2017-03-02 Thread wm4
From: Anton Khirnov This makes sure the actual stream parameters are used, which is important mainly for hardware decoding+filtering cases, which would previously require various weird workarounds to handle the fact that a fake software graph has to be constructed, but never used. This should als

Re: [FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

2017-03-02 Thread Carl Eugen Hoyos
2017-03-02 0:26 GMT+01:00 James Almer : > On 3/1/2017 7:18 PM, Carl Eugen Hoyos wrote: >>> This doesn't consider the CodecPrivate contents for FFV1 v3 >>> and above. It's only valid for v1 and v2. >> >> Is this comment meant for the muxer or the demuxer part? >> >> How can I reproduce the issue yo

Re: [FFmpeg-devel] [PATCH]lavf/flacdec: Return maximum score if a valid streaminfo header was found

2017-03-02 Thread Carl Eugen Hoyos
2017-03-02 3:09 GMT+01:00 Michael Niedermayer : > On Wed, Mar 01, 2017 at 09:38:58AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> I implemented this patch to fix ticket #6208 but it turned out the flac probe >> function wasn't the issue. Still looks like a good idea to me. >> >> Please comment, Carl