Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread Aaron Levinson
I don't seem to have the original e-mail in my inbox anymore, so I'll respond to wm4's response. Overall, the new code is a lot cleaner and easier to understand than the existing code. See below for more. Aaron Levinson On 5/2/2017 5:04 PM, wm4 wrote: On Fri, 28 Apr 2017 21:27:56 -0300 Jame

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-02 Thread Steven Liu
2017-05-03 9:49 GMT+08:00 Aaron Levinson : > On 4/27/2017 7:21 PM, Steven Liu wrote: > >> 2017-04-26 7:30 GMT+08:00 Steven Liu : >> >> fix ticket id: #6353 >>> >>> Signed-off-by: Steven Liu >>> --- >>> libavformat/hlsenc.c | 24 >>> 1 file changed, 24 insertions(+) >>> >

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Initial implementation of ADPCM encoding for DCA encoder

2017-05-02 Thread Rostislav Pehlivanov
On 2 May 2017 at 22:53, Даниил Чередник wrote: > Hi. > > This patch introduces initial implementation of subband ADPCM encoding for > DCA codec. > > Some results: > > sample: > > https://yadi.sk/d/B_3sVskM3HZiWK - original > > https://yadi.sk/d/7CK47Nt63HZiWf - without adpcm > > https://yadi.sk/d

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-02 Thread James Almer
On 5/3/2017 12:21 AM, Michael Niedermayer wrote: > Fixes timeout > Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/avpacke

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-02 Thread wm4
On Wed, 3 May 2017 05:21:50 +0200 Michael Niedermayer wrote: > Fixes timeout > Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > lib

[FFmpeg-devel] [PATCH] videotoolbox: add hwcontext support

2017-05-02 Thread wm4
This adds tons of code for no other benefit than making VideoToolbox support conform with the new hwaccel API (using hw_device_ctx and hw_frames_ctx). Since VideoToolbox decoding does not actually require the user to allocate frames, the new code does mostly nothing. One benefit is that ffmpeg_vi

[FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-02 Thread Michael Niedermayer
Fixes timeout Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/avpacket.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavc

[FFmpeg-devel] [PATCH 2/2] libavcodec/mpeg4videodec: Convert sprite_offset to 64bit

2017-05-02 Thread Michael Niedermayer
This avoids intermediates from overflowing (the final values are checked) Fixes: runtime error: signed integer overflow: -167712 + -2147352576 cannot be represented in type 'int' Fixes: 1298/clusterfuzz-testcase-minimized-5955580877340672 Found-by: continuous fuzzing process https://github.com/

[FFmpeg-devel] [PATCH] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Rodger Combs
--- libavformat/utils.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index ba82a766dc..80895b31f0 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3505,6 +3505,8 @@ int avformat_find_stream_info(

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC stream

2017-05-02 Thread Jun Zhao
On 2017/5/3 4:23, Mark Thompson wrote: > On 02/05/17 03:49, Jun Zhao wrote: >> From e39078e9fe02c8d77c5e28436aef4d80a2d7b3a0 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 2 May 2017 10:36:55 +0800 >> Subject: [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC >> stre

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC stream

2017-05-02 Thread Jun Zhao
On 2017/5/2 22:08, Michael Niedermayer wrote: > On Tue, May 02, 2017 at 10:49:50AM +0800, Jun Zhao wrote: >> vaapi_encode.c | 15 +++ >> vaapi_encode.h |4 >> vaapi_encode_h264.c | 45 + >> 3 files changed, 64 inserti

Re: [FFmpeg-devel] [RFC] Reviewing merges

2017-05-02 Thread Marton Balint
On Wed, 3 May 2017, wm4 wrote: >>> https://trac.ffmpeg.org/ticket/6323 Rather tricky to fix, so I didn't. The problem is that the filter graph remains unconfigured, so it can't know about unconnected outputs. It remains unconfigured because the first input file is connected to two filters (on

Re: [FFmpeg-devel] [PATCH] ffmpeg: check for unconnected outputs

2017-05-02 Thread Carl Eugen Hoyos
2017-05-03 1:06 GMT+02:00 wm4 : > Fixes e.g.: > > ffmpeg -f lavfi -i testsrc -f lavfi -i testsrc -filter_complex > "[0:v][1:v]psnr[out]" -f null none Please mention the ticket number in the commit message. Carl Eugen ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-02 Thread Aaron Levinson
On 4/27/2017 7:21 PM, Steven Liu wrote: 2017-04-26 7:30 GMT+08:00 Steven Liu : fix ticket id: #6353 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 24 1 file changed, 24 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 27c8e3355d..3

Re: [FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Fix jp2 inner atom size used for overread checks

2017-05-02 Thread Carl Eugen Hoyos
2017-05-02 21:06 GMT+02:00 Michael Niedermayer : > On Tue, May 02, 2017 at 04:13:07PM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> The atom2_size variable when reading the inner atoms of a jp2 header >> is not reduced after reading the first 64 bit of the atom, the >> variable is used later for seve

Re: [FFmpeg-devel] [PATCH] ffmpeg: check for unconnected outputs

2017-05-02 Thread Steven Liu
2017-05-03 7:06 GMT+08:00 wm4 : > Fixes e.g.: > > ffmpeg -f lavfi -i testsrc -f lavfi -i testsrc -filter_complex > "[0:v][1:v]psnr[out]" -f null none > --- > ffmpeg.h| 1 + > ffmpeg_filter.c | 15 +++ > ffmpeg_opt.c| 2 ++ > 3 files changed, 18 insertions(+) > > diff --g

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-02 Thread wm4
On Tue, 2 May 2017 20:47:06 -0400 Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/hls.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index bac53a4350..643d50e1da 100644 > --- a/libavformat

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread Thomas Mundt
2017-05-02 19:14 GMT+02:00 James Almer : > On 5/2/2017 1:49 PM, Paul B Mahol wrote: > > On 5/2/17, Thomas Mundt wrote: > >> 2017-04-29 18:15 GMT+02:00 Thomas Mundt : > >> > >>> 2017-04-20 23:54 GMT+02:00 Thomas Mundt : > >>> > Patch attached... > > Ping > >>> > >> > >> Ping > >> __

[FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-02 Thread Micah Galizia
Signed-off-by: Micah Galizia --- libavformat/hls.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index bac53a4350..643d50e1da 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -630,8 +630,14 @@ static int open_url(AV

Re: [FFmpeg-devel] [PATCH] Observe Set-Cookie headers in HLS streams

2017-05-02 Thread Micah Galizia
Hi, I was hoping to get this one in too so I've named the patch appropriately. With this change, cookie authenticated streams (eg: Neulion) should play properly again. Thanks, ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH 2/2] Add http cookie tests cases to fate

2017-05-02 Thread Micah Galizia
Hello, Same patch with corrected name. Thanks in advance. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2] libavformat/tests: Add http cookie tests cases to fate

2017-05-02 Thread Micah Galizia
Signed-off-by: Micah Galizia --- libavformat/Makefile | 1 + libavformat/tests/http.c | 186 + tests/fate/libavformat.mak | 5 ++ tests/ref/fate/http| 30 4 files changed, 222 insertions(+) create mode 100644 libavformat/t

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread wm4
On Fri, 28 Apr 2017 21:27:56 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/concatdec.c | 94 > - > 1 file changed, 30 insertions(+), 64 deletions(-) > > diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c >

[FFmpeg-devel] [PATCH] cuvid: support AVCodecContext.hw_device_ctx API

2017-05-02 Thread wm4
This is a newer API that is intended for decoders like the cuvid wrapper. Until now, the wrapper required to set an awkward "incomplete" hw_frames_ctx to set the device. Now the device can be set directly, and the user can get AV_PIX_FMT_CUDA output for a specific device simply by setting hw_device

Re: [FFmpeg-devel] [PATCH] avcodec/decode: also check for FF_CODEC_CAP_SETS_PKT_DTS in audio decoders

2017-05-02 Thread James Almer
On 5/2/2017 5:38 PM, Michael Niedermayer wrote: > On Mon, May 01, 2017 at 08:32:47PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/decode.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) > > should be ok > > thx Pushed. ___

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread James Almer
On 4/28/2017 9:27 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/concatdec.c | 94 > - > 1 file changed, 30 insertions(+), 64 deletions(-) Ping ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] Clarification about bits_per_coded_sample vs bits_per_raw_sample

2017-05-02 Thread wm4
On Tue, 2 May 2017 18:01:37 -0400 Shawn Singh wrote: > Hello, > > We are trying to understand two fields in AVCodecParameters: > bits_per_coded_sample and bits_per_raw_sample. > > In the comments in libavcodec/avcodec.h, bits_per_coded_sample is described > as "the bitrate per sample". This

[FFmpeg-devel] [PATCH] ffmpeg: check for unconnected outputs

2017-05-02 Thread wm4
Fixes e.g.: ffmpeg -f lavfi -i testsrc -f lavfi -i testsrc -filter_complex "[0:v][1:v]psnr[out]" -f null none --- ffmpeg.h| 1 + ffmpeg_filter.c | 15 +++ ffmpeg_opt.c| 2 ++ 3 files changed, 18 insertions(+) diff --git a/ffmpeg.h b/ffmpeg.h index 4d0456c1fb..d34561275

Re: [FFmpeg-devel] [RFC] Reviewing merges

2017-05-02 Thread wm4
On Mon, 1 May 2017 15:29:22 -0300 James Almer wrote: > On 5/1/2017 3:13 PM, Marton Balint wrote: > > > > On Mon, 24 Apr 2017, wm4 wrote: > > > >> On Mon, 24 Apr 2017 21:14:15 +0200 (CEST) > >> Marton Balint wrote: > >> > >>> On Mon, 24 Apr 2017, Michael Niedermayer wrote: > >>> > On Mon,

[FFmpeg-devel] Clarification about bits_per_coded_sample vs bits_per_raw_sample

2017-05-02 Thread Shawn Singh
Hello, We are trying to understand two fields in AVCodecParameters: bits_per_coded_sample and bits_per_raw_sample. In the comments in libavcodec/avcodec.h, bits_per_coded_sample is described as "the bitrate per sample". This sounds like (encoded bitrate / sample rate), for example 128 kbps 44.

Re: [FFmpeg-devel] [PATCH]configure: Fix libopus detection

2017-05-02 Thread Aaron Levinson
On 4/25/2017 1:19 AM, Carl Eugen Hoyos wrote: 2017-04-13 1:08 GMT+02:00 Carl Eugen Hoyos : 2017-03-30 1:52 GMT+02:00 James Almer : On 3/29/2017 7:47 PM, Carl Eugen Hoyos wrote: Hi! Attached patch fixes a compilation error here. Please test for success, Carl Eugen 0001-configure-Fix-libopus

[FFmpeg-devel] [PATCH] avcodec/dcaenc: Initial implementation of ADPCM encoding for DCA encoder

2017-05-02 Thread Даниил Чередник
Hi. This patch introduces initial implementation of subband ADPCM encoding for DCA codec. Some results: sample: https://yadi.sk/d/B_3sVskM3HZiWK - original https://yadi.sk/d/7CK47Nt63HZiWf - without adpcm https://yadi.sk/d/25q1JDV93HZiWq - with adpcm chirp tone: https://yadi.sk/i/tZKHoJ1d3H

[FFmpeg-devel] [PATCH v2 8/9] hevc_parse: decode SEI message NALUs in extradata

2017-05-02 Thread James Almer
They may be available in hvcc style extradata. Based on a patch by Hendrik Leppkes. Signed-off-by: James Almer --- libavcodec/Makefile| 6 +++--- libavcodec/hevc_parse.c| 21 ++--- libavcodec/hevc_parse.h| 7 --- libavcodec/hevcdec.c | 2 +- libavcod

[FFmpeg-devel] [PATCH v2 7/9] hevc_parser: move slice header parsing to its own function

2017-05-02 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 227 +-- 1 file changed, 120 insertions(+), 107 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 57f2b2bb3e..4f41b78f66 100644 --- a/libavcodec/hevc_parser.c +

[FFmpeg-devel] [PATCH v3 6/9] hevc_parser: remove HEVCContext usage

2017-05-02 Thread James Almer
This gets rid of the duplicate, limited parser. Signed-off-by: James Almer --- libavcodec/Makefile | 2 +- libavcodec/hevc_parser.c | 177 +-- 2 files changed, 33 insertions(+), 146 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Mak

[FFmpeg-devel] [PATCH v2 9/9] doc/libav_merge: remove line about ADVANCED_PARSER

2017-05-02 Thread James Almer
It's been addressed. Signed-off-by: James Almer --- doc/libav-merge.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/libav-merge.txt b/doc/libav-merge.txt index 6f052ec2eb..da9e2757f5 100644 --- a/doc/libav-merge.txt +++ b/doc/libav-merge.txt @@ -105,7 +105,6 @@ Collateral damage that

[FFmpeg-devel] [PATCH v3 5/9] hevc_parser: use ff_h2645_packet_split() to parse NAL units

2017-05-02 Thread James Almer
This simplifies the code considerably. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 50 ++-- 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 9e7fa621ce..501cbc3498 1

[FFmpeg-devel] [PATCH v2 4/9] hevcdec: move SliceHeader struct definition to hevc_ps

2017-05-02 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_ps.h | 83 libavcodec/hevcdec.h | 83 2 files changed, 83 insertions(+), 83 deletions(-) diff --git a/libavcodec/hevc_ps.h b/libavcodec/hevc_ps

[FFmpeg-devel] [PATCH v2 3/9] hevcdec: remove HEVCContext usage from ff_hevc_compute_poc()

2017-05-02 Thread James Almer
Move it to hevc_ps as well. This is in preparation for a following patch. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 2 +- libavcodec/hevc_ps.c | 23 +++ libavcodec/hevc_ps.h | 5 + libavcodec/hevc_refs.c | 23 --- libavcodec

[FFmpeg-devel] [PATCH v3 2/9] hevcdec: move SEI message parsing into a separate header

2017-05-02 Thread James Almer
It doesn't depend on hevcdec anymore. Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 47 --- libavcodec/hevc_sei.h | 125 ++ libavcodec/hevcdec.h | 67 +-- 3 files changed, 136 insertions(+), 103 d

[FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-02 Thread James Almer
Some changes and fixes suggested on IRC. Some patches are v3 as they have been sent before outside the previous set. James Almer (9): hevcdec: remove HEVCContext usage from hevc_sei hevcdec: move SEI message parsing into a separate header hevcdec: remove HEVCContext usage from ff_hevc_comput

[FFmpeg-devel] [PATCH v3 1/9] hevcdec: remove HEVCContext usage from hevc_sei

2017-05-02 Thread James Almer
Based on the H264 SEI implementation. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 9 +-- libavcodec/hevc_refs.c | 4 +- libavcodec/hevc_sei.c| 144 ++- libavcodec/hevcdec.c | 90 ++--- libavcodec/hev

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-02 Thread wm4
On Tue, 2 May 2017 14:17:33 -0700 Aaron Levinson wrote: > On 5/1/2017 11:06 PM, MFojtak wrote: > > Currently this muxer does not work at all. I don't know if 000Z would make > > it compatible with more player as I don't know any. However, adding Z makes > > it compatible with most popular ones li

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-02 Thread Aaron Levinson
On 5/1/2017 11:06 PM, MFojtak wrote: Currently this muxer does not work at all. I don't know if 000Z would make it compatible with more player as I don't know any. However, adding Z makes it compatible with most popular ones like dash.js and shaka. Having this muxer working properly would bring m

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread Michael Niedermayer
On Tue, May 02, 2017 at 06:49:07PM +0200, Paul B Mahol wrote: > On 5/2/17, Thomas Mundt wrote: > > 2017-04-29 18:15 GMT+02:00 Thomas Mundt : > > > >> 2017-04-20 23:54 GMT+02:00 Thomas Mundt : > >> > >>> Patch attached... > >>> > >>> Ping > >> > > > > Ping > > __

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC stream

2017-05-02 Thread Mark Thompson
On 02/05/17 21:23, Mark Thompson wrote: > On 02/05/17 03:49, Jun Zhao wrote: >> From e39078e9fe02c8d77c5e28436aef4d80a2d7b3a0 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 2 May 2017 10:36:55 +0800 >> Subject: [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC >> strea

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: Suppress the "above array bounds" warning.

2017-05-02 Thread Mark Thompson
On 02/05/17 01:10, Jun Zhao wrote: > On 2017/4/30 20:47, Mark Thompson wrote: >> On 26/04/17 07:44, Jun Zhao wrote: >>> From f3678e0ceb691b6df5957a2c3d26d4f0d91d4ff5 Mon Sep 17 00:00:00 2001 >>> From: Jun Zhao >>> Date: Wed, 26 Apr 2017 14:00:56 +0800 >>> Subject: [PATCH] lavc/vaapi_encode_h265: S

Re: [FFmpeg-devel] [PATCH] avcodec/decode: also check for FF_CODEC_CAP_SETS_PKT_DTS in audio decoders

2017-05-02 Thread Michael Niedermayer
On Mon, May 01, 2017 at 08:32:47PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/decode.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is t

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC stream

2017-05-02 Thread Mark Thompson
On 02/05/17 03:49, Jun Zhao wrote: > From e39078e9fe02c8d77c5e28436aef4d80a2d7b3a0 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Tue, 2 May 2017 10:36:55 +0800 > Subject: [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC > stream. > > Add aud option to support insert AUD na

Re: [FFmpeg-devel] [PATCH]compat/strtod: Add missing const qualifiers

2017-05-02 Thread Aaron Levinson
On 5/1/2017 1:51 AM, Carl Eugen Hoyos wrote: Hi! Even without the casts, the patch reduces the number of warnings shown when compiling compat/strtod from seven to three. Please comment, Carl Eugen LGTM Aaron Levinson ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: count packets when queued

2017-05-02 Thread Muhammad Faiz
On Wed, May 3, 2017 at 12:58 AM, Michael Niedermayer wrote: > On Tue, May 02, 2017 at 02:39:46PM +0700, Muhammad Faiz wrote: >> Because write_packet() fakely writes packets to muxer by queueing >> them when muxer hasn't been initialized, it should also increment >> frame_number fakely. >> This is

Re: [FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Fix jp2 inner atom size used for overread checks

2017-05-02 Thread Michael Niedermayer
On Tue, May 02, 2017 at 04:13:07PM +0200, Carl Eugen Hoyos wrote: > Hi! > > The atom2_size variable when reading the inner atoms of a jp2 header > is not reduced after reading the first 64 bit of the atom, the > variable is used later for several checks to avoid overreads. > > Please comment, C

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-02 Thread Paul B Mahol
On 5/2/17, Muhammad Faiz wrote: > On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure | 2 + >> doc/filters.texi| 10 ++ >> libavfilter/Makefile| 1 + >> libavfilter/af_afirfilter.c | 409 >> ++

Re: [FFmpeg-devel] [PATCH v2] avcodec/decode: do not treat discarded frames as eof when draining

2017-05-02 Thread Muhammad Faiz
On Mon, May 1, 2017 at 9:01 PM, wm4 wrote: > On Mon, 1 May 2017 07:36:35 +0700 > Muhammad Faiz wrote: > >> Fix fate failures: >> make fate-mov THREADS=32 >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/decode.c | 8 +--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: don't set AVFrame.pkt_dts

2017-05-02 Thread wm4
On Tue, 2 May 2017 14:50:32 -0300 James Almer wrote: > On 5/2/2017 2:19 PM, wm4 wrote: > > On Mon, 1 May 2017 20:52:14 -0300 > > James Almer wrote: > > > >> decode.c already sets it to the default value. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec/vp9.c | 1 - > >> 1 file

Re: [FFmpeg-devel] [PATCH] fixes the issue https://trac.ffmpeg.org/ticket/6338

2017-05-02 Thread Michael Niedermayer
On Mon, May 01, 2017 at 01:01:34PM +0530, Vineet Goel wrote: > --- > > libavformat/http.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/libavformat/http.c b/libavformat/http.c > > index 293a8a7..27b52fe 100644 > > --- a/libavformat/http.c > > +++ b/libavformat

Re: [FFmpeg-devel] Trac notification not working

2017-05-02 Thread Michael Niedermayer
On Sun, Apr 30, 2017 at 02:08:32PM -0500, Home-Email wrote: > I hope this is the right place to send the following notification. > I tried to use the Trac system but was locked out by the sign-up > procedure. It has been going on for so long I have forgotten what I was > going to send as a bug repo

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: treat audio streams with no parsed packets like unknown streams

2017-05-02 Thread Michael Niedermayer
On Mon, May 01, 2017 at 08:42:17PM -0500, Rodger Combs wrote: > --- > ffmpeg_opt.c | 8 > 1 file changed, 8 insertions(+) probably ok please also add a testcase to fate for this [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house the

[FFmpeg-devel] [PATCH] fixes the issue https://trac.ffmpeg.org/ticket/6338

2017-05-02 Thread Vineet Goel
--- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7..27b52fe 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1094,7 +1094,7 @@ static int http_connect(URLContext *h, const char *path, c

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-02 Thread MFojtak
Currently this muxer does not work at all. I don't know if 000Z would make it compatible with more player as I don't know any. However, adding Z makes it compatible with most popular ones like dash.js and shaka. Having this muxer working properly would bring more attention to it and maybe in the

[FFmpeg-devel] Trac notification not working

2017-05-02 Thread Home-Email
I hope this is the right place to send the following notification. I tried to use the Trac system but was locked out by the sign-up procedure. It has been going on for so long I have forgotten what I was going to send as a bug report. The following message is at the head of any trac.ffmpeg.org doc

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: count packets when queued

2017-05-02 Thread Michael Niedermayer
On Tue, May 02, 2017 at 02:39:46PM +0700, Muhammad Faiz wrote: > Because write_packet() fakely writes packets to muxer by queueing > them when muxer hasn't been initialized, it should also increment > frame_number fakely. > This is required because code in do_streamcopy() rely on > frame_number. >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: don't set AVFrame.pkt_dts

2017-05-02 Thread James Almer
On 5/2/2017 2:19 PM, wm4 wrote: > On Mon, 1 May 2017 20:52:14 -0300 > James Almer wrote: > >> decode.c already sets it to the default value. >> >> Signed-off-by: James Almer >> --- >> libavcodec/vp9.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavcodec/vp9.c b/libavcodec/vp9.

Re: [FFmpeg-devel] [RFC] Reviewing merges

2017-05-02 Thread wm4
On Mon, 1 May 2017 15:29:22 -0300 James Almer wrote: > On 5/1/2017 3:13 PM, Marton Balint wrote: > > > > On Mon, 24 Apr 2017, wm4 wrote: > > > >> On Mon, 24 Apr 2017 21:14:15 +0200 (CEST) > >> Marton Balint wrote: > >> > >>> On Mon, 24 Apr 2017, Michael Niedermayer wrote: > >>> > On Mon,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: don't set AVFrame.pkt_dts

2017-05-02 Thread wm4
On Mon, 1 May 2017 20:52:14 -0300 James Almer wrote: > decode.c already sets it to the default value. > > Signed-off-by: James Almer > --- > libavcodec/vp9.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 4d7310f6d4..3147ffa0db 100644 > --

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-02 Thread wm4
On Tue, 2 May 2017 16:16:35 +0200 Nicolas George wrote: > Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : > > This is all one big mess. > > It is, but I will not take responsibility when it is not mine. > > Libavfilter was in need of a serious overhaul. I do not see you denying > it, an

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread James Almer
On 5/2/2017 1:49 PM, Paul B Mahol wrote: > On 5/2/17, Thomas Mundt wrote: >> 2017-04-29 18:15 GMT+02:00 Thomas Mundt : >> >>> 2017-04-20 23:54 GMT+02:00 Thomas Mundt : >>> Patch attached... Ping >>> >> >> Ping >> ___ >> ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread Paul B Mahol
On 5/2/17, Thomas Mundt wrote: > 2017-04-29 18:15 GMT+02:00 Thomas Mundt : > >> 2017-04-20 23:54 GMT+02:00 Thomas Mundt : >> >>> Patch attached... >>> >>> Ping >> > > Ping > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-05-02 Thread Thomas Mundt
2017-04-29 18:15 GMT+02:00 Thomas Mundt : > 2017-04-20 23:54 GMT+02:00 Thomas Mundt : > >> Patch attached... >> >> Ping > Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Michael Niedermayer
On Mon, May 01, 2017 at 08:42:18PM -0500, Rodger Combs wrote: > --- > libavformat/utils.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) this breaks ./ffmpeg -i ~/tickets/3673/no-video-stream_cut.flv -an -vcodec copy -f framecrc - https://trac.ffmpeg.org/raw-attac

Re: [FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Read resolution box from jp2 files

2017-05-02 Thread Carl Eugen Hoyos
2017-05-02 16:21 GMT+02:00 Nicolas George : > Le tridi 13 floréal, an CCXXV, Carl Eugen Hoyos a écrit : >> Attached patch allows reading the aspect ratio from jpeg2000 files. >> Kakadu allows to produce samples, the "aspect" is defined as the >> horizontal and vertical resolution as in tiff. > > Di

Re: [FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Read resolution box from jp2 files

2017-05-02 Thread Nicolas George
Le tridi 13 floréal, an CCXXV, Carl Eugen Hoyos a écrit : > Attached patch allows reading the aspect ratio from jpeg2000 files. > Kakadu allows to produce samples, the "aspect" is defined as the > horizontal and vertical resolution as in tiff. Did you test what happens with this patch if you try

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: check return value of read in ff_rtsp_read_reply()

2017-05-02 Thread Daniel Richard G.
Resending... On Mon, 2017 Apr 17 01:12-0400, Daniel Richard G. wrote: > In the course of testing RTSP streaming of CCTV video via the FFmpeg > API, I have found some Valgrind uninitialized-memory errors due to what > appear to be short/failed reads in ffurl_read_complete(). > > The calling functi

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-02 Thread Nicolas George
Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : > This is all one big mess. It is, but I will not take responsibility when it is not mine. Libavfilter was in need of a serious overhaul. I do not see you denying it, and you suffered from the limitations it was causing as much as anybody else

[FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Read resolution box from jp2 files

2017-05-02 Thread Carl Eugen Hoyos
Hi! Attached patch allows reading the aspect ratio from jpeg2000 files. Kakadu allows to produce samples, the "aspect" is defined as the horizontal and vertical resolution as in tiff. Please comment, Carl Eugen From 9955a76ea9abd6ad0c79b4e3d7fe74d4cf292aa6 Mon Sep 17 00:00:00 2001 From: Carl Eug

[FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Fix jp2 inner atom size used for overread checks

2017-05-02 Thread Carl Eugen Hoyos
Hi! The atom2_size variable when reading the inner atoms of a jp2 header is not reduced after reading the first 64 bit of the atom, the variable is used later for several checks to avoid overreads. Please comment, Carl Eugen From 8519c62b141953ecbd47f4eb9572a54db29bfec3 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add option to insert AUD nal to AVC stream

2017-05-02 Thread Michael Niedermayer
On Tue, May 02, 2017 at 10:49:50AM +0800, Jun Zhao wrote: > vaapi_encode.c | 15 +++ > vaapi_encode.h |4 > vaapi_encode_h264.c | 45 + > 3 files changed, 64 insertions(+) > 32cb532f5b6e7a3237b3997a79a93bf54b02660f >

Re: [FFmpeg-devel] [PATCH] avformat/nut: add DSDs support

2017-05-02 Thread Michael Niedermayer
On Tue, May 02, 2017 at 12:33:34PM +0900, Takayuki 'January June' Suwa wrote: > codec tags for DSDs are similar to PCMs: 'D', where > 'D' means DSD, or pulse-Density-modulation, > is 'L' for LSB-first, 'M' for MSB-first > is 'D' for default, 'P' for planar > is always binary one :) please s

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/simple_idct: separate macro arguments with commas

2017-05-02 Thread Benoit Fouet
Hi, On 28/04/2017 21:58, Matthieu Bouron wrote: > Untested: fixes ticket #6324. > --- > libavcodec/aarch64/simple_idct_neon.S | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/aarch64/simple_idct_neon.S > b/libavcodec/aarch64/simple_idct_neon.S > i

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-02 Thread Muhammad Faiz
On Mon, May 1, 2017 at 11:45 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, May 1, 2017 at 12:44 PM, Ronald S. Bultje > wrote: > >> Hi, >> >> On Sun, Apr 30, 2017 at 1:16 PM, wm4 wrote: >> >>> I think it's probably ok to push your current patch, since the original >>> author of the patch who brok

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Matthias Hunstock
Am 02.05.2017 um 11:07 schrieb Rodger Combs: > This doesn't apply to subtitle streams, and audio or video streams generally > have at least several packets per second, so streams that are actually active > _shouldn't_ be affected even with the smaller value. I think this is a dangerous assumptio

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Rodger Combs
> On May 2, 2017, at 03:59, Matthias Hunstock wrote: > > Am 02.05.2017 um 03:42 schrieb Rodger Combs: >> +max_empty_analyze_duration = max_analyze_duration; >> if (!max_analyze_duration) { >> +max_empty_analyze_duration = >> max_stream_analyze_duration = >> max_an

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Matthias Hunstock
Am 02.05.2017 um 03:42 schrieb Rodger Combs: > +max_empty_analyze_duration = max_analyze_duration; > if (!max_analyze_duration) { > +max_empty_analyze_duration = > max_stream_analyze_duration = > max_analyze_duration= 5*AV_TIME_BASE; > max_subtitl

[FFmpeg-devel] [PATCH v2] ffmpeg: count packets when queued

2017-05-02 Thread Muhammad Faiz
Because write_packet() fakely writes packets to muxer by queueing them when muxer hasn't been initialized, it should also increment frame_number fakely. This is required because code in do_streamcopy() rely on frame_number. Should fix Ticket6227 Signed-off-by: Muhammad Faiz --- ffmpeg.c | 38 ++

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-02 Thread Muhammad Faiz
On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 2 + > doc/filters.texi| 10 ++ > libavfilter/Makefile| 1 + > libavfilter/af_afirfilter.c | 409 > > lib