Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Initial implementation of ADPCM encoding for DCA encoder

2017-05-07 Thread Rostislav Pehlivanov
On 6 May 2017 at 11:47, Даниил Чередник wrote: > Tiny fix: missed inline attr. > > On Thu, May 4, 2017 at 1:17 AM, Даниил Чередник > wrote: > > > All notices were fixed. Also I found issue with uninitialized subband > > buffer - fixed. New patch

[FFmpeg-devel] [PATCH 2/3] img2dec: add support for piped SVG demuxing

2017-05-07 Thread Rostislav Pehlivanov
Only checks the extension and MIME type, since determining whether a file is SVG is difficult since they're just XML files. Signed-off-by: Rostislav Pehlivanov --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/img2dec.c| 20

[FFmpeg-devel] [PATCH 1/3] lavc: add codec ID and description for SVG

2017-05-07 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 8 2 files changed, 9 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 35df4f6ced..4bbe5179b4 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH 3/3] lavc: add a librsvg rasterization library wrapper

2017-05-07 Thread Rostislav Pehlivanov
Enables rendering of SVG images. This is possible since SVG images still contain and specify the dimensions in pixels to which they've been drawn to and thus enable browsers to display them without any external data. Users can still override and generate images with arbitrary resolutions.

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-05-07 Thread Rodger Combs
--- Changelog| 2 + doc/demuxers.texi| 8 ++ libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/cuedec.c | 207 +++ libavformat/version.h| 4 +- 6 files changed, 221 insertions(+), 2

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 88 +-- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b8800cc..0e948ac 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -30,6 +30,7 @@

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9bb4947..b8800cc 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -315,7 +315,7 @@ static int flac_write_trailer(struct

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-05-07 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 24 libavformat/version.h | 2 +- 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b80bc68..3707d05 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-05-07 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8575d32..9c6ce73 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -184,6 +184,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 271 +++--- 1 file changed, 236 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9bb4947 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-05-07 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0866142..b80bc68 100644 ---

Re: [FFmpeg-devel] [PATCH] lavd/alsa: fixes ALSA resource leak on closing the PCM handle

2017-05-07 Thread James Almer
On 5/8/2017 1:09 AM, Takayuki 'January June' Suwa wrote: > By avoiding thread race condition (CAS-ing with null handle) > > --- > libavdevice/alsa.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavdevice/alsa.c b/libavdevice/alsa.c > index 1bbff30..81187ab

[FFmpeg-devel] [PATCH] lavd/alsa: fixes ALSA resource leak on closing the PCM handle

2017-05-07 Thread Takayuki 'January June' Suwa
By avoiding thread race condition (CAS-ing with null handle) --- libavdevice/alsa.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavdevice/alsa.c b/libavdevice/alsa.c index 1bbff30..81187ab 100644 --- a/libavdevice/alsa.c +++ b/libavdevice/alsa.c @@ -30,6 +30,7

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix memleak

2017-05-07 Thread Steven Liu
fix memleak bug, when all the process is normal, just free old_filename Signed-off-by: Steven Liu --- libavformat/hlsenc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 221089c..d62d5b8 100644

Re: [FFmpeg-devel] [PATCH] tests/fate/fifo-muxer: update fifo-muxer dependencies

2017-05-07 Thread Paul B Mahol
On 5/4/17, Tobias Rapp wrote: > Fixes fate when configured with --disable-network. > --- > tests/fate/fifo-muxer.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/fifo-muxer.mak b/tests/fate/fifo-muxer.mak > index ef8b3b3..9c13954

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-07 Thread Ronald S. Bultje
Hi, On Sun, May 7, 2017 at 2:55 PM, Hendrik Leppkes wrote: > On Sun, May 7, 2017 at 7:17 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Sun, May 7, 2017 at 11:15 AM, Hendrik Leppkes > > wrote: > > > >> Ronald suggested on IRC

Re: [FFmpeg-devel] [PATCH] videotoolbox: add hwcontext support

2017-05-07 Thread Aaron Levinson
Are you also planning to change ffmpeg_videotoolbox.c? See below for more comments. Aaron Levinson On 5/2/2017 8:26 PM, wm4 wrote: This adds tons of code for no other benefit than making VideoToolbox support conform with the new hwaccel API (using hw_device_ctx and hw_frames_ctx). Since

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-07 Thread Hendrik Leppkes
On Sun, May 7, 2017 at 7:17 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, May 7, 2017 at 11:15 AM, Hendrik Leppkes > wrote: > >> Ronald suggested on IRC that the only parts suffering from this are >> the ASM DSP components, and we should just make

[FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure| 2 + doc/filters.texi | 30 +++ libavfilter/Makefile | 1 + libavfilter/af_afir.c| 541 +++ libavfilter/allfilters.c | 1 + 5 files changed, 575

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-07 Thread Marton Balint
On Fri, 5 May 2017, Aaron Levinson wrote: On 5/5/2017 4:57 PM, Marton Balint wrote: On Fri, 5 May 2017, Aaron Levinson wrote: On 4/16/2017 4:11 PM, Aaron Levinson wrote: On 4/15/2017 6:13 AM, Aaron Levinson wrote: On 4/15/2017 4:19 AM, Marton Balint wrote: On Thu, 13 Apr 2017, Aaron

Re: [FFmpeg-devel] [PATCH] ffmpeg: check for unconnected outputs

2017-05-07 Thread James Almer
On 5/7/2017 3:02 PM, Marton Balint wrote: > > On Sat, 6 May 2017, James Almer wrote: > >> On 5/2/2017 8:06 PM, wm4 wrote: >>> Fixes e.g.: >>> >>> ffmpeg -f lavfi -i testsrc -f lavfi -i testsrc -filter_complex >>> "[0:v][1:v]psnr[out]" -f null none >> >> This should be backported to release/3.3

Re: [FFmpeg-devel] [PATCH] ffmpeg: check for unconnected outputs

2017-05-07 Thread Marton Balint
On Sat, 6 May 2017, James Almer wrote: On 5/2/2017 8:06 PM, wm4 wrote: Fixes e.g.: ffmpeg -f lavfi -i testsrc -f lavfi -i testsrc -filter_complex "[0:v][1:v]psnr[out]" -f null none This should be backported to release/3.3 before 3.3.1 is tagged. Done. Regards, Marton

Re: [FFmpeg-devel] [PATCH] lavfi/avfiltergraph: only return EOF in avfilter_graph_request_oldest if all sinks EOFed

2017-05-07 Thread Marton Balint
On Sun, 7 May 2017, Marton Balint wrote: On Sun, 7 May 2017, Nicolas George wrote: Le septidi 17 floréal, an CCXXV, Marton Balint a écrit : Fixes a regression introduced in 32c59a115d3cc757676b5384a5ea44b5a7a7b872, becoming effective in 912969a33e313c57c906e87a7e2367b78a2160f4. Fixes

[FFmpeg-devel] [PATCH 2/2] qsvenc: Make sure the interlaced encoding works

2017-05-07 Thread Aaron Levinson
From 30eb78bac7bd92b0c085ba6873341e8319072acc Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 5 May 2017 21:31:30 -0700 Subject: [PATCH 2/2] qsvenc: Make sure the interlaced encoding works Purpose: qsvenc: make sure that interlaced encoding works. Also, reduce the

[FFmpeg-devel] [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters

2017-05-07 Thread Aaron Levinson
From 2882d77d76805e74fe139f6763f91c39746bebaf Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 5 May 2017 18:49:57 -0700 Subject: [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters Purpose: Fill out the default/unset parameters with ones

Re: [FFmpeg-devel] [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding

2017-05-07 Thread Aaron Levinson
Please disregard this patch--I'm submitting two new patches that have already been reviewed and applied to libav. Aaron Levinson On 4/13/2017 11:36 PM, Aaron Levinson wrote: From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001 From: Aaron Levinson

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Ronald S. Bultje
Hi, On Sun, May 7, 2017 at 7:50 AM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, Ronald S. Bultje a écrit : > > My understanding from what Nicolas said is that the goal is to have > > higher-level code (utils.c-level, e.g. the callers of filter() or > > encode_frame()

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-07 Thread Ronald S. Bultje
Hi, On Sun, May 7, 2017 at 11:15 AM, Hendrik Leppkes wrote: > Ronald suggested on IRC that the only parts suffering from this are > the ASM DSP components, and we should just make checkasm tests for all > of them and let checkasm test the alignment they claim to support,

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_template: Do not decode 2nd PCE if it will lead to failure

2017-05-07 Thread Michael Niedermayer
On Mon, Apr 10, 2017 at 03:27:38AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: 1072/clusterfuzz-testcase-6456688074817536 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-07 Thread Steven Liu
2017-05-05 20:20 GMT+08:00 wm4 : > On Sat, 6 May 2017 04:06:03 +0800 > Steven Liu wrote: > > > Fixes Coverity CID: 1405453 > > > > Signed-off-by: Steven Liu > > --- > > libavformat/matroskadec.c |1 + > > 1 files changed,

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Hendrik Leppkes
On Sun, May 7, 2017 at 1:47 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, May 7, 2017 at 7:34 AM, Marton Balint wrote: > >> >> On Sat, 6 May 2017, Nicolas George wrote: >> >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> As far as I know.

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-07 Thread Hendrik Leppkes
On Sat, May 6, 2017 at 8:34 PM, Nicolas George wrote: > > Encouraging the applications to be aware of the issue for performances > reasons is a good thing. > > Forcing them to do so when it is not convenient, on pain of crash, when > it can be done for them just as easily, not so

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Hendrik Leppkes
On Sun, May 7, 2017 at 1:34 PM, Marton Balint wrote: > > On Sat, 6 May 2017, Nicolas George wrote: > >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> >>> As far as I know. No new features can go to release branch. >>> Or maybe I'm wrong. >> >> >> As I said, if this

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Marton Balint a écrit : > I suggest to return 1 if an actual alignment (with deep copy) happened. Actually, as Muhammad just pointed and as I noticed a few minutes ago, we can not use the same function from lavfi and lavc, due to the get_buffer issue. I propose the

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Muhammad Faiz
On Sun, May 7, 2017 at 6:34 PM, Marton Balint wrote: > > On Sat, 6 May 2017, Nicolas George wrote: > >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> >>> As far as I know. No new features can go to release branch. >>> Or maybe I'm wrong. >> >> >> As I said, if this

Re: [FFmpeg-devel] [PATCH] lavfi/avfiltergraph: only return EOF in avfilter_graph_request_oldest if all sinks EOFed

2017-05-07 Thread Marton Balint
On Sun, 7 May 2017, Nicolas George wrote: Le septidi 17 floréal, an CCXXV, Marton Balint a écrit : Fixes a regression introduced in 32c59a115d3cc757676b5384a5ea44b5a7a7b872, becoming effective in 912969a33e313c57c906e87a7e2367b78a2160f4. Fixes trimmed output of ffmpeg -f lavfi -i

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-07 Thread James Almer
On 5/7/2017 10:18 AM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, James Almer a écrit : >> Will that complete fix be ready and be backport-enabled (AKA, no new >> API) in the coming days? > > It can. Right now, I am waiting for a comment from Hendrik, who seemed > to have objections on

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, James Almer a écrit : > Will that complete fix be ready and be backport-enabled (AKA, no new > API) in the coming days? It can. Right now, I am waiting for a comment from Hendrik, who seemed to have objections on the principle but that I hope to have convinced.

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-07 Thread James Almer
On 5/7/2017 5:33 AM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, Muhammad Faiz a écrit : >> Is it ok to push this? > > Of course not. How would it be ok to push a partial fix when a complete > one is being discussed? > > Regards, Will that complete fix be ready and be

Re: [FFmpeg-devel] [PATCH] lavfi/avfiltergraph: only return EOF in avfilter_graph_request_oldest if all sinks EOFed

2017-05-07 Thread Nicolas George
Le septidi 17 floréal, an CCXXV, Marton Balint a écrit : > Fixes a regression introduced in 32c59a115d3cc757676b5384a5ea44b5a7a7b872, > becoming effective in 912969a33e313c57c906e87a7e2367b78a2160f4. > > Fixes trimmed output of > ffmpeg -f lavfi -i "sine=d=0.01" -f lavfi -i "sine=d=1"

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Marton Balint a écrit : > As the av_frame_realign API is useful on its own without any framework, I > suggest we implement that. > > Once the implementation is complete we can backport it to 3.3 with the > avpriv prefix and without bumping version numbers. > > In

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Ronald S. Bultje a écrit : > My understanding from what Nicolas said is that the goal is to have > higher-level code (utils.c-level, e.g. the callers of filter() or > encode_frame() or get_buffer() inside decode_frame()) call this for every > input frame going back

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Ronald S. Bultje
Hi, On Sun, May 7, 2017 at 7:34 AM, Marton Balint wrote: > > On Sat, 6 May 2017, Nicolas George wrote: > > Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >> >>> As far as I know. No new features can go to release branch. >>> Or maybe I'm wrong. >>> >> >> As I said, if

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Marton Balint
On Sat, 6 May 2017, Nicolas George wrote: TODO Actual implementation. Signed-off-by: Nicolas George --- libavutil/frame.h | 9 + 1 file changed, 9 insertions(+) Here is a proposal for actually fixing the alignment problems that are all over the place in the current

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Marton Balint
On Sat, 6 May 2017, Nicolas George wrote: Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : As far as I know. No new features can go to release branch. Or maybe I'm wrong. As I said, if this is the only issue, then it is not: just copy-paste av_frame_realign() at the two places where

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/simple_idct: separate macro arguments with commas

2017-05-07 Thread Matthieu Bouron
Le 2 mai 2017 12:01 PM, "Benoit Fouet" a écrit : Hi, On 28/04/2017 21:58, Matthieu Bouron wrote: > Untested: fixes ticket #6324. > --- > libavcodec/aarch64/simple_idct_neon.S | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Muhammad Faiz a écrit : > Is it ok to push this? Of course not. How would it be ok to push a partial fix when a complete one is being discussed? Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-07 Thread Muhammad Faiz
On Fri, May 5, 2017 at 1:01 PM, Muhammad Faiz wrote: > This should fix Ticket6349. > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > generate unaligned frame data. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/avfilter.c | 26