[FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

From: Dmytro Humeniuk Signed-off-by: Dmytro Humeniuk --- Changelog | 1 + doc/filters.texi | 23 libavfilter/Makefile | 1 + libavfilter/af_dumpwave.c | 285

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

There is no rush on this. Could you please do a code review so I can see how to do things properly? > On 10 Jan 2018, at 08:43, Kyle Swanson wrote: > > Hi, > > On Tue, Jan 9, 2018 at 3:49 PM, wrote: >> From: Dmytro Humeniuk

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

Hi, On Tue, Jan 9, 2018 at 3:49 PM, wrote: > From: Dmytro Humeniuk > > Signed-off-by: Dmytro Humeniuk > --- > Changelog | 1 + > doc/filters.texi | 23 >

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: AIFF fix in case of ANNO

Yes, the problem found from playing the file AIFF file you can download it from: https://www.datafilehost.com/d/60337fcd On Tue, Jan 9, 2018 at 10:53 PM, Michael Niedermayer wrote: > On Mon, Jan 08, 2018 at 02:03:40PM +, endus...@gmail.com wrote: > > From: Eduard

Re: [FFmpeg-devel] [PATCH] configure: don't use SDL.h in check_func_headers when checking for SDL2

On 1/7/2018 6:15 PM, James Almer wrote: > check_func_headers() defines a main() function, which clashes with a > redefinition done by said SDL header. Check for SDL_PollEvent using > SDL_events.h only instead, where the redefinition doesn't happen. > > Fixes a regression since

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink: addition of absolute wallclock option for pts source

On 1/9/18 3:22 AM, Moritz Barsnick wrote: > On Mon, Jan 08, 2018 at 10:56:56 +0530, vdi...@akamai.com wrote: > >> -{ "audio_pts", "audio pts source", OFFSET(audio_pts_source), >> AV_OPT_TYPE_INT, { .i64 = PTS_SRC_AUDIO}, 1, 4, DEC, "pts_source"}, >> -{ "video_pts",

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: set bytesPerPixel only for packed formats.

On 1/4/2018 5:25 PM, Gyan Doshi wrote: On 12/29/2017 8:38 AM, Michael Niedermayer wrote: On Thu, Dec 28, 2017 at 12:50:00PM -0900, Lou Logan wrote: On Thu, Dec 28, 2017, at 11:51 AM, Michael Niedermayer wrote: who maintains vf_vidstabtransform.c ? Realistically, nobody. Ideally, should

[FFmpeg-devel] [PATCH v2 3/3] avdevice/decklink: addition of absolute wallclock option for pts source

From: Vishwanath Dixit --- doc/indevs.texi | 6 -- libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 4 libavdevice/decklink_dec_c.c| 1 + 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/indevs.texi

[FFmpeg-devel] [PATCH v2 2/3] avdevice/decklink: addition of PTS_SRC_NB in enum DecklinkPtsSource

From: Vishwanath Dixit --- libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec_c.c| 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/decklink_common_c.h b/libavdevice/decklink_common_c.h index ac6563a..18097e2 100644 ---

[FFmpeg-devel] [PATCH v2 1/3] avdevice/decklink: addition of copyts option

From: Vishwanath Dixit --- doc/indevs.texi | 5 + libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 18 +++--- libavdevice/decklink_dec_c.c| 1 + 4 files changed, 18 insertions(+), 7 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http.c: Free allocated client URLContext in case of error.

On Sat, May 20, 2017 at 2:50 AM, Stephan Holljes wrote: > On Sat, Apr 22, 2017 at 3:18 AM, Stephan Holljes > wrote: >> On Tue, Apr 11, 2017 at 8:05 PM, Stephan Holljes >> wrote: >>> --- >>> >>> This version returns 0

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

Hi, >Can you provide some context for this? Please add docs as well. filter converts samples to decibels and calculates RMS (Root-Mean-Square) audio power scaled to desired values, it supposed to generate something like SoundCloud does http://plnkr.co/edit/WeppGcEPQiOyKDsA0C4Y I added docs. >Can't

[FFmpeg-devel] [PATCH] add dumpwave filter

From: Dmytro Humeniuk Signed-off-by: Dmytro Humeniuk --- Changelog | 1 + doc/filters.texi | 23 libavfilter/Makefile | 1 + libavfilter/af_dumpwave.c | 285

[FFmpeg-devel] [PATCH v1 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

From: Mark Thompson Refcount all of the context information. This also fixes a potential segmentation fault when accessing freed memory (buffer returned after the codec has been closed). Tested-by: Jorge Ramirez-Ortiz ---

[FFmpeg-devel] [PATCH v1 3/3] avcodec: v4l2_m2m: context: fix raising warning on POLLERR

From: Jorge Ramirez-Ortiz During the initialization stage, the codec attempts to get free buffers from the driver before any have been queued (this is to keep the code simple and generic) When the kernel driver detects this situation, it returns POLLERR in

[FFmpeg-devel] [PATCH v1 2/3] avcodec: v4l2_m2m: remove unnecessary timeout.

From: Jorge Ramirez-Ortiz Qualcomm's db410c/db820 Venus driver currently present in mainline kernel has a bug which mishandles the CMD_STOP requests causing the decoder to block while draining [1]. This patch removes the workaround that was used to prevent that

[FFmpeg-devel] [PATCH 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

From: Mark Thompson Refcount all of the context information. This also fixes a potential segmentation fault when accessing freed memory (buffer returned after the codec has been closed). Tested-by: Jorge Ramirez-Ortiz ---

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: v4l2_m2m: context: fix raising warning on POLLERR

On 01/09/2018 06:06 PM, Jorge Ramirez-Ortiz wrote: From: Jorge Ramirez-Ortiz During the initialization stage, the codec attempts to get free buffers from the driver before any have been queued (this is to keep the code simple and generic) When the kernel driver

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: v4l2_m2m: remove unnecessary timeout.

--- a/libavcodec/v4l2_m2m_dec.c +++ b/libavcodec/v4l2_m2m_dec.c @@ -131,14 +131,22 @@ static int v4l2_receive_frame(AVCodecContext *avctx, AVFrame *frame) V4L2Context *const capture = >capture; V4L2Context *const output = >output; AVPacket avpkt = {0}; -int ret; +int

Re: [FFmpeg-devel] [PATCH 04/11] Preserve AFD side data when going from AVPacket to AVFrame

On Mon, Jan 08, 2018 at 08:16:51PM -0500, Devin Heitmueller wrote: > This is needed to ensure that AFD data continues to work when > capturing V210 video with the Decklink libavdevice input. > > Signed-off-by: Devin Heitmueller > --- > libavcodec/decode.c | 1 + > 1

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: AIFF fix in case of ANNO

On Mon, Jan 08, 2018 at 02:03:40PM +, endus...@gmail.com wrote: > From: Eduard Sinelnikov > > Apple's AIFF protocol clearly states that each chucnk which is odd sized a > padding should be added. > In the old version of aiffdec adding of padding was done in `get_meta`.

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

On 01/09/2018 08:36 PM, wm4 wrote: Yes, that seems much better conceptually. Though I wonder why there's still an atomic refcount left. that one is for the dynamic resolution change (a feature that is probably broken). I don't have the hardware I need to test it yet but will start to work on

Re: [FFmpeg-devel] [PATCH] avformat/avio: fix off-by-one in retry_transfer_wrapper

On Tue, 9 Jan 2018 09:15:39 +0100 Martin Herkt wrote: > This reportedly fixes hangs with segmented streams. > Affects playback via Schannel on Windows in particular. > > Can be reproduced with any YouTube live stream. > --- > libavformat/avio.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

On Tue, 9 Jan 2018 18:06:11 +0100 Jorge Ramirez-Ortiz wrote: > From: Mark Thompson > > Refcount all of the context information. This also fixes a potential > segmentation fault when accessing freed memory (buffer returned after > the codec has

Re: [FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

On Sun, Jan 07, 2018 at 04:55:43PM +0100, Aurelien Jacobs wrote: > On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote: > > On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote: > > > --- > > > Changelog| 2 +- > > > libavformat/Makefile | 2 ++ > >

[FFmpeg-devel] Fix typo, use all coeffs in range for band tonality calculation

Hi. Current opusenc_psy code (step_collect_psy_metrics) uses only last coeff in range to calculate tone value. It looks like typo. -- Daniil Cherednik 0001-opusenc_psy-Typo-use-all-coeffs-in-range-for-band-to.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add comment into eval_expr

On Tue, Jan 09, 2018 at 10:41:44AM +0800, Steven Liu wrote: > comment about the looks like a duplicate line. > but that is used to reason x is expressed from y > > Signed-off-by: Steven Liu > --- > libavfilter/vf_overlay.c | 1 + > 1 file changed, 1 insertion(+) LGTM, btw

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Expose encryption info to the app.

On Mon, Jan 8, 2018 at 5:23 PM, Carl Eugen Hoyos wrote: > 2018-01-09 0:22 GMT+01:00 Jacob Trimble : > >> Updated with the new design for the side data and applied the realloc >> fix to avoid large allocations. > >> +kid_count =

[FFmpeg-devel] GSoC 2018

Hi folks, yet again, the registration for Google Summer of Code 2018 has opened. Like in the previous years, we've setup an ideas page in our wiki: https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2018 Same procedure as every year - we need to define more interesting tasks for students to

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

On Mon, Jan 8, 2018 at 5:39 PM, Carl Eugen Hoyos wrote: > 2018-01-08 23:34 GMT+01:00 Jacob Trimble : >> On Fri, Jan 5, 2018 at 3:41 PM, Carl Eugen Hoyos wrote: >>> 2018-01-05 23:58 GMT+01:00 Jacob Trimble >>>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Mon, Jan 8, 2018 at 5:19 PM, Carl Eugen Hoyos wrote: > 2018-01-08 23:16 GMT+01:00 Jacob Trimble : >>> You can't remove API just like that without a deprecation period. >>> Add a new av_aes_ctr_set_full_iv() function, and either leave >>>

[FFmpeg-devel] [PATCH] avformat/avio: fix off-by-one in retry_transfer_wrapper

This reportedly fixes hangs with segmented streams. Affects playback via Schannel on Windows in particular. Can be reproduced with any YouTube live stream. --- libavformat/avio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index

[FFmpeg-devel] [PATCH 3/3] avcodec: v4l2_m2m: context: fix raising warning on POLLERR

From: Jorge Ramirez-Ortiz During the initialization stage, the codec attempts to get free buffers from the driver before any have been queued (this is to keep the code simple and generic) When the kernel driver detects this situation, it returns POLLERR in

[FFmpeg-devel] [PATCH 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

From: Mark Thompson Refcount all of the context information. This also fixes a potential segmentation fault when accessing freed memory (buffer returned after the codec has been closed). Tested-by: Jorge Ramirez-Ortiz ---

[FFmpeg-devel] [PATCH 2/3] avcodec: v4l2_m2m: remove unnecessary timeout.

From: Jorge Ramirez-Ortiz Qualcomm's db410c/db820 Venus driver currently present in mainline kernel has a bug which mishandles the CMD_STOP requests causing the decoder to block while draining [1]. This patch removes the workaround that was used to prevent that

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 9, 2018 at 3:21 PM, Rostislav Pehlivanov wrote: > On 9 January 2018 at 14:07, Rostislav Pehlivanov > wrote: > >> >> >> On 9 January 2018 at 09:00, Hendrik Leppkes wrote: >> >>> On Tue, Jan 9, 2018 at 9:33 AM, Hendrik

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 9 January 2018 at 14:07, Rostislav Pehlivanov wrote: > > > On 9 January 2018 at 09:00, Hendrik Leppkes wrote: > >> On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes >> wrote: >> > On Tue, Jan 9, 2018 at 5:07 AM, Rostislav

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 9 January 2018 at 09:00, Hendrik Leppkes wrote: > On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes > wrote: > > On Tue, Jan 9, 2018 at 5:07 AM, Rostislav Pehlivanov > > wrote: > >> > >>> Anyway, all this discussion is moot as

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

On 1/9/18 3:05 PM, 刘歧 wrote: >>> >>> >>> I cannot sure use -cc_stream_map_ccgroup option is ok, because the ccgroup >>> string is not standard, maybe it can be defined bu user. >>> Maybe two ways: >>> 1. use -cc_stream_map_ccgroup ? this way is defined the name by ffmpeg, >>> cannot

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

>>> >> >> >> I cannot sure use -cc_stream_map_ccgroup option is ok, because the ccgroup >> string is not standard, maybe it can be defined bu user. >> Maybe two ways: >> 1. use -cc_stream_map_ccgroup ? this way is defined the name by ffmpeg, >> cannot modify. >> 2. parse the closed captions

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

On 1/9/18 2:41 PM, 刘歧 wrote: >>> >> >> If only copy command of the document, it’s ok, >> If input string by myself, It’s have problem, cannot be used. >> >> >> liuqideMacBook-Pro:xxx liuqi$ ./ffmpeg -re -f lavfi -i color=red -g 25 >> -b:v 1000k -b:a 64k -a53cc 1 -f hls -cc_stream_map >>

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

>> > > If only copy command of the document, it’s ok, > If input string by myself, It’s have problem, cannot be used. > > > liuqideMacBook-Pro:xxx liuqi$ ./ffmpeg -re -f lavfi -i color=red -g 25 -b:v > 1000k -b:a 64k -a53cc 1 -f hls -cc_stream_map > "ccgroup:cc,instreamid:CC1,language:en"

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

> On 9 Jan 2018, at 16:45, vdi...@akamai.com wrote: > > From: Vishwanath Dixit > > --- > doc/muxers.texi | 37 +++ > libavformat/dashenc.c | 2 +- > libavformat/hlsenc.c | 155 +- >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes wrote: > On Tue, Jan 9, 2018 at 5:07 AM, Rostislav Pehlivanov > wrote: >> >>> Anyway, all this discussion is moot as Hendrik pointed out that profile >>> can't be set outside of lavc to determine a decoder

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: closed caption tags in the master playlist

On 12/29/17 5:35 PM, Steven Liu wrote: > 2017-12-29 19:58 GMT+08:00 Dixit, Vishwanath : >> >> On 12/29/17 5:11 PM, Steven Liu wrote: >>> 2017-12-29 18:44 GMT+08:00 : From: Vishwanath Dixit --- doc/muxers.texi

[FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

From: Vishwanath Dixit --- doc/muxers.texi | 37 +++ libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 155 +- libavformat/hlsplaylist.c | 5 +- libavformat/hlsplaylist.h | 3 +- 5 files changed,

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 9, 2018 at 5:07 AM, Rostislav Pehlivanov wrote: > >> Anyway, all this discussion is moot as Hendrik pointed out that profile >> can't be set outside of lavc to determine a decoder behavior. >> > > What, based on a comment in lavc? Comments there describe the api