Re: [FFmpeg-devel] [PATCH 4/4] lavc/cbs_h2645: fix no slice data trigger the assert.

2018-05-12 Thread James Almer
On 5/12/2018 8:07 PM, Mark Thompson wrote: > On 11/05/18 16:38, James Almer wrote: >> On 5/11/2018 7:10 AM, Mark Thompson wrote: >>> On 11/05/18 06:11, Jun Zhao wrote: when the NALU data with zero, just give a warning. Fixes ticket #7200 Signed-off-by: Jun Zhao

Re: [FFmpeg-devel] [PATCH] avfilter: add bm3d filter

2018-05-12 Thread Michael Niedermayer
On Sat, May 12, 2018 at 09:04:44AM +0200, Paul B Mahol wrote: > On 5/12/18, Michael Niedermayer wrote: > > On Fri, May 11, 2018 at 04:03:07PM +0200, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavfilter/Makefile |1 + >

[FFmpeg-devel] [PATCH 3/5] ffserver: Implement http interface and implementation

2018-05-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- httpd.h | 58 +++ lavfhttpd.c | 153 2 files changed, 211 insertions(+) create mode 100644 httpd.h create mode 100644 lavfhttpd.c diff --git

[FFmpeg-devel] [PATCH 5/5] ffserver: Add basic documentation of the architecture

2018-05-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- Documentation.txt | 89 +++ 1 file changed, 89 insertions(+) create mode 100644 Documentation.txt diff --git a/Documentation.txt b/Documentation.txt new file mode 100644 index

[FFmpeg-devel] [PATCH 1/5] ffserver: Implement refcounted segments.

2018-05-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- segment.c | 168 ++ segment.h | 114 ++ 2 files changed, 282 insertions(+) create mode 100644 segment.c create mode 100644 segment.h

[FFmpeg-devel] [GSoC] Qualification task (?) FFserver, further implementation

2018-05-12 Thread Stephan Holljes
This version contains some fixes including: - fix compiler warning - initial fixing of muxing non-matroska files - clarify documentation unrelated but helpful for testing: - add address-sanitation to compilation As mentioned, using non-matroska files does not properly work as of now.

Re: [FFmpeg-devel] [PATCH 2/2] flvenc: Fix sequence header update timestamps

2018-05-12 Thread Michael Niedermayer
On Thu, May 10, 2018 at 06:40:08PM -0700, Alex Converse wrote: > From: Alex Converse > > --- > libavformat/flvenc.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/2] flvenc: Factorize timestamp writing

2018-05-12 Thread Michael Niedermayer
On Thu, May 10, 2018 at 06:40:07PM -0700, Alex Converse wrote: > From: Alex Converse > > The code is trivial but the semantics in the spec are ambiguous. This > should help keep parts of the muxer interpreting them consistently. > --- > libavformat/flvenc.c | 12

[FFmpeg-devel] [PATCH 2/5] ffserver: Implement publisher

2018-05-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- publisher.c | 308 publisher.h | 170 + 2 files changed, 478 insertions(+) create mode 100644 publisher.c create mode 100644 publisher.h

[FFmpeg-devel] [PATCH 4/5] ffserver: Implement ffserver and add Makefile

2018-05-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- Makefile | 19 +++ ffserver.c | 520 + 2 files changed, 539 insertions(+) create mode 100644 Makefile create mode 100644 ffserver.c diff --git a/Makefile b/Makefile new

Re: [FFmpeg-devel] [PATCH 4/5] ffserver: Implement ffserver and add Makefile

2018-05-12 Thread Stephan Holljes
On Fri, May 11, 2018 at 3:05 PM, Stephan Holljes wrote: > On Fri, May 11, 2018 at 2:49 PM, Moritz Barsnick wrote: >> On Thu, May 10, 2018 at 17:41:25 +0200, Stephan Holljes wrote: >>> +ffserver: segment.o publisher.o lavfhttpd.o ffserver.c >>> + cc

Re: [FFmpeg-devel] [PATCH 4/4] lavc/cbs_h2645: fix no slice data trigger the assert.

2018-05-12 Thread Mark Thompson
On 11/05/18 16:38, James Almer wrote: > On 5/11/2018 7:10 AM, Mark Thompson wrote: >> On 11/05/18 06:11, Jun Zhao wrote: >>> when the NALU data with zero, just give a warning. >>> >>> Fixes ticket #7200 >>> >>> Signed-off-by: Jun Zhao >>> --- >>> libavcodec/cbs_h2645.c | 6

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: moving amf common code (library and context) to lavu/hwcontext_amf from amfenc to be reused in other amf components

2018-05-12 Thread Mark Thompson
On 12/05/18 09:48, Alexander Kravchenko wrote: > This patch moves AMF common parts from amfenc to hwcontext_amf. > Now av_hwdevice_ctx API is used for AMF context creation/destroying. > This patch does not change component behaviour. > it contains only restructurization for further patches with

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: moving amf common code (library and context) to lavu/hwcontext_amf from amfenc to be reused in other amf components

2018-05-12 Thread Mark Thompson
On 11/05/18 19:37, Alexander Kravchenko wrote: > Hi Mark, > Thank you for your comments. > Could you see my comments and questions bellow > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Thursday, May 10, 2018

[FFmpeg-devel] [PATCH 2/2] libavfilter/vf_nlmeans: add amount parameter

2018-05-12 Thread Paul B Mahol
For better control of denoising. Signed-off-by: Paul B Mahol --- doc/filters.texi | 4 libavfilter/vf_nlmeans.c | 5 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index d77c67eb10..60ce18298b 100644 ---

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_nlmeans: better weighting of centered pixel

2018-05-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index 82e779ce85..6c9c9d312d 100644 --- a/libavfilter/vf_nlmeans.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_nlmeans: add parameter to control weight of centered pixel

2018-05-12 Thread Paul B Mahol
On 5/11/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_nlmeans.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > Please ignore, better patch posted. ___

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-12 Thread Rostislav Pehlivanov
On 12 May 2018 at 20:40, Paul B Mahol wrote: > On 5/12/18, Rostislav Pehlivanov wrote: > > On 1 May 2018 at 20:39, Paul B Mahol wrote: > > > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/avcodec.h | 1 + > >>

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-12 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:26, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-12 Thread Paul B Mahol
On 5/12/18, Rostislav Pehlivanov wrote: > On 1 May 2018 at 20:39, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/avcodec.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-12 Thread Rostislav Pehlivanov
On 1 May 2018 at 20:39, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/avcodec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index fb0c6fae70..3a8f69243c 100644 > ---

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: require 90% of a file to be mp3 if only 1 mp3 frame is found in sequence

2018-05-12 Thread Aman Gupta
On Sat, May 12, 2018 at 9:33 AM, Michael Niedermayer wrote: > This eliminates several low score detections of non mp3 files > Thanks for working on this. Spurious mp3 detection has been a real headache. Aman > > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: require 90% of a file to be mp3 if only 1 mp3 frame is found in sequence

2018-05-12 Thread Michael Niedermayer
This eliminates several low score detections of non mp3 files Signed-off-by: Michael Niedermayer --- libavformat/mp3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index d419f8c9fe..ef884934e1 100644

[FFmpeg-devel] [PATCH 4/5] avformat/mp3dec: Require 50% of the file to be mp3 frames in the maxframes>200 probing test

2018-05-12 Thread Michael Niedermayer
This corrects several misdetections of large files Signed-off-by: Michael Niedermayer --- libavformat/mp3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index a26714ebaf..d419f8c9fe 100644 ---

[FFmpeg-devel] [PATCH 1/5] avformat/tty: Remove .txt from the extensions as it more likely is not a multimedia related file

2018-05-12 Thread Michael Niedermayer
Iam not sure if this is a good idea or not but it may make some attacks harder. So throwing this out for discussions ... Signed-off-by: Michael Niedermayer --- libavformat/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tty.c

[FFmpeg-devel] [PATCH 3/5] avformat/mp3dec: Require probing data to be 50% mp3 frames for low score probing to succeed

2018-05-12 Thread Michael Niedermayer
This massively reduces the detection of random data as low score mp3 It may improve security by making it harder to read non multimedia data Signed-off-by: Michael Niedermayer --- libavformat/mp3dec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[FFmpeg-devel] [PATCH 2/5] avformat/bintext: Reduce detection for random .bin files as it more likely is not a multimedia related file

2018-05-12 Thread Michael Niedermayer
Iam not sure if this is a good idea or not but it may make some attacks harder. So throwing this out for discussions ... Signed-off-by: Michael Niedermayer --- libavformat/bintext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/bintext.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashenc: Added option for Segment file format

2018-05-12 Thread Jan Ekström
On Fri, May 4, 2018 at 9:32 AM, Karthick J wrote: > From: Karthick Jeyapal > > Right now segment file format is chosen to be either mp4 or webm based on the > codec format. > This patch makes that choice configurable by the user, instead of being >

Re: [FFmpeg-devel] [RFC][PATCH] configure: Disable unsafe demuxers by default

2018-05-12 Thread Michael Niedermayer
On Fri, May 11, 2018 at 12:14:47AM +0100, Derek Buitenhuis wrote: > > please correct me if iam wrong, theres quite a bit iam guessing here > > IIUC the problem is that in your usecase > > 1. ffmpeg has access to sensitive files > > 2. one of these files can be opened by an attacker with ffmpeg > >

[FFmpeg-devel] [PATCH] avfilter: add bm3d filter

2018-05-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 86 libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/vf_bm3d.c| 1077 ++ 4 files changed, 1165 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH] lavc/amfenc: moving amf common code (library and context) to lavu/hwcontext_amf from amfenc to be reused in other amf components

2018-05-12 Thread Alexander Kravchenko
This patch moves AMF common parts from amfenc to hwcontext_amf. Now av_hwdevice_ctx API is used for AMF context creation/destroying. This patch does not change component behaviour. it contains only restructurization for further patches with new amf components --- Sending updated patch based on

Re: [FFmpeg-devel] [PATCH] avfilter: add bm3d filter

2018-05-12 Thread Paul B Mahol
On 5/12/18, Michael Niedermayer wrote: > On Fri, May 11, 2018 at 04:03:07PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/Makefile |1 + >> libavfilter/allfilters.c |1 + >> libavfilter/vf_bm3d.c| 1002