Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

On Fri, May 18, 2018 at 04:54:25PM -0700, Wang Cao wrote: > - Make ffmpeg to output stats for each video streams and each ouptut file > ffmpeg output log in print_report. > - The report of video/audio sizes is clear as previously all output > video/audio sizes were combined to report and it is

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: create nalus without trailing bits

On Fri, May 18, 2018 at 05:19:48PM -0700, Aman Gupta wrote: > On Fri, May 18, 2018 at 4:50 PM, Aman Gupta wrote: > > > From: Aman Gupta > > > > Fixes "unknown SEI type 128" debug messages from the parser > > on https://tmm1.s3.amazonaws.com/vts.mpg > > > This

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: create nalus without trailing bits

On Fri, May 18, 2018 at 4:50 PM, Aman Gupta wrote: > From: Aman Gupta > > Fixes "unknown SEI type 128" debug messages from the parser > on https://tmm1.s3.amazonaws.com/vts.mpg This fixed SEI parsing, but now I'm seeing other parser errors on the same input:

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

- Make ffmpeg to output stats for each video streams and each ouptut file ffmpeg output log in print_report. - The report of video/audio sizes is clear as previously all output video/audio sizes were combined to report and it is unclear such stats is for one output files or aggregates for all

[FFmpeg-devel] [PATCH] avcodec/h264_parser: create nalus without trailing bits

From: Aman Gupta Fixes "unknown SEI type 128" debug messages from the parser on https://tmm1.s3.amazonaws.com/vts.mpg Signed-off-by: Aman Gupta --- libavcodec/h264_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v2] avformat/hls: Properly expose intercepted ID3 tags to the API.

From: Richard Shaffer The HLS demuxer will process any ID3 tags at the beginning of a segment in order to obtain timestamp data. However, when this data was parsed on a second or subsequent segment, the updated metadata would be discarded. This change preserves the data and

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

On Fri, May 18, 2018 at 11:17 PM, wm4 wrote: > > Other flags are also generic. For a long time, AV_PKT_FLAG_KEY was the > only flag. It applies to every codec, and is in theory not necessary > for decoding (although some decoders might read it anyway, but that's > a

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

On 18 May 2018 at 22:17, wm4 wrote: > > > But I think a new side data type would be much saner. We could even > just make it something generic, like AV_PKT_DATA_ANCILLARY or > something. It's apparently just packet data which somehow couldn't go > into the packet data. >

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

On Fri, 18 May 2018 21:59:13 +0100 Rostislav Pehlivanov wrote: > On 18 May 2018 at 21:03, wm4 wrote: > > > On Fri, 18 May 2018 20:09:02 +0100 > > Rostislav Pehlivanov wrote: > > > > > On 18 May 2018 at 20:05, Patrick Keroulas

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

On 18 May 2018 at 21:03, wm4 wrote: > On Fri, 18 May 2018 20:09:02 +0100 > Rostislav Pehlivanov wrote: > > > On 18 May 2018 at 20:05, Patrick Keroulas < > > patrick.kerou...@savoirfairelinux.com> wrote: > > > > > > > > - Original Message - > >

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

On Fri, 18 May 2018 20:09:02 +0100 Rostislav Pehlivanov wrote: > On 18 May 2018 at 20:05, Patrick Keroulas < > patrick.kerou...@savoirfairelinux.com> wrote: > > > > > - Original Message - > > > From: "Rostislav Pehlivanov" > > > To: "FFmpeg

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

On 18 May 2018 at 20:05, Patrick Keroulas < patrick.kerou...@savoirfairelinux.com> wrote: > > - Original Message - > > From: "Rostislav Pehlivanov" > > To: "FFmpeg development discussions and patches" < > ffmpeg-devel@ffmpeg.org> > > Sent: Tuesday, May 15, 2018

Re: [FFmpeg-devel] [PATCH] avformat/hls: Properly expose intercepted ID3 tags to the API.

On Fri, 18 May 2018 11:54:52 -0700 Richard Shaffer wrote: > On Fri, May 18, 2018 at 2:54 AM, wm4 wrote: > > > On Thu, 17 May 2018 20:49:42 -0700 > > rshaf...@tunein.com wrote: > > > > > From: Richard Shaffer > > > > > > The

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

On Fri, May 18, 2018 at 10:43 AM, Aman Gupta wrote: > > > On Fri, May 18, 2018 at 10:28 AM, Devin Heitmueller < > dheitmuel...@kernellabs.com> wrote: > >> > The issue is that the PMT PID advertised in the PAT contains multiple >> PMTs >> > for different programs. This is because

Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets with top/bottom field

- Original Message - > From: "Rostislav Pehlivanov" > To: "FFmpeg development discussions and patches" > Sent: Tuesday, May 15, 2018 4:46:02 PM > Subject: Re: [FFmpeg-devel] [PATCH v6 1/3] avcodec: add flags for packets > with top/bottom

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vc1: FIELDTX is only coded raw in interlaced frame I pictures

> 2018-05-18 17:06 GMT+02:00, Jerome Borsboom : > >> This patch set solves various issues that affected the SA10180.vc1 >> test file. With these patches applied, this file decodes bitequal to >> the Intel VAAPI decoder on Haswell. > > I still see artefacts beginning after ~22 seconds that are

Re: [FFmpeg-devel] [PATCH] avformat/hls: Properly expose intercepted ID3 tags to the API.

On Fri, May 18, 2018 at 2:54 AM, wm4 wrote: > On Thu, 17 May 2018 20:49:42 -0700 > rshaf...@tunein.com wrote: > > > From: Richard Shaffer > > > > The HLS demuxer will process any ID3 tags at the beginning of a segment > in > > order to obtain

[FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

From: Aman Gupta These fields will allow the mpegts demuxer to expose details about the PMT/program which created the AVProgram and its AVStreams. In mpegts, a PMT which advertises streams has a version number which can be incremented at any time. When the version changes, the

[FFmpeg-devel] [PATCH v4 2/3] avformat/mpegts: keep track of PMT details in AVProgram/AVStream

From: Aman Gupta With these fields, the user has enough information to detect PMT changes and switch to new streams when the PMT is updated with new ES pids. To do so, the user would monitor the AVProgram they're interested in for changes to pmt_version. If the version changes,

[FFmpeg-devel] [PATCH v4 3/3] avformat/mpegts: add merge_pmt_versions option

From: Aman Gupta This new optional flag makes it easier to deal with mpegts samples where the PMT is updated and elementary streams move to different PIDs in the middle of playback. Previously, new AVStreams were created per PID, and it was up to the user to figure out which

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

On Fri, May 18, 2018 at 10:28 AM, Devin Heitmueller < dheitmuel...@kernellabs.com> wrote: > > The issue is that the PMT PID advertised in the PAT contains multiple > PMTs > > for different programs. This is because the broadcaster decided to re-use > > the same PID for multiple program PMTs. > >

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

> The issue is that the PMT PID advertised in the PAT contains multiple PMTs > for different programs. This is because the broadcaster decided to re-use > the same PID for multiple program PMTs. Ugh, ok. I understand the case you're talking about now. Thanks for clarifying. > To be clear, this

Re: [FFmpeg-devel] [FFmpeg-cvslog] checkasm: add vf_nlmeans test for ssd_integral_image

On Thu, May 10, 2018 at 02:10:00AM +0200, Michael Niedermayer wrote: > On Tue, May 08, 2018 at 08:29:00AM +, Clément Bœsch wrote: > > ffmpeg | branch: master | Clément Bœsch | Sun May 6 10:57:23 > > 2018 +0200| [f679711c1b516786a39f9e582622a200502fff74] | committer: Clément >

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/vf_nlmeans: add amount parameter

On Sat, May 12, 2018 at 10:24:35PM +0200, Paul B Mahol wrote: > For better control of denoising. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 4 > libavfilter/vf_nlmeans.c | 5 - > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_nlmeans: better weighting of centered pixel

On Sat, May 12, 2018 at 10:24:34PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_nlmeans.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c > index

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

On Fri, May 18, 2018 at 6:12 AM, Devin Heitmueller < dheitmuel...@kernellabs.com> wrote: > Hello Aman, > > On Thu, May 17, 2018 at 8:04 PM, Aman Gupta wrote: > > From: Aman Gupta > > > > Some filtered mpegts streams may erroneously include PMTs for programs > >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vc1: FIELDTX is only coded raw in interlaced frame I pictures

2018-05-18 17:06 GMT+02:00, Jerome Borsboom : > This patch set solves various issues that affected the SA10180.vc1 > test file. With these patches applied, this file decodes bitequal to > the Intel VAAPI decoder on Haswell. I still see artefacts beginning after ~22

Re: [FFmpeg-devel] Stream selection algorithm crossing program boundaries

Hi Devin, On 5/18/2018 9:17 PM, Devin Heitmueller wrote: Indeed when I dug into the code it became clear that there is added complexity when multiple input files are involved, if for no other reason than it’s not immediately clear which input stream comes from which file and hence it’s

Re: [FFmpeg-devel] Stream selection algorithm crossing program boundaries

Hello Gyan, Thanks for your comments. See inline: > On May 18, 2018, at 10:24 AM, Gyan Doshi wrote: > If nb_input_files is 1, coupling the stream selection seems to me an > improvement. But in the scenario of multiple inputs and no -map options, > users usually intend to

[FFmpeg-devel] [PATCH 2/5] avcodec/vc1: fix mquant calculation for interlace field pictures

For interlace field pictures s->mb_height indicates the height of the full picture in MBs, i.e. the two fields combined. A single field is half this size. When calculating mquant for interlace field pictures, the bottom edge is the last MB row of the field. Signed-off-by: Jerome Borsboom

[FFmpeg-devel] [PATCH 3/5] avcodec/vc1: DIRECTBIT is only present in inter MBs

DIRECTBIT was decoded before the intra/inter MB branching when decoding interlace frame B pictures. Resulting in mistakenly also decoding it for intra MBs where this syntax element is not present. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_block.c | 71

[FFmpeg-devel] [PATCH 4/5] avcodec/vc1: fix calculation of the last line of a slice

Only for the last slice of the first field is the last line of the slice equal to the height of the field. Signed-off-by: Jerome Borsboom --- libavcodec/vc1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1dec.c

[FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

Direct prediction for interlace frame B pictures references the mv in the second block in an MB in the backward reference frame for the twomv case. When the backward reference frame is an I frame, this value may be unset. Signed-off-by: Jerome Borsboom ---

[FFmpeg-devel] [PATCH 1/5] avcodec/vc1: FIELDTX is only coded raw in interlaced frame I pictures

FIELDTX bitplane is only present in interlace frame I pictures. v->fieldtx_is_raw may spill over from a previous interlaced frame I picture while decoding a non-interlace frame I picture. Signed-off-by: Jerome Borsboom --- This patch set solves various issues that

Re: [FFmpeg-devel] Stream selection algorithm crossing program boundaries

On 5/18/2018 6:50 PM, Devin Heitmueller wrote: Is this something anyone is actively looking into? If not, I'll dig into it and see about respecting program membership in ffmpeg's selection algorithm. My larger concern is that with MPEG-TS streams, the commonly accepted heuristic is to

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: add pal75bars and pal100bars video filter sources

On 18.05.2018 15:23, Paul B Mahol wrote: On 5/17/18, Tobias Rapp wrote: Generates color bar test patterns based on EBU PAL recommendations. Signed-off-by: Tobias Rapp --- Changelog| 1 + doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: add pal75bars and pal100bars video filter sources

On 5/17/18, Tobias Rapp wrote: > Generates color bar test patterns based on EBU PAL recommendations. > > Signed-off-by: Tobias Rapp > --- > Changelog| 1 + > doc/filters.texi | 10 +++- >

Re: [FFmpeg-devel] [PATCH]lavc/v210dec: Skip Canopus C210 extradata

On 17/05/18 12:20, Carl Eugen Hoyos wrote: > 2018-05-10 22:50 GMT+02:00, Carl Eugen Hoyos : > >> Peter Bubestinger provided a C210 file where every frame starts with >> 64 bytes of extradata (24 byte "INFO", 16 byte "RDRT", rest "FIEL"). >> Piotr confirmed that the Canopus

[FFmpeg-devel] Stream selection algorithm crossing program boundaries

Hello all, By default, ffmpeg will pick the "best" audio and video streams if the user doesn’t explicitly indicate such using the “-map” argument. However it completely ignores which programs streams are a part of, which can lead to cases where the video is picked from one program and the

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

Hello Aman, On Thu, May 17, 2018 at 8:04 PM, Aman Gupta wrote: > From: Aman Gupta > > Some filtered mpegts streams may erroneously include PMTs for programs > that are not advertised in the PAT. This confuses ffmpeg and most > players because multiple audio/video

Re: [FFmpeg-devel] [PATCH]configure: Support libxml2 on systems without pkg-config

Carl Eugen Hoyos (2018-05-14): > No, you have many times refused to allow them being solved. I have opposer your solutions because I think they are bad solutions and I can see a better one. I have proposed to help design said better solution, you have always declined but never given technical

Re: [FFmpeg-devel] [PATCH] cmdutils - don't search for option 'default'

On 5/18/2018 7:04 AM, Michael Niedermayer wrote: make: *** [fate-mpegts-probe-pmt-merge] Error 1 make: *** [fate-concat-demuxer-simple1-lavf-mxf_d10] Error 1 make: *** [fate-concat-demuxer-extended-lavf-mxf_d10] Error 1 make: *** [fate-concat-demuxer-simple1-lavf-mxf] Error 1 make: ***

Re: [FFmpeg-devel] [PATCH] cmdutils - don't search for option 'default'

On 5/18/2018 2:08 PM, Hendrik Leppkes wrote: You can avoid that by using a relative path to the samples. FATE does not properly quote/escape pathes for windows absolute pathes to work. That works. 0 fails. Thanks, Gyan ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

On Thu, 17 May 2018 17:21:42 -0700 Aman Gupta wrote: > On Thu, May 17, 2018 at 5:04 PM, Aman Gupta wrote: > > > From: Aman Gupta > > > > Some filtered mpegts streams may erroneously include PMTs for programs > > that are not advertised in the

Re: [FFmpeg-devel] [PATCH] avformat/hls: Properly expose intercepted ID3 tags to the API.

On Thu, 17 May 2018 20:49:42 -0700 rshaf...@tunein.com wrote: > From: Richard Shaffer > > The HLS demuxer will process any ID3 tags at the beginning of a segment in > order to obtain timestamp data. However, when this data was parsed on a second > or subsequent segment, the

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpegts: keep track of AVProgram.pmt_version and set AV_PROGRAM_CHANGED on version updates

On Thu, 17 May 2018 18:13:34 -0700 Aman Gupta wrote: > On Thu, May 17, 2018 at 3:49 PM, Aman Gupta wrote: > > > From: Aman Gupta > > > > This can be used to detect changes to the streams in an AVProgram > > > > Forgot to add: I have seen two

Re: [FFmpeg-devel] [PATCH 1/2] hevcdec: Miss the location of chroma samples when exporting stream parameters

On Fri, May 18, 2018 at 10:52 AM, Xiang, Haihao wrote: > On Thu, 2018-05-17 at 12:30 +0200, Hendrik Leppkes wrote: >> On Thu, May 17, 2018 at 8:08 AM, Xiang, Haihao >> wrote: >> > On Wed, 2018-05-16 at 11:27 +0200, Hendrik Leppkes wrote: >> > > On

Re: [FFmpeg-devel] [PATCH 1/2] hevcdec: Miss the location of chroma samples when exporting stream parameters

On Thu, 2018-05-17 at 12:30 +0200, Hendrik Leppkes wrote: > On Thu, May 17, 2018 at 8:08 AM, Xiang, Haihao wrote: > > On Wed, 2018-05-16 at 11:27 +0200, Hendrik Leppkes wrote: > > > On Wed, May 16, 2018 at 10:49 AM, Xiang, Haihao > > > wrote: > > >

Re: [FFmpeg-devel] [PATCH] cmdutils - don't search for option 'default'

On Thu, May 17, 2018 at 1:10 PM, Gyan Doshi wrote: > > Of these, 10 failed (and have always failed) because of avformat_open_file > errors. Since I'm running this in MSYS2, > > '/ffmpeg/fate-suite/folder/samplefile' > > gets translated to > >

Re: [FFmpeg-devel] [PATCH v3] configure: error out on unsupported MSVC versions

2018-05-18 3:40 GMT+02:00, Rostislav Pehlivanov : > Pushed, thanks I believe you forgot the requested entry in the Changelog. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-18 3:41 GMT+02:00, Rostislav Pehlivanov : > Pushed, thanks > Its a bittersweet victory, took 3 years but its finally done. Is it possible that you don't see that a "victory" always has a disadvantage? Carl Eugen ___