Re: [FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

On Wed, Sep 19, 2018 at 7:07 PM Michael Niedermayer wrote: > > On Tue, Sep 18, 2018 at 09:37:29PM +0800, Jun Zhao wrote: > > Fixes ticket #7441. > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/vf_deshake.c | 12 +++- > > 1 files changed, 7 insertions(+), 5 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] lavc/mpeg2dec: fix MPEG2 VA-API interlace decoding issue.

On Mon, Sep 17, 2018 at 8:00 PM Hendrik Leppkes wrote: > > On Mon, Sep 17, 2018 at 1:22 PM Jun Zhao wrote: > > > > From: Jun Zhao > > > > For interlaced frame, it has to call slice_end() for both fields. And > > VASliceParameterBufferMPEG2::slice_vertical_position is supposed to be > > the

Re: [FFmpeg-devel] [PATCH 09/10] doc/examples/vaapi_transcode: Fix the typo

On Thu, Sep 20, 2018 at 12:08 AM Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > --- > doc/examples/vaapi_transcode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c > index

Re: [FFmpeg-devel] FFmpeg 4.1

On Wed, Sep 19, 2018 at 10:31:19PM +0200, Marton Balint wrote: > > > On Fri, 14 Sep 2018, Michael Niedermayer wrote: > > >Hi all > > > >its almost 5 months since 4.0 so its time to make a new release. > > > >Are there any suggestions for a name ? > >If not ill pick something from unused past

[FFmpeg-devel] [PATCH] avcodec/unary: Improve get_unary() docs

Found-by: kierank Signed-off-by: Michael Niedermayer --- libavcodec/unary.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/unary.h b/libavcodec/unary.h index 908dc93507..e7541a7604 100644 --- a/libavcodec/unary.h +++ b/libavcodec/unary.h @@ -28,7 +28,12 @@

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dvdsubdec: Sanity check len in decode_rle()

On Thu, Sep 13, 2018 at 04:24:50AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 9778/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVDSUB_fuzzer-5186007132536832 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4videodec: Check rice_prefix_code

On Sat, Sep 15, 2018 at 02:08:21AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 10064/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5766801384800256 > Fixes: > 10225/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5071833448054784 >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Fix undefined shift in get_amv()

On Sat, Sep 15, 2018 at 02:08:22AM +0200, Michael Niedermayer wrote: > Fixes: runtime error: shift exponent -1 is negative > Fixes: > 9938/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5653783529914368 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pcx: Check for end of input in pcx_rle_decode() and propagate error

On Sun, Sep 16, 2018 at 02:27:37AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 10279/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PCX_fuzzer-5729311395414016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 02/10] avcodec/av1_parse: Fix bistream typo

On Wed, Sep 19, 2018 at 01:14:07PM -0300, James Almer wrote: > On 9/19/2018 1:05 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/av1_parse.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/av1_parse.h

Re: [FFmpeg-devel] FFmpeg 4.1

On Fri, 14 Sep 2018, Michael Niedermayer wrote: Hi all its almost 5 months since 4.0 so its time to make a new release. Are there any suggestions for a name ? If not ill pick something from unused past suggestions. If there are no objections i will likely make that release in the next

[FFmpeg-devel] [PATCH]lavf/matroskadec: Simplify string length calculation slightly

Hi! Attached patch removes useless sizeof's, we require sizeof(char)==1 afaict. Please comment, Carl Eugen From 8384c2097976ce8546d1b73ce822851a6f608813 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 3 Sep 2018 14:18:02 +0200 Subject: [PATCH] lavf/matroskadec: Simplify string length

Re: [FFmpeg-devel] [PATCH] avcodec: [loongson] optimize get_cabac_inline.

On Tue, Sep 18, 2018 at 10:59:41AM +0800, Shiyou Yin wrote: > This optimization improved h264 decoding performance about 4%(from 74fps to > 77fps, tested on loongson 3A3000). > --- > libavcodec/cabac_functions.h | 3 ++ > libavcodec/mips/cabac.h | 119 >

Re: [FFmpeg-devel] [V2 PATCH 2/3] avfilter/dnn_backend_native: fix invalid free

Pushed, Thanks! 2018-09-18 23:55 GMT-03:00 Zhao Zhili : > --- > libavfilter/dnn_backend_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_ > native.c > index 184fe54..7dd35d46 100644 > ---

Re: [FFmpeg-devel] [V2 PATCH 1/3] avfilter/vf_sr: fix read out of bounds

Pushed, Thanks! 2018-09-18 23:55 GMT-03:00 Zhao Zhili : > --- > libavfilter/vf_sr.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c > index 8a77a1d..c1ae6c5 100644 > --- a/libavfilter/vf_sr.c > +++ b/libavfilter/vf_sr.c

Re: [FFmpeg-devel] [V2 PATCH 3/3] avfilter/dnn_backend_native: fix memleak

Pushed, thanks! 2018-09-18 23:55 GMT-03:00 Zhao Zhili : > --- > libavfilter/dnn_backend_native.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_ > native.c > index 7dd35d46..70d857f 100644 > ---

Re: [FFmpeg-devel] [PATCH 02/10] avcodec/av1_parse: Fix bistream typo

On 9/19/2018 1:05 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/av1_parse.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/av1_parse.h b/libavcodec/av1_parse.h > index 0de619dbec..276af33ba9 100644 > ---

Re: [FFmpeg-devel] [PATCH]lavd/dshow: Interpret negative height as bottom-down frame

2018-09-19 0:44 GMT+02:00, Michael Niedermayer : > On Tue, Sep 18, 2018 at 12:36:39AM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch was tested by the reporter of ticket #7436. >> >> Please comment, Carl Eugen > >> dshow.c |4 >> 1 file changed, 4 insertions(+) >>

Re: [FFmpeg-devel] [PATCH]lavf/webvttenc: Always write hours in timestamps with two characters

2018-09-17 19:16 GMT+02:00, Reto Kromer : > Carl Eugen Hoyos wrote: > >>Attached patch fixes ticket #7442 for me. > > LGTM Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 09/10] doc/examples/vaapi_transcode: Fix the typo

Signed-off-by: Michael Niedermayer --- doc/examples/vaapi_transcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c index 6f0cf9d258..279d20f636 100644 --- a/doc/examples/vaapi_transcode.c +++

[FFmpeg-devel] [PATCH 10/10] avcodec/speedhq: Make speedhq_vlc const

Signed-off-by: Michael Niedermayer --- libavcodec/speedhq.c | 73 +--- 1 file changed, 34 insertions(+), 39 deletions(-) diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c index 6d3487ca19..890b8253cd 100644 --- a/libavcodec/speedhq.c +++

[FFmpeg-devel] [PATCH 03/10] avformat/movenc: Remove unneeded variable from mov_find_codec_tag()

Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6b9c012bc6..33978ee1b0 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1611,8 +1611,6

[FFmpeg-devel] [PATCH 06/10] libavcodec/v4l2_buffers.h: fix cant typos

Signed-off-by: Michael Niedermayer --- libavcodec/v4l2_buffers.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v4l2_buffers.h b/libavcodec/v4l2_buffers.h index dc5cc9e267..7a57caf949 100644 --- a/libavcodec/v4l2_buffers.h +++ b/libavcodec/v4l2_buffers.h @@

[FFmpeg-devel] [PATCH 08/10] avfilter/vf_tonemap_opencl: Fix seperate typo

Signed-off-by: Michael Niedermayer --- libavfilter/vf_tonemap_opencl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_tonemap_opencl.c b/libavfilter/vf_tonemap_opencl.c index 5da2333169..cd293c2522 100644 --- a/libavfilter/vf_tonemap_opencl.c +++

[FFmpeg-devel] [PATCH 01/10] libavformat/ty: use decimal constant for shift

This was the only case in the source that uses a hexadecimal shift value. The change removed a special case in respect to greping Signed-off-by: Michael Niedermayer --- libavformat/ty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ty.c b/libavformat/ty.c index

[FFmpeg-devel] [PATCH 07/10] avcodec/vc1_loopfilter: Fix colums typos

Signed-off-by: Michael Niedermayer --- libavcodec/vc1_loopfilter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc1_loopfilter.c b/libavcodec/vc1_loopfilter.c index d43fa5b3ae..0f990cccef 100644 --- a/libavcodec/vc1_loopfilter.c +++

[FFmpeg-devel] [PATCH 04/10] avfilter/af_aiir: Remove l from %lf in av_log environment

The l modifier does nothing in C99 and it was undefined in C89 for %f Signed-off-by: Michael Niedermayer --- libavfilter/af_aiir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_aiir.c b/libavfilter/af_aiir.c index 9a4769c25f..845d542d29 100644 ---

[FFmpeg-devel] [PATCH 05/10] avfilter/af_biquads: Remove l from %lf in av_log environment

The l modifier does nothing in C99 and it was undefined in C89 for %f Signed-off-by: Michael Niedermayer --- libavfilter/af_biquads.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 56d3035d77..ae5e1c6ade 100644 ---

[FFmpeg-devel] [PATCH 02/10] avcodec/av1_parse: Fix bistream typo

Signed-off-by: Michael Niedermayer --- libavcodec/av1_parse.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1_parse.h b/libavcodec/av1_parse.h index 0de619dbec..276af33ba9 100644 --- a/libavcodec/av1_parse.h +++ b/libavcodec/av1_parse.h @@ -61,7 +61,7 @@

[FFmpeg-devel] [PATCH 2/3] avformat/movenc: add mov_write_int_metadata()

Converted from mov_write_int8_metadata(), allowing to also write 16-bit and 32-bit integer atoms, at up to 32-bit total size. Converted mov_write_int8_metadata() into a macro specifying a truncation of one byte length. Signed-off-by: Moritz Barsnick --- libavformat/movenc.c | 22

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: use mov_write_int_metadata() in place of mov_write_tmpo_tag()

Removes code duplication. Signed-off-by: Moritz Barsnick --- libavformat/movenc.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 0bb66e5fd1..52f661e061 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 1/3] avformat/movenc: allow padding to two bytes in mov_write_int8_metadata()

Padding to four bytes was already possible. This is in preparation for being able to also write 16-bit integer atoms (and other currently unneeded scenarios). Signed-off-by: Moritz Barsnick --- libavformat/movenc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH 0/3] avformat/movenc: refactor to avoid code duplication

While mov_write_tmpo_tag() had code to write a 16-bit integer atom, mov_write_int8_metadata() had code to write 8-bit and 32-bit integer atoms with an 8-bit value. Both functions were extremely similar though. Consolidated the two in three steps, preserving mov_write_int8_metadata()'s constraints

[FFmpeg-devel] [PATCH 2/2] avformat/mov: parse tmpo atom

It is assigned to the "tmpo" metadatakey, which may be incorrect, but corresponds to the key used by avformat/movenc. Signed-off-by: Moritz Barsnick --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 03c39d0e5d..095d5f8f3c

[FFmpeg-devel] [PATCH 1/2] avformat/mov: add mov_metadata_int16()

Allows to read 16-bit integer atoms (currently only tmpo known to be such). Signed-off-by: Moritz Barsnick --- libavformat/mov.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ec57a05803..03c39d0e5d 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH 0/2] avformat/mov: add support for parsing tmpo atom

Adds mov_metadata_int16() for parsing 16-bit integer atoms, and a corresponding call in mov_read_udta_string. The atom's value is mapped to the "tmpo" metadata key, which is the same one as used by avformat/movenc. I couldn't find a concise doc about what it should map to.

Re: [FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

On Tue, Sep 18, 2018 at 09:37:29PM +0800, Jun Zhao wrote: > Fixes ticket #7441. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_deshake.c | 12 +++- > 1 files changed, 7 insertions(+), 5 deletions(-) this doesnt look correct the blocks that will be used are not going out of

[FFmpeg-devel] [PATCH v2] http connect: retry few times before reporting about error

This should be an AVOption instead of a hardcoded number. I didn't change mechanism of attempts: there was attempts variable for auth with magical max attempts constant 3, I just add open attempts with the same 3 max attempts... Regards, Artjom.

Re: [FFmpeg-devel] [PATCH v4 29/38] vaapi_encode: Support configurable slices

On Tue, Sep 18, 2018 at 11:31:07PM +0100, Mark Thompson wrote: > This adds common code to query driver support and set appropriate > address/size information for each slice. It only supports rectangular > slices for now, since that is the most common use-case. > > Also immediately use that to

Re: [FFmpeg-devel] [PATCH v4 12/38] vaapi_encode_h26[45]: Make the AUD option a boolean

On Wed, Sep 19, 2018 at 6:33 AM Mark Thompson wrote: > > --- > libavcodec/vaapi_encode_h264.c | 2 +- > libavcodec/vaapi_encode_h265.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c > index