Re: [FFmpeg-devel] [PATCH 2/2] avdevice/sdl2 : add option to set window position

2018-10-01 Thread Gyan
On Tue, Oct 2, 2018 at 2:47 AM Dave Rice wrote: > Allows arrangement of multiple windows such as: > ffmpeg -re -f lavfi -i mandelbrot -f sdl -window_x 1 -window_y 1 > mandelbrot -vf waveform,format=yuv420p -f sdl -window_x 641 -window_y 1 > waveform -vf vectorscope,format=yuv420p -f sdl

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rasc: Fix off by 1 error in vertical coordinate

2018-10-01 Thread Michael Niedermayer
On Tue, Oct 02, 2018 at 03:04:51AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 10311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-4856330905452544 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH 3/3] avcodec/rasc: unref both frames on reinit

2018-10-01 Thread Michael Niedermayer
Fixes: integer overflow Fixes: inconsistent frame dimensions Fixes: 10454/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5656301162463232 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/3] avcodec/tiff: check remaining packet size for strips

2018-10-01 Thread Michael Niedermayer
Fixes: Timeout Fixes: 10280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5676217211027456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 4 +++- 1 file changed, 3

[FFmpeg-devel] [PATCH 2/3] avcodec/rasc: Fix off by 1 error in vertical coordinate

2018-10-01 Thread Michael Niedermayer
Fixes: out of array read Fixes: 10311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-4856330905452544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rasc.c | 6 +++--- 1 file

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: options to specify window position

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Dave Rice wrote: From 14d6833b564bd672613d50ecc4c3ede1768eee37 Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Mon, 1 Oct 2018 17:07:44 -0400 Subject: [PATCH 1/2] ffplay: options to specify window position --- fftools/ffplay.c | 10 +- 1 file changed, 9

Re: [FFmpeg-devel] [PATCH] lavfi/vf_colorconstancy: add weighted_greyedge

2018-10-01 Thread Moritz Barsnick
On Mon, Oct 01, 2018 at 18:02:19 +0200, Mina wrote: > >> +The power applied to the weight map to emphasis heigher weights. Must be > >> chosen > >^ emphasize > > British spelling but done. Your call, but "emphasis" was wrong either way, because that's

[FFmpeg-devel] [PATCH 2/2] avdevice/sdl2 : add option to set window position

2018-10-01 Thread Dave Rice
Allows arrangement of multiple windows such as: ffmpeg -re -f lavfi -i mandelbrot -f sdl -window_x 1 -window_y 1 mandelbrot -vf waveform,format=yuv420p -f sdl -window_x 641 -window_y 1 waveform -vf vectorscope,format=yuv420p -f sdl -window_x 1 -window_y 481 vectorscop From

[FFmpeg-devel] [PATCH 1/2] ffplay: options to specify window position

2018-10-01 Thread Dave Rice
From 14d6833b564bd672613d50ecc4c3ede1768eee37 Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Mon, 1 Oct 2018 17:07:44 -0400 Subject: [PATCH 1/2] ffplay: options to specify window position --- fftools/ffplay.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Paul B Mahol
On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 10/1/18, Marton Balint wrote: >>> >>> >>> On Mon, 1 Oct 2018, Paul B Mahol wrote: >>> On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 10/1/18,

Re: [FFmpeg-devel] [PATCH 2/5] avformat/segment: fix segment_time_delta option min/max value

2018-10-01 Thread Paul B Mahol
On 9/30/18, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/segment.c b/libavformat/segment.c > index 7fb4dc7d21..e2ac2c3a7f 100644 > --- a/libavformat/segment.c > +++

Re: [FFmpeg-devel] [PATCH 3/5] avutil/opt: check for minimum and maximum values when setting AV_OPT_TYPE_DURATION fields

2018-10-01 Thread Paul B Mahol
On 9/30/18, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/opt.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 99282605f5..93d6c26c11 100644 > --- a/libavutil/opt.c > +++

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18,

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Paul B Mahol
On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 10/1/18, Marton Balint wrote: >>> >>> >>> On Mon, 1 Oct 2018, Paul B Mahol wrote: >>> On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 10/1/18,

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 9/30/18,

Re: [FFmpeg-devel] Unsupported video format

2018-10-01 Thread Paul B Mahol
On 10/1/18, John Duchek wrote: > I think I found a video format that is not supported that would be > useful (particularly for amateur astronomers) to be supported. > When taking webcam type photos of the moon and planets, these people > have moved away from avi files, and are using .ser files. >

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-10-01 Thread Jacob Trimble
On Mon, Sep 17, 2018 at 2:35 PM Jacob Trimble wrote: > > On Wed, Sep 12, 2018 at 11:50 AM Michael Niedermayer > wrote: > > > > On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > > > [...] > > > > > > So how about, when we see an encrypted frame, we flush the parser > > > before

[FFmpeg-devel] Unsupported video format

2018-10-01 Thread John Duchek
I think I found a video format that is not supported that would be useful (particularly for amateur astronomers) to be supported. When taking webcam type photos of the moon and planets, these people have moved away from avi files, and are using .ser files. My understanding of this comes from:

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Alex Sukhanov
On Sun, Sep 30, 2018 at 2:09 PM Jan Ekström wrote: > Sn Sun, Sep 30, 2018 at 8:56 PM wrote: > > > > ... > > +if (st->codecpar->codec_id == AV_CODEC_ID_H264) { > > +if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && > > + (AV_RB24(pkt->data) !=

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Paul B Mahol
On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 10/1/18, Marton Balint wrote: >>> >>> >>> On Mon, 1 Oct 2018, Paul B Mahol wrote: >>> On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 9/30/18,

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 9/30/18, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/af_afade.c |

[FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread alx . sukhanov
From: Alex Sukhanov --- libavformat/ivfenc.c | 50 +--- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 66441a2a43..6410828533 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c

Re: [FFmpeg-devel] [PATCH v2] avcodec: libdav1d AV1 decoder wrapper.

2018-10-01 Thread Kyle Swanson
Hi, On Sun, Sep 30, 2018 at 5:08 PM James Almer wrote: > From: Ronald S. Bultje > > Originally written by Ronald S. Bultje, with fixes, optimizations and > improvements by James Almer. > > Signed-off-by: James Almer > --- > Updated with some refactoring and to use a few new public facing

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-10-01 Thread James Almer
On 9/26/2018 10:45 AM, Dave Rice wrote: > >> On Sep 12, 2018, at 11:56 AM, Sigríður Regína Sigurþórsdóttir >> wrote: >> >> On Thu, Sep 6, 2018 at 3:31 PM James Almer > > wrote: >>> >>> On 9/6/2018 4:18 PM, James Darnley wrote: On 2018-09-06 19:39, Sigríður Regína

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Paul B Mahol
On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 10/1/18, Marton Balint wrote: >>> >>> >>> On Mon, 1 Oct 2018, Paul B Mahol wrote: >>> On 9/30/18, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/af_afade.c | 4 ++--

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Paul B Mahol wrote: On 10/1/18, Marton Balint wrote: On Mon, 1 Oct 2018, Paul B Mahol wrote: On 9/30/18, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/af_afade.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Why? Value is too

[FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-10-01 Thread Mina
Hi,   This patch was part of GSoC Color Constancy filter. It introduces an improved color constancy filter(weighted_greyedge) based on the already pushed greyedge. I'm sending it again after updating it against latest version of master. V2 changes: - fixed some spelling mistakes in

Re: [FFmpeg-devel] [PATCH] lavfi/vf_colorconstancy: add weighted_greyedge

2018-10-01 Thread Mina
On 10/01/2018 12:24 PM, Moritz Barsnick wrote: +The standard deviation of Gaussian blur to be applied on the scene. Must be ^ to Done. +The power applied to the weight map to emphasis heigher weights. Must be chosen

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/f_cue: use inlink fifo for queueing frames

2018-10-01 Thread Nicolas George
Marton Balint (2018-09-30): > Signed-off-by: Marton Balint > --- > libavfilter/f_cue.c | 87 > ++--- > 1 file changed, 29 insertions(+), 58 deletions(-) LGTM. It would have been slightly easier to read with symbolic constants for status, but

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/filters: add ff_inlink_peek_frame and ff_inlink_queued_frames to access frames in the inlink fifo

2018-10-01 Thread Nicolas George
Marton Balint (2018-09-30): > Signed-off-by: Marton Balint > --- > libavfilter/avfilter.c | 13 + > libavfilter/filters.h | 14 ++ > 2 files changed, 27 insertions(+) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index 85eff0aa1d..9e4b8e5ca3 100644

Re: [FFmpeg-devel] [PATCH 2/2] lavu/qsv: make a copy as libmfx alignment requirement for uploading

2018-10-01 Thread Maxym Dmytrychenko
On Sun, Sep 30, 2018 at 11:14 AM Zhong Li wrote: > Libmfx requires 16 bytes aligned input/output for uploading. > Currently only output is 16 byte aligned and assigning same width/height to > input with smaller buffer size actually, thus definitely will cause > segment fault. > > Can reproduce

Re: [FFmpeg-devel] [PATCH 1/2] lavu/qsv: fix a random hwupload failure regression

2018-10-01 Thread Maxym Dmytrychenko
On Sun, Sep 30, 2018 at 11:14 AM Zhong Li wrote: > Variable 'ret' hasn't been initialized,thus introducing a random > hwupload failure regression due to qsv session uninitialized. > > Signed-off-by: Zhong Li > --- > libavutil/hwcontext_qsv.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Paul B Mahol
On 10/1/18, Nicolas George wrote: > Paul B Mahol (2018-10-01): >> Same is given with AVERROR_BUG, instead of hard crashing with assert, >> which is >> very unprofessional. > > A program crashing seems very professional to me. The most professional > program ever, windows, has a long history of

Re: [FFmpeg-devel] [PATCH] lavfi/vf_colorconstancy: add weighted_greyedge

2018-10-01 Thread Moritz Barsnick
> +The standard deviation of Gaussian blur to be applied on the scene. Must be ^ to > +The power applied to the weight map to emphasis heigher weights. Must be > chosen ^ emphasize > +The angular

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Nicolas George
Paul B Mahol (2018-10-01): > Same is given with AVERROR_BUG, instead of hard crashing with assert, which is > very unprofessional. A program crashing seems very professional to me. The most professional program ever, windows, has a long history of crashing. Fortunately, FFmpeg is not a

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Paul B Mahol
On 10/1/18, Marton Balint wrote: > > > On Mon, 1 Oct 2018, Paul B Mahol wrote: > >> On 9/30/18, Marton Balint wrote: >>> Signed-off-by: Marton Balint >>> --- >>> libavfilter/af_afade.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >> >> Why? >> >> Value is too big. > >

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Gyan wrote: On Mon, Oct 1, 2018 at 2:15 AM Marton Balint wrote: +{ "duration", "set cross fade duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0. }, 0, 6000, FLAGS }, +{ "d","set cross fade duration", OFFSET(duration),

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Marton Balint
On Mon, 1 Oct 2018, Paul B Mahol wrote: On 9/30/18, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/af_afade.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Why? Value is too big. AV_OPT_TYPE_DURATION is microsecond precision, therefore 60 is 60 usecs.

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Paul B Mahol
On 9/30/18, Nicolas George wrote: > Paul B Mahol (2018-09-30): >> > For consistency within a single function, an assert is the correct >> > choice. >> No, it is not. Asserts do not add any consistency. > > Asserts do not add consistency indeed. Their purpose is to check > consistency, which is

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/af_afade: fix crossfade duration maximum value

2018-10-01 Thread Paul B Mahol
On 9/30/18, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/af_afade.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Why? Value is too big. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org