Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

On 10/24/2018 5:25 PM, Martin Vignali wrote: > New patch in attach > > 001 : remove dead comment, add av_packet_make_writable > 002 : change the test to use md5 and didn't use ffprobe. Also change color > property > > I will try to add prores to cbs later. Any tips for this ? Grab one of the

[FFmpeg-devel] [PATCH 0/2] Fix error handle if av_image_fill_pointers fail

av_image_fill_pointers will return a negative error code in case of failure, so we use the error code in the caller. Jun Zhao (2): lavc/decode: Fix the error number report if av_image_fill_pointers fail. lavu/frame: Add error report if av_image_fill_pointers fail. libavcodec/decode.c |

[FFmpeg-devel] [PATCH 1/2] lavc/decode: Fix the error number report if av_image_fill_pointers fail.

-1 will be map to error number "EPERM", and will be map to the error message like "Error while decoding stream #0:0: Operation not permitted", it's a strange error message when debug update_frame_pool fail, now only return the error code from av_image_fill_pointers in case of

[FFmpeg-devel] [PATCH 2/2] lavu/frame: Add error report if av_image_fill_pointers fail.

Add error handle if av_image_fill_pointers fail. Signed-off-by: Jun Zhao --- libavutil/frame.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 92626dc..9b3fb13 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

Re: [FFmpeg-devel] [PATCH 2/2] flvdec: Add an option for exporting unknown metadata packets as opaque data

On Sat, Oct 27, 2018 at 09:22:18PM +0300, Martin Storsjö wrote: > On Sat, 27 Oct 2018, Michael Niedermayer wrote: > > >On Thu, Oct 25, 2018 at 03:59:17PM +0300, Martin Storsjö wrote: > >>--- > >> libavformat/flv.h| 1 + > >> libavformat/flvdec.c | 21 + > >> 2 files

[FFmpeg-devel] [PATCH v3 6/6] lavc/h265_profile_level: Add new profiles

Monochrome 10 and Main 10 Still Picture profiles are added by the 2018 version of the standard. --- libavcodec/h265_profile_level.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/h265_profile_level.c b/libavcodec/h265_profile_level.c index

[FFmpeg-devel] [PATCH v3 4/6] h265_metadata: Add option to set the level of the stream

--- doc/bitstream_filters.texi | 9 +++ libavcodec/Makefile| 2 +- libavcodec/h265_metadata_bsf.c | 136 + 3 files changed, 146 insertions(+), 1 deletion(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index

[FFmpeg-devel] [PATCH v3 5/6] lavc/h265_profile_level: Add unit test

Operates in the same way as the h264-levels test. --- libavcodec/Makefile| 1 + libavcodec/tests/h265_levels.c | 297 + tests/fate/libavcodec.mak | 5 + 3 files changed, 303 insertions(+) create mode 100644 libavcodec/tests/h265_levels.c diff

[FFmpeg-devel] [PATCH v3 2/6] lavc/h265_profile_level: Fix DPB size calculation

The maxDpbPicBuf value which is used in the DPB size calculation depends on the profile (it's usually 6, but 7 for screen-extended profiles). --- libavcodec/h265_profile_level.c | 86 - libavcodec/h265_profile_level.h | 1 + 2 files changed, 44 insertions(+), 43

[FFmpeg-devel] [PATCH v3 3/6] lavc/h265_profile_level: Do not allow high tier at level < 4

--- libavcodec/h265_profile_level.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavcodec/h265_profile_level.c b/libavcodec/h265_profile_level.c index 692252bb4d..126f8dbc2a 100644 --- a/libavcodec/h265_profile_level.c +++

[FFmpeg-devel] [PATCH v3 1/6] fate/libavcodec: Fix config dependency of h264-levels test

--- tests/fate/libavcodec.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index aa4c36b112..5dde1243fa 100644 --- a/tests/fate/libavcodec.mak +++ b/tests/fate/libavcodec.mak @@ -46,7 +46,7 @@ fate-dct8x8:

[FFmpeg-devel] [PATCH 4/4] cbs_h265: Add a lot more SEI parsing support

Supports both prefix and suffix SEI, decoding all of the common SEI types and some more obscure ones. Most of this is tested by the existing tests in fate. --- libavcodec/cbs_h2645.c| 20 +- libavcodec/cbs_h265.h | 124 +++

[FFmpeg-devel] [PATCH 2/4] cbs_h265: Add PTL parsing for Main 10 Still Picture profile

This was added in the 2018 version of the standard. --- libavcodec/cbs_h265_syntax_template.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index d4e4f7b1c2..e43f3caf99 100644 ---

[FFmpeg-devel] [PATCH 1/4] cbs_h264: Include SEI type names in trace output

--- libavcodec/cbs_h264_syntax_template.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/cbs_h264_syntax_template.c b/libavcodec/cbs_h264_syntax_template.c index 9e29132fec..dbf9ff1268 100644 --- a/libavcodec/cbs_h264_syntax_template.c +++

[FFmpeg-devel] [PATCH 3/4] cbs_h265: Add PTL parsing for sublayers

With fate test using the SLPPLP_A_VIDYO_2 conformance file, which contains two sublayers with full PTL information. --- libavcodec/cbs_h265.h| 26 +- libavcodec/cbs_h265_syntax_template.c| 60 ++-- tests/fate/cbs.mak | 3

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-27 20:50 GMT+02:00, Mark Thompson : > This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. > > The additional braces cause build errors with Linux headers earlier > than 4.5 because the first element of the structure was not originally > a union. > Not sure what compiler was

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

On 10/27/2018 5:52 PM, James Zern wrote: > a thread count of 0 is treated the same as 1, use av_cpu_count() to get > the correct thread count when auto threads is requested. > > this matches the fix in libvpxenc: > 27df34bf1f avcodec/libvpxenc: fix setting amount of threads used for encoding > >

[FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

a thread count of 0 is treated the same as 1, use av_cpu_count() to get the correct thread count when auto threads is requested. this matches the fix in libvpxenc: 27df34bf1f avcodec/libvpxenc: fix setting amount of threads used for encoding Signed-off-by: James Zern --- libavcodec/libvpxdec.c

Re: [FFmpeg-devel] [PATCH 1/2] avutil/pixdesc: Add av_write_image_line2(), av_read_image_line2()

On Fri, Oct 26, 2018 at 12:33:00AM +0200, Michael Niedermayer wrote: > This is needed because of 32bit float formats (which are difficult to > store in 16bits) > > This also fixes undefined behavior found by fate > > Signed-off-by: Michael Niedermayer > --- > doc/APIchanges

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_vp9: keep track of reference frames

On 10/27/2018 4:28 PM, Mark Thompson wrote: > On 26/10/18 23:07, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_vp9.h | 13 + >> libavcodec/cbs_vp9_syntax_template.c | 40 +--- >> 2 files changed, 49 insertions(+), 4

[FFmpeg-devel] [PATCH] cbs_vp9: Ensure that reserved zero bits are actually zero

--- On 27/10/18 20:26, James Almer wrote: > On 10/27/2018 4:13 PM, James Almer wrote: >> On 10/27/2018 4:11 PM, Mark Thompson wrote: >>> On 26/10/18 20:37, James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs_vp9_syntax_template.c | 1 + 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_vp9: keep track of reference frames

On 26/10/18 23:07, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_vp9.h | 13 + > libavcodec/cbs_vp9_syntax_template.c | 40 +--- > 2 files changed, 49 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/cbs_vp9.h

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_vp9: fix parsing sRGB samples

On 10/27/2018 4:13 PM, James Almer wrote: > On 10/27/2018 4:11 PM, Mark Thompson wrote: >> On 26/10/18 20:37, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavcodec/cbs_vp9_syntax_template.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git

[FFmpeg-devel] [PATCH] avfilter: add (a)graphmonitor filter(s)

Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/f_graphmonitor.c | 272 +++ 3 files changed, 276 insertions(+) create mode 100644 libavfilter/f_graphmonitor.c diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_vp9: fix parsing sRGB samples

On 10/26/2018 6:56 PM, Hendrik Leppkes wrote: > On Fri, Oct 26, 2018 at 9:37 PM James Almer wrote: >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_vp9_syntax_template.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/cbs_vp9_syntax_template.c >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_vp9: fix parsing sRGB samples

On 10/27/2018 4:11 PM, Mark Thompson wrote: > On 26/10/18 20:37, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_vp9_syntax_template.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/cbs_vp9_syntax_template.c >>

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix parsing frame_size_with_refs

On 10/27/2018 3:54 PM, Mark Thompson wrote: > On 27/10/18 01:38, James Almer wrote: >> found_ref is not a single value in the bitstream. Fixes parsing files with >> frame size changes. >> >> Based on code from cbs_vp9. >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1.h

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_vp9: fix parsing sRGB samples

On 26/10/18 20:37, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_vp9_syntax_template.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/cbs_vp9_syntax_template.c > b/libavcodec/cbs_vp9_syntax_template.c > index 0db0f52a6d..b4a7f65e85 100644 > ---

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

On 27/10/18 19:56, James Almer wrote: > On 10/27/2018 3:50 PM, Mark Thompson wrote: >> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. >> >> The additional braces cause build errors with Linux headers earlier >> than 4.5 because the first element of the structure was not originally

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

James Almer (2018-10-27): > > Not sure what compiler was warning about these, but it's definitely > > incorrect for it to do so. Maybe an old gcc? Recent gcc should > > have this fixed - see > > . > Clang seems to do it as well. See >

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix parsing frame_size_with_refs

On 27/10/18 01:38, James Almer wrote: > found_ref is not a single value in the bitstream. Fixes parsing files with > frame size changes. > > Based on code from cbs_vp9. > > Signed-off-by: James Almer > --- > libavcodec/cbs_av1.h | 2 +- > libavcodec/cbs_av1_syntax_template.c |

Re: [FFmpeg-devel] [PATCH] libaomenc: Add support for tiles

On 10/22/2018 7:40 PM, Mark Thompson wrote: > Adds an option to specify the number of tile rows and columns, then uses > a uniform tiling if possible and otherwise a fixed tiling with equal-sized > tiles to fill the frame. > > Also adds -tile-columns and -tile-rows options to make tilings with >

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

On 10/27/2018 3:50 PM, Mark Thompson wrote: > This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. > > The additional braces cause build errors with Linux headers earlier > than 4.5 because the first element of the structure was not originally > a union. > --- > Not sure what compiler

[FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. The additional braces cause build errors with Linux headers earlier than 4.5 because the first element of the structure was not originally a union. --- Not sure what compiler was warning about these, but it's definitely incorrect for

Re: [FFmpeg-devel] [PATCH v2 1/5] vaapi_encode: Support configurable slices

On 23/10/18 00:06, Mark Thompson wrote: > On 25/09/18 02:40, myp...@gmail.com wrote: >> On Mon, Sep 24, 2018 at 5:53 AM Mark Thompson wrote: >>> >>> This adds common code to query driver support and set appropriate >>> address/size information for each slice. It only supports rectangular >>>

Re: [FFmpeg-devel] [PATCH 2/2] flvdec: Add an option for exporting unknown metadata packets as opaque data

On Sat, 27 Oct 2018, Michael Niedermayer wrote: On Thu, Oct 25, 2018 at 03:59:17PM +0300, Martin Storsjö wrote: --- libavformat/flv.h| 1 + libavformat/flvdec.c | 21 + 2 files changed, 18 insertions(+), 4 deletions(-) [...] @@ -1290,6 +1302,7 @@ static const

Re: [FFmpeg-devel] [PATCH 2/2] flvdec: Add an option for exporting unknown metadata packets as opaque data

On Thu, Oct 25, 2018 at 03:59:17PM +0300, Martin Storsjö wrote: > --- > libavformat/flv.h| 1 + > libavformat/flvdec.c | 21 + > 2 files changed, 18 insertions(+), 4 deletions(-) [...] > @@ -1290,6 +1302,7 @@ static const AVOption options[] = { > {

Re: [FFmpeg-devel] [PATCH 1/2] flvdec: Rename FLV_STREAM_TYPE_DATA into FLV_STREAM_TYPE_SUBTITLE

On Thu, Oct 25, 2018 at 03:59:16PM +0300, Martin Storsjö wrote: > This is always treated as a subtitle at the moment anyway. > --- > libavformat/flv.h| 2 +- > libavformat/flvdec.c | 8 > 2 files changed, 5 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

Do you know which spec the contains the eratta for top channels? There doesn't seem to be much of value in Amd.6. Do you have any real examples of a multichannel stream with a top center speaker or any supporting documentation you could point me at? Hi The relevant spec is ISO/IEC

Re: [FFmpeg-devel] Initialize DirectShow source filters with IFileSourceFilter::Load

On Fri, Sep 21, 2018 at 3:19 PM Maxim Ershtein wrote: > > Hello, > > ffmpeg allows capturing a/v from custom DirectShow source filters, and > provides some methods to pass parameters to these filters, but these > methods seem insufficient. > > So ffmpeg offers to launch a filter configuration

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve XMA missing samples

> You can set final number of samples in output frame directly: > frame->nb_samples = X. I was told I shouldn't do that (even though other codecs do it?). I quote: >> No, this is wrong. Codecs don't need to do this manually, this is done by >> libavcodec/decode.c, based on the packet's

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve XMA missing samples

On 10/27/18, bananaman...@gmail.com wrote: > From: bnnm > > Writes missing (delay) samples after EOF. > > Signed-off-by: bnnm > --- > libavcodec/wmaprodec.c | 35 --- > 1 file changed, 32 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/wmaprodec.c