From: hwrenx
Signed-off-by: hwrenx
---
libavcodec/libdavs2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c
index 37635bb..a714213 100644
--- a/libavcodec/libdavs2.c
+++ b/libavcodec/libdavs2.c
@@ -205,7 +205,7 @@ AVCodec
greetings!
after commit 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 temp_file functionality
totally broken.
attached patch prototype will fix:
1) while assigning 'use_temp_file' addressing to '->flags' is done incorrectly
in 4 places.
2) before that commit playlist was always created via .tmp
On Thu, Dec 13, 2018 at 11:18:22PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavformat/nutdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you
> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote:
>
>
>
>>> 在 2018年12月12日，上午5:08，Ronak 写道：
>>>
>>>
>>> On Dec 11, 2018, at 3:28 PM, Gyan wrote:
>>>
>>>
On 12-12-2018 01:13 AM, Ronak wrote:
Looks like I found out why:
On Fri, Dec 14, 2018 at 6:18 AM Paul B Mahol wrote:
>
> Signed-off-by: Paul B Mahol
> ---
> libavformat/nutdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
> index 27440c88d4..9910ffe936 100644
> ---
Hi
replying to a comment from IRC here because "durandal_1707 has quit" so it
wouldnt be seen, and might be interresting for others so not mailing private
michaelni: nut does not take into consideration duration of
last frame to return real duration
michaelni: so duration is always smaller by
Signed-off-by: Paul B Mahol
---
libavformat/nutdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
index 27440c88d4..9910ffe936 100644
--- a/libavformat/nutdec.c
+++ b/libavformat/nutdec.c
@@ -582,7 +582,7 @@ static int
Chromium fuzzing produced a whacky file with extra tkhds. This caused
an AVStream that was already in use to be corrupted by assigning it a
new id, which blows up later in mov_read_trun because the
MOVFragmentStreamInfo.index_entry now points OOB.
---
libavformat/mov.c | 12 +++-
1 file
On Thu, 13 Dec 2018, Nicolas George wrote:
Marton Balint (2018-12-09):
Seeking will only work in the special case I provided in the commit message,
when we always seek back to the beginning and otherwise read the referenced
files continously.
In theory, when we are in "seekable" state then
> But if the ID isn't coming from a tkhd (either because none exits, or
because you have truns before the tkhd appears), perhaps we can consider
invalid.
Taking a closer look at the spec, I think it actually _is valid_ to have
truns before tkhd. They "strongly recommend" that the header boxes
>
> "st->id" is not necessary for demuxing AFAIK, please correct me if Im
> wrong.
> Would an init value to -1 for st->id work ?
>
st->id does get used here and there. For ex, mov_read_trun reads the id to
decide which stream corresponds to the current fragment. But if the ID
isn't coming from a
Hey guys,
> On Dec 13, 2018, at 11:40 AM, Chris Cunningham
> wrote:
>
>> I have at least 2 files which have a id of 0
>> Iam not sure where they are from so iam not sure i can share them
Does Quicktime play them ? If not they are broken files.
> This was my fear as well. Also, we currently
On 12/13/2018 4:15 PM, Paul B Mahol wrote:
> Fixes #5028.
>
> Signed-off-by: Paul B Mahol
> ---
> libavformat/flac_picture.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c
> index 38982b960d..6698d4ea6a 100644
> ---
> I have at least 2 files which have a id of 0
> Iam not sure where they are from so iam not sure i can share them
This was my fear as well. Also, we currently default the ID for a new
stream to be the number of streams now in the list. I worried that some
files may lack a tkhd or could be
avio_read may return EOF, leaving the mimetype array unitialized. fail
early when this occurs to avoid using the array in an unitialized state.
---
libavformat/id3v2.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index
>
> Yet another problem that could have been caught by static analysis..
> Wouldn't it be better to always leave the array in a valid state?
>
Will add that in the next patch. It has the extra benefit of protecting the
isv34 branch.
Goto fail; skips a lot of lines that aren't needed if mimetype
Fixes #5028.
Signed-off-by: Paul B Mahol
---
libavformat/flac_picture.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c
index 38982b960d..6698d4ea6a 100644
--- a/libavformat/flac_picture.c
+++ b/libavformat/flac_picture.c
@@ -20,6
Marton Balint (2018-12-09):
> Seeking will only work in the special case I provided in the commit message,
> when we always seek back to the beginning and otherwise read the referenced
> files continously.
>
> In theory, when we are in "seekable" state then if we detect a duration
> change we
On Thu, Dec 13, 2018 at 03:34:18PM +0100, Tomas Härdin wrote:
> ons 2018-12-12 klockan 19:55 +0100 skrev Michael Niedermayer:
> > On Wed, Dec 12, 2018 at 01:25:15PM +0100, Tomas Härdin wrote:
> > > ons 2018-12-12 klockan 00:05 +0100 skrev Michael Niedermayer:
> > > > On Mon, Dec 10, 2018 at
ons 2018-12-12 klockan 19:55 +0100 skrev Michael Niedermayer:
> On Wed, Dec 12, 2018 at 01:25:15PM +0100, Tomas Härdin wrote:
> > ons 2018-12-12 klockan 00:05 +0100 skrev Michael Niedermayer:
> > > On Mon, Dec 10, 2018 at 12:32:51PM +0100, Tomas Härdin wrote:
> > > >
> > > > @@ -491,6 +501,28 @@
ons 2018-12-12 klockan 19:26 +0100 skrev Paul B Mahol:
> Fixes #4140.
>
> > Signed-off-by: Paul B Mahol
> ---
> libavformat/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 93e588ee1e..7afef545fe 100644
> ---
tor 2018-12-13 klockan 03:16 +0100 skrev Michael Niedermayer:
> Fixes:
> 11696/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO5_fuzzer-5740319635668992
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael
ons 2018-12-12 klockan 18:59 -0800 skrev chcunningham:
> avio_read may return EOF, leaving the mimetype array unitialized. fail
> early when this occurs to avoid using the array in an unitialized state.
> ---
> libavformat/id3v2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
On 12/12/18, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/codec_desc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Will apply set ASAP.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Use bprint API instead.
Fixes #4833.
Signed-off-by: Paul B Mahol
---
libavformat/ffmetadec.c | 57 +
1 file changed, 52 insertions(+), 5 deletions(-)
diff --git a/libavformat/ffmetadec.c b/libavformat/ffmetadec.c
index 3290b3b7bc..6f7133e389 100644
---
On 12/13/18, Michael Niedermayer wrote:
> On Wed, Dec 12, 2018 at 08:08:53PM -0800, Baptiste Coudurier wrote:
>> Hi,
>>
>> > On Dec 12, 2018, at 6:53 PM, chcunningham
>> > wrote:
>> >
>> > Chromium fuzzing produced a whacky file with extra tkhds. This caused
>> > an AVStream that was already in
Use bprint API instead.
Fixes #4833.
Signed-off-by: Paul B Mahol
---
libavformat/ffmetadec.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/libavformat/ffmetadec.c b/libavformat/ffmetadec.c
index 3290b3b7bc..5427e67c54 100644
---
On Wed, Dec 12, 2018 at 08:08:53PM -0800, Baptiste Coudurier wrote:
> Hi,
>
> > On Dec 12, 2018, at 6:53 PM, chcunningham wrote:
> >
> > Chromium fuzzing produced a whacky file with extra tkhds. This caused
> > an AVStream that was already in use to be corrupted by assigning it a
> > new id,
./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt
yuv420p16le \
-f null -vframes 100 -v error -nostats -
2120 UNITS in planar1, 65393 runs,143 skips
-cpuflags 0
19157 UNITS in planar1, 65512 runs, 24 skips
9.03632 speedup, 16be similarly.
Fate passes, each
./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt
yuv420p16le \
-f null -vframes 100 -v error -nostats -
19157 UNITS in planar1, 65512 runs, 24 skips
-cpuflags 0
2120 UNITS in planar1, 65393 runs,143 skips
9.03632 speedup, 16be similarly.
Fate passes, each
On 12/13/18, Nicolas George wrote:
> Paul B Mahol (2018-12-12):
>> Signed-off-by: Paul B Mahol
>> ---
>> libavcodec/codec_desc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
>> index 4850e4fb43..73f343ce24 100644
Paul B Mahol (2018-12-12):
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/codec_desc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> index 4850e4fb43..73f343ce24 100644
> --- a/libavcodec/codec_desc.c
> +++
On 12/13/18, Moritz Barsnick wrote:
> On Wed, Dec 12, 2018 at 17:32:53 +0100, Paul B Mahol wrote:
>> Based on patch by Bjorn Roche.
> [...]
>> + * Copyright (c) 2018 Byorn Roche
>
> The second name is misspelt.
Fixed.
___
ffmpeg-devel mailing list
On 12/13/18, Moritz Barsnick wrote:
> On Wed, Dec 12, 2018 at 17:32:56 +0100, Paul B Mahol wrote:
>> -.long_name = NULL_IF_CONFIG_SMALL("GIF Animation"),
>> +.long_name = NULL_IF_CONFIG_SMALL("CompuServe Graphics
>> Interchange Format (GIF)"),
>
> Why is this string different
On Wed, Dec 12, 2018 at 17:32:56 +0100, Paul B Mahol wrote:
> -.long_name = NULL_IF_CONFIG_SMALL("GIF Animation"),
> +.long_name = NULL_IF_CONFIG_SMALL("CompuServe Graphics Interchange
> Format (GIF)"),
Why is this string different from the one in 6/6?
Moritz
On Wed, Dec 12, 2018 at 17:32:53 +0100, Paul B Mahol wrote:
> Based on patch by Bjorn Roche.
[...]
> + * Copyright (c) 2018 Byorn Roche
The second name is misspelt.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On 12/12/18, Carl Eugen Hoyos wrote:
> 2018-12-12 23:44 GMT+01:00, Paul B Mahol :
>> On 12/12/18, Carl Eugen Hoyos wrote:
>>> 2018-12-12 23:30 GMT+01:00, Paul B Mahol :
On 12/12/18, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes ticket #4553 for me.
>
> Please
37 matches
Mail list logo
