[FFmpeg-devel] [PATCH] avutil/cuda_check: Fix non-dynamic-loader implementation

2019-02-19 Thread Philip Langdale
The function typedefs we were using are only present when using the dynamic loader, which means compilation breaks for code directly using the cuda SDK. To fix this, let's just duplicate the function typedefs locally. These are not going to change. Signed-off-by: Philip Langdale ---

Re: [FFmpeg-devel] [PATCHv2 3/3] avformat/mpegtsenc: add support for service and provider names with utf8 encoding

2019-02-19 Thread Marton Balint
On Tue, 12 Feb 2019, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 88 + 1 file changed, 53 insertions(+), 35 deletions(-) Ping, will push soon. Regards, Marton diff --git a/libavformat/mpegtsenc.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] configure: libnpp is always nonfree, even with LGPL

2019-02-19 Thread Carl Eugen Hoyos
2017-03-15 23:56 GMT+01:00, Ricardo Constantino : > ffmpeg | branch: master | Ricardo Constantino | Wed Mar > 15 22:47:58 2017 +| [b409d8d4a276490cd67255fd4230ea0954bd8c50] | > committer: James Almer > > configure: libnpp is always nonfree, even with LGPL > > libnpp was erroneously grouped up

[FFmpeg-devel] [PATCH] avfilter/vf_yadif_cuda: Relicence cuda kernel to MIT

2019-02-19 Thread Philip Langdale
In practice, compiling a real-world cuda kernel requires the use of the cuda SDK and specifically involves linking in some sort of static library that implements various parts of the cuda API on the GPU side. As such, it's unclear to me whether it's even logically consistent to place the cuda

Re: [FFmpeg-devel] [PATCH] palettegen: Fill with last color, not black

2019-02-19 Thread Tomas Härdin
sön 2019-02-17 klockan 23:22 +0100 skrev Tomas Härdin: > tor 2019-01-17 klockan 11:14 +0100 skrev Michael Niedermayer: > > On Thu, Jan 17, 2019 at 09:44:47AM +0100, Clément Bœsch wrote: > > > On Wed, Jan 16, 2019 at 01:40:20PM +0100, Tomas Härdin wrote: > > > > Hi > > > > > > > > I was helping

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/zmbvenc: motion estimation improvements/bug fixes:

2019-02-19 Thread Tomas Härdin
sön 2019-02-10 klockan 17:04 +0100 skrev Tomas Härdin: > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > > - Clamp ME range to -64..63 (prevents corruption when me_range is too high) > > - Allow MV's up to *and including* the positive range limit > > - Allow out-of-edge ME by padding

[FFmpeg-devel] [PATCH 2/3] avcodec/wcmv: Copy/Init frame later

2019-02-19 Thread Michael Niedermayer
Speeds up error cases Fixes: 13132/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664190616829952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wcmv.c | 20

[FFmpeg-devel] [PATCH 1/3] avcodec/error_resilience: Use a symmetric check for skipping MV estimation

2019-02-19 Thread Michael Niedermayer
This speeds up the testcase by a factor of 4 Fixes: Timeout Fixes: 13100/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV2_fuzzer-5767533905313792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 3/3] avcodec/wcmv: Avoid copying frames if they are unchanged

2019-02-19 Thread Michael Niedermayer
Improves speed of the testcase by about a factor of 10 Fixes: Timeout Fixes: 13132/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664190616829952 Signed-off-by: Michael Niedermayer --- libavcodec/wcmv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/4] avformat/utils: be more strict about stream specifiers

2019-02-19 Thread Carl Eugen Hoyos
2019-02-18 22:43 GMT+01:00, Marton Balint : > > > On Sun, 17 Feb 2019, Carl Eugen Hoyos wrote: > >> 2019-02-17 20:55 GMT+01:00, Marton Balint : >>> This reworks the code to be more strict about accepting >>> stream specifiers. From now on we strictly enforce the >>> syntax in the documentation up

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Added comments

2019-02-19 Thread Carl Eugen Hoyos
2019-02-19 7:48 GMT+01:00, Karthick J : > +// Explanation for why certain movflags are used for streaming: I don't think this is a useful line. > +// frag_every_frame :- Every frame should be moof fragment, so Is there a smiley in the middle of the line? > +// the data from

Re: [FFmpeg-devel] FW: Requirements for compiling with CUDA_SDK option enabled

2019-02-19 Thread Carl Eugen Hoyos
2019-02-19 20:25 GMT+01:00, Soft Works : >> > From your explanations, the situation doesn't seem to be as >> > bad as it could be. When the CPU code of the filters can be >> > changed to dynamic linking >> >> The type of the linking of course cannot change the license. > > Maybe I should have said

Re: [FFmpeg-devel] FW: Requirements for compiling with CUDA_SDK option enabled

2019-02-19 Thread Philip Langdale
On 2019-02-19 11:25, Soft Works wrote: > From your explanations, the situation doesn't seem to be as > bad as it could be. When the CPU code of the filters can be > changed to dynamic linking The type of the linking of course cannot change the license. Maybe I should have said 'dynamic

Re: [FFmpeg-devel] FW: Requirements for compiling with CUDA_SDK option enabled

2019-02-19 Thread Soft Works
> > From your explanations, the situation doesn't seem to be as > > bad as it could be. When the CPU code of the filters can be > > changed to dynamic linking > > The type of the linking of course cannot change the license. Maybe I should have said 'dynamic loading' rather than 'dynamic linking'.

Re: [FFmpeg-devel] FW: Requirements for compiling with CUDA_SDK option enabled

2019-02-19 Thread Carl Eugen Hoyos
2019-02-18 22:44 GMT+01:00, Soft Works : > From your explanations, the situation doesn't seem to be as > bad as it could be. When the CPU code of the filters can be > changed to dynamic linking The type of the linking of course cannot change the license. Carl Eugen

Re: [FFmpeg-devel] FW: Requirements for compiling with CUDA_SDK option enabled

2019-02-19 Thread Soft Works
> > Thanks again for your kind reply. Although I’m not a lawyer myself, I > > know > > that if you’re the sole(!) author of the yadif_cuda kernel source, then > > you > > would be allowed to publish that code under any additional license you > > want. > > > > But that would be your very own

Re: [FFmpeg-devel] FW: Requirements for compiling with CUDA_SDK option enabled

2019-02-19 Thread Philip Langdale
On 2019-02-18 20:08, Soft Works wrote: Thanks again for your kind reply. Although I’m not a lawyer myself, I know that if you’re the sole(!) author of the yadif_cuda kernel source, then you would be allowed to publish that code under any additional license you want. But that would be your

Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-19 Thread Guillaume Desmottes
Hi James, On 19/02/2019 17:14, James Almer wrote: On 2/11/2019 1:59 PM, Guillaume Desmottes wrote: CDG doesn't ensure a constant framerate as we can have holes in the CDG stream. So there is no guarantee of the duration of a single frame, it will be displayed until a new packet with CDG

Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-19 Thread James Almer
On 2/11/2019 1:59 PM, Guillaume Desmottes wrote: > CDG doesn't ensure a constant framerate as we can have holes in the CDG > stream. So there is no guarantee of the duration of a single frame, it > will be displayed until a new packet with CDG instruction arrives in the > stream. > >

Re: [FFmpeg-devel] [PATCH v2] lavf/jacosubdec: compute subtitle duration correctly

2019-02-19 Thread Paul B Mahol
On 2/19/19, Adam Sampson wrote: > When a JACOsub subtitle has two timestamps, they represent its start and > end times (http://unicorn.us.com/jacosub/jscripts.html#l_times); the > duration is the difference between the two, not the sum of the two. > > The subtitle end times in the FATE test for

[FFmpeg-devel] [PATCH v2] lavf/jacosubdec: compute subtitle duration correctly

2019-02-19 Thread Adam Sampson
When a JACOsub subtitle has two timestamps, they represent its start and end times (http://unicorn.us.com/jacosub/jscripts.html#l_times); the duration is the difference between the two, not the sum of the two. The subtitle end times in the FATE test for this were wrong as a result; fix them too.