Re: [FFmpeg-devel] [PATCH v2 5/6] vaapi_encode: Add ROI support

2019-03-13 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, March 13, 2019 5:44 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 5/6] vaapi_encode: Add ROI support > > On 13/03/2019 02:46,

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Fāng-ruì Sòng
On Thu, Mar 14, 2019 at 10:36 AM Fāng-ruì Sòng wrote: > > On Thu, Mar 14, 2019 at 9:59 AM Henrik Gramner wrote: > > > > On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng > > wrote: > > > --- a/libavutil/mem.h > > > +++ b/libavutil/mem.h > > > > > > +#if defined(__GNUC__) && !(defined(_WIN32) ||

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Sun, Jing A
On Wed, Mar 13, 2019 at 8:29 PM Sun, Jing A wrote: > > > > On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > wrote: > > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure > in the HEVC bitstream, but supports no interface for setting the color > properties

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Vittorio Giovara
On Wed, Mar 13, 2019 at 8:29 PM Sun, Jing A wrote: > > > > On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > wrote: > > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure in > the HEVC bitstream, but supports no interface for setting the color > properties

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Fāng-ruì Sòng
On Thu, Mar 14, 2019 at 9:59 AM Henrik Gramner wrote: > > On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng > wrote: > > --- a/libavutil/mem.h > > +++ b/libavutil/mem.h > > > > +#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__)) > > +#define DECLARE_HIDDEN __attribute__

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Henrik Gramner
On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng wrote: > --- a/libavutil/mem.h > +++ b/libavutil/mem.h > > +#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__)) > +#define DECLARE_HIDDEN __attribute__ ((visibility ("hidden"))) > +#else > +#define DECLARE_HIDDEN > +#endif

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Fāng-ruì Sòng
Ping :) In short, when people build .so from ffmpeg .o/.a files, they no longer need -Bsymbolic -Bsymbolic is bad because it breaks C++ semantics, e.g. address uniqueness of inline functions and their static local variables, uniqueness of template specializations, address uniqueness of type_info

Re: [FFmpeg-devel] [PATCH v2] avformat/smoothstreamingenc:add bitrate calculate

2019-03-13 Thread Jun Li
On Tue, Mar 12, 2019 at 6:24 PM Jun Li wrote: > Hi Carl, > Thanks for review, is there any more issue I need to take care ? > or any process I need to follow before applying the patch? I am new to the > community, don't know too much. > > Thanks > -Jun > > On Mon, Mar 11, 2019 at 11:44 AM Carl

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Sun, Jing A
> On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > mailto:jing.a@intel.com>> wrote: Hi Giovara, SVT HEVC has the interface to enable/disable sending a vui structure in the HEVC bitstream, but supports no interface for setting the color properties before encoding yet. I will be opening an

[FFmpeg-devel] [PATCH] avcodec/arbc: Check nb_segments before allocating and copying frame

2019-03-13 Thread Michael Niedermayer
Fixes: Timeout (30sec -> 2sec) Fixes: 13578/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5685625527730176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/arbc.c | 15

Re: [FFmpeg-devel] [PATCH v1] avformat/rtpdec.h remove unused variable

2019-03-13 Thread Michael Niedermayer
On Wed, Mar 13, 2019 at 07:22:41AM +0800, Steven Liu wrote: > > > > On Mar 13, 2019, at 05:26, Jun Li wrote: > > > > Looks like the variable 'cur_timestamp' is not used anywhere. > > So remove this variable. > > > > Signed-off-by: Jun Li > > --- > > libavformat/rtpdec.h | 1 - > > 1 file

[FFmpeg-devel] [PATCH] Added more commandline options for libaom encoder.

2019-03-13 Thread Sam John
The following are the newly added options: arnr_max_frames, arnr_strength, aq_mode, denoise_noise_level, denoise_block_size, rc_undershoot_pct, rc_overshoot_pct, minsection_pct, maxsection_pct, frame_parallel, enable_cdef, and enable_global_motion. Also added macros for compiling for aom 1.0.0

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Vittorio Giovara
On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A wrote: > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure in > the HEVC bitstream, but supports no interface for setting the color > properties before encoding yet. I will be opening an issue in SVT HEVC >

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-13 Thread Matthew Fearnley
> On 12 Mar 2019, at 11:46, Tomas Härdin wrote: > > tis 2019-03-12 klockan 10:27 + skrev Matthew Fearnley: >>> On 11 Mar 2019, at 10:37, Tomas Härdin wrote: >>> >>> >>> There's some justification for adding sub-8bpp, like BMP. bmp.c >>> converts all of them except GRAY8 to PAL8.

Re: [FFmpeg-devel] [PATCH v6] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-03-13 Thread Michael Niedermayer
On Wed, Mar 13, 2019 at 05:54:53PM -0400, Shaofei Wang wrote: > It enabled multiple simple filter graph concurrency, which bring above about > 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration > > Below are some test cases and comparison as reference. > (Hardware platform:

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: add ability to check CRC

2019-03-13 Thread Lynne
8 Mar 2019, 17:48 by d...@lynne.ee: > > > > 7 Mar 2019, 21:18 by > mich...@niedermayer.cc > > : > >> On Wed, Mar 06, 2019 at 07:09:52PM +0100, Lynne wrote: >> >>> A lot of files have CRC included. >>> The CRC only covers 34 bytes at most from the frame but it

Re: [FFmpeg-devel] [PATCH v2 4/6] libx265: Update ROI behaviour to match documentation

2019-03-13 Thread Michael Niedermayer
On Wed, Mar 13, 2019 at 04:44:29PM +0100, Michael Niedermayer wrote: > On Wed, Mar 13, 2019 at 12:17:46AM +, Mark Thompson wrote: > > Equivalent to the previous patch for libx264. > > --- > > libavcodec/libx265.c | 42 +- > > 1 file changed, 21

Re: [FFmpeg-devel] [PATCH v2 4/6] libx265: Update ROI behaviour to match documentation

2019-03-13 Thread Michael Niedermayer
On Wed, Mar 13, 2019 at 12:17:46AM +, Mark Thompson wrote: > Equivalent to the previous patch for libx264. > --- > libavcodec/libx265.c | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) breaks build CC libavcodec/vaapi_encode.o

Re: [FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list

2019-03-13 Thread Paweł Wegner
On Mon, Mar 4, 2019 at 10:52 AM Paweł Wegner wrote: > On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner > wrote: > >> ping >> >> On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner >> wrote: >> >>> This fixes avformat_query_codec incorrectly returning 0 for >>> mov container and mov_text subtitles. >>>

Re: [FFmpeg-devel] [PATCHv2] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-13 Thread Oliver Collyer
>>> Can you explain the actual intended use-case for this? >>> >>> The current way to handle resolution changes (or any other stream change of >>> similar magnitude, like a pixel format change) is to flush the existing >>> encoder and then make a new one with the new parameters. Even ignoring

Re: [FFmpeg-devel] [PATCHv2] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-13 Thread Mark Thompson
On 13/03/2019 01:01, Oliver Collyer wrote: >> On 12 Mar 2019, at 23:40, Mark Thompson wrote: >> >>> On 08/03/2019 07:44, Oliver Collyer wrote: >>> From c704e3535f866d9f89535b9df59db9ca9811bcf9 Mon Sep 17 00:00:00 2001 >>> From: Oliver Collyer >>> Date: Fri, 8 Mar 2019 07:42:41 + >>> Subject:

Re: [FFmpeg-devel] [PATCH v2 5/6] vaapi_encode: Add ROI support

2019-03-13 Thread Mark Thompson
On 13/03/2019 02:46, Guo, Yejun wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: Wednesday, March 13, 2019 8:18 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH v2 5/6] vaapi_encode: Add

[FFmpeg-devel] [PATCH] avformat/aiffdec: parse replaygain metadata

2019-03-13 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- Tested against sample provided here: https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html libavformat/aiffdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index 7c701e0c70..ea2955816a

[FFmpeg-devel] [PATCH v6] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-03-13 Thread Shaofei Wang
It enabled multiple simple filter graph concurrency, which bring above about 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration Below are some test cases and comparison as reference. (Hardware platform: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz) (Software: Intel iHD driver -

Re: [FFmpeg-devel] [PATCHv3] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-13 Thread Oliver Collyer
>> >> >> Can you explain the actual intended use-case for this? >> >> The current way to handle resolution changes (or any other stream change of >> similar magnitude, like a pixel format change) is to flush the existing >> encoder and then make a new one with the new parameters. Even

Re: [FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add mxf user comments tests

2019-03-13 Thread Michael Niedermayer
On Tue, Mar 12, 2019 at 10:04:32PM +0100, Michael Niedermayer wrote: > On Mon, Mar 11, 2019 at 01:22:38PM -0700, mindm...@gmail.com wrote: > > From: Mark Reid > > > > --- > > tests/fate/mxf.mak | 15 ++- > > tests/ref/fate/mxf-d10-user-comments| 1 + > >

Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-13 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Zern > Sent: Wednesday, March 13, 2019 7:45 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add VP8 >

Re: [FFmpeg-devel] [PATCH 1/5] lavu/opencl: replace va_ext.h with standard name

2019-03-13 Thread Song, Ruiling
> -Original Message- > From: Song, Ruiling > Sent: Tuesday, January 22, 2019 3:16 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Song, Ruiling > Subject: [PATCH 1/5] lavu/opencl: replace va_ext.h with standard name > > Khronos OpenCL header (https://github.com/KhronosGroup/OpenCL-Headers) >

Re: [FFmpeg-devel] [PATCH v2 6/6] lavfi: addroi filter

2019-03-13 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, March 13, 2019 8:18 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2 6/6] lavfi: addroi filter > > This can be used to add region of

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Sun, Jing A
On Monday, March 11, 2019 10:50 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: >On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: >I just searched my inbox again but failed to find that email of question you >mentioned. > >Yeah I often see my mail bounced with this message: >