Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Gyan
On 20-05-2019 02:18 AM, Marton Balint wrote: On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1. Possible regression since

Re: [FFmpeg-devel] [PATCH V3] lavfi/opencl: add nlmeans_opencl filter

2019-05-19 Thread Song, Ruiling
> -Original Message- > From: Song, Ruiling > Sent: Monday, May 13, 2019 10:18 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org>; 'Mark Thompson' > Subject: RE: [FFmpeg-devel] [PATCH V3] lavfi/opencl: add nlmeans_opencl > filter > > > -Original Message- > >

Re: [FFmpeg-devel] [PATCH v2] libavcodec/vp9: fix ref-frame size judging method

2019-05-19 Thread Ronald S. Bultje
Hi, On Sun, May 19, 2019 at 7:05 PM Yan Cen wrote: > From: yancen > > There is no need all reference frame demension is valid in libvpx. > > So this change contains three part: > 1. Change each judgement's loglevel from "ERROR" to "WARNING" > 2. Make sure at least one of frames that this frame

[FFmpeg-devel] [PATCH v2] libavcodec/vp9: fix ref-frame size judging method

2019-05-19 Thread Yan Cen
From: yancen There is no need all reference frame demension is valid in libvpx. So this change contains three part: 1. Change each judgement's loglevel from "ERROR" to "WARNING" 2. Make sure at least one of frames that this frame references has valid dimension. 3. All judgements fail would

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-19 Thread Daniel Kučera
Dňa ne 19. 5. 2019, 16:14 James Almer napísal(a): > On 5/19/2019 6:43 AM, Daniel Kučera wrote: > > Dňa pi 17. 5. 2019, 21:12 Daniel Kučera > > napísal(a): > > > >> > >> > >> Dňa št 16. 5. 2019, 12:04 Daniel Kučera > >> napísal(a): > >> > >>> > >>> > >>> Dňa st 15. 5. 2019, 11:14 Daniel Kučera

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1. Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Paul B Mahol
On 5/19/19, Marton Balint wrote: > > > On Sun, 19 May 2019, Paul B Mahol wrote: > >> On 5/19/19, Marton Balint wrote: >>> Fixes infinte loop with -vf loop=loop=1. >>> >>> Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. >>> >>> Signed-off-by: Marton Balint >>> --- >>>

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1. Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton Balint --- libavfilter/f_loop.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Paul B Mahol
On 5/19/19, Marton Balint wrote: > Fixes infinte loop with -vf loop=loop=1. > > Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. > > Signed-off-by: Marton Balint > --- > libavfilter/f_loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Nicolas George
Marton Balint (12019-05-19): > loop=1 is the loop count (number of loops), not the loop size (number of > frames to loop) which is also 0 by default. Issue is present with any > nonzero loop count, 1 is just an example. Ok, thanks for explaining. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Nicolas George wrote: Marton Balint (12019-05-19): Fixes infinte loop with -vf loop=loop=1. The subject line talks about loop=0, this line about loop=1. Typo somewhere, or am I missing something? loop=1 is the loop count (number of loops), not the loop size (number

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Nicolas George
Marton Balint (12019-05-19): > Fixes infinte loop with -vf loop=loop=1. The subject line talks about loop=0, this line about loop=1. Typo somewhere, or am I missing something? Regards, -- Nicolas George signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
Fixes infinte loop with -vf loop=loop=1. Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton Balint --- libavfilter/f_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_loop.c b/libavfilter/f_loop.c index

Re: [FFmpeg-devel] [PATCH v3] avformat/utils: Use av_packet_move_ref for packet ownership transfer

2019-05-19 Thread Andriy Gelman
On Sun, 21. Apr 10:14, Andriy Gelman wrote: > From: Andriy Gelman > > During AVPacket assignment, it is currently not clear when the lhs takes > ownership of the packet. This commit replaces assignment with an > explicit av_packet_move_ref call when there is an ownership transfer to > clear the

[FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-19 Thread Marton Balint
English was used before. Signed-off-by: Marton Balint --- libavformat/movenc.c | 2 +- tests/ref/acodec/alac | 2 +- tests/ref/acodec/pcm-s16be | 2 +- tests/ref/acodec/pcm-s24be | 2 +-

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v4] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Antonin Gouzer wrote: --- Add the index of the timecode in case of multiple timecodes values Limit to 3 the number of timecodes remove break Am I reading this correctly, you'd get XML like right? The problem is that your output now looks as if the frame have 3

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-19 Thread Devin Heitmueller
Hello Phillip, On Thu, May 16, 2019 at 9:32 AM Phillip Burr wrote: > > Minimal support for ATSC PSIP tables. Does not support STT or > EIT tables and so is not compliant with terrestrial ATSC. > ATSC tables are not created by default, and will only be transmitted > if either "atsc_name" or

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-19 Thread Devin Heitmueller
Hello Paul, On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: > > On 5/17/19, Mathieu Duponchelle wrote: > > There isn't one, as I said the added indentation is because of the new loop! > > To get this committed to tree you need to comply to review requests. I think Mathieu's point is that

[FFmpeg-devel] CPIA

2019-05-19 Thread Michael Niedermayer
Hi Looking at the CPIA decoder, it seems to contain bugs, i have some fixes but CPIA being a format from V4L testing is trikier. Can someone who has the right hardware for CPIA, dump some frames into a file so people and myself can test this without special hw. Or am i missing something and this

Re: [FFmpeg-devel] [PATCH] avcodec/cpia: Check input size also against linesizes and EOL

2019-05-19 Thread Michael Niedermayer
On Sun, May 19, 2019 at 05:42:04PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (14sec -> 29ms) > Fixes: > 14733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CPIA_fuzzer-5707022445576192 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] avcodec/cpia: Check input size also against linesizes and EOL

2019-05-19 Thread Michael Niedermayer
Fixes: Timeout (14sec -> 29ms) Fixes: 14733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CPIA_fuzzer-5707022445576192 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cpia.c | 2 +- 1

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-19 Thread James Almer
On 5/19/2019 4:22 AM, Peter Ross wrote: > On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: >> On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: >>> ah, i see what you did there! it works perfectly, just missing >>> UPDATE_CACHE at the start and in the loop. >>> >>> test

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-19 Thread James Almer
On 5/19/2019 6:43 AM, Daniel Kučera wrote: > Dňa pi 17. 5. 2019, 21:12 Daniel Kučera > napísal(a): > >> >> >> Dňa št 16. 5. 2019, 12:04 Daniel Kučera >> napísal(a): >> >>> >>> >>> Dňa st 15. 5. 2019, 11:14 Daniel Kučera >>> napísal(a): >>> > > Ping. > > -- > > S

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-19 Thread Paul B Mahol
On 5/19/19, Ulf Zibis wrote: > > Am 18.05.19 um 23:48 schrieb Alexander Strasser: >> This is so sad :( >> And I am looking at both of you Nicolas and Paul. >> >> From what I know libavfilter wouldn't be anywhere near where it is today >> without you two! > +1 > >> There needs to be room for

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-19 Thread Ulf Zibis
Am 18.05.19 um 23:48 schrieb Alexander Strasser: > This is so sad :( > And I am looking at both of you Nicolas and Paul. > > From what I know libavfilter wouldn't be anywhere near where it is today > without you two! +1 > There needs to be room for discussion on the mailing list. If Nicolas >

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-19 Thread Ulf Zibis
Am 19.05.19 um 15:09 schrieb talkvi...@talkvideo.net: > Any interest in hashing this out on YouTube? Perhaps with > some live discussion? > > I can set up a call-in line, and stream the discussion live. > > Documents, code, etc can be displayed on-screen in full 1080p > so they can be read just

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-19 Thread TalkVideo
Any interest in hashing this out on YouTube? Perhaps with some live discussion? I can set up a call-in line, and stream the discussion live. Documents, code, etc can be displayed on-screen in full 1080p so they can be read just like they were on one's own desktop. Personally I think it would

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-19 Thread Daniel Kučera
Dňa pi 17. 5. 2019, 21:12 Daniel Kučera napísal(a): > > > Dňa št 16. 5. 2019, 12:04 Daniel Kučera > napísal(a): > >> >> >> Dňa st 15. 5. 2019, 11:14 Daniel Kučera >> napísal(a): >> >>> > >>> > Ping. >>> > >>> > -- >>> > >>> > S pozdravom / Best regards >>> > Daniel Kucera. >>> >>> Ping. >>>

Re: [FFmpeg-devel] [PATCH] avcodec/v210dec: Fix alignment check for AVX2

2019-05-19 Thread Michael Niedermayer
On Sat, May 18, 2019 at 01:26:01PM +0200, James Darnley wrote: > On 2019-05-18 12:15, Michael Niedermayer wrote: > > On Sat, May 18, 2019 at 12:02:55PM +0200, James Darnley wrote: > >> I object to the commit message though because it isn't a "null pointer > >> dereference" but if that is the error

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-19 Thread Peter Ross
On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: > On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: > > ah, i see what you did there! it works perfectly, just missing > > UPDATE_CACHE at the start and in the loop. > > > > test results on i7 decoding 3 minute long 4k