Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-20 Thread Jacob Siddall
> doesnt apply with git > > Applying: avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation > Using index info to reconstruct a base tree... > error: patch failed: libavformat/rtpdec_rfc4175.c:206 > error: libavformat/rtpdec_rfc4175.c: patch does not apply > error: Did you hand

[FFmpeg-devel] [PATCH v2] vf_drawtext documentation additions and correction

2019-06-20 Thread greg Luce
Split this patch off since it just deals with documentation for features already present in the code. Hope I formatted everything correctly! Gyan and kepstin helped write the documentation 0001-vf_drawtext documentation additions and correction.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] vf_drawtext documentation additions and correction

2019-06-20 Thread greg Luce
> > +A 1 character description of the current packet's picture type. > > packet --> frame. You know I was thinking about that. I'll change and resubmit ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265: fix valid range of num_tile_{columns, rows}_minus1 in H265RawPPS

2019-06-20 Thread Gyan
On 20-06-2019 11:15 PM, James Almer wrote: The spec states they can't be higher than the respective dimensions of the stream in CTBs. Signed-off-by: James Almer --- I don't think it's wise further limiting the range to the maximum currently defined for level 6.2 using those two HEVC_

[FFmpeg-devel] [PATCH] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-06-20 Thread James Almer
As defined in section F.14.2.8 and F.14.3.8 Signed-off-by: James Almer --- https://trac.ffmpeg.org/attachment/ticket/7965/puppets_with_alpha_hevc.mov libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h265.h | 12 + libavcodec/cbs_h265_syntax_template.c | 37

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-20 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 06:21:53AM +, Jacob Siddall wrote: > The previous calculation code did not account for the fact that the > copy_offset for the start of the frame array is at index 0, yet the > scan line number from the rfc4175 RTP header starts at 1. > This caused 2 issues to appear: >

[FFmpeg-devel] [PATCH 6/7] avcodec/alsdec: Fix another integer overflow in INTERLEAVE_OUTPUT()

2019-06-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 41582592 * 256 cannot be represented in type 'int' Fixes: 15296/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5739558227935232 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 3/7] avcodec/alsdec: Fix integer overflow with buffer number

2019-06-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 65313 * 65313 cannot be represented in type 'int' Fixes: 15290/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5738074249625600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 5/7] avcodec/alsdec: Add FF_CODEC_CAP_INIT_CLEANUP

2019-06-20 Thread Michael Niedermayer
Fixes: multiple memleaks Fixes: 15293/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5642409288925184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 7/7] avcodec/4xm: Fix vlc memleak

2019-06-20 Thread Michael Niedermayer
Fixes: memleak Fixes: 15297/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5746203548975104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/4xm.c | 1 + 1 file changed, 1

[FFmpeg-devel] [PATCH 2/7] avcodec/alsdec: Fixes signed integer overflow in LSB addition

2019-06-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 8 * 536870912 cannot be represented in type 'int' Fixes: 15281/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5744458785619968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/7] avcodec/alsdec: Fix invalid shift in multiply()

2019-06-20 Thread Michael Niedermayer
Fixes: shift exponent -24 is negative Fixes: 15292/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5768533318828032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 3

[FFmpeg-devel] [PATCH 1/7] avcodec/alsdec: Check opt_order / sb_length in ra_block handling

2019-06-20 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120 Fixes: 15280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5741062137577472 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH] vp4: prevent unaligned memory access in loop filter

2019-06-20 Thread Peter Ross
VP4 applies a loop filter during motion compensation, causing the block offset will often by unaligned. This produces a bus error on some platforms, namely ARMv7 NEON. This patch adds a unaligned version of the loop filter function pointer to VP3DSPContext. Reported-by: Mike Melanson ---

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-20 Thread Chris Cunningham
On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: > On 2/26/2019 10:18 PM, Chris Cunningham wrote: > > On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham > > mailto:chcunning...@chromium.org>> wrote: > > > > I'm fine to do either. James, do you still prefer to skip the later > > headers

Re: [FFmpeg-devel] [PATCH] libavcodec: Reduce the size of some arrays

2019-06-20 Thread James Almer
On 6/19/2019 4:08 PM, Michael Niedermayer wrote: > On Wed, Jun 19, 2019 at 04:39:47AM +0200, Andreas Rheinhardt wrote: >> This commit uses smaller types for some static const arrays to reduce >> their size in case the entries can be represented in the smaller type. >> The biggest savings came from

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265: fix valid range of num_tile_{columns, rows}_minus1 in H265RawPPS

2019-06-20 Thread James Almer
The spec states they can't be higher than the respective dimensions of the stream in CTBs. Signed-off-by: James Almer --- I don't think it's wise further limiting the range to the maximum currently defined for level 6.2 using those two HEVC_ defines, since a stream could in theory go beyond them

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h265: fix valid range of column_{width, height}_minus1 in H265RawPPS

2019-06-20 Thread James Almer
The spec states they are in units of CTBs. Signed-off-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index d2a20ddb35..571c9d3544

Re: [FFmpeg-devel] [PATCH] vf_drawtext documentation additions and correction

2019-06-20 Thread Gyan
On 20-06-2019 09:44 PM, greg Luce wrote: Split this patch off since it just deals with documentation for features already present in the code. Hope I formatted everything correctly! Gyan and kepstin helped write the documentation > +A 1 character description of the current packet's picture

[FFmpeg-devel] [PATCH] vf_drawtext documentation additions and correction

2019-06-20 Thread greg Luce
Split this patch off since it just deals with documentation for features already present in the code. Hope I formatted everything correctly! Gyan and kepstin helped write the documentation 0001-vf_drawtext documentation additions and correction.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: Consider frame_size in ra_block handling

2019-06-20 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 06:06:29PM +0200, Thilo Borgmann wrote: > Am 20.06.19 um 16:17 schrieb Michael Niedermayer: > > Fixes: out of array access > > Fixes: > > 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/h265_profile_level: Fix DPB size calculation

2019-06-20 Thread James Almer
On 6/2/2019 1:48 PM, Mark Thompson wrote: > On 06/05/2019 22:02, Mark Thompson wrote: >> The maxDpbPicBuf value which is used in the DPB size calculation depends >> on the profile (it's usually 6, but 7 for screen-extended profiles). >> --- >> libavcodec/h265_profile_level.c | 86

[FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-20 Thread greg Luce
Info at https://trac.ffmpeg.org/ticket/7947 C code in file 0001, documentation and version tick in file 0002 Documentation written with help from Gyan and Moritz Barsnick Documentation patch has info in what I hope is the commit message

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: Consider frame_size in ra_block handling

2019-06-20 Thread Thilo Borgmann
Am 20.06.19 um 16:17 schrieb Michael Niedermayer: > Fixes: out of array access > Fixes: > 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH] avcodec/alsdec: Consider frame_size in ra_block handling

2019-06-20 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 9 + 1

[FFmpeg-devel] [PATCH V1] lavfi/normalize: improve the performance

2019-06-20 Thread Jun Zhao
From: Jun Zhao Remove unnecessary max value found, it's will improve the performance about 10%. Used the test command like: ffmpeg -i 1080P.mp4 -an -vf normalize -f null /dev/null, the FPS change from 96fps to 107fps. Signed-off-by: Jun Zhao --- libavfilter/vf_normalize.c |7 +++ 1

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix muxing tmcd tracks in MOV

2019-06-20 Thread Gyan
On 20-06-2019 10:01 AM, Gyan wrote: On 18-06-2019 07:39 PM, Gyan wrote: Fixes crash when muxing tmcd tracks. Will push soon. Pushed as 91f5950f833fd48f12de769374129334f8c6b237 Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] movenc: calculate track_duration without packet duration

2019-06-20 Thread Alfred E. Heggestad
On 19/06/2019 15:36, Derek Buitenhuis wrote: On 19/06/2019 06:43, Gyan wrote: setting track_duration is inconsistent; some times it includes duration and some times not. It may be best to check the commits for these assignments to see if the inconsistency is deliberate. The track duration is

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-20 Thread Alfred E. Heggestad
On 20/06/2019 05:19, Jeyapal, Karthick wrote: On 6/19/19 3:08 PM, Alfred E. Heggestad wrote: On 19/06/2019 07:21, Jeyapal, Karthick wrote: On 6/18/19 1:48 PM, Alfred E. Heggestad wrote: On 18/06/2019 04:02, Steven Liu wrote: Alfred E. Heggestad 于2019年6月17日周一 下午4:02写道: From

Re: [FFmpeg-devel] [PATCH v1] lavf/mov: Fix timestamp rescale on sidx atom

2019-06-20 Thread Jun Li
On Tue, May 21, 2019 at 1:05 AM Jun Li wrote: > > > On Thu, May 16, 2019 at 1:00 AM Jun Li wrote: > >> >> >> On Sun, May 12, 2019 at 7:44 PM Jun Li wrote: >> >>> >>> >>> On Fri, May 10, 2019 at 7:25 PM Jun Li wrote: >>> On Thu, May 9, 2019 at 2:08 AM Jun Li wrote: > Fix

[FFmpeg-devel] [PATCH] avformat/hlsenc: better checking var_stream_map content

2019-06-20 Thread Bodecs Bela
Dear All, When multiple variant streams are specified by var_stream_map option, implementation assumes that each elementary stream is assigned only once to any variant. But this is not checked currently. But 2nd and further instances of same elementary source streams are silently neglected

[FFmpeg-devel] [PATCH v3] avfilter/vaapi: add overlay_vaapi filter

2019-06-20 Thread Zachary Zhou
--- configure | 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vaapi_vpp.c| 95 + libavfilter/vaapi_vpp.h| 5 + libavfilter/vf_overlay_vaapi.c | 365 + 6 files

Re: [FFmpeg-devel] [FFmpeg-cvslog] av_format/hlsenc: fix %v handling by format_name function

2019-06-20 Thread Bodecs Bela
2019.06.20. 5:11 keltezéssel, Liu Steven írta: 在 2019年6月20日,上午1:37,Michael Niedermayer 写道: On Wed, Jun 19, 2019 at 10:03:51AM +, Bodecs Bela wrote: ffmpeg | branch: master | Bodecs Bela | Mon Jun 17 23:05:21 2019 +0200| [09a4853930e7950f423e9161004871afe659ed84] | committer: Steven

Re: [FFmpeg-devel] [PATCH v2] avfilter/vaapi: add overlay_vaapi filter

2019-06-20 Thread Zhou, Zachary
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > myp...@gmail.com > Sent: Wednesday, June 19, 2019 9:21 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter/vaapi: add overlay_vaapi >

Re: [FFmpeg-devel] [PATCH v3] vf_drawtext - Add variables

2019-06-20 Thread Carl Eugen Hoyos
Am 20.06.2019 um 00:01 schrieb greg Luce : >> Who has written the patch that you attached? >> >> Thank you, Carl Eugen > > The C code was written by kepstin > I wrote the change to the documentation with help from several people > There's a trac ticket at https://trac.ffmpeg.org/ticket/7947

[FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-20 Thread Jacob Siddall
The previous calculation code did not account for the fact that the copy_offset for the start of the frame array is at index 0, yet the scan line number from the rfc4175 RTP header starts at 1. This caused 2 issues to appear: - The first scan line was being copied into the array where the second