Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-18 Thread Thilo Borgmann
Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > There seems to be no limit in the specification and upto 64k could be stored > 64 is chooses as limit as thats also used for AAC and is what a int64 mask > can handle > > An alternative to this patch would be a max_channels variable There's a

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/alsdec: Fix integer overflow in decode_var_block_data()

2019-08-18 Thread Thilo Borgmann
Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > Fixes: signed integer overflow: 1927975249 - -514719744 cannot be represented > in type 'int' > Fixes: > 16413/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5651206856245248 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v17 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-18 Thread Sun, Jing A
-Original Message- From: Sun, Jing A Sent: Monday, August 19, 2019 1:55 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v17 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper Fixed memleak. Regards, Sun, Jing

[FFmpeg-devel] [PATCH v17 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-18 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 497 +++

[FFmpeg-devel] [PATCH v17 2/2] doc: Add libsvt_hevc encoder docs

2019-08-18 Thread Jing Sun
Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jing Sun --- doc/encoders.texi | 149 ++ doc/general.texi | 8 +++ 2 files

Re: [FFmpeg-devel] [PATCH] hevc_mp4toannexb: Do not duplicate parameter sets

2019-08-18 Thread Andriy Gelman
Andreas, On Tue, 13. Aug 06:24, Andreas Rheinhardt wrote: > Andriy Gelman: > > Andreas, > > > > On Sun, 21. Jul 10:47, Andreas Rheinhardt wrote: > >> Andriy Gelman: > >>> From: Andriy Gelman > >>> > >>> Fixes #7799 > >>> > >>> Currently, the mp4toannexb filter always inserts extradata at the

Re: [FFmpeg-devel] [PATCH v1] lavf/hlsenc: fix one warning: unused variable 'filename' [-Wunused-variable]

2019-08-18 Thread Liu Steven
> 在 2019年8月19日,上午9:42,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index f6f9c8161d..149b2a3bd0 100644 > ---

[FFmpeg-devel] [PATCH v2] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-08-18 Thread Andriy Gelman
From: Andriy Gelman Fixes #7799 Currently, the mp4toannexb filter always inserts the same extradata at the start of the first IRAP unit. As in ticket #7799, this can lead to decoding errors if modified parameter sets are signalled in-band. This commit keeps track of the vps/sps/pps parameter

Re: [FFmpeg-devel] [PATCH, v2] lavc/vaapi_encode: grow packet if vaMapBuffer returns multiple buffers

2019-08-18 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Tuesday, August 6, 2019 16:12 > To: FFmpeg development discussions and patches de...@ffmpeg.org>; Mark Thompson > Subject: Re: [FFmpeg-devel] [PATCH, v2]

[FFmpeg-devel] [PATCH v1] lavf/hlsenc: fix one warning: unused variable 'filename' [-Wunused-variable]

2019-08-18 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f6f9c8161d..149b2a3bd0 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1571,7 +1571,7 @@

[FFmpeg-devel] [PATCH v1] avcodec/h264_parse: retry decoding SPS with complete NAL

2019-08-18 Thread Jun Li
Fix #6591 The content has no rbsp_stop_one_bit for ending the SPS, that causes the decoding SPS failure, results decoding frame failure as well. The patch is just adding a retry with complete NALU. --- libavcodec/h264_parse.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush queued frame in field mode

2019-08-18 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Aman Gupta > Sent: Wednesday, August 14, 2019 10:05 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush >

Re: [FFmpeg-devel] [PATCH v4] avfilter/vaapi: add overlay_vaapi filter

2019-08-18 Thread Zachary Zhou
Hi Mark, Do you have any comments on this patch ? Thanks, Zachary On 7/11/19 5:29 PM, Zachary Zhou wrote: --- configure | 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_overlay_vaapi.c | 424

[FFmpeg-devel] [PATCH 2/3] avcodec/alsdec: Fix integer overflow in decode_var_block_data()

2019-08-18 Thread Michael Niedermayer
Fixes: signed integer overflow: 1927975249 - -514719744 cannot be represented in type 'int' Fixes: 16413/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5651206856245248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 3/3] avcodec/atrac9dec: Check block_align

2019-08-18 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 16260/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5676365617037312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/atrac9dec.c | 5 + 1

[FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-18 Thread Michael Niedermayer
There seems to be no limit in the specification and upto 64k could be stored 64 is chooses as limit as thats also used for AAC and is what a int64 mask can handle An alternative to this patch would be a max_channels variable Fixes: OOM Fixes:

Re: [FFmpeg-devel] [PATCH 2/3] avutil/imgutils: remove dead assignment

2019-08-18 Thread Michael Niedermayer
On Sat, Aug 17, 2019 at 09:41:04PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c | 1 - > 1 file changed, 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who

Re: [FFmpeg-devel] [CALL] New FFmpeg developers meeting

2019-08-18 Thread Thomas Volkert
On 18.08.19 18:25, Tomas Härdin wrote: lör 2019-08-17 klockan 11:48 +0200 skrev Paul B Mahol: Hi, When and how to organize this? Physical meeting or over the internets? IBC is coming up, that might be a good opportunity. Depending on form, attending remotely via mumble or jingle might also be

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 02:49:39PM +0200, Tomas Härdin wrote: > sön 2019-08-18 klockan 14:18 +0200 skrev Michael Niedermayer: > > On Sun, Aug 18, 2019 at 01:40:01PM +0200, Tomas Härdin wrote: > > > sön 2019-08-18 klockan 12:19 +0200 skrev Michael Niedermayer: > > > > On Sun, Aug 18, 2019 at

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: do not ignore bad size errors

2019-08-18 Thread Tomas Härdin
lör 2019-08-17 klockan 21:41 +0200 skrev Marton Balint: > The return value was unintentionally lost after > 00a2652df3bf25a27d174cc67ed508b5317cb115. > > Signed-off-by: Marton Balint > --- > libavformat/mxfdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [CALL] New FFmpeg developers meeting

2019-08-18 Thread Tomas Härdin
lör 2019-08-17 klockan 11:48 +0200 skrev Paul B Mahol: > Hi, > > When and how to organize this? Physical meeting or over the internets? IBC is coming up, that might be a good opportunity. Depending on form, attending remotely via mumble or jingle might also be a good idea. /Tomas

[FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-18 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dump.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index a3791a3..56814ff 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -321,13 +321,16 @@ static

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Tomas Härdin
sön 2019-08-18 klockan 14:18 +0200 skrev Michael Niedermayer: > On Sun, Aug 18, 2019 at 01:40:01PM +0200, Tomas Härdin wrote: > > sön 2019-08-18 klockan 12:19 +0200 skrev Michael Niedermayer: > > > On Sun, Aug 18, 2019 at 12:00:45PM +0200, Paul B Mahol wrote: > > > > On Sun, Aug 18, 2019 at 11:44

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:40:01PM +0200, Tomas Härdin wrote: > sön 2019-08-18 klockan 12:19 +0200 skrev Michael Niedermayer: > > On Sun, Aug 18, 2019 at 12:00:45PM +0200, Paul B Mahol wrote: > > > On Sun, Aug 18, 2019 at 11:44 AM Michael Niedermayer > > > > > > wrote: > > > > > > > On Sun, Aug

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Tomas Härdin
sön 2019-08-18 klockan 12:19 +0200 skrev Michael Niedermayer: > On Sun, Aug 18, 2019 at 12:00:45PM +0200, Paul B Mahol wrote: > > On Sun, Aug 18, 2019 at 11:44 AM Michael Niedermayer > > > > wrote: > > > > > On Sun, Aug 18, 2019 at 10:47:26AM +0200, Tomas Härdin wrote: > > > > sön 2019-08-18

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-18 Thread Paul B Mahol
NAK On Thu, Aug 15, 2019 at 11:51 PM Michael Niedermayer wrote: > Fixes: overflow in aspect ratio calculation > Fixes: signed integer overflow: 393215 * 14594 cannot be represented in > type 'int' > Fixes: >

Re: [FFmpeg-devel] [PATCH 1/1] avformat/matroska: fully parse stsd atom in v_quicktime tracks

2019-08-18 Thread Stanislav Ionascu
Hi, thanks for looking into this. On Sun, Aug 18, 2019 at 4:55 AM Andreas Rheinhardt wrote: > > Hello, > > I am no expert on mov (and so this should definitely be looked at from > someone who is), but I have some points: > > Stanislav Ionascu: > > diff --git a/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Paul B Mahol
On Sun, Aug 18, 2019 at 12:19 PM Michael Niedermayer wrote: > On Sun, Aug 18, 2019 at 12:00:45PM +0200, Paul B Mahol wrote: > > On Sun, Aug 18, 2019 at 11:44 AM Michael Niedermayer > > > wrote: > > > > > On Sun, Aug 18, 2019 at 10:47:26AM +0200, Tomas Härdin wrote: > > > > sön 2019-08-18

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 12:00:45PM +0200, Paul B Mahol wrote: > On Sun, Aug 18, 2019 at 11:44 AM Michael Niedermayer > wrote: > > > On Sun, Aug 18, 2019 at 10:47:26AM +0200, Tomas Härdin wrote: > > > sön 2019-08-18 klockan 02:35 +0200 skrev Tomas Härdin: > > > > lör 2019-08-17 klockan 17:33

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 02:35:45AM +0200, Tomas Härdin wrote: > lör 2019-08-17 klockan 17:33 +0200 skrev Michael Niedermayer: > > On Sat, Aug 17, 2019 at 12:26:27AM +0200, Tomas Härdin wrote: > > > fre 2019-08-16 klockan 14:57 +0200 skrev Tomas Härdin: > > > > fre 2019-08-16 klockan 00:50 +0200

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Paul B Mahol
On Sun, Aug 18, 2019 at 11:44 AM Michael Niedermayer wrote: > On Sun, Aug 18, 2019 at 10:47:26AM +0200, Tomas Härdin wrote: > > sön 2019-08-18 klockan 02:35 +0200 skrev Tomas Härdin: > > > lör 2019-08-17 klockan 17:33 +0200 skrev Michael Niedermayer: > > > > On Sat, Aug 17, 2019 at 12:26:27AM

Re: [FFmpeg-devel] [v3] avformat/flvdec: delete unused code

2019-08-18 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 11:07:18AM +0800, leozhang wrote: > Reviewed-by: Carl Eugen Hoyos > Signed-off-by: leozhang > --- > libavformat/flvdec.c | 17 - > 1 file changed, 17 deletions(-) probably ok thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 10:47:26AM +0200, Tomas Härdin wrote: > sön 2019-08-18 klockan 02:35 +0200 skrev Tomas Härdin: > > lör 2019-08-17 klockan 17:33 +0200 skrev Michael Niedermayer: > > > On Sat, Aug 17, 2019 at 12:26:27AM +0200, Tomas Härdin wrote: > > > > fre 2019-08-16 klockan 14:57 +0200

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-18 Thread Paul B Mahol
On Sun, Aug 18, 2019 at 10:25 AM Michael Niedermayer wrote: > On Sun, Aug 18, 2019 at 09:21:25AM +0200, Paul B Mahol wrote: > > NAK > > What problem do you see in this patch ? > > What change do you suggest ? > or what alternative fix for the issue do you suggest ? > > a DOS issue in png will

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer overflows in

2019-08-18 Thread Michael Niedermayer
On Sat, Aug 17, 2019 at 03:40:26PM +0200, Moritz Barsnick wrote: > On Thu, Aug 15, 2019 at 23:49:15 +0200, Michael Niedermayer wrote: > > Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple > > integer overflows in > > ... in what? Spurious " in"? ... overflows in

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/anm: Check input size for a frame with just a stop code

2019-08-18 Thread Michael Niedermayer
On Fri, Aug 16, 2019 at 10:20:42PM +1000, Peter Ross wrote: > On Thu, Aug 15, 2019 at 11:49:13PM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (11sec -> 6sec) > > Fixes: > > 16344/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ANM_fuzzer-5673032000995328 > > > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-18 Thread Tomas Härdin
sön 2019-08-18 klockan 02:35 +0200 skrev Tomas Härdin: > lör 2019-08-17 klockan 17:33 +0200 skrev Michael Niedermayer: > > On Sat, Aug 17, 2019 at 12:26:27AM +0200, Tomas Härdin wrote: > > > fre 2019-08-16 klockan 14:57 +0200 skrev Tomas Härdin: > > > > > > I feel I should point out that being

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 08:49:06AM +0200, Reimar Döffinger wrote: > On 18.08.2019, at 01:28, Michael Niedermayer wrote: > > > 30M cycles -> 5M cycles > > I see nothing wrong with it, but: > You could save reviewers a lot of time if you gave them a hint of what the > change > contains instead

[FFmpeg-devel] [PATCH] avcodec/pngdec: Optimize has_trns code

2019-08-18 Thread Michael Niedermayer
add inner loop specialisations for 2 bpp and 4 bpp These are all cases for which i found testsamples. 30M cycles -> 5M cycles Testcase: fate-rgbapng-4816 Testcase: 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 09:21:25AM +0200, Paul B Mahol wrote: > NAK What problem do you see in this patch ? What change do you suggest ? or what alternative fix for the issue do you suggest ? a DOS issue in png will have to be fixed, otherwise major users would have to use different libraries

Re: [FFmpeg-devel] EOF and IO error checking

2019-08-18 Thread Michael Niedermayer
On Sat, Aug 17, 2019 at 09:10:59PM +0200, Marton Balint wrote: > Hi, > > As you might now avio_feof() returns true both in case of actual EOF and in > case of IO errors. > > Some demuxers (matroska) have special handling for this exact reason, e.g.: > > if (avio_feof(pb)) { > if (pb->error)

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-18 Thread Paul B Mahol
NAK On Sun, Aug 18, 2019 at 1:36 AM Michael Niedermayer wrote: > Fixes: Timeout (70sec -> 243ms) > Fixes: > 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

2019-08-18 Thread Reimar Döffinger
On 18.08.2019, at 01:28, Michael Niedermayer wrote: > 30M cycles -> 5M cycles I see nothing wrong with it, but: You could save reviewers a lot of time if you gave them a hint of what the change contains instead of them having to reverse-engineer. In this case for example something like "add