Re: [FFmpeg-devel] [PATCH v2 5/8] avformat/utils: Fix memleaks II

2019-08-24 Thread Andriy Gelman
Andreas, On Mon, 19. Aug 23:56, Andreas Rheinhardt wrote: > Up until now, avformat_find_stream_info had a potential for memleaks: > When everything is fine, it read packets and (depending upon whether > AVFMT_FLAG_NOBUFFER was set) put them in a packet list or unreferenced > them when they were

Re: [FFmpeg-devel] [PATCH 0/3] Dolby TrueHD support in ISO BMFF

2019-08-24 Thread James Almer
On 8/24/2019 2:29 PM, James Almer wrote: > On 8/17/2019 11:34 AM, James Almer wrote: >> On 8/17/2019 6:43 AM, Paul B Mahol wrote: >>> On Fri, Aug 16, 2019 at 11:18 PM James Almer wrote: >>>

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Increase maxpixels threshold for dirac

2019-08-24 Thread Michael Niedermayer
wavelets allow significant size expansion and they are also not very fast. Fixes: Timeout Fixes: 16480/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5659892689403904 (108sec -> 17ms) Fixes: 16480/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5749422717140992

[FFmpeg-devel] lavf: Add DICOM demuxer

2019-08-24 Thread Shivam
The patch contains DICOM demuxer. I have improved the code as suggested. Please, push it as soon as possible, as i have to share the commit in GSoC final evaluation. if anything remain i would add it after that. Thank you, Shivam Goyal >From e76ce45b2f7c0e6ce9706cbcb62da147e56e3e61 Mon Sep

[FFmpeg-devel] [PATCH] lavc: Add DICOM decoder

2019-08-24 Thread Shivam
The patch contains DICOM decoder. I have improved the code as suggested. Please, push it as soon as possible, as i have to share the commit in GSoC final evaluation. if anything remain i would add it after that. Thank you, Shivam Goyal >From 29f25f6650822ed8de8e51fa0510cf4ac91288aa Mon Sep

[FFmpeg-devel] [PATCH] avformat/utils: return pending IO error on EOF in av_read_frame()

2019-08-24 Thread Marton Balint
avio_feof() returns true both in case of actual EOF and in case of IO errors. Some demuxers (matroska) have special handling to be able to return the proper error for this exact reason, e.g.: if (avio_feof(pb)) { if (pb->error) { return pb->error; } else { return

Re: [FFmpeg-devel] [PATCH v3 3/3] FATE: add a test for freeezedetect

2019-08-24 Thread Carl Eugen Hoyos
Am Fr., 23. Aug. 2019 um 14:25 Uhr schrieb : > +FREEZEDETECT_DEPS = FFPROBE AVDEVICE LAVFI_INDEV MPTESTSRC_FILTER > SCALE_FILTER FREEZEDETECT_FILTER > +FATE_METADATA_FILTER-$(call ALLYES, $(FREEZEDETECT_DEPS)) += > fate-filter-metadata-freezedetect > +fate-filter-metadata-freezedetect: CMD =

[FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-24 Thread Michael Niedermayer
Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 30 ++ tests/ref/fate/qtrle-8bit | 1 + 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c index 2c29547e5a..c22a1a582d 100644

[FFmpeg-devel] [PATCH 2/6] avcodec: add FF_CODEC_CAP_SETS_PKT_POS

2019-08-24 Thread Michael Niedermayer
Suggested-by: James Almer Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 2 +- libavcodec/internal.h | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index cf9676e2ac..5976da78c8 100644 --- a/libavcodec/decode.c

[FFmpeg-devel] [PATCH 3/6] avcodec: Add ff_setup_buffered_frame_for_return()

2019-08-24 Thread Michael Niedermayer
Suggested-by: James Almer Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 17 + libavcodec/internal.h | 5 + 2 files changed, 22 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 5976da78c8..72482e2168 100644 ---

[FFmpeg-devel] [PATCH 4/6] avcodec/internal: Add need_flush, simplify the next 2 commits

2019-08-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/decode.c| 4 +++- libavcodec/internal.h | 3 +++ libavcodec/pthread_frame.c | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 72482e2168..a757249f93 100644 ---

[FFmpeg-devel] [PATCH 6/6] avcodec/nuv: Avoid duplicating frames

2019-08-24 Thread Michael Niedermayer
Testcase: 14843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5661969614372864 Testcase: 16257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5769175464673280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/6] avcodec/aacps: Fix integer overflows in hybrid_synthesis()

2019-08-24 Thread Michael Niedermayer
Fixes: signed integer overflow: -822667928 + -1399761199 cannot be represented in type 'int' Fixes: 15756/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5645182051024896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH] hwcontext_d3d11va: support bgr0 pixel format

2019-08-24 Thread Carl Eugen Hoyos
Am Do., 8. Aug. 2019 um 02:35 Uhr schrieb Thomas Volkert : > > From: Thomas Volkert > > --- > libavutil/hwcontext_d3d11va.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c > index 6670c47579..0204407330

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-24 Thread Marton Balint
On Fri, 23 Aug 2019, Anthony Delannoy wrote: I think we should only merge the part of this patchset which makes the EIT available as a data stream. Parsing the whole EIT or dumping the data as ASCII is not libavcodec's or libavutil's job. The EPG decoder does not change the table's data, it

Re: [FFmpeg-devel] [PATCH v3 3/3] FATE: add a test for freeezedetect

2019-08-24 Thread Marton Balint
On Sat, 24 Aug 2019, Limin Wang wrote: On Fri, Aug 23, 2019 at 08:27:22PM +0200, Michael Niedermayer wrote: On Fri, Aug 23, 2019 at 08:17:09PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 4

Re: [FFmpeg-devel] [PATCH V3] swscale/ppc/yuv2rgb_altivec: Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-24 Thread Carl Eugen Hoyos
Am Sa., 24. Aug. 2019 um 19:25 Uhr schrieb Lauri Kasanen : > > Hi, > > This change uses VSX code in a function marked Altivec, aka it makes it > not work on pre-power7 (macs, etc). As such I would've NAK'd it. Please send a patch. Atm, I only have access to power7 and newer. Carl Eugen

Re: [FFmpeg-devel] [PATCH v3] libavformat: Add ZeroMQ as a protocol option

2019-08-24 Thread Marton Balint
On Fri, 23 Aug 2019, Andriy Gelman wrote: On Mon, 19. Aug 17:28, Andriy Gelman wrote: Minor changes in v3: 1. Removed tab character from as per feedback 2. Removed unused timeout variable from ZMQContext Andriy From 66c11c12fcfa8a7fbb3c8c09d23c017992229a99 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH 0/3] Dolby TrueHD support in ISO BMFF

2019-08-24 Thread James Almer
On 8/17/2019 11:34 AM, James Almer wrote: > On 8/17/2019 6:43 AM, Paul B Mahol wrote: >> On Fri, Aug 16, 2019 at 11:18 PM James Almer wrote: >> >>> >>> https://developer.dolby.com/globalassets/technology/dolby-truehd/dolbytruehdbitstreamswithintheisobasemediafileformat.pdf >>> >>> There's no

Re: [FFmpeg-devel] [PATCH V3] swscale/ppc/yuv2rgb_altivec: Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-24 Thread Lauri Kasanen
Hi, This change uses VSX code in a function marked Altivec, aka it makes it not work on pre-power7 (macs, etc). As such I would've NAK'd it. - Lauri ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 0/2] AltiVec/VSX fixes in swscale

2019-08-24 Thread Lauri Kasanen
Hi, I approve of this series, but being in the middle of a move, I can't test it. - Lauri ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v1 3/3] avfilter/vf_show: display QP table data and properties side data

2019-08-24 Thread Paul B Mahol
The API is deprecated, do not use it. On Sat, Aug 24, 2019 at 6:25 PM wrote: > From: Limin Wang > > Below is the final displaying format for the QP table data and properties, > timecode: > [Parsed_showinfo_0 @ 0x364fdc0] side data - pan/scan > [Parsed_showinfo_0 @ 0x364fdc0] side data - QP

[FFmpeg-devel] [PATCH v1 3/3] avfilter/vf_show: display QP table data and properties side data

2019-08-24 Thread lance . lmwang
From: Limin Wang Below is the final displaying format for the QP table data and properties, timecode: [Parsed_showinfo_0 @ 0x364fdc0] side data - pan/scan [Parsed_showinfo_0 @ 0x364fdc0] side data - QP table data (1350 bytes) [Parsed_showinfo_0 @ 0x364fdc0] side data - QP table properties

[FFmpeg-devel] [PATCH v1 2/3] avfilter/vf_showinfo: display GOP timecode side data

2019-08-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 3c13f11..31f6b32 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -313,6

[FFmpeg-devel] [PATCH v1 1/3] avfilter/f_sidedata: try to fix warning: comparison of constant -1 with expression of type 'enum AVFrameSideDataType'

2019-08-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_sidedata.c | 10 +- libavutil/frame.h| 10 ++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/libavfilter/f_sidedata.c b/libavfilter/f_sidedata.c index 381da5a..3082aa6 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/dhav: gracefully handle corrupted files

2019-08-24 Thread Paul B Mahol
Hi, New patches attached. Now also with handling of files with missing data at start. On Sat, Aug 24, 2019 at 11:02 AM Paul B Mahol wrote: > Hi, > > patch attached. > 0001-avformat-dhav-gracefully-handle-corrupted-files.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] hwcontext_d3d11va: support bgr0 pixel format

2019-08-24 Thread Thomas Volkert
On 08.08.2019 02:30, Thomas Volkert wrote: > From: Thomas Volkert > > --- > libavutil/hwcontext_d3d11va.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c > index 6670c47579..0204407330 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: set default disposition

2019-08-24 Thread Gyan
On 24-08-2019 07:07 PM, Nicolas George wrote: Gyan (12019-08-24): The ticket reports a change in auto-mapping behaviour. Manual mapping is a workaround which I already provided at trac but it doesn't correct the regression which should be addressed since I've confirmed that auto-mapping is

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: set default disposition

2019-08-24 Thread Nicolas George
Gyan (12019-08-24): > The ticket reports a change in auto-mapping behaviour. Manual mapping is a > workaround which I already provided at trac but it doesn't correct the > regression which should be addressed since I've confirmed that auto-mapping > is affected for instances beyond that in the

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: set default disposition

2019-08-24 Thread Gyan
On 24-08-2019 04:43 PM, Hendrik Leppkes wrote: On Sat, Aug 24, 2019 at 11:28 AM Gyan wrote: Fixes #8091, which reports what I consider a change rather than a regression since 11d3b03fcb2baae4324aac9481b9bd4a171d4345

Re: [FFmpeg-devel] [PATCH] avformat/avidec: add support for recognizing HEVC fourcc when demuxing

2019-08-24 Thread James Almer
On Sat, Aug 24, 2019 at 5:48 AM Marton Balint wrote: > > > On Sat, 24 Aug 2019, Carl Eugen Hoyos wrote: > > > Am Sa., 24. Aug. 2019 um 01:47 Uhr schrieb Marton Balint >: > >> > >> Some security cams generate this, as well as some versions of > VirtualDub so > >> support for _reading_ such files

Re: [FFmpeg-devel] [PATCH v3 3/3] FATE: add a test for freeezedetect

2019-08-24 Thread Limin Wang
On Fri, Aug 23, 2019 at 08:27:22PM +0200, Michael Niedermayer wrote: > On Fri, Aug 23, 2019 at 08:17:09PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak | 4 + > >

Re: [FFmpeg-devel] [PATCH 1/3] libavutil: AVEncodeInfo data structures

2019-08-24 Thread Nicolas George
Juan De León (12019-08-23): > AVEncodeInfoFrame data structure to store as AVFrameSideData of type > AV_FRAME_DATA_ENCODE_INFO. > The structure stores quantization index for each plane, DC/AC deltas > for luma and chroma planes, and an array of AVEncodeInfoBlock type > denoting position, size, and

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: set default disposition

2019-08-24 Thread Hendrik Leppkes
On Sat, Aug 24, 2019 at 11:28 AM Gyan wrote: > > Fixes #8091, which reports what I consider a change rather than a > regression since 11d3b03fcb2baae4324aac9481b9bd4a171d4345 > > > It may be good

[FFmpeg-devel] [PATCH] avformat/mp3dec: set default disposition

2019-08-24 Thread Gyan
Fixes #8091, which reports what I consider a change rather than a regression since 11d3b03fcb2baae4324aac9481b9bd4a171d4345 It may be good practice to set default disposition in all demuxers which

[FFmpeg-devel] [PATCH] avformat/dhav: gracefully handle corrupted files

2019-08-24 Thread Paul B Mahol
Hi, patch attached. 0001-avformat-dhav-gracefully-handle-corrupted-files.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avformat/avidec: add support for recognizing HEVC fourcc when demuxing

2019-08-24 Thread Marton Balint
On Sat, 24 Aug 2019, Carl Eugen Hoyos wrote: Am Sa., 24. Aug. 2019 um 01:47 Uhr schrieb Marton Balint : Some security cams generate this, as well as some versions of VirtualDub so support for _reading_ such files is justified. Please also mention vlc. Ok. Fixes ticket #7110. See

Re: [FFmpeg-devel] [PATCH] fate/als: Add test for conformance file with 512 channels.

2019-08-24 Thread Thilo Borgmann
Am 23.08.19 um 21:54 schrieb Michael Niedermayer: > On Thu, Aug 22, 2019 at 09:23:49PM +0200, Thilo Borgmann wrote: >> Hi, >> >> new fate test for many channels in ALS, like requested. >> >> I already uploaded the corresponding file into fate-suite. >> If there are no objections, I'll commit this

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-24 Thread Pavel Koshevoy
On 8/23/19 3:46 PM, Aman Gupta wrote: On Wed, Aug 14, 2019 at 3:53 AM Pavel Koshevoy wrote: On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy wrote: vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, but videotoolbox_hevc used ff_videotoolbox_uninit which doesn't unref