Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-27 Thread Niki Bowe
On Sun, Aug 25, 2019 at 11:39 AM Michael Niedermayer wrote: > On Fri, Aug 23, 2019 at 04:03:10PM -0700, Niki Bowe wrote: > > On Thu, Aug 22, 2019 at 2:30 AM Paul B Mahol wrote: > > > > > On Thu, Aug 22, 2019 at 11:19 AM Carl Eugen Hoyos > > > wrote: > > > > > > > Am Mi., 21. Aug. 2019 um 23:05

Re: [FFmpeg-devel] [PATCH v2] libavcodec/amfenc: Vulkan initialization support for encoder.

2019-08-27 Thread Philip Langdale
On Tue, 27 Aug 2019 10:08:43 -0700 Philip Langdale wrote: > On 2019-08-08 11:33, OvchinnikovDmitrii wrote: > > > > diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c > > index 384d8efc92..f66b95645e 100644 > > --- a/libavcodec/amfenc.c > > +++ b/libavcodec/amfenc.c > > @@ -213,6 +213,7 @@

Re: [FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v3]

2019-08-27 Thread Marton Balint
On Mon, 26 Aug 2019, Andreas Håkon wrote: Hi, ‐‐‐ Original Message ‐‐‐ On Monday, 19 de August de 2019 21:16, Andreas Håkon wrote: Hi, This is the third version of my patch for an "interleaved MPEG-TS muxer". This new version includes all recommendations and rebases the fix of

Re: [FFmpeg-devel] [PATCH v1] lavf/hlsenc: refine the get_relative_url function to avoid extra malloc for relation path

2019-08-27 Thread Steven Liu
Limin Wang 于2019年8月27日周二 下午10:40写道: > > > ping, I have tested with below command and check the m3u8 is ok: > > ./ffmpeg -threads 4 -vsync 1 -i ~/Movies/1.mp4 -r 25 \ > -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ > -b:v:1 4200k -c:v h264 -pix_fmt yuv420p -profile:v main

[FFmpeg-devel] [PATCH v3] avfilter/vf_delogo: support expr in delogo filter

2019-08-27 Thread Steven Liu
Signed-off-by: Steven Liu --- libavfilter/vf_delogo.c | 83 ++--- 1 file changed, 79 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 065d093641..5323603ddb 100644 --- a/libavfilter/vf_delogo.c +++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-27 Thread Marton Balint
On Tue, 27 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 9:34, Marton Balint wrote: Fixes DTS < PCR errors with this command line: ./ffmpeg -loglevel verbose -y -f lavfi -i \

[FFmpeg-devel] [PATCH 1/2] avcodec/mpeg12enc: Add FF_CODEC_CAP_INIT_CLEANUP

2019-08-27 Thread Michael Niedermayer
Fixes: Multiple memleaks Fixes: ffmpeg-memory-leak Found-by: Francis Provencher Signed-off-by: Michael Niedermayer --- libavcodec/mpeg12enc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 2bc5289d63..cbf2f6fa03 100644 ---

[FFmpeg-devel] [PATCH 2/2] libavcodec/utils: Free threads on init failure

2019-08-27 Thread Michael Niedermayer
Fixes: Multiple memleaks Fixes: ffmpeg-memory-leak Found-by: Francis Provencher Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index a6a646636d..729c10a8ed 100644 --- a/libavcodec/utils.c

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: support expr in delogo filter

2019-08-27 Thread Steven Liu
> 在 2019年8月27日,23:29,Limin Wang 写道: > > On Tue, Aug 27, 2019 at 03:17:09PM +0800, Steven Liu wrote: >> Signed-off-by: Steven Liu >> --- >> libavfilter/vf_delogo.c | 72 ++--- >> 1 file changed, 68 insertions(+), 4 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [Compiled Failed] Trying to compile FFmpeg with mysofa and it failed at af_sofalizer.c:164:32

2019-08-27 Thread Andrey Semashev
On 12/29/18 10:15 PM, James Almer wrote: On 12/29/2018 8:09 AM, Paul B Mahol wrote: On 12/29/18, Ysy wrote: I was trying to compile FFmpeg with `--enable-libmysofa`, and it failed with this message below: src/libavfilter/af_sofalizer.c:164:32: error: implicit declaration of function

Re: [FFmpeg-devel] lavf: Add DICOM demuxer

2019-08-27 Thread Shivam
On 8/27/19 2:05 AM, Moritz Barsnick wrote: On Sun, Aug 25, 2019 at 03:22:02 +0530, Shivam wrote: The patch contains DICOM demuxer. I have improved the code as suggested. Second part of my review: From: Shivam Goyal <1998.goyal.shi...@gmail.com> Date: Sun, 25 Aug 2019 02:57:35 +0530 Subject:

Re: [FFmpeg-devel] [PATCH] lavc: Add DICOM decoder

2019-08-27 Thread Shivam
On 8/27/19 2:04 AM, Moritz Barsnick wrote: On Sun, Aug 25, 2019 at 03:20:13 +0530, Shivam wrote: The patch contains DICOM decoder. I have improved the code as suggested. Hi Shivan, nice job. First of all, all your samples now appear to demux and decode properly. I didn't get a chance to look

Re: [FFmpeg-devel] [PATCH 4/3 v2][RFC] avcodec/qtrle: call ff_reget_buffer() only when the picture data is going to change

2019-08-27 Thread James Almer
On 8/27/2019 12:51 PM, Michael Niedermayer wrote: > On Mon, Aug 26, 2019 at 04:02:14PM -0300, James Almer wrote: >> ff_reget_buffer() will attempt to create a writable copy of the frame, >> which is not needed when the decoder intends to return a reference to >> the same buffer as the previous

Re: [FFmpeg-devel] [PATCH v2] libavcodec/amfenc: Vulkan initialization support for encoder.

2019-08-27 Thread Philip Langdale
On 2019-08-08 11:33, OvchinnikovDmitrii wrote: diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 384d8efc92..f66b95645e 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -213,6 +213,7 @@ static int amf_init_from_dxva2_device(AVCodecContext *avctx, AVDXVA2DeviceContex

Re: [FFmpeg-devel] [PATCH 1/1] libavcodec/h264: Handle ENOMEM error when decoding slice nal unit.

2019-08-27 Thread Asaf Kave
Hello all, Long time pass, can somebody look at this? Thanks On Wed, Jul 17, 2019 at 11:35 AM Asaf Kave wrote: > Populate the real error when alloc_picture failed, during decoding h264 > slice. > When this error occurred, need to break the decoding process of the rest > nal's, and need to

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/atrac9dec: Check block_align

2019-08-27 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 01:30:54AM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 16260/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5676365617037312 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 4/3 v2][RFC] avcodec/qtrle: call ff_reget_buffer() only when the picture data is going to change

2019-08-27 Thread Michael Niedermayer
On Mon, Aug 26, 2019 at 04:02:14PM -0300, James Almer wrote: > ff_reget_buffer() will attempt to create a writable copy of the frame, > which is not needed when the decoder intends to return a reference to > the same buffer as the previous frame. > > Should reduce data copy, hopefully achieving a

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: support expr in delogo filter

2019-08-27 Thread Limin Wang
On Tue, Aug 27, 2019 at 03:17:09PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavfilter/vf_delogo.c | 72 ++--- > 1 file changed, 68 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c > index

Re: [FFmpeg-devel] [PATCH] Change libvpx-vpx default to crf=32.

2019-08-27 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 04:43:31PM -0700, Elliott Karpilovsky wrote: > Current default is 200kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). Use > CRF instead, which will adapt. Affects vp8/vp9. Also > have VP8 use a default bitrate of 256kbps. > --- >

Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/videotoolboxenc: add H264 Extended profile and level

2019-08-27 Thread Richard Kern
I’ll look at it this weekend. > On Aug 27, 2019, at 10:40 AM, Limin Wang wrote: > > > ping the patchset. > >> On Tue, Aug 20, 2019 at 07:04:29PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/videotoolboxenc.c | 14

Re: [FFmpeg-devel] [PATCH 3/3] dnn: export operand info in python script and load in c code

2019-08-27 Thread Pedro Arthur
hi, Em ter, 20 de ago de 2019 às 05:54, Guo, Yejun escreveu: > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn/dnn_backend_native.c| 49 +++--- > libavfilter/dnn/dnn_backend_native.h| 2 +- > libavfilter/dnn_interface.h | 2 +- >

Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/videotoolboxenc: add H264 Extended profile and level

2019-08-27 Thread Limin Wang
ping the patchset. On Tue, Aug 20, 2019 at 07:04:29PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/videotoolboxenc.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavcodec/videotoolboxenc.c

[FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-27 Thread lance . lmwang
From: Limin Wang How to check it: ./ffmpeg -f lavfi -i testsrc -c:v mpeg2video -f null - master: Side data: cpb: bitrate max/min/avg: 0/0/20 buffer size: 0 vbv_delay: 18446744073709551615 patch applied: Side data: cpb: bitrate max/min/avg: 0/0/20 buffer size: 0

Re: [FFmpeg-devel] [PATCH v1] lavf/hlsenc: refine the get_relative_url function to avoid extra malloc for relation path

2019-08-27 Thread Limin Wang
ping, I have tested with below command and check the m3u8 is ok: ./ffmpeg -threads 4 -vsync 1 -i ~/Movies/1.mp4 -r 25 \ -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ -b:v:1 4200k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ -b:v:1 3150k -c:v h264 -pix_fmt

Re: [FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-27 Thread Limin Wang
Add Reviewed-by: only, please help to push it, thanks. On Tue, Aug 27, 2019 at 10:34:54PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > How to check it: > ./ffmpeg -f lavfi -i testsrc -c:v mpeg2video -f null - > master: > Side data: > cpb: bitrate max/min/avg:

Re: [FFmpeg-devel] [PATCH 1/3] dnn: introduce dnn operand (in c code) to hold operand infos within network

2019-08-27 Thread Pedro Arthur
Hi, Em ter, 20 de ago de 2019 às 05:54, Guo, Yejun escreveu: > > the info can be saved in dnn operand object without regenerating again and > again, > and it is also needed for layer split/merge, and for memory reuse. > > to make things step by step, this patch just focuses on c code, > the

[FFmpeg-devel] [PATCH] avcodec/nuv: call ff_reget_buffer() only when the picture data is going to change

2019-08-27 Thread James Almer
Signed-off-by: James Almer --- This is an alternative approach to "avcodec/nuv: Avoid duplicating frames", similar to the one from "avcodec/qtrle: call ff_reget_buffer() only when the picture data is going to change", to workaround fuzzer reported timeouts but without changing the behavior of the

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread James Almer
On 8/27/2019 10:03 AM, Michael Niedermayer wrote: > On Tue, Aug 27, 2019 at 10:58:13AM +0200, Marton Balint wrote: >> >> >> On Tue, 27 Aug 2019, Michael Niedermayer wrote: >> >>> On Tue, Aug 27, 2019 at 09:12:53AM +0200, Marton Balint wrote: On Mon, 26 Aug 2019, James Almer wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: zero initialize the rbsp buffer

2019-08-27 Thread James Almer
On 8/27/2019 4:23 AM, Andreas Rheinhardt wrote: > James Almer: >> Fixes ticket #8093 >> >> Signed-off-by: James Almer >> --- >> libavcodec/h2645_parse.c | 9 +++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c >>

Re: [FFmpeg-devel] [PATCH] [cbs_h2645]: Used av_realloc instead of av_malloc

2019-08-27 Thread Paul B Mahol
Probably OK On Mon, Aug 26, 2019 at 10:51 PM Thierry Foucu wrote: > Follow the description of av_realloc, the memory needs to be allocated > by av_realloc. > --- > libavcodec/cbs_h2645.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_h2645.c

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Michael Niedermayer
On Tue, Aug 27, 2019 at 10:58:13AM +0200, Marton Balint wrote: > > > On Tue, 27 Aug 2019, Michael Niedermayer wrote: > > >On Tue, Aug 27, 2019 at 09:12:53AM +0200, Marton Balint wrote: > >> > >> > >>On Mon, 26 Aug 2019, James Almer wrote: > >> > >>>Used to signal frames that can be safely

Re: [FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-08-27 Thread Andreas Håkon
Hi, Ping! ‐‐‐ Original Message ‐‐‐ > On Friday, 16 de August de 2019 12:19, Andreas Håkon > wrote: > >> Hi, >> >> The latest version ready to merge of the bitstream filter "editpts". >> Implements all requests. >> >> This supersedes: >> >> https://patchwork.ffmpeg.org/patch/14302/ >>

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Marton Balint
On Tue, 27 Aug 2019, Michael Niedermayer wrote: On Tue, Aug 27, 2019 at 09:12:53AM +0200, Marton Balint wrote: On Mon, 26 Aug 2019, James Almer wrote: Used to signal frames that can be safely discarded without losing any picture data, side data, or metadata other than timing info.

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-27 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 9:34, Marton Balint wrote: > Fixes DTS < PCR errors with this command line: > > ./ffmpeg -loglevel verbose -y -f lavfi -i \ >

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Michael Niedermayer
On Tue, Aug 27, 2019 at 09:12:53AM +0200, Marton Balint wrote: > > > On Mon, 26 Aug 2019, James Almer wrote: > > >Used to signal frames that can be safely discarded without losing > >any picture data, side data, or metadata other than timing info. > > > >Signed-off-by: James Almer > >--- >

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Michael Niedermayer
On Tue, Aug 27, 2019 at 09:12:53AM +0200, Marton Balint wrote: > > > On Mon, 26 Aug 2019, James Almer wrote: > > >Used to signal frames that can be safely discarded without losing > >any picture data, side data, or metadata other than timing info. > > > >Signed-off-by: James Almer > >--- >

[FFmpeg-devel] [PATCH 1/2] docs/formats: fix max_interleave_delta default

2019-08-27 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/formats.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/formats.texi b/doc/formats.texi index 729c77b01d..d689fbadfa 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -139,7 +139,7 @@ Consider things that a sane encoder

[FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-27 Thread Marton Balint
7d097a0fc57f0fa8385962a539c657c2f40b5ed0 had the same purpose as 3700f655c55e2001b57215210b957b169d66b50f but the former is much simpler, so let's remove the latter. Unfortunately both checks were wrong, because in order to make sure DTS > PCR we have to give us some headroom, so instead of using

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: zero initialize the rbsp buffer

2019-08-27 Thread Andreas Rheinhardt
James Almer: > Fixes ticket #8093 > > Signed-off-by: James Almer > --- > libavcodec/h2645_parse.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c > index 24658b3dfa..307e8643e6 100644 > ---

[FFmpeg-devel] [PATCH v2] avfilter/vf_delogo: support expr in delogo filter

2019-08-27 Thread Steven Liu
Signed-off-by: Steven Liu --- libavfilter/vf_delogo.c | 72 ++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 065d093641..cbc7e87a1c 100644 --- a/libavfilter/vf_delogo.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_delogo: support expr in delogo filter

2019-08-27 Thread Liu Steven
> 在 2019年8月27日,上午11:02,Steven Liu 写道: > > Signed-off-by: Steven Liu > --- > libavfilter/vf_delogo.c | 72 ++--- > 1 file changed, 68 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c > index

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Marton Balint
On Mon, 26 Aug 2019, James Almer wrote: Used to signal frames that can be safely discarded without losing any picture data, side data, or metadata other than timing info. Signed-off-by: James Almer --- This implements the "disposable frame" solution to allow library users to drop duplicate

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-27 Thread Guo, Yejun
> -Original Message- > From: James Zern [mailto:jz...@google.com] > Sent: Tuesday, August 27, 2019 12:03 PM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based > encoding support for VP8/VP9 support

Re: [FFmpeg-devel] [PATCH] avcodec/qtrle: add a flush() callback

2019-08-27 Thread Paul B Mahol
LGTM On Mon, Aug 26, 2019 at 8:28 PM James Almer wrote: > The reference frame isn't valid after seeking > > Signed-off-by: James Almer > --- > libavcodec/qtrle.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c > index