[FFmpeg-devel] [PATCH] avcodec/mips: Fix a warnning of indentation not reflect the block structure.

2019-09-08 Thread Shiyou Yin
The indentation of code dose not reflect the if block structure in 'apply_ltp_mips', and this will generate a warnning when build with '-Wall' or '-Wmisleading-indentation'. --- libavcodec/mips/aacdec_mips.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: split empty text sample when duration overflow

2019-09-08 Thread Jun Li
On Sun, Sep 8, 2019 at 5:59 PM Jun Li wrote: > > > On Sun, Sep 8, 2019 at 5:51 PM Jun Li wrote: > >> Fix #7637 >> One empty/end sample is created and inserted between two caption lines >> when there is a gap. >> This patch is to split the sample into multiple ones when its duration is >> too

Re: [FFmpeg-devel] [PATCH v3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-09-08 Thread Andriy Gelman
On Sun, 08. Sep 14:18, Andreas Rheinhardt wrote: > Andriy Gelman: > > Changes in v3: > > Patch 1/2 > > - Fixed a bug where rbsp payload (without 0x03) was > > written into packet instead of the raw data (with > > 0x03). > > - Segment packets using ff_h2645_packet_split

Re: [FFmpeg-devel] [PATCH] configure: check for a sufficiently recent enough AMF version

2019-09-08 Thread James Almer
On 9/8/2019 7:51 PM, Hendrik Leppkes wrote: > Due to the recent addition of Vulkan support to AMF, we require more > recent headers that include the new structures, which have been > available since AMF 1.4.9 released in September 2018. > --- > configure | 2 +- > 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH V1] lavfi/concat: fix logic error in framerate check

2019-09-08 Thread Jun Zhao
From: Jun Zhao fix logic error in framerate check, it's introduced by commit 3ad5d4df9ce794d3eeb0f526c5f3e446bf97c616 Signed-off-by: Jun Zhao --- libavfilter/avf_concat.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/avf_concat.c

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: split empty text sample when duration overflow

2019-09-08 Thread Jun Li
On Sun, Sep 8, 2019 at 5:51 PM Jun Li wrote: > Fix #7637 > One empty/end sample is created and inserted between two caption lines > when there is a gap. > This patch is to split the sample into multiple ones when its duration is > too long (>= INT_MAX). > --- > libavformat/movenc.c

[FFmpeg-devel] [PATCH v2] avformat/movenc: split empty text sample when duration overflow

2019-09-08 Thread Jun Li
Fix #7637 One empty/end sample is created and inserted between two caption lines when there is a gap. This patch is to split the sample into multiple ones when its duration is too long (>= INT_MAX). --- libavformat/movenc.c | 24 ++-

[FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-08 Thread Hyun Yoo
From: EaseTheWorld rtsp_st->sdp_payload_type is the first codec in 'm=' tag st->codecpar->id is the first supported codec in 'a=' tag the two is not guaranteed to be same for example when 1) the order between attributes is random(rfc4566 doesn't force it) 2) the first codec is same for 'm=' and

[FFmpeg-devel] [PATCH] configure: check for a sufficiently recent enough AMF version

2019-09-08 Thread Hendrik Leppkes
Due to the recent addition of Vulkan support to AMF, we require more recent headers that include the new structures, which have been available since AMF 1.4.9 released in September 2018. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-09-08 Thread Michael Niedermayer
On Sat, Sep 07, 2019 at 03:52:01PM -0700, Darren Mo wrote: > I think I understand some of what you are saying. You are saying that after > the bisection, continuously step backwards + read forward while doubling the > step size until the keyframe is found? yes > > Some questions: > - What is

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: Avoid inlink fifo build up.

2019-09-08 Thread Thierry Foucu
ping? On Wed, Aug 28, 2019 at 7:14 PM Nikolas Bowe wrote: > When duplicating frames we need to schedule for activation again, > otherwise frames can build up in the inlink fifo. > --- > libavfilter/vf_fps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-08 Thread Michael Niedermayer
On Sun, Sep 08, 2019 at 10:28:49AM +0900, Hyun Yoo wrote: > Sorry about this. > At first I commit with git format-patch & send-email on my desktop > but it was discarded because I didn't subcribe to devel mailing list. > After join the ml I forwarded the mail on mobile gmail which might cause >

[FFmpeg-devel] [PATCH 2/4] avcodec/h264_slice: clear frame only on gaps when it is not otherwise initilaized

2019-09-08 Thread Michael Niedermayer
Fixes: Timeout (53sec -> 31sec) Fixes: 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h264_slice.c | 18

[FFmpeg-devel] [PATCH 4/4] avcodec/utils: Optimize ff_color_frame() using memcpy()

2019-09-08 Thread Michael Niedermayer
4650975 -> 4493240 dezicycles This optimizes lines 2 and later. Line 1 still uses av_memcpy_backptr() This change originally fixed ossfuzz 10790 but this is now fixed by other optimizations already Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 18 -- 1 file

[FFmpeg-devel] [PATCH 1/4] avcodec/utils: Use av_memcpy_backptr() in ff_color_frame()

2019-09-08 Thread Michael Niedermayer
Fixes: Timeout (191sec -> 53sec) Fixes: 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864 Fixes: 10709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5630617975259136 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 3/4] avcodec/aacdec: Check if we run out of input in read_stream_mux_config()

2019-09-08 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 16920/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5653421289373696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacdec.c | 2 ++ 1 file

Re: [FFmpeg-devel] [PATCH v3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-09-08 Thread Andriy Gelman
Hey Andreas, Thanks for reviewing. I've actually just finished the updated version that removes emulation 0x03 bytes from the relevant nal units only (as you suggested in the previous review). The other nal units are just copied over. I'll add your changes to that version On Sun, 08. Sep

Re: [FFmpeg-devel] [PATCH v3] Allow 'concat' filter to support inputs with different frame rates

2019-09-08 Thread Nicolas George
Calvin Walton (12019-08-30): > Right now, the concat filter does not set the frame_rate value on any of > the out links. As a result, the default ffmpeg behaviour kicks in - to > copy the framerate from the first input to the outputs. > > If a later input is higher framerate, this results in

Re: [FFmpeg-devel] [PATCH v3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-09-08 Thread Andreas Rheinhardt
Andriy Gelman: > Changes in v3: > Patch 1/2 > - Fixed a bug where rbsp payload (without 0x03) was > written into packet instead of the raw data (with > 0x03). > - Segment packets using ff_h2645_packet_split directly > from mp4-style format without converting to

[FFmpeg-devel] [PATCH v3 2/2] swscale/swscale: various cosmetics for the code style

2019-09-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/swscale.c | 66 +++- 1 file changed, 24 insertions(+), 42 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index b4f958a..5212317 100644 --- a/libswscale/swscale.c

[FFmpeg-devel] [PATCH v3 1/2] swscale/swscale: delete unwanted assignments

2019-09-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/swscale.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 4069550..b4f958a 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -291,11 +291,9 @@ static int

Re: [FFmpeg-devel] [PATCH v1] swscale/swscale: various cosmetics for the code style

2019-09-08 Thread Limin Wang
On Sun, Sep 08, 2019 at 01:53:12PM +0200, Moritz Barsnick wrote: > On Sat, Sep 07, 2019 at 16:20:35 -0400, Andriy Gelman wrote: > > > if (isPacked(c->srcFormat)) { > > > -src[0] = > > > -src[1] = > > > -src[2] = > > > -src[3] = src[0]; > > > -

Re: [FFmpeg-devel] [PATCH v1] swscale/swscale: various cosmetics for the code style

2019-09-08 Thread Moritz Barsnick
On Sat, Sep 07, 2019 at 16:20:35 -0400, Andriy Gelman wrote: > > if (isPacked(c->srcFormat)) { > > -src[0] = > > -src[1] = > > -src[2] = > > -src[3] = src[0]; > > -srcStride[0] = > > -srcStride[1] = > > -srcStride[2] = > > -

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-08 Thread Limin Wang
On Sun, Sep 08, 2019 at 12:46:25AM +0300, Andrey Semashev wrote: > On 2019-09-07 18:32, Limin Wang wrote: > >On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote: > >>On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote: > >>>Because lavf_container is sometimes called

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-08 Thread Limin Wang
On Sun, Sep 08, 2019 at 02:15:28AM +0200, Michael Niedermayer wrote: > On Sat, Sep 07, 2019 at 11:11:25PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_scale.c | 26 ++ > > 1 file changed, 22

Re: [FFmpeg-devel] [PATCH v1 1/3] avfilter/f_sidedata: try to fix warning: comparison of constant -1 with expression of type 'enum AVFrameSideDataType'

2019-09-08 Thread Limin Wang
ping, #patch 2 is pushed already. On Sun, Aug 25, 2019 at 12:17:58AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/f_sidedata.c | 10 +- > libavutil/frame.h| 10 ++ > 2 files changed, 15 insertions(+), 5

[FFmpeg-devel] [PATCH v2] swscale/swscale: various cosmetics for the code style

2019-09-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/swscale.c | 61 ++-- 1 file changed, 21 insertions(+), 40 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 4069550..1aa23c6 100644 --- a/libswscale/swscale.c

Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.

2019-09-08 Thread Andrey Semashev
On 2019-09-02 20:10, Paul B Mahol wrote: On 9/2/19, Andrey Semashev wrote: Ping? I would like this to make it into 4.2 as well. Applied to master. Thanks. Could you also merge it to 4.2 branch? On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev wrote: The current code in

Re: [FFmpeg-devel] [PATCH v4] avformat/hlsenc: merge mpegts and fmp4 workflow to one workflow

2019-09-08 Thread Andreas Rheinhardt
Liu Steven: > > >> 在 2019年8月9日,下午5:30,Liu Steven 写道: >> >> >> >>> 在 2019年8月5日,上午10:29,Steven Liu 写道: >>> >>> just remove the 'i' of the v3 mail subject. >>> write mpegts or fmp4 context into buffer, and flush the buffer into >>> output file when split fragment. merge two format split workflow