Re: [FFmpeg-devel] [PATCH 5/5 v2] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread Ronald S. Bultje
Hi, On Mon, Nov 11, 2019 at 9:17 PM James Almer wrote: > +static int leb(AVIOContext *pb, uint32_t *len) { > this can overflow, should be uint64_t. > +unsigned bits; > Same. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 2/2] avcodec/v4l2_context: Fix indentation

2019-11-11 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/v4l2_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index 874761752cb..bdc2b841530 100644 --- a/libavcodec/v4l2_context.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_m2m_dec: Fix decoding on Odroid XU4

2019-11-11 Thread Andriy Gelman
From: Andriy Gelman c0c79461967 unintentianally changed the initialization flow of the decoder: It caused the capture buffers to be initialized on v4l2_m2m.c:180 in v4l2_configure_contexts(). This breaks h264 decoding on the Odroid XU4 (RPI4 was not affected). This commit postpones capture

Re: [FFmpeg-devel] [PATCH 2/5 V2] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread James Almer
On 11/11/2019 8:36 PM, James Almer wrote: >>> +for (i = 0; i < frag->nb_units; i++) { >>> +if (i && frag->units[i].type == AV1_OBU_TEMPORAL_DELIMITER) { >>> +av_log(bsf, AV_LOG_ERROR, "Temporal Delimiter in the middle of >>> a packet.\n"); >>> +err =

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Check encoder pix_fmt matches pix_fmt on device

2019-11-11 Thread Andriy Gelman
On Mon, 11. Nov 07:05, Carl Eugen Hoyos wrote: > > > > Am 11.11.2019 um 04:42 schrieb Andriy Gelman : > > > > +/* check configured pix_fmt matches avctx->pix_fmt */ > > Is this comment really useful? ok, will remove > > > +pix_fmt_output =

[FFmpeg-devel] [PATCH 5/5 v2] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread James Almer
Signed-off-by: James Almer --- configure| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/obu.c| 277 +++ 4 files changed, 280 insertions(+) create mode 100644 libavformat/obu.c diff --git

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

2019-11-11 Thread Baptiste Coudurier
Hi Thomas, > On Nov 11, 2019, at 3:17 PM, Tomas Härdin wrote: > > lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: >> +static const UID mxf_dv_container_uls[] = { >> +{ >> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0D,0x01,0x03,0x01,0x02,0x02,0x01,0x01 >> }, // IEC DV25 525/60

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: correctly set width values for dvcprohd

2019-11-11 Thread Baptiste Coudurier
> On Nov 11, 2019, at 3:30 PM, Tomas Härdin wrote: > > lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: >> --- >> libavformat/mxfenc.c | 15 --- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c >> index

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-11 Thread Dale Curtis
On Fri, Nov 1, 2019 at 4:46 PM Carl Eugen Hoyos wrote: > Testing would be helpful. > > Works for AVIF after adding the line I proposed as well as setting codecpar->width/height for the stream based on ispe. Breaks AVIFS files that were previously demuxing as mp4 w/ video track, i.e.,

[FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

2019-11-11 Thread Baptiste Coudurier
--- libavformat/mxfenc.c | 128 --- 1 file changed, 46 insertions(+), 82 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index aa23ee3947..5e987488f6 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -83,6 +83,7 @@

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: correctly set width values for dvcprohd

2019-11-11 Thread Tomas Härdin
lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: > --- > libavformat/mxfenc.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index b7ae5cc637..f7df9c3daf 100644 > --- a/libavformat/mxfenc.c > +++

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

2019-11-11 Thread Tomas Härdin
lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: > +static const UID mxf_dv_container_uls[] = { > +{ > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0D,0x01,0x03,0x01,0x02,0x02,0x01,0x01 > }, // IEC DV25 525/60 > +{ >

Re: [FFmpeg-devel] [PATCH 2/5 V2] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread Andreas Rheinhardt
James Almer: > This BSF takes Temporal Units split across different AVPackets and merges them > by looking for Temporal Delimiter OBUs. > > Signed-off-by: James Almer > --- > Now copying packet props. > > configure| 1 + > libavcodec/Makefile | 1 + >

Re: [FFmpeg-devel] [RFC PATCH v2] avutil/frame: fix remove_side_data

2019-11-11 Thread Marton Balint
On Sun, 10 Nov 2019, Marton Balint wrote: On Sun, 3 Nov 2019, Zhao Zhili wrote: remove_side_data is supposed to remove a single instance by design. Since new_side_data() doesn't forbid add multiple instances of the same type, remove_side_data should deal with that. --- I'm afraid this

Re: [FFmpeg-devel] [PATCH] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode

2019-11-11 Thread James Almer
On 11/11/2019 11:16 AM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/librav1e.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c > index 5052cac896..11c1d09e36 100644 > ---

Re: [FFmpeg-devel] [PATCH 2/5] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread Andreas Rheinhardt
James Almer: > On 11/11/2019 12:01 PM, Andreas Rheinhardt wrote: >> James Almer: >>> This BSF takes Temporal Units split across different AVPackets and merges >>> them >>> by looking for Temporal Delimiter OBUs. >>> >>> Signed-off-by: James Almer >>> --- >>> configure|

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread James Almer
On 11/11/2019 4:28 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> configure| 1 + >> libavformat/Makefile | 1 + >> libavformat/allformats.c | 1 + >> libavformat/obu.c| 276 +++ >> 4

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > configure| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/obu.c| 276 +++ > 4 files changed, 279 insertions(+) > create mode 100644

Re: [FFmpeg-devel] [PATCH v1 2/2] avformat/mp3dec: replace SAME_HEADER_MASK with MP3_MASK

2019-11-11 Thread Michael Niedermayer
On Mon, Nov 11, 2019 at 09:05:02AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > mp3 header bitstream syntax: > header() > { > syncword 12bits bslsf > id 1bitbslsf > layer 2bitbslsf > protection_bit 1bit bslsf > bitrate_index 4bits bslsf >

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread James Almer
On 11/11/2019 2:36 PM, Carl Eugen Hoyos wrote: > > >> Am 11.11.2019 um 22:36 schrieb James Almer : >> >> +AVInputFormat ff_obu_demuxer = { >> +.name = "obu", > > Why is the demuxer not called “av1”? > > Thank you, Carl Eugen > (Sleepless in Japan) I liked obu more, being the

Re: [FFmpeg-devel] [PATCH 2/5] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread James Almer
On 11/11/2019 12:01 PM, Andreas Rheinhardt wrote: > James Almer: >> This BSF takes Temporal Units split across different AVPackets and merges >> them >> by looking for Temporal Delimiter OBUs. >> >> Signed-off-by: James Almer >> --- >> configure| 1 + >>

[FFmpeg-devel] [PATCH 2/5 V2] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread James Almer
This BSF takes Temporal Units split across different AVPackets and merges them by looking for Temporal Delimiter OBUs. Signed-off-by: James Almer --- Now copying packet props. configure| 1 + libavcodec/Makefile | 1 + libavcodec/av1_frame_merge_bsf.c |

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread Carl Eugen Hoyos
> Am 11.11.2019 um 22:36 schrieb James Almer : > > +AVInputFormat ff_obu_demuxer = { > +.name = "obu", Why is the demuxer not called “av1”? Thank you, Carl Eugen (Sleepless in Japan) ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/5] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread Andreas Rheinhardt
James Almer: > This BSF takes Temporal Units split across different AVPackets and merges them > by looking for Temporal Delimiter OBUs. > > Signed-off-by: James Almer > --- > configure| 1 + > libavcodec/Makefile | 1 + > libavcodec/av1_frame_merge_bsf.c

[FFmpeg-devel] [PATCH] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode

2019-11-11 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavcodec/librav1e.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 5052cac896..11c1d09e36 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -329,6 +329,10 @@ static

[FFmpeg-devel] [PATCH 2/5] avcodec: add an AV1 frame merge bitstream filter

2019-11-11 Thread James Almer
This BSF takes Temporal Units split across different AVPackets and merges them by looking for Temporal Delimiter OBUs. Signed-off-by: James Almer --- configure| 1 + libavcodec/Makefile | 1 + libavcodec/av1_frame_merge_bsf.c | 153

Re: [FFmpeg-devel] [PATCH v1 1/3] tests/fate/filter-video: add test for colorlevels

2019-11-11 Thread Michael Niedermayer
On Wed, Oct 23, 2019 at 06:27:41PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 6 +++ > tests/ref/fate/filter-colorlevels| 55 > tests/ref/fate/filter-colorlevels-16 | 55

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: Don't use restrict directly to fix build on MSVC

2019-11-11 Thread Michael Niedermayer
On Mon, Nov 11, 2019 at 11:02:25AM +, Matthias Troffaes wrote: > I can confirm this patch fixes the compile problem on MSVC. See: > > https://ci.appveyor.com/project/mcmtroffaes/ffmpeg-msvc-build/build/job/get5kbjlyw6w1vi5 >

[FFmpeg-devel] [PATCH 1/5] avcodec/cbs_av1: support one byte long OBUs when the size is not set in the bitstream

2019-11-11 Thread James Almer
This was missed in 96717a42715fdcc2f93558206e24d6dfd26b8d58, and will be needed by the next commit, where packets with a single Temporal Delimiter OBU with no size need to be parsed. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[FFmpeg-devel] [PATCH 3/5] avcodec/av1_parser: export bitstream timing info when available

2019-11-11 Thread James Almer
Based on h264_parser code. Signed-off-by: James Almer --- libavcodec/av1_parser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/av1_parser.c b/libavcodec/av1_parser.c index b916608d65..510cad987b 100644 --- a/libavcodec/av1_parser.c +++ b/libavcodec/av1_parser.c @@ -157,6

[FFmpeg-devel] [PATCH 5/5] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread James Almer
Signed-off-by: James Almer --- configure| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/obu.c| 276 +++ 4 files changed, 279 insertions(+) create mode 100644 libavformat/obu.c diff --git

[FFmpeg-devel] [PATCH 0/5] AV1 Annex B demuxer

2019-11-11 Thread James Almer
This includes a bitstream filter to merge Temporal Units split across different AVPackets, given that Annex B encapsulation splits OBUs at the Temporal Unit, Frame and OBU boundaries. Bitstream reconstruction is required to prevent propagating AVPackets with contents that could generate invalid

[FFmpeg-devel] [PATCH 4/5] avcodec/libdav1d: export bitstream timing info when available

2019-11-11 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libdav1d.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 98737cb162..cf4b178f1d 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -287,6 +287,13 @@ static int

Re: [FFmpeg-devel] [PATCH V4] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-11 Thread Tao Zhang
ping, at the beginning of the new week:) leozhang 于2019年11月3日周日 下午6:50写道: > > Reviewed-by: Paul B Mahol > Reviewed-by: Jun Zhao > Signed-off-by: leozhang > --- > libavfilter/vf_bilateral.c | 39 ++- > 1 file changed, 34 insertions(+), 5 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: Don't use restrict directly to fix build on MSVC

2019-11-11 Thread Matthias Troffaes
I can confirm this patch fixes the compile problem on MSVC. See: https://ci.appveyor.com/project/mcmtroffaes/ffmpeg-msvc-build/build/job/get5kbjlyw6w1vi5 https://github.com/mcmtroffaes/ffmpeg-msvc-build/commit/d1cc29f4c56937ec75b297bc6feaf0fd8989a549 Kind regards, Matthias On Sun, Nov 10, 2019

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Async the encoding and output procedure of encoder

2019-11-11 Thread Fu, Linjie
> -Original Message- > From: Fu, Linjie > Sent: Friday, November 8, 2019 00:32 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [PATCH] lavc/vaapi_encode: Async the encoding and output > procedure of encoder > > Currently, vaapi encodes a pic if all its references are ready, >

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: Set surfaces reference pool size according to SPS for H.264/HEVC

2019-11-11 Thread Fu, Linjie
> -Original Message- > From: Fu, Linjie > Sent: Wednesday, November 6, 2019 12:54 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [PATCH] lavc/vaapi_decode: Set surfaces reference pool size > according to SPS for H.264/HEVC > > Set surfaces pool used for storing reference

[FFmpeg-devel] [PATCH] lavc/qsv: Standardize some usages of ff_qsv_print_error

2019-11-11 Thread Linjie Fu
ff_qsv_print_error would output the ":" and "\n" internally in the function. Signed-off-by: Linjie Fu --- libavcodec/qsv.c| 2 +- libavcodec/qsvdec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index b00e427435..ec87ed7a3f