[FFmpeg-devel] [PATCH] Changelog: Fix typo of comments

2019-12-20 Thread Steven Liu
Signed-off-by: Steven Liu --- Changelog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index d654ea5321..2b576b8051 100644 --- a/Changelog +++ b/Changelog @@ -5,8 +5,8 @@ version : - v360 filter - Intel QSV-accelerated MJPEG decoding - Intel

Re: [FFmpeg-devel] [PATCH][DISCUSS] nvenc: Add encoder flush API.

2019-12-20 Thread Philip Langdale
On Fri, 20 Dec 2019 19:12:00 -0500 Dennis Mungai wrote: > On Fri, 20 Dec 2019 at 19:03, Josh Allmann > > For CLI usage, does this affect the behavior of the global output > option > > -flush_packets 1 > > When the NVENC encoder is in use, in any way? It's unrelated. This is a muxer level

[FFmpeg-devel] [PATCH v4 4/4] avcodec/h264: create user data unregistered side data H.264

2019-12-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264_sei.c | 20 +++-- libavcodec/h264_sei.h | 2 + libavcodec/h264_slice.c | 14 tests/ref/fate/mov-zombie | 195 ++ 4 files changed, 161 insertions(+), 70 deletions(-)

[FFmpeg-devel] [PATCH v4 2/4] avcodec/hevc_sei: add support for user data unregistered SEI message

2019-12-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_sei.c | 31 +++ libavcodec/hevc_sei.h | 6 ++ libavcodec/hevcdec.c| 14 ++ tests/ref/fate/hevc-monochrome-crop | 3 +++ 4 files changed, 54

Re: [FFmpeg-devel] [PATCH v3 4/5] avcodec/h264_sei: fix the size of user data unregistered

2019-12-20 Thread James Almer
On 12/19/2019 2:09 AM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > According to the specifications, the payloadSize includes the 16-byte size of > UUID. > > Signed-off-by: Limin Wang > --- > libavcodec/h264_sei.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: keep closed captions in sync between multiple thread contexts

2019-12-20 Thread Limin Wang
On Fri, Dec 20, 2019 at 02:05:42PM -0300, James Almer wrote: > Based on h264 code. > > Signed-off-by: James Almer > --- > libavcodec/hevcdec.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index f8270b87c3..19b0cd815d 100644 > ---

Re: [FFmpeg-devel] [PATCH v3 3/5] avfilter/vf_showinfo: display user data unregistered message

2019-12-20 Thread Limin Wang
On Fri, Dec 20, 2019 at 02:30:23PM -0300, James Almer wrote: > On 12/19/2019 2:09 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_showinfo.c | 33 + > > 1 file changed, 33 insertions(+) > > > >

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/hevc_sei: add support for user data unregistered SEI message

2019-12-20 Thread Limin Wang
On Fri, Dec 20, 2019 at 02:23:40PM -0300, James Almer wrote: > On 12/19/2019 2:09 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/hevc_sei.c | 34 + > > libavcodec/hevc_sei.h

Re: [FFmpeg-devel] [PATCH][DISCUSS] nvenc: Add encoder flush API.

2019-12-20 Thread Dennis Mungai
On Fri, 20 Dec 2019 at 19:03, Josh Allmann wrote: > > On Fri, 20 Dec 2019 at 15:36, Philip Langdale wrote: > > > > On 2019-11-18 17:13, Josh Allmann wrote: > > > This patch is meant to be an entry point for discussion around an > > > issue we are having with flushing the nvenc encoder while

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-20 Thread Josh Allmann
On Fri, 20 Dec 2019 at 15:34, Philip Langdale wrote: > > It can be useful to re-use an encoder instance when doing segmented > encodings, and this requires flushing the encoder at the start of > each segment. > --- > libavcodec/nvenc.c | 5 + > libavcodec/nvenc.h | 2 ++ >

Re: [FFmpeg-devel] [PATCH][DISCUSS] nvenc: Add encoder flush API.

2019-12-20 Thread Josh Allmann
On Fri, 20 Dec 2019 at 15:36, Philip Langdale wrote: > > On 2019-11-18 17:13, Josh Allmann wrote: > > This patch is meant to be an entry point for discussion around an > > issue we are having with flushing the nvenc encoder while doing > > segmented transcoding. Hopefully there will be a less

Re: [FFmpeg-devel] [PATCH][DISCUSS] nvenc: Add encoder flush API.

2019-12-20 Thread Philip Langdale
On 2019-11-18 17:13, Josh Allmann wrote: This patch is meant to be an entry point for discussion around an issue we are having with flushing the nvenc encoder while doing segmented transcoding. Hopefully there will be a less kludgey workaround than this. Hi Josh, I happened to see your email

[FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-20 Thread Philip Langdale
It can be useful to re-use an encoder instance when doing segmented encodings, and this requires flushing the encoder at the start of each segment. --- libavcodec/nvenc.c | 5 + libavcodec/nvenc.h | 2 ++ libavcodec/nvenc_h264.c | 1 + libavcodec/nvenc_hevc.c | 1 + 4 files changed,

Re: [FFmpeg-devel] [PATCHv2] movenc: Write durations based on pts into mvhd/mdhd/tkhd/elst

2019-12-20 Thread Michael Niedermayer
On Tue, Dec 17, 2019 at 03:15:09PM +0200, Martin Storsjö wrote: > Keep all the existing data fields as they are (there's lots and > lots of nontrivial calculation and heuristics based on them in > their current form), but derive the duration as the difference > between the pts of the first packet

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-20 Thread James Zern
On Wed, Dec 18, 2019 at 4:17 PM Wonkap Jang wrote: > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > and modifies the example to match the description. > --- > doc/encoders.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > applied, thanks.

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

2019-12-20 Thread James Zern
On Wed, Dec 18, 2019 at 7:25 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > libavcodec/libaomenc.c | 6 ++ Can you update doc/encoders.texi with this detail please? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 3/5] avfilter/vf_showinfo: display user data unregistered message

2019-12-20 Thread James Almer
On 12/19/2019 2:09 AM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/hevc_sei: add support for user data unregistered SEI message

2019-12-20 Thread James Almer
On 12/19/2019 2:09 AM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/hevc_sei.c | 34 + > libavcodec/hevc_sei.h | 6 + > libavcodec/hevcdec.c| 18 +++ >

Re: [FFmpeg-devel] [PATCH v1] avcodec/hevc_sei: switch to AVBufferRef buffer for a53 caption

2019-12-20 Thread James Almer
On 12/19/2019 10:17 PM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > Please apply after the following patch: > https://patchwork.ffmpeg.org/patch/16878/ It doesn't really depend on it, so i'll apply it alone while that set is reviewed. Thanks. > >

[FFmpeg-devel] [PATCH] avcodec/hevcdec: keep closed captions in sync between multiple thread contexts

2019-12-20 Thread James Almer
Based on h264 code. Signed-off-by: James Almer --- libavcodec/hevcdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index f8270b87c3..19b0cd815d 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -3463,6 +3463,13 @@ static

[FFmpeg-devel] -progress option per output

2019-12-20 Thread vivien anglesio
Hi, I would like to work on a "per output" -progress option. I will try to implement this myself but before putting my hands on it I wanted to discuss about the different solutions with the community. I have three of them in mind Proposition 1. to put all output progress feedback in the same

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: warn users if codec isn't supported

2019-12-20 Thread Gyan
Regards, Gyan From fbbd221b089f3b272cfd712c3d4824dd86b4eac0 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 20 Dec 2019 16:39:32 +0530 Subject: [PATCH] avformat/mpegtsenc: warn users if codec isn't supported The MPEG-TS muxer will mux streams with unsupported codec id as a private data

[FFmpeg-devel] [PATCH v4 3/7] avformat: Add av_stream_add_coded_side_data()

2019-12-20 Thread Nicolas Gaullier
This will allow avformat_find_stream_info() get side data from the codec context. --- doc/APIchanges | 3 +++ libavformat/avformat.h | 11 +++ libavformat/utils.c| 15 +++ libavformat/version.h | 4 ++-- 4 files changed, 31 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v3 3/7] avformat: Add av_stream_add_coded_side_data()

2019-12-20 Thread Andreas Rheinhardt
Nicolas Gaullier: > This will allow avformat_find_stream_info() get side data from the codec > context. > --- > doc/APIchanges | 3 +++ > libavformat/avformat.h | 11 +++ > libavformat/utils.c| 15 +++ > libavformat/version.h | 4 ++-- > 4 files changed, 31

[FFmpeg-devel] [PATCH v3 3/7] avformat: Add av_stream_add_coded_side_data()

2019-12-20 Thread Nicolas Gaullier
This will allow avformat_find_stream_info() get side data from the codec context. --- doc/APIchanges | 3 +++ libavformat/avformat.h | 11 +++ libavformat/utils.c| 15 +++ libavformat/version.h | 4 ++-- 4 files changed, 31 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat: Add av_stream_add_coded_side_data()

2019-12-20 Thread Gaullier Nicolas
>> #define LIBAVFORMAT_VERSION_MAJOR 58 >> -#define LIBAVFORMAT_VERSION_MINOR 35 >> +#define LIBAVFORMAT_VERSION_MINOR 36 >> #define LIBAVFORMAT_VERSION_MICRO 101 >> >You forgot to reset micro. > >- Andreas Sorry, I just checked the git log and now understand how micro versions works. I will

Re: [FFmpeg-devel] [PATCH 3/7] avformat/icecast: Free the right buffer on error

2019-12-20 Thread Marvin Scholz
On 19 Dec 2019, at 23:36, Andreas Rheinhardt wrote: > Michael Niedermayer: >> On Sun, Nov 10, 2019 at 05:07:29AM +0100, Andreas Rheinhardt wrote: >>> In case an AVBPrint was not complete, icecast_open() would free some >>> buffers that have not been allocated yet instead of freeing the data of

Re: [FFmpeg-devel] [PATCH 4/7] avformat/icecast: Use AV_DICT_DONT_STRDUP_VAL to save an av_strdup

2019-12-20 Thread Marvin Scholz
On 10 Nov 2019, at 5:07, Andreas Rheinhardt wrote: This will probably also fix CID 1452559, a false positive where Coverity claims a double-free occurs, because it thinks that av_dict_set() frees its key and value arguments even when the AV_DICT_DONT_STRDUP_* flags aren't used.