[FFmpeg-devel] [PATCH v2] avfilter: add overlay vaapi filter

2020-01-05 Thread Xinpeng Sun
Overlay one video on the top of another. It takes two inputs and has one output. The first input is the "main" video on which the second input is overlaid. This filter requires same memory layout for all the inputs. An example command to use this filter to overlay an image LOGO at the top-left

Re: [FFmpeg-devel] [PATCH V4 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2020-01-05 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Friday, January 3, 2020 04:36 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4 1/2] libswscale/x86/yuv2rgb: Change > inline assembly into nasm code > > On

[FFmpeg-devel] [PATCH V5 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2020-01-05 Thread Ting Fu
Tested using this command: /ffmpeg -pix_fmt yuv420p -s 1920*1080 -i ArashRawYuv420.yuv \ -vcodec rawvideo -s 1920*1080 -pix_fmt rgb24 -f null /dev/null The fps increase from 389 to 640 on my local machine. Signed-off-by: Ting Fu --- libswscale/x86/yuv2rgb.c | 7 +-

[FFmpeg-devel] [PATCH V5 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2020-01-05 Thread Ting Fu
Signed-off-by: Ting Fu --- libswscale/x86/Makefile | 1 + libswscale/x86/swscale.c | 16 +- libswscale/x86/yuv2rgb.c | 81 +++--- libswscale/x86/yuv2rgb_template.c | 441 ++ libswscale/x86/yuv_2_rgb.asm | 270 ++ 5

Re: [FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2020-01-05 Thread Gyan
Ping for the remainder of patchset.  Expression parsing and backup has been factorized so code duplication is minimized. On 01-01-2020 01:12 am, Gyan Doshi wrote: Retains parsed expressions which allows for better error-checking and adding animation support. --- First version was rebased

Re: [FFmpeg-devel] [PATCH v1] doc/filters: add missing entry for the showinfo

2020-01-05 Thread Gyan
On 06-01-2020 07:00 am, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 6cbbe88..b3574e6 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

2020-01-05 Thread zhilizhao
> On Jan 4, 2020, at 9:43 PM, zhilizhao wrote: > > > >> On Jan 4, 2020, at 9:09 PM, Paul B Mahol > > wrote: >> >> On 1/4/20, zhilizhao > > wrote: >>> >>> On Jan 4, 2020, at 7:04 PM, Paul B Mahol >>> >

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/h2645_parse: Don't automatically remove nuh_layer_id > 0 packets

2020-01-05 Thread Andriy Gelman
On Fri, 13. Dec 22:18, Andriy Gelman wrote: > On Thu, 05. Dec 22:15, Andriy Gelman wrote: > > From: Andriy Gelman > > > > HEVC standard supports multi-layer streams (ITU-T H.265 02/2018 Annex > > F). Each NAL unit belongs to a particular layer defined by nuh_layer_id > > in the header. > > > >

Re: [FFmpeg-devel] [PATCH] CDToons decoder

2020-01-05 Thread Carl Eugen Hoyos
Am So., 5. Jan. 2020 um 22:57 Uhr schrieb Alyssa Milburn : > diff --git a/libavformat/riff.c b/libavformat/riff.c > index c73f6e9db0..560a3aa208 100644 > --- a/libavformat/riff.c > +++ b/libavformat/riff.c > @@ -491,6 +491,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { > { AV_CODEC_ID_IMM5,

Re: [FFmpeg-devel] [PATCH V1 04/12] lavc/libvpxenc: fix memory leak after av_dict_parse_string fail

2020-01-05 Thread myp...@gmail.com
On Sat, Jan 4, 2020 at 7:34 AM James Zern wrote: > > Hi, > > On Tue, Dec 31, 2019 at 9:21 PM Jun Zhao wrote: > > > > From: Jun Zhao > > > > In case of failure, all the successfully set entries are stored in > > *pm. We need to manually free the created dictionary to avoid > > memory leak. > > >

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_showinfo: Fix erroneous results for mean and stdev with pixel bits >8

2020-01-05 Thread Limin Wang
ping, please review it. I'll add packed format support after that. On Fri, Nov 29, 2019 at 07:28:23PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Have tested with be and le pixel format on be and le system for >8bit. > System: > lmwang@ubuntu:~/ffmpeg.git.mips$ grep

Re: [FFmpeg-devel] [PATCH 2/6] avformat: remove uneeded avio_flush() calls from the end of write_header functions

2020-01-05 Thread Marton Balint
On Sun, 5 Jan 2020, Martin Storsjö wrote: On Sun, 5 Jan 2020, Marton Balint wrote: The IO context is flushed by libavformat/mux.c after writing the header by calling avio_write_marker(s->pb, AV_NOPTS_VALUE, AVIO_DATA_MARKER_UNKNOWN), so this change should have no effect at all.

Re: [FFmpeg-devel] [PATCH v2] lavc/ffv1: Properly check that the 4th and 5th quant tables are zeroes

2020-01-05 Thread Michael Niedermayer
On Sun, Jan 05, 2020 at 02:45:25PM +, Derek Buitenhuis wrote: > Currently, the decoder checks the 128th value of the 4th quant table during > while deriving the context on each sample, in order to speed itself up. This > is due to relying on the behavior of FFmpeg's FFV1 encoder, in which if

Re: [FFmpeg-devel] [PATCH] CDToons decoder

2020-01-05 Thread James Almer
On 1/5/2020 6:57 PM, Alyssa Milburn wrote: > This adds a decoder for Broderbund's sprite-based QuickTime CDToons > codec, based on the decoder I wrote for ScummVM. > > A couple of samples can be found at http://noopwafel.net/cdtoons/. > > Signed-off-by: Alyssa Milburn > --- > Changelog

[FFmpeg-devel] [PATCH] CDToons decoder

2020-01-05 Thread Alyssa Milburn
This adds a decoder for Broderbund's sprite-based QuickTime CDToons codec, based on the decoder I wrote for ScummVM. A couple of samples can be found at http://noopwafel.net/cdtoons/. Signed-off-by: Alyssa Milburn --- Changelog | 1 + doc/general.texi| 2 +

Re: [FFmpeg-devel] [PATCH 6/6] avformat: convert some avio_flush() calls to avio_write_marker(AVIO_DATA_MARKER_FLUSH_POINT)

2020-01-05 Thread Martin Storsjö
On Sun, 5 Jan 2020, Marton Balint wrote: Converting explicit avio_flush() calls helps us to buffer more data and avoid flushing the IO context too often which causes reduced IO throughput for non-streamed file output. The user can control FLUSH_POINT flushing behaviour using the -flush_packets

Re: [FFmpeg-devel] [PATCH 5/6] avformat: remove more unneeded avio_flush() calls

2020-01-05 Thread Martin Storsjö
On Sun, 5 Jan 2020, Marton Balint wrote: These instances are simply redundant or present because avio_flush() used to be required before doing a seekback. That is no longer the case, aviobuf code does the flush automatically on seek. This only affects code which is either disabled for

Re: [FFmpeg-devel] [PATCH 4/6] avformat: remove avio_flush() calls from the end of write_packet functions

2020-01-05 Thread Martin Storsjö
On Sun, 5 Jan 2020, Marton Balint wrote: Removing explicit avio_flush() calls helps us to buffer more data and avoid flushing the IO context too often which causes reduced IO throughput for non-streamed file output. The user can control flushing behaviour at the end of every packet using the

Re: [FFmpeg-devel] [PATCH 2/6] avformat: remove uneeded avio_flush() calls from the end of write_header functions

2020-01-05 Thread Martin Storsjö
On Sun, 5 Jan 2020, Marton Balint wrote: The IO context is flushed by libavformat/mux.c after writing the header by calling avio_write_marker(s->pb, AV_NOPTS_VALUE, AVIO_DATA_MARKER_UNKNOWN), so this change should have no effect at all. Signed-off-by: Marton Balint If I read

Re: [FFmpeg-devel] [PATCH 3/6] avformat: remove uneeded avio_flush() calls from the end of write_trailer functions

2020-01-05 Thread Martin Storsjö
On Sun, 5 Jan 2020, Marton Balint wrote: The IO context is always flushed by libavformat/mux.c after write_trailer is called, so this change should have no effect at all. --- libavformat/aiffenc.c| 2 -- libavformat/astenc.c | 1 - libavformat/au.c | 1 - libavformat/cafenc.c |

Re: [FFmpeg-devel] [PATCH 1/6] avformat: remove unneded avio_flush() calls before calling avio_close_dyn_buf()

2020-01-05 Thread Martin Storsjö
On Sun, 5 Jan 2020, Marton Balint wrote: avio_close_dyn_buf() also does avio_flush(). Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 2 -- libavformat/oggenc.c | 1 - libavformat/rtpdec.c | 2 -- 3 files changed, 5 deletions(-) LGTM // Martin

[FFmpeg-devel] [PATCH v2] lavc/ffv1: Properly check that the 4th and 5th quant tables are zeroes

2020-01-05 Thread Derek Buitenhuis
Currently, the decoder checks the 128th value of the 4th quant table during while deriving the context on each sample, in order to speed itself up. This is due to relying on the behavior of FFmpeg's FFV1 encoder, in which if that value is zero, the entire 4th and 5th quant tables are assumed to be

[FFmpeg-devel] [PATCH 5/6] avformat: remove more unneeded avio_flush() calls

2020-01-05 Thread Marton Balint
These instances are simply redundant or present because avio_flush() used to be required before doing a seekback. That is no longer the case, aviobuf code does the flush automatically on seek. This only affects code which is either disabled for streaming IO contexts or does no seekbacks after the

[FFmpeg-devel] [PATCH 6/6] avformat: convert some avio_flush() calls to avio_write_marker(AVIO_DATA_MARKER_FLUSH_POINT)

2020-01-05 Thread Marton Balint
Converting explicit avio_flush() calls helps us to buffer more data and avoid flushing the IO context too often which causes reduced IO throughput for non-streamed file output. The user can control FLUSH_POINT flushing behaviour using the -flush_packets option, the default typically means to

[FFmpeg-devel] [PATCH 2/6] avformat: remove uneeded avio_flush() calls from the end of write_header functions

2020-01-05 Thread Marton Balint
The IO context is flushed by libavformat/mux.c after writing the header by calling avio_write_marker(s->pb, AV_NOPTS_VALUE, AVIO_DATA_MARKER_UNKNOWN), so this change should have no effect at all. Signed-off-by: Marton Balint --- libavformat/aiffenc.c | 3 --- libavformat/amr.c | 1

[FFmpeg-devel] [PATCH 4/6] avformat: remove avio_flush() calls from the end of write_packet functions

2020-01-05 Thread Marton Balint
Removing explicit avio_flush() calls helps us to buffer more data and avoid flushing the IO context too often which causes reduced IO throughput for non-streamed file output. The user can control flushing behaviour at the end of every packet using the -flush_packets option, the default typically

[FFmpeg-devel] [PATCH 1/6] avformat: remove unneded avio_flush() calls before calling avio_close_dyn_buf()

2020-01-05 Thread Marton Balint
avio_close_dyn_buf() also does avio_flush(). Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 2 -- libavformat/oggenc.c | 1 - libavformat/rtpdec.c | 2 -- 3 files changed, 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 561e3ff736..d130f03ea6 100644 ---

[FFmpeg-devel] [PATCH 3/6] avformat: remove uneeded avio_flush() calls from the end of write_trailer functions

2020-01-05 Thread Marton Balint
The IO context is always flushed by libavformat/mux.c after write_trailer is called, so this change should have no effect at all. --- libavformat/aiffenc.c| 2 -- libavformat/astenc.c | 1 - libavformat/au.c | 1 - libavformat/cafenc.c | 1 - libavformat/flacenc.c| 1 -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pgssubdec: Free subtitle on error

2020-01-05 Thread Michael Niedermayer
On Sun, Jan 05, 2020 at 08:44:50AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the