Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-20 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Martin Storsj? > Sent: Tuesday, January 21, 2020 4:38 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use > bit-exact

Re: [FFmpeg-devel] [PATCH v3] avformat/rtpdec_rfc4175: support non-zero based line numbers

2020-01-20 Thread Jacob Siddall
On 11/7/19, Michael Niedermayer wrote: > I see there are multiple People working on this and others who worked > previously on this. Can one of the people working on this code > please review this ? > Iam happy to apply it if its reviewed (assuming noone spots anything > bad of course) Just had a

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-20 Thread Zhong Li
Jon Cook 于2020年1月20日周一 下午5:58写道: > > From: JonCookCubic > > Currently width_align and height_align are zero which cases "Error submitting > the frame for encoding". This change sets the alignments. Could you help to provide detail steps (CLI and input video) to reproduce the issue? > > Signed-

Re: [FFmpeg-devel] [PATCH v4 1/1] avdevice/gdigrab add use_captureblt option

2020-01-20 Thread fgodt
在 2020/1/17 10:04, fgodt 写道: On 2020/1/17 上午2:00, Calvin Walton wrote: On Thu, 2020-01-16 at 09:08 +0800, fgodt wrote: By default, this is set to @code{1}, which means that gdigrab will use the CAPTUREBLT flag when grabbing images of a window. With this flag set, gdigrab will capture the ent

Re: [FFmpeg-devel] [PATCH] avcodec/mlpdec: filter invalid block size

2020-01-20 Thread Carl Eugen Hoyos
Am Do., 9. Jan. 2020 um 04:54 Uhr schrieb Xingwen.Fang : > > From: Xingwen Fang > > When the block size is illegal, we don't need to read the > block data. Otherwise, there will be abnormal memory access > in dsp.mlp_filter_channel. > > Signed-off-by: Xingwen Fang > --- > libavcodec/mlpdec.c | 5

[FFmpeg-devel] [PATCH 2/2] avcodec/j2kenc: Simplify creation of luts

2020-01-20 Thread Andreas Rheinhardt
1. i * i + (1 << (NMSEDC_FRACBITS - 1)) is always positive (and it doesn't overflow), so one can remove the FFMAX in the computation of lut_nmsedec_sig0. 2. The discriminant of the polynomial i * i - 2^(F + 1) * i + 2^(2 * F) + 2^(F - 1) is negative; hence this polynomial has no real solutions, i.e

[FFmpeg-devel] [PATCH 1/2] avcodec/j2kenc: Fix undefined shifts of negative numbers

2020-01-20 Thread Andreas Rheinhardt
Also add parentheses to some lines to make the operator precedence clearer. This affected the FATE-tests vsynth*-jpeg2000 and vsynth*-jpeg2000-97 (where * ranges over { 1, 2, 3, _lena }) as well as ticket #7983. Signed-off-by: Andreas Rheinhardt --- Supersedes https://ffmpeg.org/pipermail/ffmpeg

Re: [FFmpeg-devel] [PATCH 25/25] avformat/matroskaenc: Redo handling of FlagDefault

2020-01-20 Thread Carl Eugen Hoyos
Am Di., 21. Jan. 2020 um 00:43 Uhr schrieb Andreas Rheinhardt : > > On Tue, Jan 21, 2020 at 12:11 AM Carl Eugen Hoyos > wrote: > > > Am Sa., 18. Jan. 2020 um 09:46 Uhr schrieb Andreas Rheinhardt > > : > > > > > > Up until now, the Matroska muxer would mark a track as default if it had > > > the di

Re: [FFmpeg-devel] [PATCH 25/25] avformat/matroskaenc: Redo handling of FlagDefault

2020-01-20 Thread Andreas Rheinhardt
On Tue, Jan 21, 2020 at 12:11 AM Carl Eugen Hoyos wrote: > Am Sa., 18. Jan. 2020 um 09:46 Uhr schrieb Andreas Rheinhardt > : > > > > Up until now, the Matroska muxer would mark a track as default if it had > > the disposition AV_DISPOSITION_DEFAULT or if there was no track with > > AV_DISPOSITION

Re: [FFmpeg-devel] [PATCH 25/25] avformat/matroskaenc: Redo handling of FlagDefault

2020-01-20 Thread Carl Eugen Hoyos
Am Sa., 18. Jan. 2020 um 09:46 Uhr schrieb Andreas Rheinhardt : > > Up until now, the Matroska muxer would mark a track as default if it had > the disposition AV_DISPOSITION_DEFAULT or if there was no track with > AV_DISPOSITION_DEFAULT set; in the latter case even more than one track > of a kind (

Re: [FFmpeg-devel] [PATCH]lavc/mpegvideo_enc: Do not write an extra RST tag after final jpeg slice

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 23:34 Uhr schrieb Michael Niedermayer : > > On Mon, Jan 20, 2020 at 11:15:31PM +0100, Carl Eugen Hoyos wrote: > > Am Mo., 20. Jan. 2020 um 22:51 Uhr schrieb Michael Niedermayer > > : > > > > > > On Mon, Jan 20, 2020 at 12:54:21AM +0100, Carl Eugen Hoyos wrote: > > > > Hi! >

Re: [FFmpeg-devel] [PATCH]lavc/mpegvideo_enc: Do not write an extra RST tag after final jpeg slice

2020-01-20 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 11:15:31PM +0100, Carl Eugen Hoyos wrote: > Am Mo., 20. Jan. 2020 um 22:51 Uhr schrieb Michael Niedermayer > : > > > > On Mon, Jan 20, 2020 at 12:54:21AM +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #8412. > > > > > > Please comment, Carl

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Andreas Rheinhardt
On Mon, Jan 20, 2020 at 2:26 PM Carl Eugen Hoyos wrote: > Am Mo., 20. Jan. 2020 um 14:18 Uhr schrieb Bodecs Bela >: > > 2020.01.20. 14:02 keltezéssel, Carl Eugen Hoyos írta: > > So why the warning did disappear? > > I believe newer compilers detect that hls->nb_varstreams cannot > be zero. > > I

Re: [FFmpeg-devel] [PATCH]lavc/mpegvideo_enc: Do not write an extra RST tag after final jpeg slice

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 22:51 Uhr schrieb Michael Niedermayer : > > On Mon, Jan 20, 2020 at 12:54:21AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #8412. > > > > Please comment, Carl Eugen > > > mpegvideo_enc.c |7 --- > > 1 file changed, 4 insertions(+), 3

Re: [FFmpeg-devel] [PATCH]lavc/mpegvideo_enc: Do not write an extra RST tag after final jpeg slice

2020-01-20 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 12:54:21AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #8412. > > Please comment, Carl Eugen > mpegvideo_enc.c |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > 73d8636d0dba4f02cf1697b622c97945d738f06f > 0001-lavc-mpegvideo_en

Re: [FFmpeg-devel] [PATCH 2/2] avformat/libzmq: Replace fail statements with goto

2020-01-20 Thread Paul B Mahol
LGTM On 1/11/20, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavformat/libzmq.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c > index 2df55542c7e..8c8b294

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-20 Thread Martin Storsjö
On Mon, 20 Jan 2020, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Monday, January 20, 2020 10:14 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fate/filter-vide

[FFmpeg-devel] [PATCH] [fateserver] Include slot owner in summary hash

2020-01-20 Thread Martin Storsjo
From: Mans Rullgard --- I think this should allow filtering on the owner by doing /index.cgi?query=owner:, but as I don't have access to the actual fate server, I'd appreciate if someone could try it out. --- FATE.pm| 14 +- report.cgi | 8 +--- 2 files changed, 14 insertion

[FFmpeg-devel] [PATCH 1/2] avcodec/adxenc: Avoid undefined left shift of negative numbers

2020-01-20 Thread Andreas Rheinhardt
Replace "((a << shift) + b) >> shift" by "a + (b >> shift)". This avoids a left shift which also happens to trigger undefined behaviour in case "a" is negative. This affected the FATE-tests acodec-adpcm-adx and acodec-adpcm-adx-trellis; it also fixes ticket #8008. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 2/2] avcodec/adxdec: Remove unnecessary left-shift

2020-01-20 Thread Andreas Rheinhardt
Replace "(a * (1 << shift) * b + c) >> shift" by "a * b + (c >> shift)". It is equivalent to the old code because a is in the range of uint16_t, shift is 12 and b is effectively a signed 4-bit number, so that no overflow/truncation of high bits happens during the multiplication (overflow would be u

[FFmpeg-devel] [PATCH] libavcodec/exr.c: Made channel name comparisons case insensitive.

2020-01-20 Thread ggarra13
From: Gonzalo Garramuño This change allows ffmpeg to match channel names in lowercase, like Diffuse.r in addition to Diffuse.R. --- libavcodec/exr.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index aeeaed40f5..

Re: [FFmpeg-devel] [PATCH] doc/fftools-common-opts: small fix to -report documentation.

2020-01-20 Thread Nicolas George
Gyan (12020-01-20): > LGTM. Thanks, pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH] doc/fftools-common-opts: small fix to -report documentation.

2020-01-20 Thread Gyan
On 20-01-2020 09:41 pm, Nicolas George wrote: Signed-off-by: Nicolas George --- doc/fftools-common-opts.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 1234de850e..31cf424823 100644 --- a/doc/fftools-

[FFmpeg-devel] [PATCH v3] avcodec/adpcm: Fix undefined left shifts of negative numbers

2020-01-20 Thread Andreas Rheinhardt
Affected the adpcm-afc, adpcm-ea-1, adpcm-ea-2, adpcm-ea-maxis-xa, adpcm-thp and ea-cdata FATE-tests. Also fixes ticket #8487. Signed-off-by: Andreas Rheinhardt --- libavcodec/adpcm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/adpcm.c b/libavc

[FFmpeg-devel] [PATCH] doc/fftools-common-opts: small fix to -report documentation.

2020-01-20 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/fftools-common-opts.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 1234de850e..31cf424823 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-20 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Monday, January 20, 2020 10:14 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use > bit-exa

Re: [FFmpeg-devel] [PATCH 2/2] avformat/libzmq: Replace fail statements with goto

2020-01-20 Thread Andriy Gelman
On Fri, 10. Jan 23:25, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavformat/libzmq.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c > index 2df55542c7e..8

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 14:25 Uhr schrieb Martin Storsjö : > Keep in mind that ideally, you shouldn't be changing the reference files > in the separate samples directory incrementially; ideally they should be > fairly static. Since not everybody is a native speaker: You cannot change reference f

[FFmpeg-devel] FOSDEM

2020-01-20 Thread Carl Eugen Hoyos
Hi! Just a friendly reminder: FOSDEM, the biggest European Open source Software Developers' meeting is taking place 1 & 2 February 2020 in Brussels. All active FFmpeg contributors can get full travel re-imbursement (railway or economy class flight to Brussels and back home) including accommodation

Re: [FFmpeg-devel] [PATCH] fate/filter-video: add two tests for dnn_processing with frame format rgb24 and grayf32

2020-01-20 Thread Pedro Arthur
Em seg., 20 de jan. de 2020 às 10:01, Martin Storsjö escreveu: > > On Tue, 14 Jan 2020, Pedro Arthur wrote: > > > Hi, > > > > Em qua., 8 de jan. de 2020 às 03:52, Guo, Yejun > > escreveu: > >> > >> Signed-off-by: Guo, Yejun > >> --- > >> tests/fate/filter-video.mak| 4

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Bodecs Bela
2020.01.20. 14:25 keltezéssel, Carl Eugen Hoyos írta: Am Mo., 20. Jan. 2020 um 14:18 Uhr schrieb Bodecs Bela : 2020.01.20. 14:02 keltezéssel, Carl Eugen Hoyos írta: This patch corrects compiler warning about returning possibly uninitialized variable in hls_write_header function. Which compil

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 14:18 Uhr schrieb Bodecs Bela : > > > 2020.01.20. 14:02 keltezéssel, Carl Eugen Hoyos írta: > > > This patch corrects compiler warning about returning possibly > uninitialized > variable in hls_write_header function. > > Which c

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-20 Thread Martin Storsjö
On Sat, 18 Jan 2020, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Saturday, January 18, 2020 7:06 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fate/filter-

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Bodecs Bela
2020.01.20. 14:02 keltezéssel, Carl Eugen Hoyos írta: This patch corrects compiler warning about returning possibly uninitialized variable in hls_write_header function. Which compiler warns about this? libavformat/hlsenc.c: In function ‘hls_write_header’: libavformat/hlsenc.c:2174: warning:

Re: [FFmpeg-devel] [PATCH] fate/filter-video: add two tests for dnn_processing with frame format rgb24 and grayf32

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 14:01 Uhr schrieb Martin Storsjö : > > On Tue, 14 Jan 2020, Pedro Arthur wrote: > > > Hi, > > > > Em qua., 8 de jan. de 2020 às 03:52, Guo, Yejun > > escreveu: > >> > >> Signed-off-by: Guo, Yejun > >> --- > >> tests/fate/filter-video.mak| 4 ++ >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 13:56 Uhr schrieb Bodecs Bela : > > > 2020.01.20. 13:46 keltezéssel, Carl Eugen Hoyos írta: > > Am Mo., 20. Jan. 2020 um 13:18 Uhr schrieb Bodecs Bela : > >> > >> 2020.01.20. 13:07 keltezéssel, Carl Eugen Hoyos írta: > >>> Am Mo., 20. Jan. 2020 um 09:41 Uhr schrieb Bodecs B

Re: [FFmpeg-devel] [PATCH] fate/filter-video: add two tests for dnn_processing with frame format rgb24 and grayf32

2020-01-20 Thread Martin Storsjö
On Tue, 14 Jan 2020, Pedro Arthur wrote: Hi, Em qua., 8 de jan. de 2020 às 03:52, Guo, Yejun escreveu: Signed-off-by: Guo, Yejun --- tests/fate/filter-video.mak| 4 ++ ...filter-dnn_processing-halve_first_channel_float | 55 ++ .../fate/filter-d

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Bodecs Bela
2020.01.20. 13:46 keltezéssel, Carl Eugen Hoyos írta: Am Mo., 20. Jan. 2020 um 13:18 Uhr schrieb Bodecs Bela : 2020.01.20. 13:07 keltezéssel, Carl Eugen Hoyos írta: Am Mo., 20. Jan. 2020 um 09:41 Uhr schrieb Bodecs Bela : 2020.01.20. 8:46 keltezéssel, Andreas Rheinhardt írta: On Mon, Jan 20

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 13:18 Uhr schrieb Bodecs Bela : > > > 2020.01.20. 13:07 keltezéssel, Carl Eugen Hoyos írta: > > Am Mo., 20. Jan. 2020 um 09:41 Uhr schrieb Bodecs Bela : > >> > >> 2020.01.20. 8:46 keltezéssel, Andreas Rheinhardt írta: > >>> On Mon, Jan 20, 2020 at 8:35 AM Bodecs Bela wrote

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Bodecs Bela
2020.01.20. 13:07 keltezéssel, Carl Eugen Hoyos írta: Am Mo., 20. Jan. 2020 um 09:41 Uhr schrieb Bodecs Bela : 2020.01.20. 8:46 keltezéssel, Andreas Rheinhardt írta: On Mon, Jan 20, 2020 at 8:35 AM Bodecs Bela wrote: Dear All, This patch corrects compiler warning about returning possibly

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Carl Eugen Hoyos
Am Mo., 20. Jan. 2020 um 09:41 Uhr schrieb Bodecs Bela : > > > 2020.01.20. 8:46 keltezéssel, Andreas Rheinhardt írta: > > On Mon, Jan 20, 2020 at 8:35 AM Bodecs Bela wrote: > > > >> Dear All, > >> > >> This patch corrects compiler warning about returning possibly uninitialized > >> variable in hls

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-20 Thread Jon Cook
From: JonCookCubic Currently width_align and height_align are zero which cases "Error submitting the frame for encoding". This change sets the alignments. Signed-off-by: Jon Cook --- libavcodec/qsvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qs

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-20 Thread Jon Cook
From: JonCookCubic Currently width_align and height_align are zero which cases "Error submitting the frame for encoding". This change sets the alignments. Signed-off-by: Jon Cook --- libavcodec/qsvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qs

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-20 Thread Jonathan Noble
On Sun, 19 Jan 2020 at 22:54, Nicolas George wrote: > Jonathan Noble (12020-01-19): > > I'd gathered that, but rather than bombing out shouldn't there be a > AVERROR > > returned or something else to notify the user of their error, like so > many > > other non-optional checks in ffmpeg? > > No. A

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-01-20 Thread Asaf Kave
Ping On Thu, Jan 16, 2020 at 4:59 PM Asaf Kave wrote: > > > On Thu, Jan 16, 2020 at 4:19 PM Carl Eugen Hoyos > wrote: > >> Am Do., 16. Jan. 2020 um 14:10 Uhr schrieb Lynne : >> > >> > Jan 15, 2020, 09:19 by kavea...@gmail.com: >> > >> > > --- >> > > libavcodec/hevc_refs.c | 15 >> > > li

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

2020-01-20 Thread Bodecs Bela
2020.01.20. 8:46 keltezéssel, Andreas Rheinhardt írta: On Mon, Jan 20, 2020 at 8:35 AM Bodecs Bela wrote: Dear All, This patch corrects compiler warning about returning possibly uninitialized variable in hls_write_header function. Which compiler warns about this? libavformat/hlsenc.c: In