Re: [FFmpeg-devel] [PATCH v2] lavc/qsv: adding DX11 support

2020-01-23 Thread Mark Thompson
On 23/01/2020 15:18, Artem Galin wrote: > This enables DX11 support for QSV with higher priority than DX9. > In case of multiple GPUs configuration, DX9 API does not allow to get > access to QSV device in some cases - headless. > Implementation based on DX11 resolves that restriction by enumerating

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/xcbgrab: move some initialization code from pixfmt_from_pixmap_format to create_stream

2020-01-23 Thread Marton Balint
On Wed, 1 Jan 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavdevice/xcbgrab.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) Applied the series. Regards, Marton diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 113cce71a5

Re: [FFmpeg-devel] [PATCH] avfilter: add xfade opencl filter

2020-01-23 Thread Michael Niedermayer
On Thu, Jan 23, 2020 at 07:42:33PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 76 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_xfade_opencl.c | 378

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add an option to set the encoder "usage"

2020-01-23 Thread James Zern
On Thu, Jan 23, 2020 at 2:26 AM James Almer wrote: > > This allows the user enable the realtime encoding speed mode > > Signed-off-by: James Almer > --- > The g_usage field is present since 1.0.0, but the AOM_USAGE_* defines were > introduced with the real time mode about a year ago. Builds befor

[FFmpeg-devel] [PATCH] checkasm: Check HAVE_GETSTDHANDLE here as well

2020-01-23 Thread Martin Storsjö
This was missed in 63418e374fcf26. --- tests/checkasm/checkasm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index bcbe775510..d67147ae6f 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -4

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add missing SRT_VERSION_VALUE check

2020-01-23 Thread Marton Balint
On Tue, 21 Jan 2020, Marton Balint wrote: This was missed in d7e2a2bb35e394287b3e3dc27744830bf0b7ca99. Pushed. Regards, Marton Signed-off-by: Marton Balint --- libavformat/libsrt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 443

[FFmpeg-devel] [PATCH 1/2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-01-23 Thread James Almer
Signed-off-by: James Almer --- doc/APIchanges | 3 +++ doc/codecs.texi| 2 ++ libavcodec/avcodec.h | 8 +++- libavcodec/options_table.h | 1 + libavcodec/version.h | 2 +- 5 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/

[FFmpeg-devel] [PATCH 2/2] avcodec/libx264: add a check for the export_prft AVCodecContext flag

2020-01-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libx264.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index ca8f6c0873..7cb716e13d 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -322,7 +322,9 @@ static int X264_fram

[FFmpeg-devel] [PATCH] avfilter: add xfade opencl filter

2020-01-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 76 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_xfade_opencl.c | 378 ++ 4 files changed, 456 insertions(+) create mode 100644 libavfilter/vf_

Re: [FFmpeg-devel] [PATCH] lavc/qsv: adding DX11 support

2020-01-23 Thread Artem Galin
On Fri, 10 Jan 2020 at 10:41, Anton Khirnov wrote: > Quoting Artem Galin (2019-12-23 19:31:04) > > This enables DX11 support for QSV with higher priority than DX9. > > In case of multiple GPUs configuration, DX9 API does not allow to get > > access to QSV device in some cases - headless. > > Impl

Re: [FFmpeg-devel] [PATCH] avfilter/vf_zoompan: fix shaking when zooming

2020-01-23 Thread Moritz Barsnick
On Thu, Jan 23, 2020 at 13:40:55 +0100, Robert Deibel wrote: > +/** > + * Scales n to be a multiple of grid_size and divisible by two but minimally > 2 * grid_size. > + * > + * Used to scale the width and height of a frame to fit with the subsampling > grid. > + * @param n The number to be scaled

Re: [FFmpeg-devel] [PATCH 2/2] libavutil: x86: Include stdlib.h before using _byteswap_ulong

2020-01-23 Thread Martin Storsjö
On Tue, 21 Jan 2020, Martin Storsjö wrote: When clang works in MSVC mode, it does have the _byteswap_ulong builtin, but one has to include stdlib.h before using it. --- libavutil/x86/bswap.h | 1 + 1 file changed, 1 insertion(+) I'll go ahead and push these two, as they're quite uncontroversial

[FFmpeg-devel] [PATCH 6/6] avformat/av1: Improve filtering AV1 OBUs

2020-01-23 Thread Andreas Rheinhardt
Both ISOBMFF as well as Matroska require certain OBUs to be stripped before muxing them. There are two functions for this purpose; one writes directly into an AVIOContext, the other returns a freshly allocated buffer with the undesired units stripped away. The latter one actually relies on the for

[FFmpeg-devel] [PATCH 4/6] avformat/av1, hevc: Make *_buf-functions return 0 on success

2020-01-23 Thread Andreas Rheinhardt
The output size is already returned via a pointer argument, so there is no need to return it via the ordinary return value as well. The rationale behind this is to not poison the return value on success. It also unifies the behaviour of the *_buf-functions for AVC, AV1 and HEVC. Signed-off-by: And

[FFmpeg-devel] [PATCH 1/6] avformat/matroskaenc: Check for reformatting errors

2020-01-23 Thread Andreas Rheinhardt
This is needed especially for AV1: If a reformatting error happens (e.g. if the length field of an OBU contained in the current packet indicates that said OBU extends beyond the current packet), the data pointer is still NULL, yet the size is unchanged, so that writing the data leads to a segmentat

[FFmpeg-devel] [PATCH 5/6] avformat/movenc: Check for reformatting errors when writing hint tracks

2020-01-23 Thread Andreas Rheinhardt
If this is not done, the avio_write() calls will cause segfaults immediately afterwards on error. Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index fb44

[FFmpeg-devel] [PATCH 2/6] avformat/matroskaenc: Cosmetics

2020-01-23 Thread Andreas Rheinhardt
Add {, } in situations like if () ... else if () /* Comment */ ... else ... Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index a72

[FFmpeg-devel] [PATCH 3/6] avformat/hevc: Fix potential leak in case of ff_hevc_annexb2mp4_buf failure

2020-01-23 Thread Andreas Rheinhardt
ff_hevc_annexb2mp4_buf() could indicate an error, yet leave cleaning after itself to the caller, so that a caller could not simply return the error, but had to free the buffer first. (Given that all current callers have set filter_ps = 0, this error can currently not be triggered.) Signed-off-by:

[FFmpeg-devel] [PATCH v2] lavc/qsv: adding DX11 support

2020-01-23 Thread Artem Galin
This enables DX11 support for QSV with higher priority than DX9. In case of multiple GPUs configuration, DX9 API does not allow to get access to QSV device in some cases - headless. Implementation based on DX11 resolves that restriction by enumerating list of available GPUs and finding device with

[FFmpeg-devel] [PATCH v2] lavc/qsv: adding DX11 support

2020-01-23 Thread Artem Galin
This enables DX11 support for QSV with higher priority than DX9. In case of multiple GPUs configuration, DX9 API does not allow to get access to QSV device in some cases - headless. Implementation based on DX11 resolves that restriction by enumerating list of available GPUs and finding device with

[FFmpeg-devel] [PATCH] lavc/qsv: adding DX11 support

2020-01-23 Thread Artem Galin
This enables DX11 support for QSV with higher priority than DX9. In case of multiple GPUs configuration, DX9 API does not allow to get access to QSV device in some cases - headless. Implementation based on DX11 resolves that restriction by enumerating list of available GPUs and finding device with

[FFmpeg-devel] [PATCH] lavc/qsv: adding DX11 support

2020-01-23 Thread Artem Galin
This enables DX11 support for QSV with higher priority than DX9. In case of multiple GPUs configuration, DX9 API does not allow to get access to QSV device in some cases - headless. Implementation based on DX11 resolves that restriction by enumerating list of available GPUs and finding device with

[FFmpeg-devel] [PATCH] lavc/qsv: adding DX11 support

2020-01-23 Thread Artem Galin
This enables DX11 support for QSV with higher priority than DX9. In case of multiple GPUs configuration, DX9 API does not allow to get access to QSV device in some cases - headless. Implementation based on DX11 resolves that restriction by enumerating list of available GPUs and finding device with

[FFmpeg-devel] [PATCH] avfilter/vf_zoompan: fix shaking when zooming

2020-01-23 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- libavfilter/vf_zoompan.c | 81 1 file changed, 57 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_zoompan.c b/libavfilter/vf

Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_structSEIvalue(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-Jun

2020-01-23 Thread Praveen Kumar
Thanks Kieran. Rectified the patch to just use repeat_pict for frame duplication and avoided modifying ticks_per_frame. Please find the updated patch attached here with and accept the same. Thanks & Regards, Praveen From: ffmpeg-devel on behalf of Kieran Kunhya

Re: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m_enc: Support changing qmin/qmax

2020-01-23 Thread Gyan
On 20-01-2020 01:24 am, Andriy Gelman wrote: From: Andriy Gelman Hard coded parameters for qmin and qmax are currently used to initialize v4l2_m2m device. This commit uses values from avctx->{qmin,qmax} if they are set. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_enc.c | 33 +

Re: [FFmpeg-devel] [PATCH] zoompan filter: fix shaking when zooming

2020-01-23 Thread Paul B Mahol
On 1/23/20, Robert Deibel wrote: > Fix shaking of image when zoom is applied by the zoompan filter. > Resolves ticket https://trac.ffmpeg.org/ticket/4298 > --- > libavfilter/vf_zoompan.c | 93 ++-- > 1 file changed, 70 insertions(+), 23 deletions(-) > > diff --

[FFmpeg-devel] [PATCH] avformat/movenc: allow ISMV timescale to be user-set

2020-01-23 Thread Gyan Doshi
As per the PIFF standard, the timescale of 1000 is recommended but not mandatory, so don't override the user-set value. A warning is shown for non-recommended values. --- libavformat/movenc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/moven

Re: [FFmpeg-devel] [PATCH] fate/filter-video: add two tests for dnn_processing with frame format rgb24 and grayf32

2020-01-23 Thread Moritz Barsnick
On Mon, Jan 20, 2020 at 10:43:50 -0300, Pedro Arthur wrote: > BTW does any one know which archs patchwork tests fate on? > currently is shows that 'make fate' was successful, is it possible to > test more archs and warn if some of these failed? It was new to me that patchwork runs fate, but appare

[FFmpeg-devel] [PATCH 2/2] avcodec/motion_est_template: Fix invalid shifts in no_sub_motion_search()

2020-01-23 Thread Michael Niedermayer
Fixes: Ticket8167 Signed-off-by: Michael Niedermayer --- libavcodec/motion_est_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/motion_est_template.c b/libavcodec/motion_est_template.c index 014038e54f..13e73f2653 100644 --- a/libavcodec/motion_est_te

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegaudioenc_template: fix invalid shift of sample

2020-01-23 Thread Michael Niedermayer
Fixes: Ticket8010 Signed-off-by: Michael Niedermayer --- libavcodec/mpegaudioenc_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegaudioenc_template.c b/libavcodec/mpegaudioenc_template.c index 93363fe1d2..12f7a098e6 100644 --- a/libavcodec/mpegaudioe

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-23 Thread Paul B Mahol
On 1/22/20, Anton Khirnov wrote: > Quoting Lynne (2020-01-21 21:52:52) >> Jan 21, 2020, 18:22 by an...@khirnov.net: >> >> Its size too? Didn't know that. >> >> I do think its a good idea to be able to append fields to it, so I've >> >> added a av_vk_frame_alloc() function. I've followed what >> >>

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ra144enc: Fix invalid left shift of negative number

2020-01-23 Thread Michael Niedermayer
On Wed, Jan 22, 2020 at 03:52:10PM +0100, Andreas Rheinhardt wrote: > by replacing it with a multiplication. Said multiplication can't > overflow an int32_t because lpc_coefs is limited to 16 bit precision. > > Fixes the FACE-test acodec-ra144 as well as part of #8217. > > Signed-off-by: Andreas

[FFmpeg-devel] [PATCH] zoompan filter: fix shaking when zooming

2020-01-23 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- libavfilter/vf_zoompan.c | 93 ++-- 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/libavfilter/vf_zoompan.c b/libavfilter/vf

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-23 Thread Hendrik Leppkes
On Wed, Jan 22, 2020 at 10:12 PM Marton Balint wrote: > > > > On Wed, 22 Jan 2020, Nicolas George wrote: > > > Marton Balint (12020-01-16): > >> It is not supported by every threading implementation, and the only thing > >> we > >> gain with it is an immediate shutdown of receiving packets on clo

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-23 Thread Matt Oliver
On Thu, 23 Jan 2020 at 08:12, Marton Balint wrote: > > > On Wed, 22 Jan 2020, Nicolas George wrote: > > > Marton Balint (12020-01-16): > >> It is not supported by every threading implementation, and the only > thing we > >> gain with it is an immediate shutdown of receiving packets on close and >

Re: [FFmpeg-devel] [PATCH] avformat/utils: log corrupt packets

2020-01-23 Thread Gyan
On 22-01-2020 11:54 am, Gyan wrote: On 26-12-2019 09:03 pm, Gyan wrote: On 26-12-2019 08:30 pm, Andreas Rheinhardt wrote: On Thu, Dec 26, 2019 at 3:55 PM Gyan Doshi wrote: ---   libavformat/utils.c | 15 +--   1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH] avcodec/libaomenc: add an option to set the encoder "usage"

2020-01-23 Thread James Almer
This allows the user enable the realtime encoding speed mode Signed-off-by: James Almer --- The g_usage field is present since 1.0.0, but the AOM_USAGE_* defines were introduced with the real time mode about a year ago. Builds before that addition simply ignore the field. libavcodec/libaomenc.c

[FFmpeg-devel] [PATCH 1/2] avcodec/dpcm: Fix integer overflow in AV_CODEC_ID_GREMLIN_DPCM

2020-01-23 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147479324 + -32568 cannot be represented in type 'int' Fixes: 20103/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GREMLIN_DPCM_fuzzer-5667667579240448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed

[FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Add threshold for IFF_ILBM

2020-01-23 Thread Michael Niedermayer
Fixes: Timeout (32 -> 1sec) Fixes: 20138/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5634665251864576 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH] avutil/thread: fix strict_pthread_cond_timedwait

2020-01-23 Thread Marton Balint
Timeout error was assumed to be fatal which it is not. Signed-off-by: Marton Balint --- libavutil/thread.h | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavutil/thread.h b/libavutil/thread.h index 65b97ef303..be5c4b1340 100644 --- a/libavutil/thr