Signed-off-by: Zhao, Gang
---
Changes from v1:
Rephrased the commit log to better describe what this patch does.
Removed calling of av_log_set_level(AV_LOG_DEBUG) which is used for debugging.
This patch doesn't depend on other patches and can be applied separately.
Tested that the new code
When the Ogg muxer writes a page, it has to do three things: It needs to
write a page header, then it has to actually copy the page data and then
it has to calculate and write a CRC checksum of both header as well as
data at a certain position in the page header.
To do this, the muxer used a
On 2020-05-01 03:01, Nicolas George wrote:
Carl Eugen Hoyos (12020-05-01):
-The desired output frame rate. The default is @code{25}.
+The output frame rate, in frames per second. May be an integer, real, or
+rational number, or an abbreviation. The default is @code{25}.
I seriously wonder who
On Sat, May 2, 2020, at 1:51 AM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> doc/mailing-list-faq.texi | 4 1 file changed, 4 insertions(+)
>
> diff --git a/doc/mailing-list-faq.texi b/doc/mailing-list-faq.texi
> index 439d783956..15fc8e86c0 100644 ---
Enables writing buffered frames to the outsink using send command api.
This is useful when a lavf user wants to fetch buffered frames without
closing/reopening the filtergraph again and again.
Signed-off-by: Jai Luthra
---
libavfilter/vf_fps.c | 36 +++-
1 file
On 2020-05-01 02:52, Carl Eugen Hoyos wrote:
Am Fr., 1. Mai 2020 um 06:05 Uhr schrieb :
From: Jim DeLaHunt
Fix unclear wording and spelling mistakes based on review.
Reduce overall word count by 11%.
This is heavily misleading and definitely not ok.
Oh, I get it! Are you saying that you
Fixes: shift exponent 32 is too large for 32-bit type 'int'
Fixes:
21647/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5686168323883008
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
Fixes: signed integer overflow: -1238335488 + -1003634688 cannot be represented
in type 'int'
Fixes:
21649/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEG_fuzzer-5112005765890048
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
John Stebbins:
> Requried to remux mkv to m2ts
> ---
> Changelog| 1 +
> doc/bitstream_filters.texi | 8 ++
> libavcodec/Makefile | 1 +
> libavcodec/bitstream_filters.c | 1 +
> libavcodec/pgs_frame_split_bsf.c | 176
John Stebbins:
> PGS segments must be merged to one packet for muxing to mkv
> ---
> libavformat/matroskaenc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index d3256d8f5d..bccf8b11d2 100644
> --- a/libavformat/matroskaenc.c
John Stebbins:
> Required to remux m2ts to mkv
> ---
> Changelog| 1 +
> doc/bitstream_filters.texi | 8 ++
> libavcodec/Makefile | 1 +
> libavcodec/bitstream_filters.c | 1 +
> libavcodec/pgs_frame_merge_bsf.c | 168
John Stebbins:
> Required to remux m2ts to mkv
> ---
> Changelog| 1 +
> doc/bitstream_filters.texi | 8 ++
> libavcodec/Makefile | 1 +
> libavcodec/bitstream_filters.c | 1 +
> libavcodec/pgs_frame_merge_bsf.c | 168
Andreas Rheinhardt:
> Commit 6fd300ac6c2c3871736ce0e6df95603255004dc6 added support for WebM
> Chunk livestreaming; in this case, both the header as well as each
> Cluster is written to a file of its own, so that even if the AVIOContext
> seems seekable, the muxer has to behave as if it were not.
On Fri, 1 May 2020, Marton Balint wrote:
On Sun, 26 Apr 2020, James Almer wrote:
On 4/25/2020 3:55 PM, Marton Balint wrote:
Signed-off-by: Marton Balint
---
fftools/ffmpeg_opt.c | 57
+++-
1 file changed, 3 insertions(+), 54
On Fri, 1 May 2020, Marton Balint wrote:
On Tue, 28 Apr 2020, Marton Balint wrote:
On Sun, 26 Apr 2020, James Almer wrote:
On 4/26/2020 5:34 AM, Marton Balint wrote:
void avcodec_flush_buffers(AVCodecContext *avctx)
{
AVCodecInternal *avci = avctx->internal;
@@ -2117,7 +2001,7
The Matroska muxer has a pair of functions designed to write master
elements whose exact length is not known in advance: start_ebml_master()
and end_ebml_master(). The first one of these would write the EBML ID of
the master element that is about to be started, reserve some bytes for
the length
Mainly reindentation plus some reordering in MatroskaMuxContext;
moreover, use the IS_SEEKABLE() macro troughout the code.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 298 +++---
1 file changed, 148 insertions(+), 150 deletions(-)
diff
EBML numbers are variable length numbers: Only seven bits of every byte
are available to encode the number, the other bits encode the length of
the number itself. So an eight byte EBML number can only encode numbers
in the range 0..(2^56 - 1). And when using EBML numbers to encode the
length of an
If the AVIOContext for output was unseekable when writing the header,
no space for Cues would be reserved even if the reserve_index_space
option was used (because it is reasonable to expect that one can't seek
back to the beginning to write the Cues anyway). But if the AVIOContext
was seekable
We won't be able to seek back to write the actual duration anyway.
FATE-tests using the md5pipe command had to be updated due to this change.
Signed-off-by: Andreas Rheinhardt
---
This is the one and only place where is_live still differs from
!(pb->seekable & AVIO_SEEKABLE_NORMAL): No duration
If the Matroska muxer's AVIOContext was unseekable when writing the
header, but is seekable when writing the trailer, the code for writing
the trailer presumes that a dynamic buffer exists and tries to update
its content in order to overwrite data that has already been
preliminarily written when
Since commit 4aa0665f393847c35387a1c673e62346d0acfc95, the dynamic
buffer destined for the contents of the current Cluster is no longer
constantly allocated, reallocated and then freed after writing the
content; instead it is reset and reused when closing a Cluster.
Yet the code in
The Matroska muxer behaves differently in several ways when it thinks
that it is in unseekable/livestreaming mode: It does not add Cue entries
because they won't be written anyway for a livestream and it writes some
elements only preliminarily (with the intention to overwrite them with
an updated
On Sat, May 02, 2020 at 11:51:29AM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> doc/mailing-list-faq.texi | 4
> 1 file changed, 4 insertions(+)
will apply
Note, this should be reverted once the issue is fixed
[...]
--
Michael GnuPG fingerprint:
On 5/2/2020 1:39 PM, Michael Niedermayer wrote:
> On Sat, Apr 11, 2020 at 11:01:41AM -0300, James Almer wrote:
>> Fixes: Timeout
>> Fixes:
>> 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360
>> Fixes:
>>
On Tue, Feb 11, 2020 at 11:56:46PM +0100, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -193177 * 11585 cannot be represented in type
> 'int'
> Fixes:
> 20557/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-5704852816789504
>
> Found-by: continuous fuzzing process
>
On Sun, Apr 26, 2020 at 11:12:16PM +0200, Michael Niedermayer wrote:
> Fixes: left shift of negative value -1
> Fixes:
> 21390/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-6242539519868928
>
> Found-by: continuous fuzzing process
>
On Sun, Feb 09, 2020 at 08:14:23PM +0100, Michael Niedermayer wrote:
> Fixes: left shift of negative value -8321365
> Fixes:
> 20506/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-4798062906310656
>
> Found-by: continuous fuzzing process
>
On Sun, Feb 09, 2020 at 02:09:57PM +0100, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -16 * 134217879 cannot be represented in type
> 'int'
> Fixes:
> 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5639509530378240
>
> Found-by: continuous fuzzing process
>
On Sat, Apr 11, 2020 at 11:01:41AM -0300, James Almer wrote:
> Fixes: Timeout
> Fixes:
> 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360
> Fixes:
> 21214/clusterfuzz-testcase-minimized-ffmpeg_BSF_MPEG2_METADATA_fuzzer-5165560875974656
> Fixes:
>
extradata changing would result in an invalid and undecodable stream.
Also, as the code was written, rewriting extradata was corrupting the
track header resulting in an invalid file.
---
libavformat/matroskaenc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
John Stebbins (12020-05-02):
> extradata changing would result in an invalid stream.
> also, as the code was written, rewriting extradata was corrupting the
> track header resulting in an invalid file.
Invalid and undecodable.
> ---
> libavformat/matroskaenc.c | 8
> 1 file changed, 8
extradata changing would result in an invalid stream.
also, as the code was written, rewriting extradata was corrupting the
track header resulting in an invalid file.
---
libavformat/matroskaenc.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavformat/matroskaenc.c
On 5/2/2020 10:11 AM, Derek Buitenhuis wrote:
> Not requiring this leads to unexpected result, since Rav1e's current
> two pass API has no way to fail in such a case.
>
> Signed-off-by: Derek Buitenhuis
> ---
> libavcodec/librav1e.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git
On Fri, Apr 17, 2020 at 03:35:44 +0200, one...@oneric.de wrote:
> On Fri, Apr 17, 2020 at 02:15:17 +0200, Oneric wrote:
> > ffmpeg does not set the 'ScaledBorderAndShadow' header for ASS
> > subtitles. This currently leads to inconsistent behaviour depending on the
> > renderer
>
> Sorry for the
On Sat, May 2, 2020 at 9:24 PM James Almer wrote:
> On 5/2/2020 7:10 AM, Zhao, Gang wrote:
> > Replaced deprecated api avcodec_decode_{audio4,video2}() with
> > avcodec_send_packet()/avcodec_receive_frame(). Also made some clean up
> > according to this change.
> >
> > Signed-off-by: Zhao, Gang
Marton Balint 于2020年5月2日周六 下午7:05写道：
>
>
>
> On Sat, 2 May 2020, Tao Zhang wrote:
>
> > Marton Balint 于2020年5月1日周五 下午9:35写道：
> >>
> >>
> >>
> >> On Thu, 30 Apr 2020, Tao Zhang wrote:
> >>
> >> > Andreas Rheinhardt 于2020年4月30日周四 下午4:23写道：
> >> >>
> >> >> Tao Zhang:
> >> >> > Marton Balint
Zhao, Gang (12020-05-02):
> Hi. Thanks for your comment. What about change the commit log to "Refactor
> the code to replace deprecated api with the recommended one"?
> I think that might better describe what I did in the patch.
Just "doc/examples/demuxing_decoding: update to new encoding API"
On 5/2/2020 7:10 AM, Zhao, Gang wrote:
> Replaced deprecated api avcodec_decode_{audio4,video2}() with
> avcodec_send_packet()/avcodec_receive_frame(). Also made some clean up
> according to this change.
>
> Signed-off-by: Zhao, Gang
> ---
> Tested that the new code generated the same files as
On Sat, May 2, 2020 at 7:20 PM Nicolas George wrote:
> Zhao, Gang (12020-05-02):
> > Replaced deprecated api avcodec_decode_{audio4,video2}() with
> > avcodec_send_packet()/avcodec_receive_frame(). Also made some clean up
> > according to this change.
> >
> > Signed-off-by: Zhao, Gang
> > ---
>
Not requiring this leads to unexpected result, since Rav1e's current
two pass API has no way to fail in such a case.
Signed-off-by: Derek Buitenhuis
---
libavcodec/librav1e.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
index
May 2, 2020, 09:14 by ceffm...@gmail.com:
> Hi!
>
> I believe attached patch fixes ticket #8649, a regression reported
> yesterday on irc, I don't see anymore (and forgot) the irc name of the
> original reporter, that's why it is missing in the ticket and the
> patch.
> Improvements for the
Zhao, Gang (12020-05-02):
> With the new api, function write_audio_frame and write_video_frame can be
> combined to one.
> Because there is already a local function called write_frame, I changed the
> name to muxing_write_frame
> to avoid name collision.
Multiple changes in the same patch make it
On Sat, May 2, 2020 at 6:13 PM Nicolas George wrote:
> Zhao, Gang (12020-05-02):
> > Fixed deprecation declarations compile warning by replacing deprecated
> > api avcodec_encode_{audio,video}2() with
> > avcodec_send_frame()/avcodec_receive_packet(). Also made some clean up
> > according to
lance.lmw...@gmail.com (12020-05-02):
> The most important is document, I think current option is OK to use.
> deprecation is more confusing.
An option with the wrong type is confusing too. But deprecation is
temporary.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
On Sat, May 02, 2020 at 01:56:02PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-02):
> > Please see the below thread, pkv submit a patch to solve the same issue
> > later,
> > more discussion are there, why not change to AV_OPT_TYPE_DURATION.
> >
Steven Liu (12020-04-29):
> fix ticket: 8625
> and add testcase into url for double dot corner case
>
> Signed-off-by: Steven Liu
> ---
> libavformat/tests/url.c | 5 +++
> libavformat/url.c | 77 ++---
> tests/ref/fate/url | 5 +++
> 3 files
On Mon, Nov 04, 2019 at 07:09:59PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> doc/bitstream_filters.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> index
lance.lmw...@gmail.com (12020-05-02):
> Please see the below thread, pkv submit a patch to solve the same issue later,
> more discussion are there, why not change to AV_OPT_TYPE_DURATION.
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/ecec232b-cc81-b544-db5c-56752f1b8...@obsproject.com/
It
On Sat, May 02, 2020 at 01:18:19PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-02):
> > will apply the patch set tomorrow if no comments.
>
> I lost track of all these patches, I thought the options were to be
> changed to AV_OPT_TYPE_DURATION.
Please see the below thread,
Marton Balint (12020-05-02):
> That would break existing command lines...
Then a reasonable transition plan needs to be prepared. Not blocking for
this patch, though.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
On Sat, 2 May 2020, Nicolas George wrote:
lance.lmw...@gmail.com (12020-05-02):
will apply the patch set tomorrow if no comments.
I lost track of all these patches, I thought the options were to be
changed to AV_OPT_TYPE_DURATION.
That would break existing command lines...
Regards,
Zhao, Gang (12020-05-02):
> Replaced deprecated api avcodec_decode_{audio4,video2}() with
> avcodec_send_packet()/avcodec_receive_frame(). Also made some clean up
> according to this change.
>
> Signed-off-by: Zhao, Gang
> ---
> Tested that the new code generated the same files as before by
lance.lmw...@gmail.com (12020-05-02):
> will apply the patch set tomorrow if no comments.
I lost track of all these patches, I thought the options were to be
changed to AV_OPT_TYPE_DURATION.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
On Wed, Apr 15, 2020 at 10:09:00AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/nvenc_h264.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/nvenc_h264.c b/libavcodec/nvenc_h264.c
> index 479155fe15..a2e77e67d0
On Tue, Mar 31, 2020 at 10:08:06PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> doc/protocols.texi | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/doc/protocols.texi b/doc/protocols.texi
> index
On Sat, 2 May 2020, Tao Zhang wrote:
Marton Balint 于2020年5月1日周五 下午9:35写道：
On Thu, 30 Apr 2020, Tao Zhang wrote:
> Andreas Rheinhardt 于2020年4月30日周四 下午4:23写道：
>>
>> Tao Zhang:
>> > Marton Balint 于2020年4月30日周四 下午3:26写道：
>> >>
>> >>
>> >>
>> >> On Thu, 30 Apr 2020, Tao Zhang wrote:
>> >>
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 78 +
libavfilter/Makefile | 1 +
libavfilter/af_apulsator.c | 224 +
libavfilter/allfilters.c | 1 +
4 files changed, 304 insertions(+)
diff --git a/doc/filters.texi
Replaced deprecated api avcodec_decode_{audio4,video2}() with
avcodec_send_packet()/avcodec_receive_frame(). Also made some clean up
according to this change.
Signed-off-by: Zhao, Gang
---
Tested that the new code generated the same files as before by running
./doc/examples/demuxing_decoding_g
---
libavformat/dashdec.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 5ba7feb245..bde4b0846d 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -29,6 +29,8 @@
#include
Zhao, Gang (12020-05-02):
> Fixed deprecated declarations compile warning by replacing deprecated
> api avcodec_encode_{audio,video}2() and
> avcodec_decode_{audio4,video2}() with
> avcodec_send_frame()/avcodec_receive_packet() and
> avcodec_send_packet()/avcodec_receive_frame(). Also made some
Fixed deprecated declarations compile warning by replacing deprecated
api avcodec_encode_{audio,video}2() and
avcodec_decode_{audio4,video2}() with
avcodec_send_frame()/avcodec_receive_packet() and
avcodec_send_packet()/avcodec_receive_frame(). Also made some clean up
according to this change.
Zhao, Gang (12020-05-02):
> Fixed deprecation declarations compile warning by replacing deprecated
> api avcodec_encode_{audio,video}2() with
> avcodec_send_frame()/avcodec_receive_packet(). Also made some clean up
> according to this change.
That is not "fixing a warning", that is changing the
Fixed deprecation declarations compile warning by replacing deprecated
api avcodec_encode_{audio,video}2() with
avcodec_send_frame()/avcodec_receive_packet(). Also made some clean up
according to this change.
Signed-off-by: Zhao, Gang
---
Tested that the new code generated the same file as
Disable deprecation declarations compile warning when we really need
to call these deprecated functions.
Signed-off-by: Zhao, Gang
---
libavcodec/encode.c | 4
libavcodec/frame_thread_encoder.c | 4
2 files changed, 8 insertions(+)
diff --git libavcodec/encode.c
Carl Eugen Hoyos (12020-05-02):
> My guess is to avoid a race condition.
Avoid a race condition is: take local variable, unlock, use local
variable. Here it is take local variable, lock, use local variable.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
Am Sa., 2. Mai 2020 um 11:56 Uhr schrieb Nicolas George :
>
> Carl Eugen Hoyos (12020-05-02):
> > Could you tell me where free_func() is used as a void *?
> > I don't see it.
>
> You are right, I misread. The problem is even simpler: why is there an
> intermediate variable in the first place?
My
Carl Eugen Hoyos (12020-05-02):
> Could you tell me where free_func() is used as a void *?
> I don't see it.
You are right, I misread. The problem is even simpler: why is there an
intermediate variable in the first place? Just test mq->free_func
directly.
Regards,
--
Nicolas George
Carl Eugen Hoyos (12020-05-01):
> https://ffmpeg.org/pipermail/ffmpeg-devel/2020-May/261801.html
>
> This email and a follow-up from you are offending and annoying, and
> it was indeed a waste of time to discuss this with you.
For reference:
James> Not really, the AV_GCC_VERSION_AT_LEAST helper
Signed-off-by: Michael Niedermayer
---
doc/mailing-list-faq.texi | 4
1 file changed, 4 insertions(+)
diff --git a/doc/mailing-list-faq.texi b/doc/mailing-list-faq.texi
index 439d783956..15fc8e86c0 100644
--- a/doc/mailing-list-faq.texi
+++ b/doc/mailing-list-faq.texi
@@ -358,6 +358,10 @@
Am Sa., 2. Mai 2020 um 11:06 Uhr schrieb Nicolas George :
>
> Carl Eugen Hoyos (12020-05-01):
> > Hi!
> >
> > Attached patch, inspired by a patch by Andreas, fixes the following
> > warning when -Wpedantic is used:
> > CC libavutil/threadmessage.o
> > libavutil/threadmessage.c: In function
Thank you for your answer Marton.
Yes I broke the parse process because I saw below in rtsp.c a specific source
code which specify to have only "One transport" :
ff_rtsp_send_cmd(s, "SETUP", rtsp_st->control_url, cmd, reply, NULL);
if (reply->status_code == 461 /* Unsupported protocol */ && i
Carl Eugen Hoyos (12020-05-01):
> Hi!
>
> Attached patch, inspired by a patch by Andreas, fixes the following
> warning when -Wpedantic is used:
> CC libavutil/threadmessage.o
> libavutil/threadmessage.c: In function ‘av_thread_message_flush’:
> libavutil/threadmessage.c:222:23: warning: ISO
Am Sa., 2. Mai 2020 um 10:49 Uhr schrieb Lynne :
>
> May 2, 2020, 09:14 by ceffm...@gmail.com:
>
> > Hi!
> >
> > I believe attached patch fixes ticket #8649, a regression reported
> > yesterday on irc, I don't see anymore (and forgot) the irc name of the
> > original reporter, that's why it is
Marton Balint 于2020年5月1日周五 下午9:35写道：
>
>
>
> On Thu, 30 Apr 2020, Tao Zhang wrote:
>
> > Andreas Rheinhardt 于2020年4月30日周四 下午4:23写道：
> >>
> >> Tao Zhang:
> >> > Marton Balint 于2020年4月30日周四 下午3:26写道：
> >> >>
> >> >>
> >> >>
> >> >> On Thu, 30 Apr 2020, Tao Zhang wrote:
> >> >>
> >> >>> Marton
Am Sa., 2. Mai 2020 um 10:14 Uhr schrieb Carl Eugen Hoyos :
> I believe attached patch fixes ticket #8649, a regression reported
> yesterday on irc, I don't see anymore (and forgot) the irc name of the
> original reporter, that's why it is missing in the ticket and the
> patch.
> Improvements for
Hi!
I believe attached patch fixes ticket #8649, a regression reported
yesterday on irc, I don't see anymore (and forgot) the irc name of the
original reporter, that's why it is missing in the ticket and the
patch.
Improvements for the commit message welcome.
Please comment, Carl Eugen
From
77 matches
Mail list logo
