Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-24 Thread Andriy Gelman
On Sat, 20. Jun 22:46, Florian Levis wrote: > > Le sam. 20 juin 2020 à 20:56, Andriy Gelman a > écrit : > > > On Sat, 20. Jun 19:16, Levis Florian wrote: > > > Signed-off-by: Levis Florian > > > --- > > > doc/protocols.texi| 15 +++ > > > libavformat/libamqp.c | 6 +- > >

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: Accept \r as newline

2020-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > After parsing the end timestamp of a WebVTT cue block, the current code > skips everything after the start of the timestamp that is not a \t, ' ' > or \n and treats what is next as the start of a WebVTT cue settings list. > Yet if there is no such list, but a single \r, this

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vaapi: try VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME_2 firstly when importing a DMABuf

2020-06-24 Thread Lynne
Jun 19, 2020, 07:47 by haihao.xi...@intel.com: > User should provide the modifier when importing a DMABuf if this DMABuf > has modifier. > > Signed-off-by: Haihao Xiang > --- > libavutil/hwcontext_vaapi.c | 137 +--- > 1 file changed, 126 insertions(+), 11

[FFmpeg-devel] [PATCH v3 4/6] avformat/hlsenc: use proper error codes

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 71fa3db..f7a4f30 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -370,6

[FFmpeg-devel] [PATCH v3 3/6] avformat/au: check return value of au_read_annotation()

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/au.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/au.c b/libavformat/au.c index ff9176a..f92863e 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -145,6 +145,7 @@ static int

[FFmpeg-devel] [PATCH v3 5/6] avformat/hlsenc: fix av_bprint_finalize() usage

2020-06-24 Thread lance . lmwang
From: Limin Wang Don't need to do double check by the description of the API. Reviewed-by: Nicolas George Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index

Re: [FFmpeg-devel] [PATCH 2/2] avformat/subtitles: Check for NOPTS in ff_subtitles_queue_finalize()

2020-06-24 Thread Michael Niedermayer
On Wed, Jun 24, 2020 at 02:10:09PM +0200, Nicolas George wrote: > Michael Niedermayer (12020-06-24): > > On Tue, Jun 23, 2020 at 02:08:44PM +0200, Nicolas George wrote: > > > Michael Niedermayer (12020-06-23): > > > > Fixes; signed integer overflow: 1 - -9223372036854775808 cannot be > > > >

[FFmpeg-devel] [PATCH v3 2/6] avformat/au: check return value of av_bprint_finalize()

2020-06-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Nicolas George Signed-off-by: Limin Wang --- libavformat/au.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/au.c b/libavformat/au.c index 4afee85..ff9176a 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -81,7

[FFmpeg-devel] [PATCH v3 6/6] avformat/hlsenc: simplify code to pass s directly

2020-06-24 Thread lance . lmwang
From: Limin Wang Suggested-by: Nicolas George Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a34da2f..0a318d2 100644 --- a/libavformat/hlsenc.c +++

[FFmpeg-devel] [PATCH v3 1/6] avutil/opt: check return value of av_bprint_finalize()

2020-06-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Nicolas George Signed-off-by: Limin Wang --- libavutil/opt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 2c3f998..c8413fa 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -2120,6 +2120,8 @@

[FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-24 Thread rcombs
--- libavutil/avutil.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/avutil.h b/libavutil/avutil.h index 4d633156d1..c11b33f466 100644 --- a/libavutil/avutil.h +++ b/libavutil/avutil.h @@ -257,7 +257,11 @@ const char *av_get_media_type_string(enum AVMediaType media_type); *

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Carl Eugen Hoyos
Am Do., 25. Juni 2020 um 00:12 Uhr schrieb Moritz Barsnick : > > On Wed, Jun 24, 2020 at 23:57:10 +0530, gautamr...@gmail.com wrote: > > +const char *header_start = "PG ML "; > > What about LM? Or do little-endian samples not exist? There are only 78 known samples, all from the jpeg2000 test

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Moritz Barsnick
On Wed, Jun 24, 2020 at 23:57:10 +0530, gautamr...@gmail.com wrote: > +const char *header_start = "PG ML "; What about LM? Or do little-endian samples not exist? > +if (bytestream2_peek_byte(>g) == ' ') > +bytestream2_skip(>g, 1); I understand the separators can also be tabs,

[FFmpeg-devel] [PATCH]doc/examples: Always open files as "binary", not "text"

2020-06-24 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8638 and the only other occurrence of fopen() without b in doc/examples. Please comment, Carl Eugen From c0ae8356baaf40dbf5d3312264b42b8f02c1561b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 25 Jun 2020 00:01:36 +0200 Subject: [PATCH] doc/examples:

[FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Please test it and reports benchmark results on non toyish GPUs. --- configure| 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_v360_vulkan.c | 668 +++ 4 files

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-24 Thread Paul B Mahol
On 6/24/20, Nicolas George wrote: > Paul B Mahol (12020-06-24): >> As already explained I can not use fixed buffer at all. > > Not true. > > Bring new, accurate arguments, or stop. You never provided argument to show how to accomplish anything with fixed buffer. You are being rude.

Re: [FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-24 Thread Carl Eugen Hoyos
Am Mi., 24. Juni 2020 um 21:10 Uhr schrieb rcombs : > > --- > libavutil/avutil.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavutil/avutil.h b/libavutil/avutil.h > index 4d633156d1..c11b33f466 100644 > --- a/libavutil/avutil.h > +++ b/libavutil/avutil.h > @@ -257,7 +257,11 @@

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Carl Eugen Hoyos
Am Mi., 24. Juni 2020 um 20:55 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch support to read and decode > pgx files. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_id.h| 1 + > libavcodec/pgx.h | 38 + >

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Nicolas George
Thanks for the patch. Here are a few preliminary remarks. gautamr...@gmail.com (12020-06-24): > From: Gautam Ramakrishnan > > This patch support to read and decode > pgx files. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_id.h| 1 + >

[FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread gautamramk
From: Gautam Ramakrishnan This patch support to read and decode pgx files. --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_id.h| 1 + libavcodec/pgx.h | 38 + libavcodec/pgxdec.c | 176 +++

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Gautam Ramakrishnan
On Wed, Jun 24, 2020 at 11:54 PM wrote: > > From: Gautam Ramakrishnan > > This patch support to read and decode > pgx files. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_id.h| 1 + > libavcodec/pgx.h | 38 + >

[FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread gautamramk
From: Gautam Ramakrishnan This patch support to read and decode pgx files. --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_id.h| 1 + libavcodec/pgx.h | 38 + libavcodec/pgxdec.c | 177 +++

[FFmpeg-devel] [PATCH 1/2] avformat/avc: Don't use ff_ prefix for static function

2020-06-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avc.c b/libavformat/avc.c index cd15ac3cdb..975d37ae82 100644 --- a/libavformat/avc.c +++ b/libavformat/avc.c @@ -27,7 +27,7 @@ #include "avc.h" #include

[FFmpeg-devel] [PATCH 2/2] avformat/avc, mxfenc: Avoid allocation of H264 SPS structure, fix memleak

2020-06-24 Thread Andreas Rheinhardt
Up until now, ff_avc_decode_sps would parse a SPS and return some properties from it in a freshly allocated structure. Yet said structure is very small and completely internal to libavformat, so there is no reason to use the heap for it. This commit therefore changes the function to return an int

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-24 Thread Mathias Rasmussen
> On 24 Jun 2020, at 17.32, Nicolas George wrote: > > Just run "make fate-filter-nonlinearstretch" and it should try the test. > > It is advised to run "make fate" completely before sending patches, > preferably with samples. > >

Re: [FFmpeg-devel] [PATCH v4 1/7] FATE: add h264 timecode side data test

2020-06-24 Thread lance . lmwang
On Wed, Jun 24, 2020 at 09:43:14PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The old fate test is for framecrc and haven't testing timecode info. > so it's better to change to ffprobe and dump them. > > Signed-off-by: Limin Wang > --- > tests/fate/h264.mak |4 +-

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hlsenc: fix av_bprint_finalize() usage

2020-06-24 Thread lance . lmwang
On Wed, Jun 24, 2020 at 05:37:59PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-22): > > From: Limin Wang > > > > Don't need to do double check by the description of the API. > > Looks ok. Could be simplified even further bu passing s directly. Yes, I prefer to change it in

Re: [FFmpeg-devel] [PATCH 1/6] avutil/opt: check return value of av_bprint_finalize()

2020-06-24 Thread lance . lmwang
On Wed, Jun 24, 2020 at 05:36:08PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-22): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/opt.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavutil/opt.c

Re: [FFmpeg-devel] [PATCH 3/6] avformat/au: check return value of av_bprint_finalize()

2020-06-24 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-22): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/au.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Probably ok, buy I do not maintain this. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hlsenc: fix av_bprint_finalize() usage

2020-06-24 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-22): > From: Limin Wang > > Don't need to do double check by the description of the API. Looks ok. Could be simplified even further bu passing s directly. I do not maintain that file. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/6] avutil/opt: check return value of av_bprint_finalize()

2020-06-24 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-22): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/opt.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 2c3f998..552985e 100644 > --- a/libavutil/opt.c > +++

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-24 Thread Nicolas George
Mathias Rasmussen (12020-06-22): > Yes, you are correct, is it supposed to be an empty file? > I'm not sure my test case really works though, is there a way to see the > results of the test? Just run "make fate-filter-nonlinearstretch" and it should try the test. It is advised to run "make fate"

Re: [FFmpeg-devel] [PATCH 06/17] avformat/smoothstreaming: Add deinit function

2020-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/smoothstreamingenc.c | 43 > 1 file changed, 16 insertions(+), 27 deletions(-) > > diff --git a/libavformat/smoothstreamingenc.c > b/libavformat/smoothstreamingenc.c > index

Re: [FFmpeg-devel] [PATCH] avformat/av1: Avoid using dynamic buffer when assembling av1c

2020-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Given that AV1 only has exactly one sequence header, it is unnecessary > to copy the content of said sequence header into an intermediate dynamic > buffer; instead the sequence header can be copied from where it is in > the input buffer. > > Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH v4 1/7] FATE: add h264 timecode side data test

2020-06-24 Thread lance . lmwang
From: Limin Wang The old fate test is for framecrc and haven't testing timecode info. so it's better to change to ffprobe and dump them. Signed-off-by: Limin Wang --- tests/fate/h264.mak |4 +- tests/ref/fate/h264-timecode | 3608 ++ 2

Re: [FFmpeg-devel] [PATCH 1/6] avutil/opt: check return value of av_bprint_finalize()

2020-06-24 Thread Tim Bradstock
unsubscribe On Mon, Jun 22, 2020 at 4:32 PM wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/opt.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 2c3f998..552985e 100644 > --- a/libavutil/opt.c >

[FFmpeg-devel] [PATCH 2/3] avcodec/mlpenc: propagate proper error values

2020-06-24 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mlpenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index f99d2f5d6f..4d50f0ea33 100644 --- a/libavcodec/mlpenc.c +++ b/libavcodec/mlpenc.c @@ -531,7 +531,7 @@ static

[FFmpeg-devel] [PATCH 1/9] avformat/smacker: Don't increase packet counter prematurely

2020-06-24 Thread Andreas Rheinhardt
The Smacker demuxer buffers audio packets before it outputs them, but it increments the counter of buffered packets prematurely: If allocating the audio buffer fails, an error (most likely AVERROR(ENOMEM)) is returned. If the caller decides to call av_read_frame() again, the next call will take

[FFmpeg-devel] [PATCH 5/9] avformat/smacker: Improve timestamps

2020-06-24 Thread Andreas Rheinhardt
A Smacker file can contain up to seven audio tracks. Up until now, the pts for the i. audio packet contained in a Smacker frame was simply the end timestamp of the last i. audio packet contained in an earlier Smacker frame. The problem with this is that a Smacker stream need not contain data in

[FFmpeg-devel] [PATCH 8/9] avformat/smacker: Use st->priv_data to store array

2020-06-24 Thread Andreas Rheinhardt
It simplifies freeing and allows to completely remove smacker_read_close. Signed-off-by: Andreas Rheinhardt --- libavformat/smacker.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/libavformat/smacker.c b/libavformat/smacker.c index 201372aee6..2e4a499a13

[FFmpeg-devel] [PATCH 9/9] avformat/smacker: Cosmetics

2020-06-24 Thread Andreas Rheinhardt
Mainly reindentation. Signed-off-by: Andreas Rheinhardt --- libavformat/smacker.c | 60 +-- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/libavformat/smacker.c b/libavformat/smacker.c index 2e4a499a13..0ca5a87b8f 100644 ---

[FFmpeg-devel] [PATCH 6/9] avformat/smacker: Don't allocate arrays separately

2020-06-24 Thread Andreas Rheinhardt
Allocating two arrays with the same number of elements together simplifies freeing them. Signed-off-by: Andreas Rheinhardt --- libavformat/smacker.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/smacker.c b/libavformat/smacker.c index

[FFmpeg-devel] [PATCH 4/9] avformat/smacker: Stop caching and copying audio frames

2020-06-24 Thread Andreas Rheinhardt
The layout of a Smacker frame is as follows: For some frames, the beginning of the frame contained a palette for the video stream; then there are potentially several audio frames, followed by the data for the video stream. The Smacker demuxer used to read the palette, then cache every audio frame

[FFmpeg-devel] [PATCH 7/9] avformat/smacker: Don't read only one byte at a time

2020-06-24 Thread Andreas Rheinhardt
Instead use ffio_read_size to read data into a buffer. Also check that the desired size was actually successfully read and combine the check with the check for reading the extradata. Signed-off-by: Andreas Rheinhardt --- libavformat/smacker.c | 13 + 1 file changed, 5 insertions(+),

[FFmpeg-devel] [PATCH 3/9] avformat/smacker: Check audio frame size

2020-06-24 Thread Andreas Rheinhardt
The first four bytes of smacker audio are supposed to contain the number of samples, so treat audio frames smaller than that as invalid. Signed-off-by: Andreas Rheinhardt --- libavformat/smacker.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/smacker.c

[FFmpeg-devel] [PATCH 2/9] avformat/smacker: Avoid potential inifinite loop on error

2020-06-24 Thread Andreas Rheinhardt
When reading a new frame, the Smacker demuxer seeks to the next frame position where it excepts the next frame; then it (potentially) reads the palette, the audio packets associated with the frame and finally the actual video frame. It is only at the end that the frame counter as well as the

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/hevcdec: create AVFrame side data from HEVC timecodes like H.264

2020-06-24 Thread lance . lmwang
On Tue, Jun 23, 2020 at 10:18:55PM +0100, Josh de Kock wrote: > On 17/06/2020 17:07, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/hevcdec.c | 44 > > 1 file changed, 44 insertions(+) >

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h265: set default VUI parameters when vui_parameters_present_flag is false

2020-06-24 Thread James Almer
On 6/22/2020 9:53 PM, James Almer wrote: > Based on cbs_h264 code. > > Should fix ticket #8752. > > Signed-off-by: James Almer > --- > libavcodec/cbs_h265_syntax_template.c | 28 +++ > 1 file changed, 28 insertions(+) Will apply soon.

[FFmpeg-devel] [PATCH v4 7/7] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Timo Rothenpieler Signed-off-by: Limin Wang --- libavcodec/nvenc.c | 17 + libavcodec/nvenc.h | 1 + libavcodec/nvenc_hevc.c | 1 + 3 files changed, 19 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index

[FFmpeg-devel] [PATCH v4 6/7] avcodec/utils: add ff_alloc_timecode_sei() for hevc timecode sei

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/internal.h | 15 libavcodec/utils.c| 63 +++ 2 files changed, 78 insertions(+) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 21708df..8771078 100644

[FFmpeg-devel] [PATCH v4 5/7] avcodec/hevcdec: create AVFrame side data from HEVC timecodes like H.264

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevcdec.c | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index c9e28f5..3bdec12 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -32,6 +32,7 @@

[FFmpeg-devel] [PATCH v4 2/7] avutil/timecode: add function av_timecode_get_smpte()

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/timecode.c | 32 libavutil/timecode.h | 13 + 2 files changed, 45 insertions(+) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index 60077ba..cca53d7 100644 ---

[FFmpeg-devel] [PATCH v4 4/7] avcodec/hevc_sei: support HEVC timecode decode

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_sei.c | 49 + libavcodec/hevc_sei.h | 21 + 2 files changed, 70 insertions(+) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index 1736891..bf92de6

[FFmpeg-devel] [PATCH v4 3/7] avcodec/h264_slice: use av_timecode_get_smpte()

2020-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264_slice.c | 33 ++--- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 47f3917..2a41de2 100644 --- a/libavcodec/h264_slice.c +++

[FFmpeg-devel] [PATCH 3/3] avcodec/mlpenc: free filter state buffers on allocation failure

2020-06-24 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mlpenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index 4d50f0ea33..52ea06ed91 100644 --- a/libavcodec/mlpenc.c +++ b/libavcodec/mlpenc.c @@ -1820,7 +1820,8 @@ static int

[FFmpeg-devel] [PATCH 1/3] avcodec/mlpenc: remove delay codec capability

2020-06-24 Thread James Almer
The encoder has no delayed packets at the end of the encoding process, so signaling this capability is unnecessary. This also fix an assertion failure introduced in 827d6fe73d, as return values higher than 0 are not expected. Signed-off-by: James Almer --- libavcodec/mlpenc.c | 7 ++- 1

Re: [FFmpeg-devel] [PATCH v3] avcodec/v4l2_m2m_dec: Remove redundant packet and fix double free

2020-06-24 Thread Andriy Gelman
On Mon, 25. May 14:59, Andriy Gelman wrote: > On Sat, 16. May 11:53, Andriy Gelman wrote: > > On Sat, 09. May 13:35, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > v4l2_receive_frame() uses two packets s->buf_pkt and avpkt. If avpkt > > > cannot be enqueued, the packet is buffered in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/subtitles: Check for NOPTS in ff_subtitles_queue_finalize()

2020-06-24 Thread Nicolas George
Michael Niedermayer (12020-06-24): > On Tue, Jun 23, 2020 at 02:08:44PM +0200, Nicolas George wrote: > > Michael Niedermayer (12020-06-23): > > > Fixes; signed integer overflow: 1 - -9223372036854775808 cannot be > > > represented in type 'long' > > > Fixes: > > >

Re: [FFmpeg-devel] [PATCH 2/2] add socks5 support for tcp clients

2020-06-24 Thread Moritz Barsnick
Now that I have tested this: On Sat, Jun 13, 2020 at 23:17:41 +0800, leviz...@live.cn wrote: > #endif /* !HAVE_WINSOCK2_H */ > +char *socks_proxy; > } TCPContext; [...] > { "listen", "Listen for incoming connections", OFFSET(listen), > AV_OPT_TYPE_INT, { .i64 = 0 },

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-24 Thread Nicolas George
Paul B Mahol (12020-06-24): > As already explained I can not use fixed buffer at all. Not true. Bring new, accurate arguments, or stop. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-24 Thread Paul B Mahol
On 6/24/20, Nicolas George wrote: > Paul B Mahol (12020-06-24): >> Also memory and CPU overhead is very small if it exists at all. > > They're not the problem, code complexity is. > > Just use a fixed buffer in your code and be done with it. > As already explained I can not use fixed buffer at

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-24 Thread Nicolas George
Paul B Mahol (12020-06-24): > Also memory and CPU overhead is very small if it exists at all. They're not the problem, code complexity is. Just use a fixed buffer in your code and be done with it. -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH]lavc: Lower MediaFoundation encoder priority

2020-06-24 Thread Moritz Barsnick
On Tue, Jun 23, 2020 at 20:43:34 +0200, Carl Eugen Hoyos wrote: > Pushed with that change, Carl Eugen I suggest backporting this to 4.3, where MediaFoundation support was added (and this issue is present). Thanks, Moritz ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-24 Thread Paul B Mahol
On 6/19/20, Paul B Mahol wrote: > On 6/16/20, Nicolas George wrote: >> Paul B Mahol (12020-06-12): >>> How so? Its purely random. >> >> +ret = ff_inlink_peek_samples(inlink, s->win_size, ); >> >> +ret = ff_inlink_peek_samples(inlink, s->window_size, ); >> >> They seem constant in

Re: [FFmpeg-devel] [PATCH] avdevice/gdigrab: client_only option to discard decorations such as titlebar or borders

2020-06-24 Thread Moritz Barsnick
On Fri, Jun 19, 2020 at 10:33:00 +0200, Sergio Acereda wrote: > +static int > +calc_titlebar_height(HWND hwnd) { Nit: the opening bracket of a function belongs in the next line. > GetClientRect(hwnd, _rect); > +if (gdigrab->client_only) { > +int cxborder =

Re: [FFmpeg-devel] [PATCH 6/6] dnn-layer-math-unary-test: add unit test for atan

2020-06-24 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年6月18日 17:16 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 6/6] dnn-layer-math-unary-test: add unit test > for atan > > Signed-off-by: Ting Fu > --- > tests/dnn/dnn-layer-mathunary-test.c | 4

Re: [FFmpeg-devel] [PATCH V2 2/2] vf_dnn_processing.c: add dnn backend openvino

2020-06-24 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2020年6月11日 21:01 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V2 2/2] vf_dnn_processing.c: add dnn backend openvino > > We can try with the srcnn model from sr filter. > 1) get srcnn.pb model file, see filter sr > 2)