[FFmpeg-devel] [PATCH 1/1] avformat: mca: relax a condition check to be able to play certain files

2020-10-01 Thread liushuyu
From: liushuyu In certain mca files, the coefficient table is in the data section instead of the header section. In this case, the coefficient offset relative to the header ending marker is a negative value thus failing the original condition check at line 146. The new check just check if the

[FFmpeg-devel] [PATCH 0/1] avformat: mca: relax a condition check to be able to play

2020-10-01 Thread liushuyu
From: liushuyu In certain mca files, the coefficient table is in the data section instead of the header section. In this case, the coefficient offset relative to the header ending marker is a negative value thus failing the original condition check at line 146. The new check just check if the

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-10-01 Thread James Almer
On 10/1/2020 8:57 PM, Mark Thompson wrote: > On 20/09/2020 18:24, James Almer wrote: >> The caller may not need all units in a fragment in reading only >> scenarios. They >> could in fact alter global state stored in the private CodedBitstreamType >> fields in an undesirable way. >> And unlike

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/cbs_av1: add an option to select an operating point

2020-10-01 Thread James Almer
On 10/1/2020 9:23 PM, Mark Thompson wrote: > On 20/09/2020 18:24, James Almer wrote: >> This implements the function drop_obu() as defined in Setion 6.2.1 >> from the >> spec. >> In a reading only scenario, units that belong to an operating point the >> caller doesn't want should not be parsed. >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rtsp: allocate correct max number of pollfds

2020-10-01 Thread Andriy Gelman
On Sun, 27. Sep 21:38, "zhilizhao(赵志立)" wrote: > > > > On Sep 27, 2020, at 6:26 AM, Andriy Gelman wrote: > > > > From: Andriy Gelman > > > > There is one general rtsp connection plus two connections per stream > > (rtp/rtcp). > > > > Signed-off-by: Andriy Gelman > > --- > >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/cbs_av1: add an option to select an operating point

2020-10-01 Thread Mark Thompson
On 20/09/2020 18:24, James Almer wrote: This implements the function drop_obu() as defined in Setion 6.2.1 from the spec. In a reading only scenario, units that belong to an operating point the caller doesn't want should not be parsed. Signed-off-by: James Almer --- libavcodec/cbs_av1.c

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-10-01 Thread Mark Thompson
On 20/09/2020 18:24, James Almer wrote: The caller may not need all units in a fragment in reading only scenarios. They could in fact alter global state stored in the private CodedBitstreamType fields in an undesirable way. And unlike preventing decomposition of units, discarding can be done

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/av1dec: clean state on frame decoding errors

2020-10-01 Thread James Almer
On 10/1/2020 7:15 PM, Mark Thompson wrote: > On 29/09/2020 19:23, James Almer wrote: >> On 9/29/2020 3:07 PM, Mark Thompson wrote: >>> On 29/09/2020 17:17, James Almer wrote: On 9/29/2020 12:57 PM, Mark Thompson wrote: > On 25/09/2020 15:43, James Almer wrote: >> Fixes: member access

[FFmpeg-devel] [WIP] Organisation process

2020-10-01 Thread Jean-Baptiste Kempf
Hello folks, I've documented what has been decided/discussed about the voting process and the committees. I'd like to know where should I commit this .md. In doc/? In a subfolder? somewhere else? I'd also like to have remarks about things that don't really match reality or are just wrong.

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2020-10-01 Thread Mark Thompson
On 29/09/2020 19:49, Pavel Koshevoy wrote: On Tue, Sep 29, 2020 at 12:14 PM Mark Thompson wrote: On 29/09/2020 18:14, Pavel Koshevoy wrote: On Tue, Sep 29, 2020 at 10:09 AM Mark Thompson wrote: - Mark It's pretty much this use case, except I'm not using ffmpeg cli but the avfilter

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/av1dec: clean state on frame decoding errors

2020-10-01 Thread Mark Thompson
On 29/09/2020 19:23, James Almer wrote: On 9/29/2020 3:07 PM, Mark Thompson wrote: On 29/09/2020 17:17, James Almer wrote: On 9/29/2020 12:57 PM, Mark Thompson wrote: On 25/09/2020 15:43, James Almer wrote: Fixes: member access within null pointer of type 'TileGroupInfo' (aka 'struct

Re: [FFmpeg-devel] [PATCH] rtsp: Fix infinite loop in listen mode with UDP transport

2020-10-01 Thread Martin Storsjö
On Thu, 1 Oct 2020, Andriy Gelman wrote: On Thu, 01. Oct 22:00, Zhao Zhili wrote: On 10/1/20 4:15 AM, Martin Storsjö wrote: > On Wed, 30 Sep 2020, Zhao Zhili wrote: > > > Hi Martin, > > > > On 9/30/20 5:41 PM, Martin Storsjö wrote: > > > In listen mode with UDP transport, once the sender

Re: [FFmpeg-devel] [PATCH] rtsp: Fix infinite loop in listen mode with UDP transport

2020-10-01 Thread Andriy Gelman
On Thu, 01. Oct 22:00, Zhao Zhili wrote: > > On 10/1/20 4:15 AM, Martin Storsjö wrote: > > On Wed, 30 Sep 2020, Zhao Zhili wrote: > > > > > Hi Martin, > > > > > > On 9/30/20 5:41 PM, Martin Storsjö wrote: > > > > In listen mode with UDP transport, once the sender has sent > > > > the TEARDOWN

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

2020-10-01 Thread Michael Niedermayer
On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote: > > > > > On 30 Sep 2020, at 08:32, Michael Niedermayer > > wrote: > > > > On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote: > >> mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin: > >>> ons 2020-09-09 klockan

Re: [FFmpeg-devel] [PATCH] fate: add scale filters for big-endian architectures.

2020-10-01 Thread Michael Niedermayer
On Wed, Sep 30, 2020 at 08:44:24PM +0200, Nicolas George wrote: > Michael Niedermayer (12020-09-30): > > > confirmed to work on qemu mips > > > so should be ok > > Sorry, I missed that part of your mail. Pushed. > > > ping, big endian is still broken > > A few minutes ago, I still did not see

Re: [FFmpeg-devel] [PATCH] avcodec: add Cintel RAW decoder

2020-10-01 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/codec_id.h | 1 + > libavcodec/cri.c| 300 > libavformat/img2.c | 1

[FFmpeg-devel] [PATCH] avcodec: add Cintel RAW decoder

2020-10-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/cri.c| 300 libavformat/img2.c | 1 + 6 files changed, 311

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

2020-10-01 Thread Harry Mallon
> On 30 Sep 2020, at 08:32, Michael Niedermayer wrote: > > On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote: >> mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin: >>> ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: * As embedded by Apple Compressor

Re: [FFmpeg-devel] [PATCH] rtsp: Fix infinite loop in listen mode with UDP transport

2020-10-01 Thread Zhao Zhili
On 10/1/20 4:15 AM, Martin Storsjö wrote: On Wed, 30 Sep 2020, Zhao Zhili wrote: Hi Martin, On 9/30/20 5:41 PM, Martin Storsjö wrote: In listen mode with UDP transport, once the sender has sent the TEARDOWN and closed the connection, poll will indicate that one can read from the connection

[FFmpeg-devel] [PATCH v3] avformat/libsrt: print streamid at client

2020-10-01 Thread raghavendra
Print the SRT streamid at the client. Logged to the context and changed into to verbose. Signed-off-by: raghavendra --- libavformat/libsrt.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 4025b24976..2cf5f57304 100644 ---

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: Don't free AVCodecParameters manually

2020-10-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > Sorry, I missed that my tree is dirty before sending the last patch. > > libavformat/movenc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: Free old vos_data before overwriting it

2020-10-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Otherwise the old data leaks whenever extradata needs to be rewritten > (e.g. when encoding FLAC with our encoder that sends an updated > extradata packet at the end). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/movenc.c | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix stack overflow when remuxing timecode tracks

2020-10-01 Thread Andreas Rheinhardt
Martin Storsjö: > On Wed, 30 Sep 2020, Andreas Rheinhardt wrote: > >> There are two possible kinds of timecode tracks (with tag "tmcd") in the >> mov muxer: Tracks created internally by the muxer and timecode tracks >> sent by the user. If any of the latter exists, the former are >> deactivated.

[FFmpeg-devel] [PATCH] avcodec/dolby_e: set constant frame_size

2020-10-01 Thread Nicolas Gaullier
Fixes pts generation. --- libavcodec/dolby_e.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dolby_e.c b/libavcodec/dolby_e.c index 429612ec08..b0e6d6aee3 100644 --- a/libavcodec/dolby_e.c +++ b/libavcodec/dolby_e.c @@ -577,6 +577,7 @@ static int filter_frame(DBEContext *s,

Re: [FFmpeg-devel] [PATCH v2] avformat/libsrt: print streamid at client

2020-10-01 Thread Moritz Barsnick
On Thu, Oct 01, 2020 at 14:13:14 +0530, raghavendra wrote: > Print the SRT streamid at the client. > Logged to the context and changed info to verbose. No, this is a patch on top of your original patch. That is not acceptable. You need to change the original commit and resubmit that. >

Re: [FFmpeg-devel] [PATCH] avcodec/qsv: Fix leak of options on error

2020-10-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/qsv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > index 7816d2f93c..6e3154e1a3 100644 > --- a/libavcodec/qsv.c > +++ b/libavcodec/qsv.c > @@ -361,6

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix stack overflow when remuxing timecode tracks

2020-10-01 Thread Martin Storsjö
On Wed, 30 Sep 2020, Andreas Rheinhardt wrote: There are two possible kinds of timecode tracks (with tag "tmcd") in the mov muxer: Tracks created internally by the muxer and timecode tracks sent by the user. If any of the latter exists, the former are deactivated. The former all belong to

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: fix infinite loop with udp transport

2020-10-01 Thread Martin Storsjö
Hi, On Thu, 1 Oct 2020, Andriy Gelman wrote: On Wed, 30. Sep 12:41, Martin Storsjö wrote: Hi, On Sun, 27 Sep 2020, Zhao Zhili wrote: > Fix #8840. > > Steps to reproduce: > 1. sender: > ./ffmpeg -i test.mp4 -c copy -f rtsp -rtsp_transport udp rtsp://localhost:12345/live.sdp > 2.

Re: [FFmpeg-devel] [PATCH] opusdec: do not fail when LBRR frames are present

2020-10-01 Thread Anton Khirnov
Quoting Lynne (2020-09-11 20:53:16) > On 11/09/2020 19:37, Anton Khirnov wrote: > > Decode and discard them. > > > > Fixes ticket 4641. > > --- > > libavcodec/opus_silk.c | 28 > > libavcodec/opustab.c | 3 +++ > > libavcodec/opustab.h | 3 +++ > > 3 files

[FFmpeg-devel] [PATCH v2] avformat/libsrt: print streamid at client

2020-10-01 Thread raghavendra
Print the SRT streamid at the client. Logged to the context and changed info to verbose. Signed-off-by: raghavendra --- libavformat/libsrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index ee64cb82f7..b6b50302b7 100644 ---

Re: [FFmpeg-devel] Example filter that process video and audio

2020-10-01 Thread Moritz Barsnick
On Sun, Sep 27, 2020 at 14:03:52 +0100, da...@3adesign.co.uk wrote: > Was looking to create a filter to process video and audio in a filter graph, > can find examples in movie or a source that has both video and audio but not > anything that takes both, any pointers to something to use as a

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: print streamid at client

2020-10-01 Thread Nicolas George
raghavendra (12020-10-01): > Print the SRT streamid at the client. > > Signed-off-by: raghavendra > --- > libavformat/libsrt.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c > index a490a386e6..ee64cb82f7 100644 > ---

[FFmpeg-devel] [PATCH] avformat/libsrt: print streamid at client

2020-10-01 Thread raghavendra
Print the SRT streamid at the client. Signed-off-by: raghavendra --- libavformat/libsrt.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index a490a386e6..ee64cb82f7 100644 --- a/libavformat/libsrt.c +++ b/libavformat/libsrt.c @@ -359,6